- gerrit-log - lists.osmocom.org

[XS] Change in libosmo-gprs[master]: llc: Mark old/current tlli as all 1's when unassigning LLME
by lynxis lazus 20 Aug '24

20 Aug '24

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/37873?usp=email ) Change subject: llc: Mark old/current tlli as all 1's when unassigning LLME ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/37873?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I9db198a31963db015e887e33baf3c32b46e2b11a Gerrit-Change-Number: 37873 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Aug 2024 15:10:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: core/socket.c: Fix socket binding on IPv4-only hosts
by laforge 20 Aug '24

20 Aug '24

Attention is currently required from: Hoernchen, pespin. Hello Hoernchen, Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email to look at the new patch set (#4). Change subject: core/socket.c: Fix socket binding on IPv4-only hosts ...................................................................... core/socket.c: Fix socket binding on IPv4-only hosts Let's avoid attempting to use IPv6 addresses on hosts that do not have IPv6 capability. Change-Id: I5690a25af98089e3a8a092cb91dfc969720abdc0 Closes: OS#7074 --- M src/core/socket.c 1 file changed, 24 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/74/37874/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5690a25af98089e3a8a092cb91dfc969720abdc0 Gerrit-Change-Number: 37874 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: core/socket.c: Fix socket binding on IPv4-only hosts
by laforge 20 Aug '24

20 Aug '24

Attention is currently required from: Hoernchen, pespin. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email ) Change subject: core/socket.c: Fix socket binding on IPv4-only hosts ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/37874/comment/ef0cf8b6_ef362ba3?… : PS1, Line 19: > valid as a configured address. *This flag is useful on, for example, > I chose to go down a different route altogether, comment no longer relevant. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5690a25af98089e3a8a092cb91dfc969720abdc0 Gerrit-Change-Number: 37874 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Aug 2024 14:59:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: [cosmetic] core/socket.c: Fix indent of 'case' within 'switch'
by laforge 20 Aug '24

20 Aug '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/37879?usp=email ) Change subject: [cosmetic] core/socket.c: Fix indent of 'case' within 'switch' ...................................................................... [cosmetic] core/socket.c: Fix indent of 'case' within 'switch' Change-Id: I8f9214fac4529aa460f2700f1f102013bb36aa47 --- M src/core/socket.c 1 file changed, 12 insertions(+), 12 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/core/socket.c b/src/core/socket.c index 97708a7..e394cf9 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -346,23 +346,23 @@ if (family == AF_UNSPEC) { for (rp = local; rp != NULL; rp = rp->ai_next) { switch (rp->ai_family) { - case AF_INET: - local_ipv4 = true; - break; - case AF_INET6: - local_ipv6 = true; - break; + case AF_INET: + local_ipv4 = true; + break; + case AF_INET6: + local_ipv6 = true; + break; } } for (rp = remote; rp != NULL; rp = rp->ai_next) { switch (rp->ai_family) { - case AF_INET: - remote_ipv4 = true; - break; - case AF_INET6: - remote_ipv6 = true; - break; + case AF_INET: + remote_ipv4 = true; + break; + case AF_INET6: + remote_ipv6 = true; + break; } } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37879?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8f9214fac4529aa460f2700f1f102013bb36aa47 Gerrit-Change-Number: 37879 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libosmocore[master]: core/socket.c: Provide more context when printing error message
by laforge 20 Aug '24

20 Aug '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/37818?usp=email ) Change subject: core/socket.c: Provide more context when printing error message ...................................................................... core/socket.c: Provide more context when printing error message Let's include the AF, SOCKTYPE and PROTO numbers when logging an error like "unable to create socket: Address family not supported by protocol" Change-Id: I91b05d0520b5432ca301cf6fd34468c2f4ac9b72 Related: SYS#7047 --- M src/core/socket.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/core/socket.c b/src/core/socket.c index 80a9d0e..97708a7 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -172,8 +172,8 @@ sfd = socket(rp->ai_family, rp->ai_socktype, rp->ai_protocol); if (sfd == -1) { - LOGP(DLGLOBAL, LOGL_ERROR, - "unable to create socket: %s\n", strerror(errno)); + LOGP(DLGLOBAL, LOGL_ERROR, "unable to create socket(%d, %d, %d): %s\n", + rp->ai_family, rp->ai_socktype, rp->ai_protocol, strerror(errno)); return sfd; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37818?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I91b05d0520b5432ca301cf6fd34468c2f4ac9b72 Gerrit-Change-Number: 37818 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: core/socket.c: Fix socket binding on IPv4-only hosts
by laforge 20 Aug '24

20 Aug '24

Attention is currently required from: Hoernchen, pespin. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email ) Change subject: core/socket.c: Fix socket binding on IPv4-only hosts ...................................................................... Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/37874/comment/3f1ed475_80e3e1f4?… : PS1, Line 19: > valid as a configured address. *This flag is useful on, for example, > Then maybe worth it testing what I mentioned about running getaddrinfo twice if first with flag fail […] I chose to go down a different route altogether, comment no longer relevant. File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/37874/comment/e21066bc_91e08f0d?… : PS1, Line 85: rc = getaddrinfo(host, portbuf, &hints, &result); > That might be an option. […] I chose to go down a different route altogether, comment no longer relevant. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5690a25af98089e3a8a092cb91dfc969720abdc0 Gerrit-Change-Number: 37874 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Aug 2024 14:59:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: core/socket.c: Fix socket binding on IPv4-only hosts
by laforge 20 Aug '24

20 Aug '24

Attention is currently required from: Hoernchen, laforge, pespin. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email ) Change subject: core/socket.c: Fix socket binding on IPv4-only hosts ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5690a25af98089e3a8a092cb91dfc969720abdc0 Gerrit-Change-Number: 37874 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Aug 2024 14:58:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in pysim[master]: ara_m: use class byte of current lchan
by dexter 20 Aug '24

20 Aug '24

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37840?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: ara_m: use class byte of current lchan ...................................................................... ara_m: use class byte of current lchan The ara_m commands use APDUs with a fix class byte (0x80). This means that all ARA-M related features only work in the basic logical channel. To fix this, let's compute the class byte for the current logical channel dynamically inside the send_apdu methods of SimCardCommands. This will fix the problem globally. Related: OS#6531 Change-Id: Ie3e48678f178a488bfaea6cc2b9a3e18145a8d10 --- M pySim/ara_m.py M pySim/commands.py 2 files changed, 25 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/40/37840/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie3e48678f178a488bfaea6cc2b9a3e18145a8d10 Gerrit-Change-Number: 37840 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: [cosmetic] core/socket.c: Fix indent of 'case' within 'switch'
by fixeria 20 Aug '24

20 Aug '24

Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/37879?usp=email ) Change subject: [cosmetic] core/socket.c: Fix indent of 'case' within 'switch' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37879?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8f9214fac4529aa460f2700f1f102013bb36aa47 Gerrit-Change-Number: 37879 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 20 Aug 2024 14:23:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: [cosmetic] core/socket.c: Fix indent of 'case' within 'switch'
by laforge 20 Aug '24

20 Aug '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/37879?usp=email ) Change subject: [cosmetic] core/socket.c: Fix indent of 'case' within 'switch' ...................................................................... [cosmetic] core/socket.c: Fix indent of 'case' within 'switch' Change-Id: I8f9214fac4529aa460f2700f1f102013bb36aa47 --- M src/core/socket.c 1 file changed, 12 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/79/37879/1 diff --git a/src/core/socket.c b/src/core/socket.c index 97708a7..e394cf9 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -346,23 +346,23 @@ if (family == AF_UNSPEC) { for (rp = local; rp != NULL; rp = rp->ai_next) { switch (rp->ai_family) { - case AF_INET: - local_ipv4 = true; - break; - case AF_INET6: - local_ipv6 = true; - break; + case AF_INET: + local_ipv4 = true; + break; + case AF_INET6: + local_ipv6 = true; + break; } } for (rp = remote; rp != NULL; rp = rp->ai_next) { switch (rp->ai_family) { - case AF_INET: - remote_ipv4 = true; - break; - case AF_INET6: - remote_ipv6 = true; - break; + case AF_INET: + remote_ipv4 = true; + break; + case AF_INET6: + remote_ipv6 = true; + break; } } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37879?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8f9214fac4529aa460f2700f1f102013bb36aa47 Gerrit-Change-Number: 37879 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log