- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: PFCP: drop no longer needed {ts,tr}_PDU_PFCP
by pespin 30 Aug '24

30 Aug '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37951?usp=email ) Change subject: PFCP: drop no longer needed {ts,tr}_PDU_PFCP ...................................................................... PFCP: drop no longer needed {ts,tr}_PDU_PFCP Change-Id: I6091d7e76e852d2487b784fb2b3e39b416a48195 Related: SYS#6772 --- M library/PFCP_Templates.ttcn 1 file changed, 0 insertions(+), 11 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/library/PFCP_Templates.ttcn b/library/PFCP_Templates.ttcn index 143175a..ad90ff2 100644 --- a/library/PFCP_Templates.ttcn +++ b/library/PFCP_Templates.ttcn @@ -113,17 +113,6 @@ message_body := ? }; -template (value) PDU_PFCP ts_PDU_PFCP(LIN3_BO_LAST sequence_number := 0, template (omit) OCT8 seid := omit) -modifies ts_PDU_PFCP_ := { - seid := seid, - sequence_number := sequence_number -}; - -template (present) PDU_PFCP tr_PDU_PFCP(template OCT8 seid := *) -modifies tr_PDU_PFCP_ := { - seid := seid -}; - /* 7.4.4.1 PFCP Association Setup Request */ template (value) PDU_PFCP ts_PFCP_Assoc_Setup_Req(template (value) Node_ID node_id, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37951?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6091d7e76e852d2487b784fb2b3e39b416a48195 Gerrit-Change-Number: 37951 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: PFCP: add Heartbeat Req/Resp templates
by pespin 30 Aug '24

30 Aug '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37952?usp=email ) Change subject: PFCP: add Heartbeat Req/Resp templates ...................................................................... PFCP: add Heartbeat Req/Resp templates Change-Id: I569b47b6ebc3ca238da544488cac69dfc1db1dfe Related: SYS#6772 --- M library/PFCP_Templates.ttcn 1 file changed, 44 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/library/PFCP_Templates.ttcn b/library/PFCP_Templates.ttcn index ad90ff2..f3b6893 100644 --- a/library/PFCP_Templates.ttcn +++ b/library/PFCP_Templates.ttcn @@ -73,13 +73,14 @@ template (value) Node_ID ts_PFCP_Node_ID_ipv4(OCT4 ip_value) := ts_PFCP_Node_ID(PFCP_Node_ID_IPv4, ip_value); template (value) Node_ID ts_PFCP_Node_ID_fqdn(charstring fqdn) := ts_PFCP_Node_ID(PFCP_Node_ID_FQDN, char2oct(fqdn)); -template (value) Recovery_Time_Stamp ts_PFCP_Recovery_Timestamp(LIN4_BO_LAST time_value) := { +template (value) Recovery_Time_Stamp +ts_PFCP_Recovery_Timestamp(template (value) LIN4_BO_LAST time_value) := { elementIdentifier := 96, lengthIndicator := 0, time_value := time_value }; - -template (present) Recovery_Time_Stamp tr_PFCP_Recovery_Timestamp(template (present) LIN4_BO_LAST time_value := ?) := { +template (present) Recovery_Time_Stamp +tr_PFCP_Recovery_Timestamp(template (present) LIN4_BO_LAST time_value := ?) := { elementIdentifier := 96, lengthIndicator := ?, time_value := time_value @@ -113,6 +114,46 @@ message_body := ? }; +/* 7.4.2.1 Heartbeat Request */ +template (value) PDU_PFCP +ts_PFCP_Heartbeat_Req(template (value) LIN4_BO_LAST recovery_time_stamp) +modifies ts_PDU_PFCP_ := { + message_body := { + heartbeat_request := { + recovery_time_stamp := ts_PFCP_Recovery_Timestamp(recovery_time_stamp) + } + } +}; +template (present) PDU_PFCP +tr_PFCP_Heartbeat_Req(template (present) LIN4_BO_LAST recovery_time_stamp := ?) +modifies tr_PDU_PFCP_ := { + message_body := { + heartbeat_request := { + recovery_time_stamp := tr_PFCP_Recovery_Timestamp(recovery_time_stamp) + } + } +}; + +/* 7.4.2.2 Heartbeat Response */ +template (value) PDU_PFCP +ts_PFCP_Heartbeat_Resp(template (value) LIN4_BO_LAST recovery_time_stamp) +modifies ts_PDU_PFCP_ := { + message_body := { + heartbeat_response := { + recovery_time_stamp := ts_PFCP_Recovery_Timestamp(recovery_time_stamp) + } + } +}; +template (present) PDU_PFCP +tr_PFCP_Heartbeat_Resp(template (present) LIN4_BO_LAST recovery_time_stamp := ?) +modifies tr_PDU_PFCP_ := { + message_body := { + heartbeat_response := { + recovery_time_stamp := tr_PFCP_Recovery_Timestamp(recovery_time_stamp) + } + } +}; + /* 7.4.4.1 PFCP Association Setup Request */ template (value) PDU_PFCP ts_PFCP_Assoc_Setup_Req(template (value) Node_ID node_id, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37952?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I569b47b6ebc3ca238da544488cac69dfc1db1dfe Gerrit-Change-Number: 37952 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: PFCP_Emulation: respond to incoming Heartbeat Req
by pespin 30 Aug '24

30 Aug '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37953?usp=email ) Change subject: PFCP_Emulation: respond to incoming Heartbeat Req ...................................................................... PFCP_Emulation: respond to incoming Heartbeat Req This is a mandatory procedure that every 3GPP TS 29.244 compliant peer shall support. Change-Id: I93990feb1864701e2903af85480093ef751bafe5 Related: SYS#6772 --- M library/PFCP_CodecPort.ttcn M library/PFCP_Emulation.ttcn 2 files changed, 16 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/library/PFCP_CodecPort.ttcn b/library/PFCP_CodecPort.ttcn index 8d4078d..783ffb0 100644 --- a/library/PFCP_CodecPort.ttcn +++ b/library/PFCP_CodecPort.ttcn @@ -26,6 +26,12 @@ PDU_PFCP pdu } +template (present) PFCP_Unitdata +tr_PFCP_UD(template (present) PDU_PFCP pdu := ?) := { + peer := ?, + pdu := pdu +} + /* Translation port on top of IPL4asp; ASP_Event passed through transparently */ type port PFCP_PT message { out PFCP_Unitdata; diff --git a/library/PFCP_Emulation.ttcn b/library/PFCP_Emulation.ttcn index d872367..2fb3a8a 100644 --- a/library/PFCP_Emulation.ttcn +++ b/library/PFCP_Emulation.ttcn @@ -15,6 +15,7 @@ import from General_Types all; import from Osmocom_Types all; import from PFCP_Types all; +import from PFCP_Templates all; import from PFCP_CodecPort all; import from PFCP_CodecPort_CtrlFunct all; @@ -123,7 +124,15 @@ while (true) { alt { - [] PFCP.receive(PFCP_Unitdata:?) -> value ud { + [] PFCP.receive(tr_PFCP_UD(tr_PFCP_Heartbeat_Req)) -> value ud { + log("Rx Heartbeat Req: ", ud.pdu); + pdu := valueof(ts_PFCP_Heartbeat_Resp(g_recovery_timestamp)); + pdu.sequence_number := ud.pdu.sequence_number; + ud.pdu := pdu; + PFCP.send(ud); + } + + [] PFCP.receive(tr_PFCP_UD(?)) -> value ud { log("PFCP_Emulation main() PFCP.receive: ", ud); vc_conn := null; if (ud.pdu.s_flag == '1'B) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37953?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I93990feb1864701e2903af85480093ef751bafe5 Gerrit-Change-Number: 37953 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: PFCP_Emulation: respond to incoming Heartbeat Req
by pespin 30 Aug '24

30 Aug '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37953?usp=email ) Change subject: PFCP_Emulation: respond to incoming Heartbeat Req ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37953?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I93990feb1864701e2903af85480093ef751bafe5 Gerrit-Change-Number: 37953 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 12:36:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: PFCP: add Heartbeat Req/Resp templates
by pespin 30 Aug '24

30 Aug '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37952?usp=email ) Change subject: PFCP: add Heartbeat Req/Resp templates ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37952?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I569b47b6ebc3ca238da544488cac69dfc1db1dfe Gerrit-Change-Number: 37952 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 12:35:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: PFCP: drop no longer needed {ts,tr}_PDU_PFCP
by pespin 30 Aug '24

30 Aug '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37951?usp=email ) Change subject: PFCP: drop no longer needed {ts,tr}_PDU_PFCP ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37951?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6091d7e76e852d2487b784fb2b3e39b416a48195 Gerrit-Change-Number: 37951 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 12:35:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: tests: move pySim-prog test and its data into a sub directory
by laforge 30 Aug '24

30 Aug '24

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37823?usp=email ) Change subject: tests: move pySim-prog test and its data into a sub directory ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic995a7f600d164fc0be3c2eb8255dbe043429bea Gerrit-Change-Number: 37823 Gerrit-PatchSet: 13 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 05:52:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: tests: move pySim-trace test and its data into a sub directory
by laforge 30 Aug '24

30 Aug '24

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37822?usp=email ) Change subject: tests: move pySim-trace test and its data into a sub directory ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I565b4268a05c1a1334b5e7d3fbcd9ef2ef0f0c4c Gerrit-Change-Number: 37822 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 05:52:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: tests: move unittests into a sub directory
by laforge 30 Aug '24

30 Aug '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37821?usp=email ) ( 9 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: tests: move unittests into a sub directory ...................................................................... tests: move unittests into a sub directory We currently mix the unit-tests with the shell script based integration tests. Let's put them into a dedicated sub directory. Related: OS#6531 Change-Id: I0978c5353d0d479a050bbb6e7ae5a63db5e08d24 --- M contrib/jenkins.sh R tests/unittests/test_apdu.py R tests/unittests/test_construct.py R tests/unittests/test_esim.py R tests/unittests/test_esim_bsp.py R tests/unittests/test_esim_saip.py R tests/unittests/test_euicc.py R tests/unittests/test_files.py R tests/unittests/test_globalplatform.py R tests/unittests/test_ota.py R tests/unittests/test_sms.py R tests/unittests/test_tlv.py R tests/unittests/test_tlvs.py R tests/unittests/test_utils.py 14 files changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 16ab1c4..3dabdd7 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -27,7 +27,7 @@ pip install pyshark # Execute automatically discovered unit tests first - python -m unittest discover -v -s tests/ + python -m unittest discover -v -s tests/unittests # Run the test with physical cards cd pysim-testdata @@ -58,7 +58,7 @@ --disable E1102 \ --disable E0401 \ --enable W0301 \ - pySim tests/*.py *.py \ + pySim tests/unittests/*.py *.py \ contrib/*.py ;; "docs") diff --git a/tests/test_apdu.py b/tests/unittests/test_apdu.py similarity index 100% rename from tests/test_apdu.py rename to tests/unittests/test_apdu.py diff --git a/tests/test_construct.py b/tests/unittests/test_construct.py similarity index 100% rename from tests/test_construct.py rename to tests/unittests/test_construct.py diff --git a/tests/test_esim.py b/tests/unittests/test_esim.py similarity index 100% rename from tests/test_esim.py rename to tests/unittests/test_esim.py diff --git a/tests/test_esim_bsp.py b/tests/unittests/test_esim_bsp.py similarity index 100% rename from tests/test_esim_bsp.py rename to tests/unittests/test_esim_bsp.py diff --git a/tests/test_esim_saip.py b/tests/unittests/test_esim_saip.py similarity index 100% rename from tests/test_esim_saip.py rename to tests/unittests/test_esim_saip.py diff --git a/tests/test_euicc.py b/tests/unittests/test_euicc.py similarity index 100% rename from tests/test_euicc.py rename to tests/unittests/test_euicc.py diff --git a/tests/test_files.py b/tests/unittests/test_files.py similarity index 100% rename from tests/test_files.py rename to tests/unittests/test_files.py diff --git a/tests/test_globalplatform.py b/tests/unittests/test_globalplatform.py similarity index 100% rename from tests/test_globalplatform.py rename to tests/unittests/test_globalplatform.py diff --git a/tests/test_ota.py b/tests/unittests/test_ota.py similarity index 100% rename from tests/test_ota.py rename to tests/unittests/test_ota.py diff --git a/tests/test_sms.py b/tests/unittests/test_sms.py similarity index 100% rename from tests/test_sms.py rename to tests/unittests/test_sms.py diff --git a/tests/test_tlv.py b/tests/unittests/test_tlv.py similarity index 100% rename from tests/test_tlv.py rename to tests/unittests/test_tlv.py diff --git a/tests/test_tlvs.py b/tests/unittests/test_tlvs.py similarity index 100% rename from tests/test_tlvs.py rename to tests/unittests/test_tlvs.py diff --git a/tests/test_utils.py b/tests/unittests/test_utils.py similarity index 100% rename from tests/test_utils.py rename to tests/unittests/test_utils.py -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0978c5353d0d479a050bbb6e7ae5a63db5e08d24 Gerrit-Change-Number: 37821 Gerrit-PatchSet: 10 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors
by fixeria 30 Aug '24

30 Aug '24

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: Let's keep this patch in review until we have functional or at least unit tests. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 30 Aug 2024 05:39:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log