- gerrit-log - lists.osmocom.org

[S] Change in libasn1c[master]: coverity CID#57681
by neels 03 Sep '24

03 Sep '24

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libasn1c/+/37984?usp=email ) Change subject: coverity CID#57681 ...................................................................... coverity CID#57681 Make sure that bits_unused cannot subtract more bits than present in st->size. Especially when st->size == 0, this ensures that sizeinunits is also 0, and that a st->size == 0 hence never enters the while (sizeinunits) loop. Change-Id: Ic8e3f5e24541989b79826de2942e5e6560079028 --- M src/OCTET_STRING.c 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libasn1c refs/changes/84/37984/1 diff --git a/src/OCTET_STRING.c b/src/OCTET_STRING.c index 3e424e7..9d2e817 100644 --- a/src/OCTET_STRING.c +++ b/src/OCTET_STRING.c @@ -1859,6 +1859,7 @@ unsigned int unit_bits; unsigned int canonical_unit_bits; unsigned int sizeinunits; + unsigned int unused; const uint8_t *buf; int ret; enum { @@ -1888,7 +1889,11 @@ case ASN_OSUBV_BIT: canonical_unit_bits = unit_bits = 1; bpc = OS__BPC_BIT; - sizeinunits = st->size * 8 - (st->bits_unused & 0x07); + sizeinunits = st->size * 8; + /* make sure sizeinunits cannot wrap past zero (especially when st->size == 0). */ + unused = st->bits_unused & 0x07; + if (unused <= sizeinunits) + sizeinunits -= unused; ASN_DEBUG("BIT STRING of %d bytes", sizeinunits); break; @@ -1994,6 +1999,9 @@ maySave, bpc, unit_bits, cval->lower_bound, cval->upper_bound, pc); } else { + /* coverity CID#57681: st->buf can be NULL, but above, we've verified that when st->buf == NULL, + * then also st->size == 0, and hence sizeinunits == 0, hence this 'while' will skip entirely, + * and hence it is safe to dereference buf here. */ ret = per_put_many_bits(po, buf, maySave * unit_bits); } if(ret) _ASN_ENCODE_FAILED; -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/37984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: Ic8e3f5e24541989b79826de2942e5e6560079028 Gerrit-Change-Number: 37984 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in libasn1c[master]: coverity CID#57935
by neels 03 Sep '24

03 Sep '24

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libasn1c/+/37983?usp=email ) Change subject: coverity CID#57935 ...................................................................... coverity CID#57935 always initialize t2m_count. Change-Id: I23cfbb1cf1fc12ebd4db8e4b58c5e797b2834897 --- M src/constr_SET.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libasn1c refs/changes/83/37983/1 diff --git a/src/constr_SET.c b/src/constr_SET.c index 8a124c0..85e2527 100644 --- a/src/constr_SET.c +++ b/src/constr_SET.c @@ -598,7 +598,7 @@ int t2m_build_own = (specs->tag2el_count != td->elements_count); const asn_TYPE_tag2member_t *t2m; asn_TYPE_tag2member_t *t2m_build; - int t2m_count; + int t2m_count = 0; (void)constraints; @@ -616,7 +616,6 @@ t2m_build = (asn_TYPE_tag2member_t *)alloca( td->elements_count * sizeof(t2m[0])); if(!t2m_build) _ASN_ENCODE_FAILED; /* There are such platforms */ - t2m_count = 0; } else { t2m_build = NULL; /* -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/37983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: I23cfbb1cf1fc12ebd4db8e4b58c5e797b2834897 Gerrit-Change-Number: 37983 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: coverity CID#272951
by neels 03 Sep '24

03 Sep '24

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/37982?usp=email ) Change subject: coverity CID#272951 ...................................................................... coverity CID#272951 Change-Id: I23f5b9957978bd680182d188271820de2d9d39ad --- M src/gsm/gsm23236.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/82/37982/1 diff --git a/src/gsm/gsm23236.c b/src/gsm/gsm23236.c index 9095930..a80ecf4 100644 --- a/src/gsm/gsm23236.c +++ b/src/gsm/gsm23236.c @@ -487,7 +487,7 @@ int osmo_nri_ranges_vty_add(const char **message, struct osmo_nri_range *added_range, struct osmo_nri_ranges *nri_ranges, int argc, const char **argv, uint8_t nri_bitlen) { - struct osmo_nri_range add_range; + struct osmo_nri_range add_range = {}; if (osmo_nri_parse_range(&add_range, argv[0], argc > 1 ? argv[1] : NULL)) { *message = "Error: cannot parse NRI range"; return -1; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37982?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I23f5b9957978bd680182d188271820de2d9d39ad Gerrit-Change-Number: 37982 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: coverity CID#272974
by neels 03 Sep '24

03 Sep '24

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/37981?usp=email ) Change subject: coverity CID#272974 ...................................................................... coverity CID#272974 Change-Id: I5633c3218067685036b79fd8d827031eede1eaa0 --- M src/gsm/gsm23236.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/37981/1 diff --git a/src/gsm/gsm23236.c b/src/gsm/gsm23236.c index 4a83ec8..9095930 100644 --- a/src/gsm/gsm23236.c +++ b/src/gsm/gsm23236.c @@ -523,7 +523,7 @@ int osmo_nri_ranges_vty_del(const char **message, struct osmo_nri_range *removed_range, struct osmo_nri_ranges *nri_ranges, int argc, const char **argv) { - struct osmo_nri_range del_range; + struct osmo_nri_range del_range = {}; if (osmo_nri_parse_range(&del_range, argv[0], argc > 1 ? argv[1] : NULL)) { *message = "Error: cannot parse NRI range"; return -1; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37981?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5633c3218067685036b79fd8d827031eede1eaa0 Gerrit-Change-Number: 37981 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: TC_setup: Validate some metrics
by fixeria 02 Sep '24

02 Sep '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37960?usp=email ) Change subject: s1gw: TC_setup: Validate some metrics ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37960?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iae629bc9291ff8b6e482f61d692e4d97ff0136bd Gerrit-Change-Number: 37960 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Sep 2024 20:41:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: ConnHdlr: Use stats reported by osmo-s1gw to expect PFCP Assoc ...
by fixeria 02 Sep '24

02 Sep '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37959?usp=email ) Change subject: s1gw: ConnHdlr: Use stats reported by osmo-s1gw to expect PFCP Assoc Setup ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37959?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I329745125d78786fc9c243f0047cd394de9b16d4 Gerrit-Change-Number: 37959 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Sep 2024 20:39:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: Initial StatsD support
by fixeria 02 Sep '24

02 Sep '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37958?usp=email ) Change subject: s1gw: Initial StatsD support ...................................................................... Patch Set 2: (2 comments) File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37958/comment/f9a54fd9_9ce9… : PS2, Line 79: VirtHNBGW copy-paste https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37958/comment/6ec41f4c_6ba5… : PS2, Line 112: f_new_ConnHdlrPars [At least now] I don't really see the need for this function. ``` var ConnHdlrPars pars := valueof(t_ConnHdlrPars()); var ConnHdlrPars pars := f_new_ConnHdlrPars(); ``` Does not worth it saving just a few chars... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37958?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib98c2fe68006a8d0f45de6966927b349a3b933ca Gerrit-Change-Number: 37958 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Sep 2024 20:38:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-ttcn3-hacks[master]: StatsD_Checker: Allow running without VTY support
by fixeria 02 Sep '24

02 Sep '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37980?usp=email ) Change subject: StatsD_Checker: Allow running without VTY support ...................................................................... Patch Set 1: (3 comments) File library/StatsD_Checker.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37980/comment/9e0e3013_30f5… : PS1, Line 163: PESPIN debugging leftovers https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37980/comment/9428166f_45b9… : PS1, Line 167: PESPIN debugging leftovers https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37980/comment/db59d880_c288… : PS1, Line 180: var default t; unused? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37980?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie1180a5b674504864309c3b9b11bfcf5256d9178 Gerrit-Change-Number: 37980 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Sep 2024 20:33:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-ttcn3-hacks[master]: StatsD_Checker: Simplify by getting rid of StatsDExpectPriv
by fixeria 02 Sep '24

02 Sep '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37979?usp=email ) Change subject: StatsD_Checker: Simplify by getting rid of StatsDExpectPriv ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib14c838c5f0647d050249853327671542182636f Gerrit-Change-Number: 37979 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Sep 2024 20:18:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: StatsD_Checker: Allow building without VTY support
by fixeria 02 Sep '24

02 Sep '24

Attention is currently required from: daniel, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37956?usp=email ) Change subject: StatsD_Checker: Allow building without VTY support ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37956?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5421c76e4f303fd16d4db945a1c69910e40ac820 Gerrit-Change-Number: 37956 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Sep 2024 19:34:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log