- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: update osmo-stp.cfg to make STP_Tests work at all again
by laforge 04 Sep '24

04 Sep '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38021?usp=email ) Change subject: update osmo-stp.cfg to make STP_Tests work at all again ...................................................................... update osmo-stp.cfg to make STP_Tests work at all again This syncs osmo-stp.cfg with changes introduced to docker-playground in Change-Id I210b7d62845075dcfe147f2f77603625cc1e64f9 on March 4th. I'm really getting tired at fixing up those kind of issues. It's well-known that config changes must be made first here and then in docker-playground. Change-Id: I7f0cef55a9a54f1cc4b23df781dab2afd52aae78 --- M stp/osmo-stp.cfg 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/38021/1 diff --git a/stp/osmo-stp.cfg b/stp/osmo-stp.cfg index 13b1b71..9a6540a 100644 --- a/stp/osmo-stp.cfg +++ b/stp/osmo-stp.cfg @@ -37,6 +37,28 @@ ! cs7 instance 0 point-code format 24 + asp asp-sender-tcp 9999 2905 m3ua tcp + local-ip 127.0.0.1 + remote-ip 127.0.0.1 + role sg + transport-role server + asp asp-client0-tcp 10002 2906 m3ua tcp + local-ip 127.0.0.1 + remote-ip 127.0.0.1 + role asp + transport-role client + as as-sender-tcp m3ua + asp asp-sender-tcp + routing-key 1123 123 + as as-client-tcp m3ua + routing-key 1155 155 + asp asp-client0-tcp + route-table system + update route 123 16777215 linkset as-sender-tcp + update route 155 16777215 linkset as-client-tcp + listen m3ua 2905 tcp + local-ip 127.0.0.1 + accept-asp-connections dynamic-permitted ! !M3UA AS/ASP: ! -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7f0cef55a9a54f1cc4b23df781dab2afd52aae78 Gerrit-Change-Number: 38021 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-hnbgw[master]: coverity CID#358069
by laforge 04 Sep '24

04 Sep '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37999?usp=email ) Change subject: coverity CID#358069 ...................................................................... coverity CID#358069 Change-Id: Ib2ed76c1bdae96457f61c2e015846566f100b8d6 --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index 1cc79f6..e373600 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -446,7 +446,7 @@ static int hnbgw_rx_hnb_deregister(struct hnb_context *ctx, ANY_t *in) { HNBAP_HNBDe_RegisterIEs_t ies; - HNBAP_Cause_t cause; + HNBAP_Cause_t cause = {}; int rc; rc = hnbap_decode_hnbde_registeries(&ies, in); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib2ed76c1bdae96457f61c2e015846566f100b8d6 Gerrit-Change-Number: 37999 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[master]: coverity CID#358072
by laforge 04 Sep '24

04 Sep '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37997?usp=email ) Change subject: coverity CID#358072 ...................................................................... coverity CID#358072 Change-Id: I90b0c73530fa3ba8b0bf74728d5b215957ef7184 --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index ddf40c9..9ed1e46 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -579,7 +579,7 @@ static int hnbgw_rx_ue_register_req(struct hnb_context *ctx, ANY_t *in) { HNBAP_UERegisterRequestIEs_t ies; - HNBAP_Cause_t cause; + HNBAP_Cause_t cause = {}; char imsi[GSM23003_IMSI_MAX_DIGITS+1]; int rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37997?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I90b0c73530fa3ba8b0bf74728d5b215957ef7184 Gerrit-Change-Number: 37997 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[master]: coverity CID#358071
by laforge 04 Sep '24

04 Sep '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37996?usp=email ) Change subject: coverity CID#358071 ...................................................................... coverity CID#358071 Change-Id: I8237bf7d4985e993bb10aaaa9370cde2ece3d812 --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: neels: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index df4ec9d..ddf40c9 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -648,7 +648,7 @@ static int hnbgw_rx_ue_deregister(struct hnb_context *ctx, ANY_t *in) { HNBAP_UEDe_RegisterIEs_t ies; - HNBAP_Cause_t cause; + HNBAP_Cause_t cause = {}; int rc; uint32_t ctxid; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37996?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I8237bf7d4985e993bb10aaaa9370cde2ece3d812 Gerrit-Change-Number: 37996 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[master]: coverity CID#358070
by laforge 04 Sep '24

04 Sep '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37998?usp=email ) Change subject: coverity CID#358070 ...................................................................... coverity CID#358070 Change-Id: I742e95fa97f41ca4efe77055c5f29f73e48826d6 --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: neels: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index 9ed1e46..1cc79f6 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -475,7 +475,7 @@ char identity_str[256]; const char *cell_id_str; struct timespec tp; - HNBAP_Cause_t cause; + HNBAP_Cause_t cause = {}; struct osmo_sockaddr cur_osa = {}; socklen_t len = sizeof(cur_osa); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37998?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I742e95fa97f41ca4efe77055c5f29f73e48826d6 Gerrit-Change-Number: 37998 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-pfcp[master]: coverity CID#313611
by laforge 04 Sep '24

04 Sep '24

Attention is currently required from: fixeria, neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/37993?usp=email ) Change subject: coverity CID#313611 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/37993?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ic5c87e029fe761b24ef9dcf801376da7b5a8d290 Gerrit-Change-Number: 37993 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Sep 2024 07:01:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: ctrl, hnbgw: access rate counter groups by given ID instead of index
by laforge 04 Sep '24

04 Sep '24

Attention is currently required from: neels, pespin. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37882?usp=email ) Change subject: ctrl, hnbgw: access rate counter groups by given ID instead of index ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: There's now also the proposal to revert to the original behaviour (always use numeric index 0): https://gerrit.osmocom.org/c/osmo-hnbgw/+/38002 Ideally libosmocore should enforce the "unique ID" rule only if there are no unique names being set. However, our API first creates the objcet with numeric ID, and then optionally sets the name in a second call - so there's no point where we can print a related error/warning message 😞 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I70e74e7554482df67aa1d90bc04314124dea444f Gerrit-Change-Number: 37882 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Sep 2024 06:57:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: ctrl, hnbgw: access rate counter groups by given ID instead of index
by neels 04 Sep '24

04 Sep '24

Attention is currently required from: laforge, pespin. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37882?usp=email ) Change subject: ctrl, hnbgw: access rate counter groups by given ID instead of index ...................................................................... Patch Set 4: (1 comment) Patchset: PS2: > I see this was resolved but there was no fedbac? I also couldn't see ant changes in the code? you are missing the use of array indexes in this API verifying rate counters via the ctrl interface. In addition to handling single objects, we also support handling N object instances at once in the counter validation API. For example, for MSC tests, we always have msc.0, msc.1, msc.2 in sequence. The API is such that you fetch all the (interesting) counters for all three instances at once. You get back an array of counter sets, the first array entry is for msc.0, the second for msc.1, etc. This array is then a cache; the test increments the expected values in the array, and then verifies it again with results fetched later. Crucially, the array index so far serves as the ID used on the CTRL interface. This was the result of first using the counter API in tests, and being annoyed by the repetetive bloat needed for multiple objects. Our ttcn test that I am trying to fix here already follows this logic of asking for hnb.0, and looking at the first entry of the returned array. -- turns out hnb.0 doesn't work reliably, and we need to use the name instead. We could keep the indexed-array stuff for index-able objects only, and force single-object access for by-name access, but that would probably introduce code duplication of the CTRL functions for counters. Callers then also need code dup for fetching N objects at once. Hence, the mapping from index to name: it allows using the same logic, the same API and the same CTRL code, just for names instead of indexes. Define a list of names once, then continue using array indexes. This also reduces repetition of name strings in ttcn code, cleaner. It also allows iterating the counters of instances. I do not want to remove this layer of abstraction for by-name counters, because it is powerful. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I70e74e7554482df67aa1d90bc04314124dea444f Gerrit-Change-Number: 37882 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Sep 2024 02:55:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: rate_ctr,CTRL[1/2]: GET using rate_ctr_group_set_name()
by neels 04 Sep '24

04 Sep '24

Attention is currently required from: laforge, pespin. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmocore/+/37881?usp=email ) Change subject: rate_ctr,CTRL[1/2]: GET using rate_ctr_group_set_name() ...................................................................... Patch Set 5: Code-Review-1 (1 comment) File src/ctrl/control_if.c: https://gerrit.osmocom.org/c/libosmocore/+/37881/comment/04b8218e_3bea1441?… : PS5, Line 690: by_id ah no, still an "id" naming here... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I841a12f76e6fcb2bd7aecb5f4b1707d9ec927137 Gerrit-Change-Number: 37881 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Sep 2024 02:32:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: rate_ctr,CTRL[2/2]: log ctrg inst names invalid for CTRL
by neels 04 Sep '24

04 Sep '24

neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmocore/+/38020?usp=email ) Change subject: rate_ctr,CTRL[2/2]: log ctrg inst names invalid for CTRL ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38020?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic721219649e20960c7af5765ee4d3b641fef5081 Gerrit-Change-Number: 38020 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 04 Sep 2024 02:25:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log