Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38118?usp=email )
Change subject: utils: support alpha identifier in enc/dec_msisdn
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
do we really want to continue to use those functions if we have proper construct encoder/decoder in place, which handle all scenarios? I'd rathe say as soon as we've converted all users, we shoul remove {enc,dec}_msisdn?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/38118?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I19ec8ba14551ec282fc0cc12ae2f6d528bdfc527
Gerrit-Change-Number: 38118
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 12 Sep 2024 11:33:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38117?usp=email )
Change subject: ts_51_011: replace encoding of EF.MSISDN with construct model
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I think this is incompatible with earlier versions of pySim, right? So if somebody has existing scripts to update the MSISDN, it would not work with the new format. I know we did that quite a bit in the early development of pySim-shell days, but today I would say we have many more users and existing manuals / documentations / scripts / ...
At the same time we don't want to prevent improvements.
The best is probably to start some kind of changelog where we document incompatible changes.
Alternatively, at least in this case, we could add some kind of compatibility wrapper. if the caller provides a dict with 'msisdn' as key, we know it's the old format and we could convert that to the new json format before calling the encoder?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/38117?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I647f5c63f7f87902a86c0c5d8e92fdc7f4350a5a
Gerrit-Change-Number: 38117
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 12 Sep 2024 11:32:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-trx/+/38114?usp=email )
Change subject: contrib/jenkins: remove broken chroot + qemu code
......................................................................
contrib/jenkins: remove broken chroot + qemu code
The mirror where it would download images from is not online anymore,
and it looks like this whole block has not been executed in years (we
always test the arm builds on native arm machines nowadays, and run all
builds in docker).
Replace the whole block with a simple check that ensures when arm flags
are used, that the build is actually running on an arm machine.
Change-Id: I2e204e4a0a7dfcf32f011ed6fb403b564f8155a7
---
M contrib/jenkins.sh
1 file changed, 13 insertions(+), 54 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/14/38114/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/38114?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I2e204e4a0a7dfcf32f011ed6fb403b564f8155a7
Gerrit-Change-Number: 38114
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/38113?usp=email )
Change subject: contrib/jenkins: remove duplicate "set -ex"
......................................................................
contrib/jenkins: remove duplicate "set -ex"
There is already a "set -ex" on top of the file, no need to set it
again.
Change-Id: Ia071f1f1d37cd1936d6a4001edfe2c5c335787b8
---
M contrib/jenkins.sh
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/13/38113/1
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 73d3ffd..dc04540 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -62,8 +62,6 @@
fi
fi
-set -ex
-
if ! [ -x "$(command -v osmo-build-dep.sh)" ]; then
echo "Error: We need to have scripts/osmo-deps.sh from http://git.osmocom.org/osmo-ci/ in PATH !"
exit 2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/38113?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ia071f1f1d37cd1936d6a4001edfe2c5c335787b8
Gerrit-Change-Number: 38113
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>