- gerrit-log - lists.osmocom.org

[XS] Change in ...pyosmocom[master]: Allow caller to pass total_len in context of osmocom.construct.build_...
by dexter 17 Sep '24

17 Sep '24

Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38187?usp=email ) Change subject: Allow caller to pass total_len in context of osmocom.construct.build_construct ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmocom/construct.py: https://gerrit.osmocom.org/c/python/pyosmocom/+/38187/comment/4c2ee6ed_9742… : PS1, Line 496: return c.build(decoded_data, **context) This is probably the safest way in terms of API stability. I solved it with an extra parameter to make it look more uniform to parse_construct: def build_construct(c, decoded_data, length: typing.Optional[int] = None, context: dict = {}): -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I7c4eab60274bcb0dd95e7bc21867a37ad70e4fc0 Gerrit-Change-Number: 38187 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 17 Sep 2024 13:29:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: osmocom.construct: Don't forget context when calling sizeof in Rpad
by dexter 17 Sep '24

17 Sep '24

Attention is currently required from: dexter, laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38186?usp=email ) Change subject: osmocom.construct: Don't forget context when calling sizeof in Rpad ...................................................................... Patch Set 1: Code-Review+2 Verified+1 (1 comment) Patchset: PS1: Tested it and it seems to work as expected. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I97e4b8fffcccba0b9d0ecb18c76a2a30fd990fd2 Gerrit-Change-Number: 38186 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Sep 2024 13:26:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: Allow caller to pass total_len in context of osmocom.construct.build_...
by laforge 17 Sep '24

17 Sep '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38187?usp=email ) Change subject: Allow caller to pass total_len in context of osmocom.construct.build_construct ...................................................................... Allow caller to pass total_len in context of osmocom.construct.build_construct The current code hard-coded 'total_len' as None during build_construct, which prevented the caller from passing a different value in the context. Let's change it in a way that the default remains None, but the caller can override it. This is useful for pySim size computations that depend on the target size of the file/record. Change-Id: I7c4eab60274bcb0dd95e7bc21867a37ad70e4fc0 --- M src/osmocom/construct.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/87/38187/1 diff --git a/src/osmocom/construct.py b/src/osmocom/construct.py index 8f01f3c..def5d85 100644 --- a/src/osmocom/construct.py +++ b/src/osmocom/construct.py @@ -492,7 +492,8 @@ def build_construct(c, decoded_data, context: dict = {}): """Helper function to handle total_len.""" - return c.build(decoded_data, total_len=None, **context) + context.setdefault('total_len', None) + return c.build(decoded_data, **context) # here we collect some shared / common definitions of data types LV = Prefixed(Int8ub, HexAdapter(GreedyBytes)) -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I7c4eab60274bcb0dd95e7bc21867a37ad70e4fc0 Gerrit-Change-Number: 38187 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in ...pyosmocom[master]: osmocom.construct: Don't forget context when calling sizeof in Rpad
by laforge 17 Sep '24

17 Sep '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38186?usp=email ) Change subject: osmocom.construct: Don't forget context when calling sizeof in Rpad ...................................................................... osmocom.construct: Don't forget context when calling sizeof in Rpad When calling the self.sizeof() method, we must pass in the context in order to make expressions like 'this._.total_len' work. Change-Id: I97e4b8fffcccba0b9d0ecb18c76a2a30fd990fd2 --- M src/osmocom/construct.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/86/38186/1 diff --git a/src/osmocom/construct.py b/src/osmocom/construct.py index 753b5de..8f01f3c 100644 --- a/src/osmocom/construct.py +++ b/src/osmocom/construct.py @@ -341,7 +341,7 @@ return obj.rstrip(self.pattern) def _encode(self, obj, context, path): - target_size = self.sizeof() * self.num_per_byte + target_size = self.sizeof(**context) * self.num_per_byte if len(obj) > target_size: raise SizeofError("Input ({}) exceeds target size ({})".format( len(obj), target_size)) -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I97e4b8fffcccba0b9d0ecb18c76a2a30fd990fd2 Gerrit-Change-Number: 38186 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-ttcn3-hacks[master]: testenv: get coredump + backtrace on crash
by osmith 17 Sep '24

17 Sep '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38185?usp=email ) Change subject: testenv: get coredump + backtrace on crash ...................................................................... testenv: get coredump + backtrace on crash If the SUT or another test component crashes, check if a matching coredump was registered in coredumpctl. If that is the case, then copy it into the testdir and print + store the backtrace. This solves the problem that it is especially tricky to get a good backtrace when a component crashes inside a container. One needs to grab the coredump from the host (usually handled by systemd-coredump, we cannot override /proc/sys/kernel/core_pattern for containers so it can't be handled in the container), then put the coredump into the container and finally run gdb to get the backtrace inside the container (where proper libraries and debug symbols are). This patch automates all of these steps. Pau requested this feature. Related: OS#6494 Change-Id: I743c20968bda9b6d6fb9c2d23bef70ee11950761 --- M _testenv/data/podman/Dockerfile A _testenv/testenv/coredump.py M _testenv/testenv/daemons.py M _testenv/testenv/podman.py 4 files changed, 100 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/38185/1 diff --git a/_testenv/data/podman/Dockerfile b/_testenv/data/podman/Dockerfile index 95a8c66..42b0635 100644 --- a/_testenv/data/podman/Dockerfile +++ b/_testenv/data/podman/Dockerfile @@ -22,6 +22,7 @@ ccache \ cmake \ flex \ + gdb \ git \ iproute2 \ iputils-ping \ diff --git a/_testenv/testenv/coredump.py b/_testenv/testenv/coredump.py new file mode 100644 index 0000000..0d56328 --- /dev/null +++ b/_testenv/testenv/coredump.py @@ -0,0 +1,89 @@ +# Copyright 2024 sysmocom - s.f.m.c. GmbH +# SPDX-License-Identifier: GPL-3.0-or-later +import datetime +import fnmatch +import json +import logging +import os +import shlex +import shutil +import subprocess +import testenv +import testenv.daemons +import testenv.testdir + +executable_path = None + + +def executable_is_relevant(exe): + if testenv.args.binary_repo: + patterns = [ + "*/usr/bin/open5gs-*", + "*/usr/bin/osmo-*", + ] + + for pattern in patterns: + if fnmatch.fnmatch(exe, pattern): + return True + else: + if exe.startswith(testenv.args.cache): + return True + + return False + + +def get_from_coredumpctl(): + global executable_path + + logging.info("Looking for a coredump") + + if not shutil.which("coredumpctl"): + logging.debug("coredumpctl is not available, won't try to get coredump") + return + + # Check for any coredump within last 3 seconds + since = (datetime.datetime.now() - datetime.timedelta(seconds=3)).strftime("%Y-%m-%d %H:%M:%S") + cmd = ["coredumpctl", "-q", "-S", since, "--json=short", "-n1"] + logging.debug(f"+ {cmd}") + + p = subprocess.run(cmd, capture_output=True, text=True) + if p.returncode != 0: + logging.debug("No coredump found") + return + + # Check if the coredump executable is from osmo-*, open5gs-*, etc. + coredump = json.loads(p.stdout)[0] + if not executable_is_relevant(coredump["exe"]): + logging.debug("Found an unrelated coredump, ignoring") + return + + logging.debug("Coredump found, copying to log dir") + core_path = f"{testenv.testdir.testdir}/core" + testenv.cmd.run( + ["coredumpctl", "dump", "-q", "-S", since, "-o", core_path, str(coredump["pid"]), coredump["exe"]], + stdout=subprocess.DEVNULL, + no_podman=True, + ) + + executable_path = coredump["exe"] + + +def get_backtrace(): + global executable_path + + core_path = f"{testenv.testdir.testdir}/core" + if not executable_path or not os.path.exists(core_path): + return + + logging.info("Running gdb to get a backtrace") + + cmd = "gdb" + cmd += " --batch" + cmd += f" {shlex.quote(executable_path)}" + cmd += f" {shlex.quote(core_path)}" + cmd += " -ex bt" + cmd += f" | tee {shlex.quote(core_path)}.backtrace" + + testenv.cmd.run(cmd) + + executable_path = None diff --git a/_testenv/testenv/daemons.py b/_testenv/testenv/daemons.py index c7e8722..0c9c0dd 100644 --- a/_testenv/testenv/daemons.py +++ b/_testenv/testenv/daemons.py @@ -7,6 +7,7 @@ import shlex import subprocess import testenv +import testenv.coredump import testenv.testdir import time import sys @@ -18,6 +19,8 @@ def init(): global run_shell_on_stop + atexit.register(testenv.coredump.get_backtrace) + if not testenv.args.podman: atexit.register(stop) if testenv.args.shell: @@ -111,6 +114,8 @@ return current_test = testenv.testsuite.get_current_test() + testenv.coredump.get_from_coredumpctl() + if current_test: logging.error(f"{daemon_name} crashed during {current_test}!") testenv.testsuite.wait_until_test_stopped() diff --git a/_testenv/testenv/podman.py b/_testenv/testenv/podman.py index 2668b0d..6d801fa 100644 --- a/_testenv/testenv/podman.py +++ b/_testenv/testenv/podman.py @@ -10,6 +10,7 @@ import subprocess import testenv.cmd import testenv.testdir +import testenv.coredump import time image_name = None @@ -276,6 +277,10 @@ if not is_running(): return + # If we have a coredump, we must get the backtrace by running gdb inside + # the container. So do it before stopping the container. + testenv.coredump.get_backtrace() + if not restart and run_shell_on_stop: logging.info("Running interactive shell before stopping container (--shell)") -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I743c20968bda9b6d6fb9c2d23bef70ee11950761 Gerrit-Change-Number: 38185 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in libosmo-abis[master]: trau2rtp EFR unit test: add patterns with bad CRC
by pespin 17 Sep '24

17 Sep '24

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38184?usp=email ) Change subject: trau2rtp EFR unit test: add patterns with bad CRC ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iee69b6a1593bdc8d11904a5f2ad46cd0fc6052a9 Gerrit-Change-Number: 38184 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 17 Sep 2024 11:48:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySim-prog: generate Ki and OPc value using _digits() function
by dexter 17 Sep '24

17 Sep '24

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/38164?usp=email ) Change subject: pySim-prog: generate Ki and OPc value using _digits() function ...................................................................... Abandoned unfortunately this is not secure, so we cannot solve the problem this way. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38164?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib53d9d04a2073dafcca7cd21b0324bee5a23c540 Gerrit-Change-Number: 38164 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: pySim-prog: add FIXME note to tell that writing hlr.db files is broken
by dexter 17 Sep '24

17 Sep '24

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38162?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: pySim-prog: add FIXME note to tell that writing hlr.db files is broken ...................................................................... pySim-prog: add FIXME note to tell that writing hlr.db files is broken The writing to osmo-hlr SQLITE files is broken since the SQLITE format has evolved over time. Let's add a FIXME note to tell that this needs fixing. Related: SYS#4120 Change-Id: I2b23f8bb9f3c2adeb48b010834057f5b4fb1e626 --- M pySim-prog.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/62/38162/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38162?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2b23f8bb9f3c2adeb48b010834057f5b4fb1e626 Gerrit-Change-Number: 38162 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[M] Change in pysim[master]: pySim-prog: rework documentation
by dexter 17 Sep '24

17 Sep '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38166?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim-prog: rework documentation ...................................................................... pySim-prog: rework documentation The documentation for the classic pySim-prog application is a bit sparse. Let's rework it so that it includes the most important information that is required to operate pySim-prog. Let's also add a section about how the batch mode and CSV files are used. Related: SYS#4120 Change-Id: I1d1a65154cea7fa77428b412fcf8c7b4cba629b1 --- M docs/legacy.rst 1 file changed, 171 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/66/38166/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38166?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1d1a65154cea7fa77428b412fcf8c7b4cba629b1 Gerrit-Change-Number: 38166 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: pySim-prog: add FIXME note to tell that writing hlr.db files is broken
by dexter 17 Sep '24

17 Sep '24

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38162?usp=email ) Change subject: pySim-prog: add FIXME note to tell that writing hlr.db files is broken ...................................................................... Patch Set 3: (1 comment) File pySim-prog.py: https://gerrit.osmocom.org/c/pysim/+/38162/comment/aab5c7fd_92eb1560?usp=em… : PS2, Line 627: dabase > database Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38162?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2b23f8bb9f3c2adeb48b010834057f5b4fb1e626 Gerrit-Change-Number: 38162 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 17 Sep 2024 08:40:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log