osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38337?usp=email )
Change subject: testenv: podman: remove mongodb-org.list
......................................................................
testenv: podman: remove mongodb-org.list
Remove mongodb-org.list at the end of building the podman image, as we
only need to install mongodb once in the container but won't use the
repository afterwards. This avoids checking the mongodb repository in
"apt update".
Change-Id: I5a0455a4dbf8a31366bff65fd011fd5494b64ea7
---
M _testenv/data/podman/Dockerfile
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/_testenv/data/podman/Dockerfile b/_testenv/data/podman/Dockerfile
index 42b0635..013c03d 100644
--- a/_testenv/data/podman/Dockerfile
+++ b/_testenv/data/podman/Dockerfile
@@ -121,4 +121,5 @@
apt-get install -y mongodb-org && \
apt-get clean && \
cd / && \
- rm -rf /tmp/mongodb
+ rm -rf /tmp/mongodb && \
+ rm /etc/apt/sources.list.d/mongodb-org.list
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38337?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5a0455a4dbf8a31366bff65fd011fd5494b64ea7
Gerrit-Change-Number: 38337
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38336?usp=email )
Change subject: testenv: requirements: find programs in /usr/sbin
......................................................................
testenv: requirements: find programs in /usr/sbin
Fix that testenv complains about a missing setcap program, if it is in
/usr/sbin/setcap and /usr/sbin is not in PATH as it is the case with
Debian. We actually run setcap with sudo when it is needed, and in that
case /usr/sbin gets added to PATH in Debian.
Fix for:
[testenv] Missing program: setcap
Change-Id: Ibbccba013ac38415ef46467f97bef846b848cf39
---
M _testenv/testenv/requirements.py
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/_testenv/testenv/requirements.py b/_testenv/testenv/requirements.py
index 7badbe9..d65e436 100644
--- a/_testenv/testenv/requirements.py
+++ b/_testenv/testenv/requirements.py
@@ -38,6 +38,12 @@
abort = False
for program in programs:
if not shutil.which(program):
+ if os.path.exists(os.path.join("/usr/sbin", program)):
+ # Debian: some programs such as setcap are in /usr/sbin, which
+ # is not in PATH unless using sudo. Therefore "shutil.which()"
+ # won't find it.
+ continue
+
logging.error(f"Missing program: {program}")
if program == "ttcn3_compiler":
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38336?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibbccba013ac38415ef46467f97bef846b848cf39
Gerrit-Change-Number: 38336
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: jolly, laforge, pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review-1 by pespin, Verified+1 by Jenkins Builder
Change subject: After writing VTY config, run sync() in a different thread
......................................................................
After writing VTY config, run sync() in a different thread
Running sync() after writing VTY config causes the process to stop for
a fraction of a second. This may result in delayed processing that
causes buffer underruns, overflows and delay. This is a problem with
applications that do real-time signal processing such as osmo-trx and
osmo-bts.
After some discussions, I decided to simply remove the sync() commands
from the VTY's write function. There is still a backup file created
of the previously saved configuration before writing the current
configurtion. Loosing current configuration caused by a system crash
afterwards is very unlikely with modern file systems.
Related: OS#6438
Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44
---
M src/vty/command.c
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/98/37798/6
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44
Gerrit-Change-Number: 37798
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Hoernchen <ewild(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38356?usp=email )
Change subject: vlr: use correct types for vlr_timer
......................................................................
vlr: use correct types for vlr_timer
A timer T is always an integer. Also osmo_tdef_get returns an unsigned long.
Match the types from osmo_tdef.
Change-Id: Ic46ddb578962619fc08bd63645c76852e676fcc9
---
M include/osmocom/vlr/vlr.h
M src/libvlr/vlr.c
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/56/38356/1
diff --git a/include/osmocom/vlr/vlr.h b/include/osmocom/vlr/vlr.h
index 27b40c2..90147ba 100644
--- a/include/osmocom/vlr/vlr.h
+++ b/include/osmocom/vlr/vlr.h
@@ -424,7 +424,7 @@
bool vlr_subscr_matches_msisdn(struct vlr_subscr *vsub, const char *msisdn);
bool vlr_subscr_matches_imei(struct vlr_subscr *vsub, const char *imei);
-uint32_t vlr_timer(struct vlr_instance *vlr, uint32_t timer);
+unsigned long vlr_timer(struct vlr_instance *vlr, int timer);
int vlr_subscr_changed(struct vlr_subscr *vsub);
int vlr_subscr_purge(struct vlr_subscr *vsub) __attribute__((warn_unused_result));
diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index f160578..866a63d 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -203,7 +203,7 @@
/* This is just a wrapper around the osmo_tdef API.
* TODO: we should start using osmo_tdef_fsm_inst_state_chg() */
-uint32_t vlr_timer(struct vlr_instance *vlr, uint32_t timer)
+unsigned long vlr_timer(struct vlr_instance *vlr, int timer)
{
/* NOTE: since we usually do not need more than one instance of the VLR,
* and since libosmocore's osmo_tdef API does not (yet) support dynamic
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38356?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic46ddb578962619fc08bd63645c76852e676fcc9
Gerrit-Change-Number: 38356
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: dexter, laforge, lynxis lazus, pespin.
Hello Jenkins Builder, dexter, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-msc/+/38111?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+2 by dexter, Code-Review+2 by pespin, Verified-1 by Jenkins Builder
Change subject: Move vlr.h & vlr_sgs.h into osmocom/vlr/
......................................................................
Move vlr.h & vlr_sgs.h into osmocom/vlr/
Prepare libvlr to be independent, start by moving the vlr headers
into its own directory.
Change-Id: I8b18b05091b35e744b3234d1ce0d537f56bccf07
---
M configure.ac
M include/osmocom/Makefile.am
M include/osmocom/msc/Makefile.am
M include/osmocom/msc/sgs_iface.h
M include/osmocom/msc/transaction_cc.h
A include/osmocom/vlr/Makefile.am
R include/osmocom/vlr/vlr.h
R include/osmocom/vlr/vlr_sgs.h
M src/libmsc/ctrl_commands.c
M src/libmsc/db.c
M src/libmsc/e_link.c
M src/libmsc/gsm_04_08.c
M src/libmsc/gsm_04_08_cc.c
M src/libmsc/gsm_04_11.c
M src/libmsc/gsm_04_11_gsup.c
M src/libmsc/gsm_09_11.c
M src/libmsc/mncc_call.c
M src/libmsc/msc_a.c
M src/libmsc/msc_a_remote.c
M src/libmsc/msc_ho.c
M src/libmsc/msc_net_init.c
M src/libmsc/msc_t.c
M src/libmsc/msc_vgcs.c
M src/libmsc/msc_vty.c
M src/libmsc/msub.c
M src/libmsc/paging.c
M src/libmsc/ran_conn.c
M src/libmsc/ran_peer.c
M src/libmsc/sgs_iface.c
M src/libmsc/silent_call.c
M src/libmsc/sms_queue.c
M src/libmsc/transaction.c
M src/libsmpputil/smpp_msc.c
M src/libvlr/vlr.c
M src/libvlr/vlr_access_req_fsm.c
M src/libvlr/vlr_auth_fsm.c
M src/libvlr/vlr_core.h
M src/libvlr/vlr_lu_fsm.c
M src/libvlr/vlr_sgs.c
M src/libvlr/vlr_sgs_fsm.c
M tests/db_sms/db_sms_test.c
M tests/msc_vlr/msc_vlr_test_rest.c
M tests/msc_vlr/msc_vlr_tests.h
M tests/sms_queue/sms_queue_test.c
44 files changed, 51 insertions(+), 47 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/11/38111/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38111?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8b18b05091b35e744b3234d1ce0d537f56bccf07
Gerrit-Change-Number: 38111
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: lynxis lazus, pespin.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-msc/+/38107?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: libvlr: replace direct call of paging_expired() into a callback
......................................................................
libvlr: replace direct call of paging_expired() into a callback
libmsc internal functions shouldn't be called from within the libvlr.
Re-use the paging callback with an osmocom specific indication to
inform it to cancel paging.
Change-Id: I7a3d15e8f0fb51c6b32add2de5024fc4d599ecf0
---
M include/osmocom/msc/sgs_iface.h
M include/osmocom/msc/vlr_sgs.h
M src/libmsc/paging.c
M src/libmsc/sgs_iface.c
M src/libvlr/vlr_sgs_fsm.c
5 files changed, 13 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/07/38107/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38107?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I7a3d15e8f0fb51c6b32add2de5024fc4d599ecf0
Gerrit-Change-Number: 38107
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: laforge, pespin.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/38125?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: protocol: gsm 29.118: add SGSAP_SERV_IND_PAGING_TIMEOUT (osmocom specific)
......................................................................
protocol: gsm 29.118: add SGSAP_SERV_IND_PAGING_TIMEOUT (osmocom specific)
To simplify the code, extend the service indication to also indicate
a paging timeout. The VLR is using this type to indicate paging
timeouts or aborting paging in case the SGs state has been terminated.
Related: OS#6547
Change-Id: I58bfba50cb9c8aff2cd1cfe88d6467d4d2bd17cb
---
M include/osmocom/gsm/protocol/gsm_29_118.h
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/25/38125/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38125?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I58bfba50cb9c8aff2cd1cfe88d6467d4d2bd17cb
Gerrit-Change-Number: 38125
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38125?usp=email )
Change subject: protocol: gsm 29.118: add SGSAP_SERV_IND_PAGING_TIMEOUT (osmocom specific)
......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
> ... and this is even stuck for two minor cosmetic changes for more than three weeks. @lynxis@fe80. […]
Done
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/38125/comment/e842bc4b_19bf2a56?… :
PS1, Line 10: a paging timeout. The VLR is susing this type to indicate paging
> didn't know Suse was developing VLRs :) (typo "susing")
Done
https://gerrit.osmocom.org/c/libosmocore/+/38125/comment/9e418038_ff3e4921?… :
PS1, Line 11: timeouts or aborting paging in case the SGS state has been terminated.
> SGs?
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38125?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I58bfba50cb9c8aff2cd1cfe88d6467d4d2bd17cb
Gerrit-Change-Number: 38125
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Oct 2024 21:00:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>