- gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: tests/vty: Show bug inserting routes with different priority
by pespin 09 Oct '24

09 Oct '24

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38374?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: tests/vty: Show bug inserting routes with different priority ...................................................................... tests/vty: Show bug inserting routes with different priority route lookup ((hmrt_message_for_routing() => osmo_ss7_route_lookup() => osmo_ss7_route_find_dpc_mask())) iterates the list of routes assuming they are ordered by mask length (so it doesn't need to iterate the full list every time). Similary, it implicitly seems to assume that the entries are also sorted by priority. However, priority is not currently taken into account when being inserted in the routing table, so the route ends up in the incorrect place. This commit adds a VTY test showing the wrong insert. Related: SYS#7112 Change-Id: I125046fcbc7563c3275f42ff9de2aa351ae616c1 --- M tests/vty/Makefile.am A tests/vty/osmo_stp_route_prio.vty 2 files changed, 90 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/74/38374/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38374?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I125046fcbc7563c3275f42ff9de2aa351ae616c1 Gerrit-Change-Number: 38374 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in libosmo-sigtran[master]: tests/vty/Makefile.am: Allow testing with specific vty file
by pespin 09 Oct '24

09 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38373?usp=email ) Change subject: tests/vty/Makefile.am: Allow testing with specific vty file ...................................................................... tests/vty/Makefile.am: Allow testing with specific vty file Change-Id: Ia0d53007334aaa3df35d1c821c520af4952b7843 --- M tests/vty/Makefile.am 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/73/38373/1 diff --git a/tests/vty/Makefile.am b/tests/vty/Makefile.am index 3d35c25..4157bcb 100644 --- a/tests/vty/Makefile.am +++ b/tests/vty/Makefile.am @@ -28,17 +28,23 @@ vty-python-test: $(top_builddir)/stp/osmo-stp $(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v +# Run a specific test with: 'make vty-test VTY_TEST_STP=osmo_stp_test.vty' +VTY_TEST_STP ?= osmo_stp_*.vty + vty-transcript-test-stp: $(top_builddir)/stp/osmo-stp osmo_verify_transcript_vty.py -v \ -n OsmoSTP -p 4239 \ -r "$(top_builddir)/stp/osmo-stp -c $(top_srcdir)/doc/examples/osmo-stp-multihome.cfg" \ - $(U) $(srcdir)/osmo_stp_*.vty + $(U) $(srcdir)/$(VTY_TEST_STP) + +# Run a specific test with: 'make vty-test VTY_TEST_ASP=ss7_asp_test.vty' +VTY_TEST_ASP ?= ss7_asp_*.vty vty-transcript-test-asp: ss7_asp_vty_test osmo_verify_transcript_vty.py -v \ -p 42043 \ -r "$(builddir)/ss7_asp_vty_test" \ - $(U) $(srcdir)/ss7_asp_*.vty + $(U) $(srcdir)/$(VTY_TEST_ASP) # To update the VTY script from current application behavior, # pass -u to osmo_verify_transcript_vty.py by doing: -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38373?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia0d53007334aaa3df35d1c821c520af4952b7843 Gerrit-Change-Number: 38373 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: tests/vty: Show bug inserting routes with different priority
by pespin 09 Oct '24

09 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38374?usp=email ) Change subject: tests/vty: Show bug inserting routes with different priority ...................................................................... tests/vty: Show bug inserting routes with different priority route lookup ((hmrt_message_for_routing() => osmo_ss7_route_lookup() => osmo_ss7_route_find_dpc_mask())) iterates the list of routes assuming they are ordered by mask length (so it doesn't need to iterate the full list every time). Similary, it implicitly seems to assume that the entries are also sorted by priority. However, priority is not currently taken into account when being inserted in the routing table, so the route ends up in the incorrect place. This commit adds a VTY test showing the wrong insert. Related: SYS#7112 Change-Id: I125046fcbc7563c3275f42ff9de2aa351ae616c1 --- M tests/vty/Makefile.am A tests/vty/osmo_stp_route_prio.vty 2 files changed, 71 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/74/38374/1 diff --git a/tests/vty/Makefile.am b/tests/vty/Makefile.am index 4157bcb..4b09f6d 100644 --- a/tests/vty/Makefile.am +++ b/tests/vty/Makefile.am @@ -7,6 +7,7 @@ EXTRA_DIST = \ osmo_stp_test.vty \ + osmo_stp_route_prio.vty \ ss7_asp_test.vty \ vty_test_runner.py \ $(NULL) diff --git a/tests/vty/osmo_stp_route_prio.vty b/tests/vty/osmo_stp_route_prio.vty new file mode 100644 index 0000000..661b3ad --- /dev/null +++ b/tests/vty/osmo_stp_route_prio.vty @@ -0,0 +1,70 @@ +OsmoSTP> enable +OsmoSTP# configure terminal +OsmoSTP(config)# cs7 instance 0 + +OsmoSTP(config-cs7)# ! CREATE 2 AS with 1 ASP EACH: +OsmoSTP(config-cs7)# asp asp1 2905 54321 m3ua +OsmoSTP(config-cs7-asp)# remote-ip 127.0.0.100 +OsmoSTP(config-cs7-asp)# local-ip 27.0.0.1 +OsmoSTP(config-cs7-asp)# exit +OsmoSTP(config-cs7)# asp asp2 2905 54321 m3ua +OsmoSTP(config-cs7-asp)# remote-ip 127.0.0.200 +OsmoSTP(config-cs7-asp)# local-ip 27.0.0.2 +OsmoSTP(config-cs7-asp)# exit +OsmoSTP(config-cs7)# as as1 m3ua +OsmoSTP(config-cs7-as)# asp asp1 +OsmoSTP(config-cs7-as)# routing-key 56 0.1.2 +OsmoSTP(config-cs7-as)# exit +OsmoSTP(config-cs7)# as as2 m3ua +OsmoSTP(config-cs7-as)# asp asp2 +OsmoSTP(config-cs7-as)# routing-key 57 0.2.4 +OsmoSTP(config-cs7-as)# exit +OsmoSTP(config-cs7)# show running-config +... +cs7 instance 0 + xua rkm routing-key-allocation dynamic-permitted + asp asp1 2905 54321 m3ua + local-ip 27.0.0.1 + remote-ip 127.0.0.100 + role sg + sctp-role server + asp asp2 2905 54321 m3ua + local-ip 27.0.0.2 + remote-ip 127.0.0.200 + role sg + sctp-role server + as as1 m3ua + asp asp1 + routing-key 56 0.1.2 + as as2 m3ua + asp asp2 + routing-key 57 0.2.4 + route-table system + listen m3ua 2905 + local-ip 127.0.0.2 + local-ip 127.0.0.1 + local-ip ::1 + accept-asp-connections dynamic-permitted +end + +OsmoSTP(config-cs7)# ! ADD 2 ROUTES WITH DECREASING PRIORITIES. THEY SHOULD END UP REORDERED BY PRIORITY: +OsmoSTP(config-cs7)# route-table system +OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset as1 priority 5 +OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset as2 priority 2 +OsmoSTP(config-cs7-rt)# ! FIXME! THIS IS WRONG ORDER: +OsmoSTP(config-cs7-rt)# show running-config +... +cs7 instance 0 +... + route-table system + update route 3.2.1 7.255.7 linkset as1 priority 5 + update route 3.2.1 7.255.7 linkset as2 priority 2 +... +OsmoSTP(config-cs7-rt)# do show cs7 instance 0 route +Routing table = system +C=Cong Q=QoS P=Prio + +Destination C Q P Linkset Name Linkset Non-adj Route +---------------------- - - - ------------------- ------- ------- ------- +3.2.1/14 5 as1 ? ? ? +3.2.1/14 2 as2 ? ? ? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38374?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I125046fcbc7563c3275f42ff9de2aa351ae616c1 Gerrit-Change-Number: 38374 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: WIP
by dexter 09 Oct '24

09 Oct '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38372?usp=email ) Change subject: WIP ...................................................................... WIP Change-Id: I6381eeef7fa19873ca0cc330a0ab43b7ef5096e4 --- M contrib/jenkins.sh 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/72/38372/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 5fa5226..de1d9f8 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -77,6 +77,11 @@ contrib/*.py ;; "docs") + virtualenv -p python3 venv --system-site-packages + . venv/bin/activate + + pip install -r requirements.txt + rm -rf docs/_build make -C "docs" html latexpdf -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38372?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6381eeef7fa19873ca0cc330a0ab43b7ef5096e4 Gerrit-Change-Number: 38372 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: Refactor diffing same GMM messages
by pespin 09 Oct '24

09 Oct '24

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email ) Change subject: Refactor diffing same GMM messages ...................................................................... Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie698d3a6894a5796663c22c8bfd12b47acda57e6 Gerrit-Change-Number: 37867 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 09 Oct 2024 14:18:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-sgsn[master]: move gsm48_gmm_att_tlvdef into gprs_gmm_util
by pespin 09 Oct '24

09 Oct '24

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37868?usp=email ) Change subject: move gsm48_gmm_att_tlvdef into gprs_gmm_util ...................................................................... Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I67dcdb986fd01dc093501d324b5c376246a5d30d Gerrit-Change-Number: 37868 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 09 Oct 2024 14:18:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySim.euicc: Fix ASN.1 encoding of integer values
by dexter 09 Oct '24

09 Oct '24

Attention is currently required from: dexter, laforge. dexter has uploaded a new patch set (#5) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38274?usp=email ) Change subject: pySim.euicc: Fix ASN.1 encoding of integer values ...................................................................... pySim.euicc: Fix ASN.1 encoding of integer values Change-Id: I26ee41705f5e95c5fa3a9997cbaebdacca3e89a7 Closes: SYS#7094 --- M pySim/euicc.py M requirements.txt M setup.py 3 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/74/38274/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38274?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I26ee41705f5e95c5fa3a9997cbaebdacca3e89a7 Gerrit-Change-Number: 38274 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: Refactor diffing same GMM messages
by lynxis lazus 09 Oct '24

09 Oct '24

Attention is currently required from: daniel, pespin. Hello Jenkins Builder, daniel, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email to look at the new patch set (#15). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: Refactor diffing same GMM messages ...................................................................... Refactor diffing same GMM messages gprs_gmm_attach_req_ies() isn'nt specific for the attach request. It also did not cover the full message because of a fixed message length when comparing both messages. A diff of the old and new GMM message is required to figure out if the MS/UE is retransmitting an old message or starting a new procedure. Change-Id: Ie698d3a6894a5796663c22c8bfd12b47acda57e6 --- M include/osmocom/sgsn/gprs_gmm.h M src/sgsn/gprs_gmm.c M src/sgsn/gprs_gmm_attach.c 3 files changed, 8 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/67/37867/15 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie698d3a6894a5796663c22c8bfd12b47acda57e6 Gerrit-Change-Number: 37867 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[M] Change in osmo-sgsn[master]: move gsm48_gmm_att_tlvdef into gprs_gmm_util
by lynxis lazus 09 Oct '24

09 Oct '24

Attention is currently required from: daniel, pespin. Hello Jenkins Builder, daniel, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37868?usp=email to look at the new patch set (#15). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: move gsm48_gmm_att_tlvdef into gprs_gmm_util ...................................................................... move gsm48_gmm_att_tlvdef into gprs_gmm_util The gprs_gmm.c is huge. Move message parsing into gprs_gmm_util.c. Change-Id: I67dcdb986fd01dc093501d324b5c376246a5d30d --- M include/osmocom/sgsn/Makefile.am A include/osmocom/sgsn/gprs_gmm_util.h M src/sgsn/Makefile.am M src/sgsn/gprs_gmm.c A src/sgsn/gprs_gmm_util.c M tests/gprs_routing_area/Makefile.am M tests/sgsn/Makefile.am 7 files changed, 67 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/68/37868/15 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I67dcdb986fd01dc093501d324b5c376246a5d30d Gerrit-Change-Number: 37868 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[M] Change in osmo-sgsn[master]: move gsm48_gmm_att_tlvdef into gprs_gmm_util
by lynxis lazus 09 Oct '24

09 Oct '24

Attention is currently required from: daniel, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37868?usp=email ) Change subject: move gsm48_gmm_att_tlvdef into gprs_gmm_util ...................................................................... Patch Set 14: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/37868/comment/b2989b8f_1d4c7a9b?us… : PS14, Line 9: The gprs_gmm.c is huge. Move message parsing into gprS_gmm_util.c. > gprs_ Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I67dcdb986fd01dc093501d324b5c376246a5d30d Gerrit-Change-Number: 37868 Gerrit-PatchSet: 14 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Oct 2024 13:58:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log