- gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: ss7 vty: Validate qos-class number being passed to 'update route'
by pespin 11 Oct '24

11 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38388?usp=email ) Change subject: ss7 vty: Validate qos-class number being passed to 'update route' ...................................................................... ss7 vty: Validate qos-class number being passed to 'update route' While at it, organize the related strings used in several places in the file. Change-Id: Ib81499d5ac692e1de463efe931381bbb68fd1131 --- M src/osmo_ss7_vty.c M tests/vty/osmo_stp_test.vty 2 files changed, 15 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/88/38388/1 diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index 06fa823..b1029ed 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -67,6 +67,14 @@ "SCTP (Stream Control Transmission Protocol)\n" \ "TCP (Transmission Control Protocol)\n" +#define QOS_CLASS_RANGE_STR "<0-255>" +#define QOS_CLASS_RANGE_HELP_STR "QoS Class\n" +#define QOS_CLASS_VAR_STR "(" QOS_CLASS_RANGE_STR "|default)" +#define QOS_CLASS_VAR_HELP_STR \ + QOS_CLASS_RANGE_HELP_STR \ + "Default QoS Class (0)\n" + + /* netinet/tcp.h */ static const struct value_string tcp_info_state_values[] = { { TCP_ESTABLISHED, "ESTABLISHED" }, @@ -341,7 +349,7 @@ } DEFUN_ATTR(cs7_rt_upd, cs7_rt_upd_cmd, - "update route POINT_CODE MASK linkset LS_NAME [priority] [PRIO] [qos-class] [(CLASS|default)]", + "update route POINT_CODE MASK linkset LS_NAME [priority] [PRIO] [qos-class] [" QOS_CLASS_VAR_STR "]", "Update the Route\n" "Update the Route\n" "Destination Point Code\n" @@ -351,8 +359,7 @@ "Specify Priority\n" "Priority\n" "Specify QoS Class\n" - "QoS Class\n" - "Default QoS Class\n", + QOS_CLASS_VAR_HELP_STR, CMD_ATTR_IMMEDIATE) { struct osmo_ss7_route_table *rtable = vty->index; @@ -1073,9 +1080,9 @@ } DEFUN_ATTR(asp_qos_clas, asp_qos_class_cmd, - "qos-class <0-255>", + "qos-class " QOS_CLASS_RANGE_STR, "Specify QoS Class of ASP\n" - "QoS Class of ASP\n", + QOS_CLASS_RANGE_HELP_STR, CMD_ATTR_NODE_EXIT) { struct osmo_ss7_asp *asp = vty->index; @@ -1934,9 +1941,9 @@ } DEFUN_ATTR(as_qos_clas, as_qos_class_cmd, - "qos-class <0-255>", + "qos-class " QOS_CLASS_RANGE_STR, "Specity QoS Class of AS\n" - "QoS Class of AS\n", + QOS_CLASS_RANGE_HELP_STR, CMD_ATTR_IMMEDIATE) { struct osmo_ss7_as *as = vty->index; diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index b2f5270..33e092b 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -570,7 +570,7 @@ OsmoSTP(config-cs7)# route-table system OsmoSTP(config-cs7-rt)# list ... - update route POINT_CODE MASK linkset LS_NAME [priority] [PRIO] [qos-class] [(CLASS|default)] + update route POINT_CODE MASK linkset LS_NAME [priority] [PRIO] [qos-class] [(<0-255>|default)] remove route POINT_CODE MASK OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass OsmoSTP(config-cs7-rt)# show running-config -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38388?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib81499d5ac692e1de463efe931381bbb68fd1131 Gerrit-Change-Number: 38388 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: ss7 vty: Handle 'update route ... qos-class default' properly
by pespin 11 Oct '24

11 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38387?usp=email ) Change subject: ss7 vty: Handle 'update route ... qos-class default' properly ...................................................................... ss7 vty: Handle 'update route ... qos-class default' properly If "default" is passed, use the default value generated by ss7_route_alloc() (zero). A follow-up patch will be submitted to also force the CLASS to be a number. Change-Id: I370bc19ef5cf2d21fa3408baf26bf8d1ce7bf362 --- M src/osmo_ss7_vty.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/87/38387/1 diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index a43e312..06fa823 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -410,7 +410,9 @@ if (argc > argind && !strcmp(argv[argind], "qos-class")) { argind++; - rt->cfg.qos_class = atoi(argv[argind++]); + if (strcmp(argv[argind], "default") != 0) + rt->cfg.qos_class = atoi(argv[argind]); + argind++; } if ((rc = ss7_route_insert(rt)) < 0) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38387?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I370bc19ef5cf2d21fa3408baf26bf8d1ce7bf362 Gerrit-Change-Number: 38387 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in pysim[master]: pySim-shell_test: re-enable test_list_and_rm_notif
by osmith 11 Oct '24

11 Oct '24

Attention is currently required from: dexter. osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38369?usp=email ) Change subject: pySim-shell_test: re-enable test_list_and_rm_notif ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38369?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95eb3b9c02a69653797851197e882ea9316805fc Gerrit-Change-Number: 38369 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Oct 2024 14:33:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySim.euicc: Fix ASN.1 encoding of integer values
by osmith 11 Oct '24

11 Oct '24

Attention is currently required from: dexter, laforge. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38274?usp=email ) Change subject: pySim.euicc: Fix ASN.1 encoding of integer values ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38274?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I26ee41705f5e95c5fa3a9997cbaebdacca3e89a7 Gerrit-Change-Number: 38274 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Oct 2024 14:33:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: jenkins: build docs in virtualenv as well
by dexter 11 Oct '24

11 Oct '24

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38372?usp=email ) Change subject: jenkins: build docs in virtualenv as well ...................................................................... jenkins: build docs in virtualenv as well The build system uses a virtual environment, in which it installs pysim and its dependencies. This is done for the integration tests, but not when building the sphinx documentation. However, the documentation build process also invokes pysim code to generate documentation from the docstrings. This means we need pysim with all its dependencies for the doc building as well. Change-Id: I6381eeef7fa19873ca0cc330a0ab43b7ef5096e4 Related: SYS#7094 --- M contrib/jenkins.sh 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 5fa5226..de1d9f8 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -77,6 +77,11 @@ contrib/*.py ;; "docs") + virtualenv -p python3 venv --system-site-packages + . venv/bin/activate + + pip install -r requirements.txt + rm -rf docs/_build make -C "docs" html latexpdf -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38372?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6381eeef7fa19873ca0cc330a0ab43b7ef5096e4 Gerrit-Change-Number: 38372 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[L] Change in osmo-sgsn[master]: Add Routing Areas
by lynxis lazus 11 Oct '24

11 Oct '24

Attention is currently required from: daniel, lynxis lazus, pespin. Hello Jenkins Builder, daniel, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email to look at the new patch set (#16). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: Add Routing Areas ...................................................................... Add Routing Areas Add a routing area layer which tracks routing area and cells within a routing area. Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa --- M configure.ac M include/osmocom/sgsn/Makefile.am M include/osmocom/sgsn/debug.h A include/osmocom/sgsn/gprs_routing_area.h M include/osmocom/sgsn/sgsn.h M src/sgsn/Makefile.am M src/sgsn/gprs_bssgp.c M src/sgsn/gprs_ns.c A src/sgsn/gprs_routing_area.c M src/sgsn/sgsn.c M src/sgsn/sgsn_main.c M tests/Makefile.am A tests/gprs_routing_area/Makefile.am A tests/gprs_routing_area/gprs_routing_area_test.c A tests/gprs_routing_area/gprs_routing_area_test.ok M tests/sgsn/Makefile.am M tests/testsuite.at 17 files changed, 982 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/64/37864/16 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa Gerrit-Change-Number: 37864 Gerrit-PatchSet: 16 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-sgsn[master]: Use %d instead of %i
by lynxis lazus 11 Oct '24

11 Oct '24

Attention is currently required from: dexter, lynxis lazus. Hello Jenkins Builder, dexter, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: Use %d instead of %i ...................................................................... Use %d instead of %i %d and %i has the same meaning when used in format string for printf. The linter will warn when using %i. %i was only added to provide symmetry between scanf() and printf(). Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf --- M src/sgsn/gprs_ranap.c M src/sgsn/slhc.c M tests/slhc/slhc_test.c M tests/sndcp_xid/sndcp_xid_test.c M tests/v42bis/v42bis_test.c M tests/xid/xid_test.c 6 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/81/38281/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf Gerrit-Change-Number: 38281 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: docs/Makefile: make SPHINXBUILD work in venv
by osmith 11 Oct '24

11 Oct '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38386?usp=email ) Change subject: docs/Makefile: make SPHINXBUILD work in venv ...................................................................... docs/Makefile: make SPHINXBUILD work in venv sphinx-build doesn't use the PYTHONPATH from the venv, unless it runs as python3 -m sphinx.cmd.build. We need it to use the imports from PYTHONPATH, so we can update the pyosmocom version in requirements.txt in a patch, and this new version will be used in the jenkins job that runs during gerrit review. Otherwise the previously installed version (from the docker image) will be used. Related: https://github.com/sphinx-doc/sphinx/issues/8910 Change-Id: I487e1af6a3493df5b806cc2d3d2b70bc5233b89f --- M docs/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/86/38386/1 diff --git a/docs/Makefile b/docs/Makefile index 3b99b25..4523bf6 100644 --- a/docs/Makefile +++ b/docs/Makefile @@ -4,7 +4,7 @@ # You can set these variables from the command line, and also # from the environment for the first two. SPHINXOPTS ?= -SPHINXBUILD ?= sphinx-build +SPHINXBUILD ?= python3 -m sphinx.cmd.build SOURCEDIR = . BUILDDIR = _build -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I487e1af6a3493df5b806cc2d3d2b70bc5233b89f Gerrit-Change-Number: 38386 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: jenkins: build docs in virtualenv as well
by osmith 11 Oct '24

11 Oct '24

Attention is currently required from: dexter. osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38372?usp=email ) Change subject: jenkins: build docs in virtualenv as well ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: This is needed, so when a patch changes requirements.txt, the new dependencies get installed during the gerrit review job. Otherwise it will use the requirements.txt from the time the docker image was built, which may e.g. have an older pyosmocom version. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38372?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6381eeef7fa19873ca0cc330a0ab43b7ef5096e4 Gerrit-Change-Number: 38372 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Oct 2024 14:09:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: ss7 vty: Fix insert order of routes with higher priority
by pespin 11 Oct '24

11 Oct '24

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email ) Change subject: ss7 vty: Fix insert order of routes with higher priority ...................................................................... Patch Set 5: (1 comment) This change is ready for review. File tests/vty/osmo_stp_route_prio.vty: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/3a3eff06_33546… : PS2, Line 87: 3.2.1/14 0 as3 ? ? ? > It seems some systems from other vendors are using a default prio of 5, so we may want to change tha […] I'll be changing default prio to 5 in a follow-up patch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6e7b5e3f06ae2c9468da58c55d2f42cbcd777218 Gerrit-Change-Number: 38375 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Oct 2024 14:07:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log