- gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: tweak description
by osmith 21 Oct '24

21 Oct '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38459?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: tweak description ...................................................................... jobs/ttcn3-testsuites-testenv: tweak description Don't link to osmo-ttcn3-hacks.git directly anymore, the wiki page that is also linked already refers to it. This shortens the boilerplate of the description with every one of these jenkins jobs. Instead of only displaying the arguments, display the full command so users can easily run the testsuite the same way it is running on jenkins. Omit the arguments --cache, --ccache, --log-dir, which only need to be adjusted for jenkins, for users the defaults make sense. Let the kernel line link to the related build-kernel job. Related: OS#6494 Change-Id: Ifad86aa3982c325394d47b5c8cf98c43b2d3d1eb --- M jobs/ttcn3-testsuites-testenv.yml 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index a9e62d6..99d4758 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -4,17 +4,17 @@ concurrent: false disabled: false description: | - Run the <code>{testsuite}</code> testsuite from - <a href="https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks"> - osmo-ttcn3-hacks.git</a> with testenv.py. - See <a href="https://osmocom.org/projects/cellular-infrastructure/wiki/Titan_TTCN3_Tests…"> - TTCN3 Testsuite</a> for more information. + Run the + <a href="https://osmocom.org/projects/cellular-infrastructure/wiki/Titan_TTCN3_Tests…"> + Osmocom TTCN3 Testsuite</a> for <code>{testsuite}</code>. - Arguments: - <code>{args}</code> + Command: + <code>./testenv.py run {testsuite} --podman {args}</code> Kernel: - <code>{kernel}</code> + <a href="https://jenkins.osmocom.org/jenkins/job/build-kernel-{kernel}/"> + <code>{kernel}</code> + </a> timer: "@midnight" kernel: "none" node: ttcn3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38459?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ifad86aa3982c325394d47b5c8cf98c43b2d3d1eb Gerrit-Change-Number: 38459 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: tweak description
by fixeria 21 Oct '24

21 Oct '24

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38459?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: tweak description ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38459?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ifad86aa3982c325394d47b5c8cf98c43b2d3d1eb Gerrit-Change-Number: 38459 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Oct 2024 06:57:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: docs/shell: Add missing :ref: when referencing other command
by laforge 20 Oct '24

20 Oct '24

Attention is currently required from: laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/36224?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: docs/shell: Add missing :ref: when referencing other command ...................................................................... docs/shell: Add missing :ref: when referencing other command Change-Id: I18f110e6313932d82b19ecaa7e07ef00c2339513 --- M docs/shell.rst 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/24/36224/7 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I18f110e6313932d82b19ecaa7e07ef00c2339513 Gerrit-Change-Number: 36224 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: pySim.esim.saip.templates: Fix DF_TELECOM FileID (7F10, not 7F11)
by laforge 20 Oct '24

20 Oct '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38471?usp=email ) Change subject: pySim.esim.saip.templates: Fix DF_TELECOM FileID (7F10, not 7F11) ...................................................................... pySim.esim.saip.templates: Fix DF_TELECOM FileID (7F10, not 7F11) Change-Id: I4bc37f9d99c046cd6c6accaaf460a39eb79b660f --- M pySim/esim/saip/templates.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/71/38471/1 diff --git a/pySim/esim/saip/templates.py b/pySim/esim/saip/templates.py index f69ec7a..3ec0b9b 100644 --- a/pySim/esim/saip/templates.py +++ b/pySim/esim/saip/templates.py @@ -293,7 +293,7 @@ oid = OID.DF_TELECOM base_path = Path('MF') files = [ - FileTemplate(0x7f11, 'DF.TELECOM', 'DF', None, None, 14, None, None, False, params=['pinStatusTemplateDO']), + FileTemplate(0x7f10, 'DF.TELECOM', 'DF', None, None, 14, None, None, False, params=['pinStatusTemplateDO']), FileTemplate(0x6f06, 'EF.ARR', 'LF', None, None, 10, None, None, True, ['nb_rec', 'size']), FileTemplate(0x6f53, 'EF.RMA', 'LF', None, None, 3, None, None, True, ['nb_rec', 'size']), FileTemplate(0x6f54, 'EF.SUME', 'TR', None, 22, 3, None, None, True), @@ -334,7 +334,7 @@ oid = OID.DF_TELECOM_v2 base_path = Path('MF') files = [ - FileTemplate(0x7f11, 'DF.TELECOM', 'DF', None, None, 14, None, None, False, params=['pinStatusTemplateDO']), + FileTemplate(0x7f10, 'DF.TELECOM', 'DF', None, None, 14, None, None, False, params=['pinStatusTemplateDO']), FileTemplate(0x6f06, 'EF.ARR', 'LF', None, None, 10, None, None, True, ['nb_rec', 'size']), FileTemplate(0x6f53, 'EF.RMA', 'LF', None, None, 3, None, None, True, ['nb_rec', 'size']), FileTemplate(0x6f54, 'EF.SUME', 'TR', None, 22, 3, None, None, True), -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38471?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4bc37f9d99c046cd6c6accaaf460a39eb79b660f Gerrit-Change-Number: 38471 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: pySim.ts_31_102: Add support for EF.ARFCNList
by laforge 20 Oct '24

20 Oct '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38472?usp=email ) Change subject: pySim.ts_31_102: Add support for EF.ARFCNList ...................................................................... pySim.ts_31_102: Add support for EF.ARFCNList Change-Id: I16797ca58c3ad6ebaf588d04fec011a0cbcfcef3 --- M pySim/ts_31_102.py 1 file changed, 31 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/72/38472/1 diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index b82c411..6f14ebb 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -30,7 +30,7 @@ from construct import Optional as COptional from construct import Int32ub, Nibble, GreedyRange, Struct, FlagsEnum, Switch, this, Int16ub, Padding -from construct import Bytewise, Int24ub, PaddedString, PrefixedArray, If +from construct import Bytewise, Int24ub, Int24sb, PaddedString, PrefixedArray, If from osmocom.utils import is_hexstr from osmocom.tlv import * @@ -893,6 +893,35 @@ super().__init__(fid, sfid=sfid, name=name, desc=desc, size=size, **kwargs) self._construct = BitStruct('rfu'/BitsRFU(7), 'from_preferred'/Flag) +# TS 31.102 Section 4.2.112 + TS 23.032 Section 6.1 +GadPoint = Struct('latitude'/Int24sb, 'longitude'/Int24sb) + +# TS 31.102 Section 4.2.112 (Rel ??) +class EF_EARFCNList(TransparentEF): + _test_de_encode = [ + # single data object with one EARFCN + one area of 3 points + ('a01a8004000100008112000001100001000002100002000003100003', + {'earfcn_list_tlv': [{'earfcn': 65536}, {'geographical_area': [{'latitude': 1, 'longitude': 1048577}, + {'latitude': 2, 'longitude': 1048578}, + {'latitude': 3, 'longitude': + 1048579}]}]}), + # single data object with one EARFCN + two areas of 3 + 4 points + ('a01a800400010000811200000110000100000210000200000310000381180000011000010000021000020000031000030001011000110', + None), + # two concatenated data objects with 3 points each + ('a01a8004000100008112000001100001000002100002000003100003a01a8004000200008112000011100011000012100012000013100013', None ), + ] + class Earfcn(BER_TLV_IE, tag=0x80): + _construct = Int32ub + class GeographicalArea(BER_TLV_IE, tag=0x81): + _construct = GreedyRange(GadPoint) + class EarfcnListTlv(BER_TLV_IE, tag=0xa0, nested=[Earfcn,GeographicalArea]): + pass + def __init__(self, fid='6ffd', sfid=None, name='EF.EARFCNList', size=(30, 100), + desc='EARFCN list for MTC/NB-IOT UEs', **kwargs): + super().__init__(fid, sfid=sfid, name=name, desc=desc, size=size, **kwargs) + self._tlv = self.EarfcnListTlv + # TS 31.102 Section 4.2.114 (Rel 18) class EF_eAKA(TransparentEF): def __init__(self, fid='6f01', sfid=None, name='EF.eAKA', size=(1, 1), @@ -1675,7 +1704,7 @@ # TODO: EF.3GPPPSDATAOFF # TODO: EF.3GPPPSDATAOFFservicelist EF_XCAPConfigData(service=120), - # TODO: EF.EARFCNList + EF_EARFCNList(service=121), EF_MuDMiDConfigData(service=134), EF_eAKA(), EF_OCST(service=148), -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38472?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I16797ca58c3ad6ebaf588d04fec011a0cbcfcef3 Gerrit-Change-Number: 38472 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libgtpnl[master]: dev_create: Avoid passing IFLA_GTP_FD* attribute with value -1
by fixeria 19 Oct '24

19 Oct '24

Attention is currently required from: laforge, pablo, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libgtpnl/+/38460?usp=email ) Change subject: dev_create: Avoid passing IFLA_GTP_FD* attribute with value -1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/38460?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ib7e1d362fbb556c9b15b25408058fbf00bcc7aa3 Gerrit-Change-Number: 38460 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pablo <pablo(a)gnumonks.org> Gerrit-Attention: pablo <pablo(a)gnumonks.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Oct 2024 15:10:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: gsm_12_21.h: fix values for NM_IPAC_F_GPRS_CODING_MCS[1-9]
by fixeria 19 Oct '24

19 Oct '24

Attention is currently required from: laforge. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/34427?usp=email ) Change subject: gsm_12_21.h: fix values for NM_IPAC_F_GPRS_CODING_MCS[1-9] ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > well, it is probably simply a question of endianness of the underlying CPU, right? It's a 16 bit va […] These flags are applied to a `uint32_t` value in **native** endianness for the host. nanoBTS and osmo-bts report a value in network byte order, which needs to be converted to host's byte order before doing any `u32 & NM_IPAC_F_` checks. * osmo-bsc: see `ipacc_parse_supp_flags()` for a usage example, * osmo-bts: grep for `NM_IPAC_F_CHANT_`. The problem this patch is solving is not about endianness, it's about wrong offset values assigned to MCS related `NM_IPAC_F_` constants. We should get this merged to fix parsing of the feature reports sent by nanoBTS. As a side effect, this will change the bit-vector sent by osmo-bts, but it's not critical because we never request GPRS related features from osmo-bts and so far only using this for informative purposes. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34427?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85316af9b57e8113077305798cb2d82a24e48e00 Gerrit-Change-Number: 34427 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 19 Oct 2024 07:09:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libgtpnl[master]: dev_create: Avoid passing IFLA_GTP_FD* attribute with value -1
by pespin 18 Oct '24

18 Oct '24

Attention is currently required from: laforge, pablo. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libgtpnl/+/38460?usp=email ) Change subject: dev_create: Avoid passing IFLA_GTP_FD* attribute with value -1 ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/38460?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ib7e1d362fbb556c9b15b25408058fbf00bcc7aa3 Gerrit-Change-Number: 38460 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pablo <pablo(a)gnumonks.org> Gerrit-Attention: pablo <pablo(a)gnumonks.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 18 Oct 2024 22:14:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in osmo-ttcn3-hacks[master]: ggsn: Introduce test TC_pdp4(6)_act_deact_mtu
by fixeria 18 Oct '24

18 Oct '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38469?usp=email ) Change subject: ggsn: Introduce test TC_pdp4(6)_act_deact_mtu ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38469?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2ceb76a3a07b44f69937c9f5a040482320bca377 Gerrit-Change-Number: 38469 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Oct 2024 18:25:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: library/PCO_Types.ttcn: Drop unsued IPCP_OPT enum
by fixeria 18 Oct '24

18 Oct '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38468?usp=email ) Change subject: library/PCO_Types.ttcn: Drop unsued IPCP_OPT enum ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I867ab36063db262b46fc4546c17a902699a6e37c Gerrit-Change-Number: 38468 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Oct 2024 18:24:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log