- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: testenv: remove dead code for [testsuite] prepare=
by fixeria 25 Oct '24

25 Oct '24

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38531?usp=email ) Change subject: testenv: remove dead code for [testsuite] prepare= ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38531?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9bed48612fad690f86017c298372dc6cea22b94b Gerrit-Change-Number: 38531 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2024 13:44:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: test for RUA Disconnect when there is no CN
by fixeria 25 Oct '24

25 Oct '24

Attention is currently required from: laforge, neels, osmith. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37809?usp=email ) Change subject: hnbgw: test for RUA Disconnect when there is no CN ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2b5c024a395e736538c0c37db40d34f3b8d99991 Gerrit-Change-Number: 37809 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 25 Oct 2024 13:42:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-msc[master]: csd_bs: cosmetic changes to csd_bs_list_to_bearer_cap()
by fixeria 25 Oct '24

25 Oct '24

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/38510?usp=email ) Change subject: csd_bs: cosmetic changes to csd_bs_list_to_bearer_cap() ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/38510/comment/9f26c164_6a681744?usp… : PS1, Line 7: csd_bs: cosmetic changes to csd_bs_list_to_bearer_cap() > Allocating a var in the stack every loop iteration This is incorrect, because a loop does not have its own stack frame, only functions do. This simply reduces the usage scope of a variable, in theory allowing the compiler to optimize code better. The resulting binary may or may not change, depending on the compiler and the `-O` level. > Marking the variable as const So that the compiler can avoid allocating stack memory for it and access `list->bs[i]` directly. By "the way this function behaves though" I meant the output it produces given the same input. Again, we can keep discussing this forever, but the core logic of this function remains unchanged. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38510?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I101f55dfbd0d327269fcce76031a2db265ca2eb9 Gerrit-Change-Number: 38510 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2024 13:38:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: testenv: set MTU=1500 for lo
by osmith 25 Oct '24

25 Oct '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38546?usp=email ) Change subject: bsc: testenv: set MTU=1500 for lo ...................................................................... bsc: testenv: set MTU=1500 for lo Two tests are failing if the MTU is 65536 instead of 1500. This should be analyzed more and fixed, but first let's adjust the testenv config so the behavior of the test environment is the same as with docker-playground. Related: OS#6602 Change-Id: Ifeda66954263fe8d2637377d0701a2208a19c332 --- A _testenv/data/scripts/podman_set_lo_mtu.sh M _testenv/testenv/podman.py M bsc/testenv_generic.cfg 3 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/46/38546/1 diff --git a/_testenv/data/scripts/podman_set_lo_mtu.sh b/_testenv/data/scripts/podman_set_lo_mtu.sh new file mode 100755 index 0000000..ed91762 --- /dev/null +++ b/_testenv/data/scripts/podman_set_lo_mtu.sh @@ -0,0 +1,11 @@ +#!/bin/sh -e +# Change the MTU for the loopback device, but only when running in podman (as +# we don't want to just make this change for the host without asking). This +# is used as workaround for OS#6602 where we have some tests that don't pass if +# the MTU=65536, the default of lo. + +MTU="$1" + +if [ "$PODMAN" = 1 ]; then + sudo ip link set dev lo mtu "$1" +fi diff --git a/_testenv/testenv/podman.py b/_testenv/testenv/podman.py index faa1837..4788076 100644 --- a/_testenv/testenv/podman.py +++ b/_testenv/testenv/podman.py @@ -215,6 +215,8 @@ "net.ipv4.conf.all.send_redirects=0", # OS#6575 "--sysctl", "net.ipv4.conf.default.send_redirects=0", # OS#6575 + "-e", + "PODMAN=1", ] if not testenv.args.binary_repo: diff --git a/bsc/testenv_generic.cfg b/bsc/testenv_generic.cfg index d453f55..b4ed393 100644 --- a/bsc/testenv_generic.cfg +++ b/bsc/testenv_generic.cfg @@ -1,4 +1,5 @@ [testsuite] +prepare=podman_set_lo_mtu.sh 1500 # OS#6602 program=BSC_Tests config=BSC_Tests.cfg -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38546?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifeda66954263fe8d2637377d0701a2208a19c332 Gerrit-Change-Number: 38546 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim-shell_test/utils: enumerate pySim-shell logs
by dexter 25 Oct '24

25 Oct '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38544?usp=email ) Change subject: pySim-shell_test/utils: enumerate pySim-shell logs ...................................................................... pySim-shell_test/utils: enumerate pySim-shell logs When pySim-shell is called by a testcase, a logfile is createted. The logfile filename contains the testcase name. However, a testcase may run pySim-shell multiple times. In this case we overwrite the log from previous run. Let's use a counter to generate unique file names for each run, so that we won't lose logs from previous runs. Related: OS#6601 Change-Id: Ib2195d9b2231f74d0a6c4fb28f4889b6c45efb1e --- M tests/pySim-shell_test/utils.py 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/44/38544/1 diff --git a/tests/pySim-shell_test/utils.py b/tests/pySim-shell_test/utils.py index 943eb48..6acbd70 100644 --- a/tests/pySim-shell_test/utils.py +++ b/tests/pySim-shell_test/utils.py @@ -170,6 +170,7 @@ testcasepath = inspect.getfile(self.__class__) testcasename = testcasepath.split("/")[-2] + "." + self._testMethodName print(boxed_heading_str("testcase: " + testcasename)) + self.pysim_shell_log_counter = 0 # Find directories self.test_dir = os.path.dirname(testcasepath) @@ -240,7 +241,8 @@ no_exceptions : fail the testcase in case any exceptions occurred while running pySim_shell """ - logfile_name = "pySim-shell_" + self._testMethodName + ".log" + logfile_name = "pySim-shell_" + self._testMethodName + "_" + str(self.pysim_shell_log_counter) + ".log" + self.pysim_shell_log_counter+=1 # Make sure the script file is available if not os.access(script, os.R_OK): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38544?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib2195d9b2231f74d0a6c4fb28f4889b6c45efb1e Gerrit-Change-Number: 38544 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim-shell_test/utils: delete log files in general
by dexter 25 Oct '24

25 Oct '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38543?usp=email ) Change subject: pySim-shell_test/utils: delete log files in general ...................................................................... pySim-shell_test/utils: delete log files in general When we get rid of temporary files, we delete those using a wildcard, but for the logs from pySim-shell we explicitly memorize the name of the pySim-shell logfile and delete it later by this explicit name. This is not necessary, let's just delete all log files present using a wildcard. Related: OS#6601 Change-Id: I09dc7e59d1a3dcb68f54e3a8dccb86a1bc6c9ee6 --- M tests/pySim-shell_test/utils.py 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/43/38543/1 diff --git a/tests/pySim-shell_test/utils.py b/tests/pySim-shell_test/utils.py index fe8386a..943eb48 100644 --- a/tests/pySim-shell_test/utils.py +++ b/tests/pySim-shell_test/utils.py @@ -220,7 +220,7 @@ print("testcase execution done -- cleaning up ...") if not self.keepfiles: os.system("rm -f ./*.tmp") - os.system("rm -f ./" + self.__pySim_shell_logfile_name) + os.system("rm -f ./*.log") for template in self.__templates_generated: os.system("rm -f ./" + template) @@ -241,7 +241,6 @@ """ logfile_name = "pySim-shell_" + self._testMethodName + ".log" - self.__pySim_shell_logfile_name = logfile_name # Make sure the script file is available if not os.access(script, os.R_OK): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38543?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I09dc7e59d1a3dcb68f54e3a8dccb86a1bc6c9ee6 Gerrit-Change-Number: 38543 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim-shell_test/utils: display pySim-shell logfile content
by dexter 25 Oct '24

25 Oct '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38545?usp=email ) Change subject: pySim-shell_test/utils: display pySim-shell logfile content ...................................................................... pySim-shell_test/utils: display pySim-shell logfile content When we configure the tests to display file content, we only display files that we compare, let's also display log file contents from pySim-shell. This will be useful in situations where we only have log output from the tests, but no access to the file system of the test host. Related: OS#6601 Change-Id: Ibf6f78d7e71c213c7ca1caaf21c4c890e892261e --- M tests/pySim-shell_test/utils.py 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/45/38545/1 diff --git a/tests/pySim-shell_test/utils.py b/tests/pySim-shell_test/utils.py index 6acbd70..348c9b1 100644 --- a/tests/pySim-shell_test/utils.py +++ b/tests/pySim-shell_test/utils.py @@ -272,6 +272,11 @@ # Check for exceptions logfile = open(logfile_name) logfile_content = logfile.read() + if self.print_content: + print("pySim-shell logfile content: (%s)" % os.path.basename(logfile_name)) + print("-----------------------8<-----------------------") + print(logfile_content) + print("-----------------------8<-----------------------") logfile.close() exception_regex_compiled = re.compile('.*EXCEPTION.*') exceptions_strings = re.findall(exception_regex_compiled, logfile_content) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38545?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibf6f78d7e71c213c7ca1caaf21c4c890e892261e Gerrit-Change-Number: 38545 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: global_platform: ensure ArgumentParser gets a list for choices
by dexter 25 Oct '24

25 Oct '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38542?usp=email ) Change subject: global_platform: ensure ArgumentParser gets a list for choices ...................................................................... global_platform: ensure ArgumentParser gets a list for choices When we use the argument parser with choices, we sometimes use a list that we derive from a dictionary. However if we do that we still must ensure that we really put a list and not a dict_values or dict_keys class as parameter because this won't work any longer with cmd2 version 2.5.0 Related: OS#6601 Change-Id: I165fefd8feb0d96cedc15d036fb32da381f711b3 --- M pySim/global_platform/__init__.py 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/42/38542/1 diff --git a/pySim/global_platform/__init__.py b/pySim/global_platform/__init__.py index e499e0f..53e13e8 100644 --- a/pySim/global_platform/__init__.py +++ b/pySim/global_platform/__init__.py @@ -589,7 +589,7 @@ put_key_parser.add_argument('--old-key-version-nr', type=auto_uint8, default=0, help='Old Key Version Number') put_key_parser.add_argument('--key-version-nr', type=auto_uint8, required=True, help='Key Version Number') put_key_parser.add_argument('--key-id', type=auto_uint7, required=True, help='Key Identifier (base)') - put_key_parser.add_argument('--key-type', choices=KeyType.ksymapping.values(), action='append', required=True, help='Key Type') + put_key_parser.add_argument('--key-type', choices=list(KeyType.ksymapping.values()), action='append', required=True, help='Key Type') put_key_parser.add_argument('--key-data', type=is_hexstr, action='append', required=True, help='Key Data Block') put_key_parser.add_argument('--key-check', type=is_hexstr, action='append', help='Key Check Value') put_key_parser.add_argument('--suppress-key-check', action='store_true', help='Suppress generation of Key Check Values') @@ -650,7 +650,7 @@ return data get_status_parser = argparse.ArgumentParser() - get_status_parser.add_argument('subset', choices=StatusSubset.ksymapping.values(), + get_status_parser.add_argument('subset', choices=list(StatusSubset.ksymapping.values()), help='Subset of statuses to be included in the response') get_status_parser.add_argument('--aid', type=is_hexstr, default='', help='AID Search Qualifier (search only for given AID)') @@ -685,9 +685,9 @@ return grd_list set_status_parser = argparse.ArgumentParser() - set_status_parser.add_argument('scope', choices=SetStatusScope.ksymapping.values(), + set_status_parser.add_argument('scope', choices=list(SetStatusScope.ksymapping.values()), help='Defines the scope of the requested status change') - set_status_parser.add_argument('status', choices=CLifeCycleState.ksymapping.values(), + set_status_parser.add_argument('status', choices=list(CLifeCycleState.ksymapping.values()), help='Specify the new intended status') set_status_parser.add_argument('--aid', type=is_hexstr, help='AID of the target Application or Security Domain') @@ -726,7 +726,7 @@ inst_inst_parser.add_argument('--install-parameters', type=is_hexstr, default='', help='Install Parameters') inst_inst_parser.add_argument('--privilege', action='append', dest='privileges', default=[], - choices=Privileges._construct.flags.keys(), + choices=list(Privileges._construct.flags.keys()), help='Privilege granted to newly installed Application') inst_inst_parser.add_argument('--install-token', type=is_hexstr, default='', help='Install Token (Section GPCS C.4.2/C.4.7)') -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38542?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I165fefd8feb0d96cedc15d036fb32da381f711b3 Gerrit-Change-Number: 38542 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in osmo-ggsn[master]: Refactor tun_t fields and alloc APIs
by fixeria 25 Oct '24

25 Oct '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38524?usp=email ) Change subject: Refactor tun_t fields and alloc APIs ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File lib/tun.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/38524/comment/3bddc0a0_b5bdbd5c?us… : PS1, Line 111: tun->devname[IFNAMSIZ - 1] = 0; This is redundant because: * the whole buffer is NUL-initialized by `talloc_zero()`, * `osmo_strlcpy()` does NUL-termination if `src` is not empty. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38524?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ic71f91c62cd5bd48c6d35534eaac2091e4c69735 Gerrit-Change-Number: 38524 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2024 13:27:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-s1gw[master]: s1gw_metrics: add a counter for unexpected PFCP PDUs
by pespin 25 Oct '24

25 Oct '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38535?usp=email ) Change subject: s1gw_metrics: add a counter for unexpected PFCP PDUs ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38535?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I338662d0fe079f1c4222a70c5521eff2d237c793 Gerrit-Change-Number: 38535 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2024 12:54:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log