- gerrit-log - lists.osmocom.org

[XS] Change in ...osmo-s1gw[master]: pfcp_peer: do not route incoming PDUs without SEID
by fixeria 25 Oct '24

25 Oct '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37964?usp=email ) Change subject: pfcp_peer: do not route incoming PDUs without SEID ...................................................................... pfcp_peer: do not route incoming PDUs without SEID Change-Id: I7d33ec4e883b217b2b4f65e4866d9365c32c753d --- M src/pfcp_peer.erl 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/pfcp_peer.erl b/src/pfcp_peer.erl index 0479071..cc98c49 100644 --- a/src/pfcp_peer.erl +++ b/src/pfcp_peer.erl @@ -238,8 +238,10 @@ %% 3GPP TS 29.244, 6.2.2.2 Heartbeat Request #pfcp{type = heartbeat_request} -> recv_heartbeat_request(PDU, {FromIp, FromPort}, S); + #pfcp{seid = SEID} when is_integer(SEID) -> + route_pdu(PDU, S); _ -> - route_pdu(PDU, S) + ?LOG_NOTICE("Rx unexpected PFCP PDU: ~p", [PDU]) end, {keep_state, S}; -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37964?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7d33ec4e883b217b2b4f65e4866d9365c32c753d Gerrit-Change-Number: 37964 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: pfcp_peer: implement Heartbeat Request procedure
by fixeria 25 Oct '24

25 Oct '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38533?usp=email ) Change subject: pfcp_peer: implement Heartbeat Request procedure ...................................................................... pfcp_peer: implement Heartbeat Request procedure Change-Id: Ie52d58ffcc169abe8e72ea106ab957c12af2e8b9 --- M src/pfcp_peer.erl 1 file changed, 139 insertions(+), 17 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/pfcp_peer.erl b/src/pfcp_peer.erl index cc98c49..9a8709c 100644 --- a/src/pfcp_peer.erl +++ b/src/pfcp_peer.erl @@ -43,6 +43,8 @@ terminate/3]). -export([start_link/2, seid_alloc/0, + heartbeat_req/0, + heartbeat_req/1, session_establish_req/3, session_modify_req/3, session_delete_req/1, @@ -54,8 +56,8 @@ %% 3GPP TS 29.244, section 4.2 "UDP Header and Port Numbers" -define(PFCP_PORT, 8805). - -define(PFCP_SEID_MAX, 16#ffffffffffffffff). +-define(PFCP_HEARTBEAT_REQ_TIMEOUT, 2000). -type pfcp_session_rsp() :: ok | {error, term()}. @@ -75,6 +77,11 @@ pfcp_msg/0, pfcp_pdu/0]). +-record(heartbeat_state, {from :: undefined | gen_statem:from(), + seq_nr :: pfcp_seq_nr(), + pid :: pid() + }). + -record(peer_state, {seid :: pfcp_seid(), sock :: gen_udp:socket(), loc_addr :: inet:ip_address(), @@ -82,7 +89,8 @@ loc_rts :: pos_integer(), rem_rts :: undefined | pos_integer(), seq_nr :: pfcp_seq_nr(), - registry :: dict:dict() + registry :: dict:dict(), + heartbeat :: undefined | #heartbeat_state{} }). -type peer_state() :: #peer_state{}. @@ -104,6 +112,18 @@ gen_statem:call(?MODULE, ?FUNCTION_NAME). +-spec heartbeat_req() -> ok | {error, term()}. +heartbeat_req() -> + heartbeat_req(block). + +-spec heartbeat_req(block | noblock) -> ok | {error, term()}. +heartbeat_req(block) -> + gen_statem:call(?MODULE, ?FUNCTION_NAME); + +heartbeat_req(noblock) -> + gen_statem:cast(?MODULE, ?FUNCTION_NAME). + + -spec session_establish_req(pfcp_seid(), list(), list()) -> pfcp_session_rsp(). session_establish_req(SEID, PDRs, FARs) -> gen_statem:call(?MODULE, {?FUNCTION_NAME, SEID, PDRs, FARs}). @@ -174,8 +194,8 @@ %% Handle incoming PFCP PDU(s) connecting(info, {udp, Sock, FromIp, FromPort, Data}, - #peer_state{sock = Sock} = S) -> - PDU = decode_pdu(Data, {FromIp, FromPort}, S), + #peer_state{sock = Sock} = S0) -> + PDU = decode_pdu(Data, {FromIp, FromPort}, S0), case PDU of #pfcp{type = association_setup_response, ie = #{pfcp_cause := 'Request accepted', @@ -184,7 +204,7 @@ s1gw_metrics:ctr_inc(?S1GW_CTR_PFCP_ASSOC_SETUP_RESP_RX), s1gw_metrics:ctr_inc(?S1GW_CTR_PFCP_ASSOC_SETUP_RESP_RX_ACK), {next_state, connected, - S#peer_state{rem_rts = RRTS}}; + S0#peer_state{rem_rts = RRTS}}; #pfcp{type = association_setup_response, ie = #{pfcp_cause := Cause}} -> ?LOG_ERROR("Rx Association Setup Response (~p)", [Cause]), @@ -195,11 +215,14 @@ %% A CP function or UP function shall be prepared to receive a Heartbeat Request %% at any time (even from unknown peers) and it shall reply with a Heartbeat Response. #pfcp{type = heartbeat_request} -> - recv_heartbeat_request(PDU, {FromIp, FromPort}, S), - {keep_state, S}; + {_, S1} = recv_heartbeat_request(PDU, {FromIp, FromPort}, S0), + {keep_state, S1}; + #pfcp{type = heartbeat_response} -> + {_, S1} = recv_heartbeat_response(PDU, {FromIp, FromPort}, S0), + {keep_state, S1}; _ -> ?LOG_NOTICE("Rx unexpected PFCP PDU: ~p", [PDU]), - {keep_state, S} + {keep_state, S0} end; connecting(Event, EventData, S) -> @@ -232,18 +255,22 @@ %% Handle incoming PFCP PDU(s) connected(info, {udp, Sock, FromIp, FromPort, Data}, - #peer_state{sock = Sock} = S) -> - PDU = decode_pdu(Data, {FromIp, FromPort}, S), + #peer_state{sock = Sock} = S0) -> + PDU = decode_pdu(Data, {FromIp, FromPort}, S0), case PDU of - %% 3GPP TS 29.244, 6.2.2.2 Heartbeat Request #pfcp{type = heartbeat_request} -> - recv_heartbeat_request(PDU, {FromIp, FromPort}, S); + {_, S1} = recv_heartbeat_request(PDU, {FromIp, FromPort}, S0), + {keep_state, S1}; + #pfcp{type = heartbeat_response} -> + {_, S1} = recv_heartbeat_response(PDU, {FromIp, FromPort}, S0), + {keep_state, S1}; #pfcp{seid = SEID} when is_integer(SEID) -> - route_pdu(PDU, S); + route_pdu(PDU, S0), + {keep_state, S0}; _ -> - ?LOG_NOTICE("Rx unexpected PFCP PDU: ~p", [PDU]) - end, - {keep_state, S}; + ?LOG_NOTICE("Rx unexpected PFCP PDU: ~p", [PDU]), + {keep_state, S0} + end; %% Catch-all handler for this state connected(Event, EventData, S) -> @@ -259,6 +286,45 @@ {keep_state, S1, [{reply, From, {ok, SEID}}]}; +%% Heartbeat Req (non-blocking) +handle_event(_State, + cast, heartbeat_req, + #peer_state{} = S0) -> + {_, S1} = send_heartbeat_request(undefined, S0), + {keep_state, S1}; + +%% Heartbeat Req (blocking) +handle_event(_State, + {call, From}, heartbeat_req, + #peer_state{} = S0) -> + case send_heartbeat_request(From, S0) of + {ok, S1} -> + %% postpone reply until we get the Resp + {keep_state, S1}; + {Error, S1} -> + {keep_state, S1, + [{reply, From, Error}]} + end; + +%% Heartbeat Req (timeout) +handle_event(_State, + cast, heartbeat_request_watchdog, + #peer_state{heartbeat = HB} = S) -> + case HB of + #heartbeat_state{from = From, + seq_nr = SeqNr} -> + ?LOG_NOTICE("Heartbeat Request (SeqNr=~p) timeout", [SeqNr]), + if + From =/= undefined -> + gen_statem:reply(From, {error, timeout}); + true -> + ok + end, + {keep_state, S#peer_state{heartbeat = undefined}}; + undefined -> + {keep_state, S} + end; + handle_event(_State, {call, From}, {session_establish_req, _SEID, _PDRs, _FARs}, #peer_state{} = S) -> @@ -444,6 +510,61 @@ %% 6.2.2 Heartbeat Procedure %% 7.4.2 Heartbeat Messages +send_heartbeat_request(_From, #peer_state{heartbeat = #heartbeat_state{seq_nr = SeqNr}} = S) -> + ?LOG_ERROR("Another Heartbeat Request is still pending (SeqNr=~p)", [SeqNr]), + {{error, heartbeat_req_pending}, S}; + +send_heartbeat_request(From, #peer_state{heartbeat = undefined, + seq_nr = SeqNr, + loc_rts = LRTS} = S0) -> + ReqIEs = #{recovery_time_stamp => #recovery_time_stamp{time = LRTS}}, + ?LOG_INFO("Tx Heartbeat Request (SeqNr=~p): ~p", [SeqNr, ReqIEs]), + case send_pdu({heartbeat_request, ReqIEs}, S0) of + {ok, S1} -> + Pid = spawn(fun heartbeat_request_watchdog/0), + HB = #heartbeat_state{from = From, + seq_nr = SeqNr, + pid = Pid}, + {ok, S1#peer_state{heartbeat = HB}}; + Result -> + Result + end. + + +heartbeat_request_watchdog() -> + receive + heartbeat_response -> + ok + after + ?PFCP_HEARTBEAT_REQ_TIMEOUT -> + gen_statem:cast(?MODULE, ?FUNCTION_NAME) + end. + + +recv_heartbeat_response(#pfcp{type = heartbeat_response, + seq_no = SeqNr, + ie = RspIEs}, + {_FromIp, _FromPort}, + #peer_state{heartbeat = HB} = S) -> + ?LOG_INFO("Rx Heartbeat Response (SeqNr=~p): ~p", [SeqNr, RspIEs]), + case HB of + #heartbeat_state{from = From, + seq_nr = SeqNr, + pid = Pid} -> + if + From =/= undefined -> + gen_statem:reply(From, ok); + true -> + ok + end, + Pid ! heartbeat_response, + {ok, S#peer_state{heartbeat = undefined}}; + _ -> + ?LOG_NOTICE("Heartbeat Response (SeqNr=~p) was not expected", [SeqNr]), + {{error, unexpected}, S} + end. + + recv_heartbeat_request(#pfcp{type = heartbeat_request, seq_no = SeqNr, ie = ReqIEs}, @@ -455,6 +576,7 @@ {Result, _} = send_pdu({heartbeat_response, RspIEs}, S#peer_state{seq_nr = SeqNr, rem_addr = FromIp}), - Result. + {Result, S}. + %% vim:set ts=4 sw=4 et: -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38533?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie52d58ffcc169abe8e72ea106ab957c12af2e8b9 Gerrit-Change-Number: 38533 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: s1gw_metrics: add counters for PFCP Heartbeat Req/Resp
by fixeria 25 Oct '24

25 Oct '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38534?usp=email ) Change subject: s1gw_metrics: add counters for PFCP Heartbeat Req/Resp ...................................................................... s1gw_metrics: add counters for PFCP Heartbeat Req/Resp Change-Id: I61b28c41be4fe051adff1a5315b70409dea9b9cd --- M include/s1gw_metrics.hrl M src/pfcp_peer.erl M src/s1gw_metrics.erl 3 files changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/include/s1gw_metrics.hrl b/include/s1gw_metrics.hrl index bb7043f..1b54018 100644 --- a/include/s1gw_metrics.hrl +++ b/include/s1gw_metrics.hrl @@ -1,3 +1,8 @@ +-define(S1GW_CTR_PFCP_HEARTBEAT_REQ_TX, [ctr, pfcp, heartbeat_req, tx]). +-define(S1GW_CTR_PFCP_HEARTBEAT_REQ_TIMEOUT, [ctr, pfcp, heartbeat_req, timeout]). +-define(S1GW_CTR_PFCP_HEARTBEAT_RESP_RX, [ctr, pfcp, heartbeat_resp, rx]). +-define(S1GW_CTR_PFCP_HEARTBEAT_REQ_RX, [ctr, pfcp, heartbeat_req, rx]). +-define(S1GW_CTR_PFCP_HEARTBEAT_RESP_TX, [ctr, pfcp, heartbeat_resp, tx]). -define(S1GW_CTR_PFCP_ASSOC_SETUP_REQ_TX, [ctr, pfcp, assoc_setup_req, tx]). -define(S1GW_CTR_PFCP_ASSOC_SETUP_REQ_TIMEOUT, [ctr, pfcp, assoc_setup_req, timeout]). -define(S1GW_CTR_PFCP_ASSOC_SETUP_RESP_RX, [ctr, pfcp, assoc_setup_resp, rx]). diff --git a/src/pfcp_peer.erl b/src/pfcp_peer.erl index 9a8709c..1d266d1 100644 --- a/src/pfcp_peer.erl +++ b/src/pfcp_peer.erl @@ -314,6 +314,7 @@ #heartbeat_state{from = From, seq_nr = SeqNr} -> ?LOG_NOTICE("Heartbeat Request (SeqNr=~p) timeout", [SeqNr]), + s1gw_metrics:ctr_inc(?S1GW_CTR_PFCP_HEARTBEAT_REQ_TIMEOUT), if From =/= undefined -> gen_statem:reply(From, {error, timeout}); @@ -521,6 +522,7 @@ ?LOG_INFO("Tx Heartbeat Request (SeqNr=~p): ~p", [SeqNr, ReqIEs]), case send_pdu({heartbeat_request, ReqIEs}, S0) of {ok, S1} -> + s1gw_metrics:ctr_inc(?S1GW_CTR_PFCP_HEARTBEAT_REQ_TX), Pid = spawn(fun heartbeat_request_watchdog/0), HB = #heartbeat_state{from = From, seq_nr = SeqNr, @@ -547,6 +549,7 @@ {_FromIp, _FromPort}, #peer_state{heartbeat = HB} = S) -> ?LOG_INFO("Rx Heartbeat Response (SeqNr=~p): ~p", [SeqNr, RspIEs]), + s1gw_metrics:ctr_inc(?S1GW_CTR_PFCP_HEARTBEAT_RESP_RX), case HB of #heartbeat_state{from = From, seq_nr = SeqNr, @@ -571,6 +574,8 @@ {FromIp, FromPort}, #peer_state{loc_rts = LRTS} = S) -> ?LOG_INFO("Rx Heartbeat Request from ~p:~p: ~p", [FromIp, FromPort, ReqIEs]), + s1gw_metrics:ctr_inc(?S1GW_CTR_PFCP_HEARTBEAT_REQ_RX), + s1gw_metrics:ctr_inc(?S1GW_CTR_PFCP_HEARTBEAT_RESP_TX), RspIEs = #{recovery_time_stamp => #recovery_time_stamp{time = LRTS}}, %% Fake #peer_state to force the right destination and SeqNr {Result, _} = send_pdu({heartbeat_response, RspIEs}, diff --git a/src/s1gw_metrics.erl b/src/s1gw_metrics.erl index e065a4a..bba5209 100644 --- a/src/s1gw_metrics.erl +++ b/src/s1gw_metrics.erl @@ -48,6 +48,11 @@ -include("s1gw_metrics.hrl"). -define(S1GW_COUNTERS, [ + ?S1GW_CTR_PFCP_HEARTBEAT_REQ_TX, + ?S1GW_CTR_PFCP_HEARTBEAT_REQ_TIMEOUT, + ?S1GW_CTR_PFCP_HEARTBEAT_RESP_RX, + ?S1GW_CTR_PFCP_HEARTBEAT_REQ_RX, + ?S1GW_CTR_PFCP_HEARTBEAT_RESP_TX, ?S1GW_CTR_PFCP_ASSOC_SETUP_REQ_TX, ?S1GW_CTR_PFCP_ASSOC_SETUP_REQ_TIMEOUT, ?S1GW_CTR_PFCP_ASSOC_SETUP_RESP_RX, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38534?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I61b28c41be4fe051adff1a5315b70409dea9b9cd Gerrit-Change-Number: 38534 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in ...osmo-s1gw[master]: s1gw_metrics: add a counter for unexpected PFCP PDUs
by fixeria 25 Oct '24

25 Oct '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38535?usp=email ) Change subject: s1gw_metrics: add a counter for unexpected PFCP PDUs ...................................................................... s1gw_metrics: add a counter for unexpected PFCP PDUs Change-Id: I338662d0fe079f1c4222a70c5521eff2d237c793 --- M include/s1gw_metrics.hrl M src/pfcp_peer.erl M src/s1gw_metrics.erl 3 files changed, 4 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/include/s1gw_metrics.hrl b/include/s1gw_metrics.hrl index 1b54018..77d6a8e 100644 --- a/include/s1gw_metrics.hrl +++ b/include/s1gw_metrics.hrl @@ -8,6 +8,7 @@ -define(S1GW_CTR_PFCP_ASSOC_SETUP_RESP_RX, [ctr, pfcp, assoc_setup_resp, rx]). -define(S1GW_CTR_PFCP_ASSOC_SETUP_RESP_RX_ACK, [ctr, pfcp, assoc_setup_resp, rx_ack]). -define(S1GW_CTR_PFCP_ASSOC_SETUP_RESP_RX_NACK, [ctr, pfcp, assoc_setup_resp, rx_nack]). +-define(S1GW_CTR_PFCP_UNEXPECTED_PDU, [ctr, pfcp, unexpected_pdu]). -define(S1GW_CTR_S1AP_ENB_ALL_RX, [ctr, s1ap, enb, all, rx]). -define(S1GW_CTR_S1AP_ENB_ALL_RX_UNKNOWN_ENB, [ctr, s1ap, enb, all, rx_unknown_enb]). -define(S1GW_CTR_S1AP_PROXY_UPLINK_PACKETS_QUEUED, [ctr, s1ap, proxy, uplink_packets_queued]). diff --git a/src/pfcp_peer.erl b/src/pfcp_peer.erl index 1d266d1..a7e9515 100644 --- a/src/pfcp_peer.erl +++ b/src/pfcp_peer.erl @@ -222,6 +222,7 @@ {keep_state, S1}; _ -> ?LOG_NOTICE("Rx unexpected PFCP PDU: ~p", [PDU]), + s1gw_metrics:ctr_inc(?S1GW_CTR_PFCP_UNEXPECTED_PDU), {keep_state, S0} end; @@ -269,6 +270,7 @@ {keep_state, S0}; _ -> ?LOG_NOTICE("Rx unexpected PFCP PDU: ~p", [PDU]), + s1gw_metrics:ctr_inc(?S1GW_CTR_PFCP_UNEXPECTED_PDU), {keep_state, S0} end; diff --git a/src/s1gw_metrics.erl b/src/s1gw_metrics.erl index bba5209..55421e7 100644 --- a/src/s1gw_metrics.erl +++ b/src/s1gw_metrics.erl @@ -58,6 +58,7 @@ ?S1GW_CTR_PFCP_ASSOC_SETUP_RESP_RX, ?S1GW_CTR_PFCP_ASSOC_SETUP_RESP_RX_ACK, ?S1GW_CTR_PFCP_ASSOC_SETUP_RESP_RX_NACK, + ?S1GW_CTR_PFCP_UNEXPECTED_PDU, ?S1GW_CTR_S1AP_ENB_ALL_RX, ?S1GW_CTR_S1AP_ENB_ALL_RX_UNKNOWN_ENB, ?S1GW_CTR_S1AP_PROXY_UPLINK_PACKETS_QUEUED, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38535?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I338662d0fe079f1c4222a70c5521eff2d237c793 Gerrit-Change-Number: 38535 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in ...osmo-s1gw[master]: s1gw_metrics: add a counter for unexpected PFCP PDUs
by fixeria 25 Oct '24

25 Oct '24

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38535?usp=email ) Change subject: s1gw_metrics: add a counter for unexpected PFCP PDUs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38535?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I338662d0fe079f1c4222a70c5521eff2d237c793 Gerrit-Change-Number: 38535 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2024 19:32:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-s1gw[master]: s1gw_metrics: add counters for PFCP Heartbeat Req/Resp
by fixeria 25 Oct '24

25 Oct '24

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38534?usp=email ) Change subject: s1gw_metrics: add counters for PFCP Heartbeat Req/Resp ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38534?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I61b28c41be4fe051adff1a5315b70409dea9b9cd Gerrit-Change-Number: 38534 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2024 19:32:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: pfcp_peer: implement Heartbeat Request procedure
by fixeria 25 Oct '24

25 Oct '24

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38533?usp=email ) Change subject: pfcp_peer: implement Heartbeat Request procedure ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38533?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie52d58ffcc169abe8e72ea106ab957c12af2e8b9 Gerrit-Change-Number: 38533 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2024 19:32:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-s1gw[master]: pfcp_peer: do not route incoming PDUs without SEID
by fixeria 25 Oct '24

25 Oct '24

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37964?usp=email ) Change subject: pfcp_peer: do not route incoming PDUs without SEID ...................................................................... Patch Set 5: Code-Review+2 (1 comment) File src/pfcp_peer.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37964/comment/a38670cd_c6b6… : PS1, Line 233: ?LOG_NOTICE("Rx unexpected PFCP PDU: ~p", [PDU]) > We should at least have a metric counter though that users can observe this counter incrementing and therefore get an idea this is happening at all. Ack, I thought the same and submitted a patch: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38535 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37964?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7d33ec4e883b217b2b4f65e4866d9365c32c753d Gerrit-Change-Number: 37964 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2024 19:32:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Allow setting reason in primitive MSC_CONN_PRIM_DISC_REQ
by fixeria 25 Oct '24

25 Oct '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38541?usp=email ) Change subject: RAN_Emulation: Allow setting reason in primitive MSC_CONN_PRIM_DISC_REQ ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38541?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1fa1148135625d840426b52450bf52da10448471 Gerrit-Change-Number: 38541 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2024 19:29:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: Convert RAN_Conn_Prim from enum to union
by fixeria 25 Oct '24

25 Oct '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38540?usp=email ) Change subject: Convert RAN_Conn_Prim from enum to union ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38540?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I17994795b51efc7e6700238ddcf45594af653e42 Gerrit-Change-Number: 38540 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2024 19:28:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log