Attention is currently required from: osmith, pespin.
Hello Jenkins Builder, fixeria, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38598?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: hnbgw: Introduce test TC_ps_iu_release_req_rua_disconnect
......................................................................
hnbgw: Introduce test TC_ps_iu_release_req_rua_disconnect
Change-Id: Id24a5aed5255af77fbbd30521be70700a9bff1c9
---
M hnbgw/HNBGW_Tests.ttcn
M hnbgw/expected-results.xml
2 files changed, 44 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/98/38598/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38598?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id24a5aed5255af77fbbd30521be70700a9bff1c9
Gerrit-Change-Number: 38598
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38615?usp=email )
Change subject: statsd: Support f_statsd_snapshot() API when using VTY-triggered stats report
......................................................................
statsd: Support f_statsd_snapshot() API when using VTY-triggered stats report
Until now that API was only used in testsuites which relied on
time-trigerred reports. This commit also supports getting a given
snapshots if the IUT is configured to only trigger a report based on VTY
request.
Change-Id: I87d34e2f365d3b71ce328c08999be43d482326ad
---
M library/StatsD_Checker.ttcnpp
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
fixeria: Looks good to me, approved
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
diff --git a/library/StatsD_Checker.ttcnpp b/library/StatsD_Checker.ttcnpp
index db5c77b..b2b8332 100644
--- a/library/StatsD_Checker.ttcnpp
+++ b/library/StatsD_Checker.ttcnpp
@@ -188,6 +188,9 @@
if (not since_last_snapshot) {
STATS.clear;
}
+#ifdef STATSD_HAVE_VTY
+ f_vty_transceive(STATSVTY, "stats report");
+#endif
T_statsd.start;
while (seen_remain > 0) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38615?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I87d34e2f365d3b71ce328c08999be43d482326ad
Gerrit-Change-Number: 38615
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38619?usp=email )
Change subject: hnbgw: Handle PFCP Assoc Setup procedure in test_CT
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Is my understanding correct that we expect the PFCP association in all testcases now? I see we execu […]
Yes, because under some tests which setup a PS RAB, it explicitly then validates no PFCP is being sent when osmo-hnbgw is configured to *NOT* use PFCP. This was already like this.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38619?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic5edecea86b9465c60f008e245a44cfce64c8ddb
Gerrit-Change-Number: 38619
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Nov 2024 16:37:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38616?usp=email )
Change subject: Add PFCP stats item group
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38616?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ic71df8df83e97f4015077677e426c803f84d31ea
Gerrit-Change-Number: 38616
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Nov 2024 16:18:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes