Attention is currently required from: fixeria, laforge, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38684?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: s1ap_proxy: add E-RAB introspection API
......................................................................
s1ap_proxy: add E-RAB introspection API
This API will be used by the upcoming interactive VTY interface.
Let's also use it unit tests to check persence/absence of E-RAB FSMs.
Change-Id: I43dcfa613a4ee0de5b2f6619911fd92b1675acd6
---
M src/s1ap_proxy.erl
M test/s1ap_proxy_test.erl
2 files changed, 33 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/84/38684/3
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38684?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I43dcfa613a4ee0de5b2f6619911fd92b1675acd6
Gerrit-Change-Number: 38684
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, laforge, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38683?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: s1ap_proxy: turn this module into a gen_server
......................................................................
s1ap_proxy: turn this module into a gen_server
This patch makes the s1ap_proxy module self-contained, so API users
no longer need to initialize, maintain, or deinitialize its internal
state, and also no longer need to trap 'EXIT' signals from the child
erab_fsm processes. These improvements in maintainability and ease
of use come at the cost of an additional process per SCTP
connection, which is manageable.
Change-Id: Id6e4c7ee29ae31edca658e1293601d38e5f43e63
---
M src/s1ap_proxy.erl
M src/sctp_proxy.erl
M test/s1ap_proxy_test.erl
3 files changed, 137 insertions(+), 120 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/83/38683/3
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38683?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Id6e4c7ee29ae31edca658e1293601d38e5f43e63
Gerrit-Change-Number: 38683
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38659?usp=email )
Change subject: pySim-shell: add utility to measure execution time
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I think this new command with its argparse needs to be added to the user manual?
Also, what about an alternative approach of always measuring the time of execution of a single command and printing it (depending on a settable variable like "set timestamping true") together with the results of the command?
This way we wouldn't need to maintain an explicit counter that can be set and updated/reset. I understand there are specific use cases for it, so maybe both options make sense by themselves....
A third idea would be to introduce a "time" command like on the shell. So you could execute something like "time select ADF.USIM" and it would perform whatever command you specify as well as printing the execution time once completed. I guess this can be difficult to implement from a command parser / tab completion point of view, but still wanted to share the idea.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/38659?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I356ea44e08efe93fe927dbc20564bf850278b546
Gerrit-Change-Number: 38659
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 07 Nov 2024 04:39:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No