- gerrit-log - lists.osmocom.org

[XS] Change in osmo-bsc[master]: Use new libosmo-sigtran API osmo_ss7_as_get_asp_protocol()
by pespin 08 Nov '24

08 Nov '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38718?usp=email ) Change subject: Use new libosmo-sigtran API osmo_ss7_as_get_asp_protocol() ...................................................................... Use new libosmo-sigtran API osmo_ss7_as_get_asp_protocol() Depends: libosmo-sigtran.git Change-Id I6171287c9bc76db6561f8ff92c4aebe453efaa7d Change-Id: I58b9713ae247a7e28c004170dd890a78c03c39c0 --- M TODO-RELEASE M src/osmo-bsc/bsc_ctrl.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/18/38718/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index b5cd5cc..193735c 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,4 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -libosmo-sigtran >2.0.1 Use API osmo_ss7_route_get_dest_as(), osmo_ss7_instance_get_id() +libosmo-sigtran >2.0.1 Use API osmo_ss7_route_get_dest_as(), osmo_ss7_instance_get_id(), osmo_ss7_as_get_asp_protocol() diff --git a/src/osmo-bsc/bsc_ctrl.c b/src/osmo-bsc/bsc_ctrl.c index 28f9188..ff917ce 100644 --- a/src/osmo-bsc/bsc_ctrl.c +++ b/src/osmo-bsc/bsc_ctrl.c @@ -671,7 +671,7 @@ } /* don't attempt to send CTRL on a non-SCCPlite AS */ - if (as->cfg.proto != OSMO_SS7_ASP_PROT_IPA) { + if (osmo_ss7_as_get_asp_protocol(as) != OSMO_SS7_ASP_PROT_IPA) { msgb_free(msg); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38718?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I58b9713ae247a7e28c004170dd890a78c03c39c0 Gerrit-Change-Number: 38718 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in libosmo-sigtran[master]: sigtran: Make osmo_ss7_instance struct private
by pespin 08 Nov '24

08 Nov '24

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38664?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sigtran: Make osmo_ss7_instance struct private ...................................................................... sigtran: Make osmo_ss7_instance struct private Change-Id: I4562fe21535c5aa468ac0e3831d505bf08b336ec --- M TODO-RELEASE M include/osmocom/sigtran/osmo_ss7.h M src/Makefile.am M src/osmo_ss7.c A src/osmo_ss7_instance.c M src/sccp_scoc.c M src/sccp_scrc.c M src/sccp_vty.c A src/ss7_instance.h M src/ss7_internal.h 10 files changed, 695 insertions(+), 614 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/64/38664/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38664?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4562fe21535c5aa468ac0e3831d505bf08b336ec Gerrit-Change-Number: 38664 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[M] Change in libosmo-sigtran[master]: sigtran: Make osmo_ss7_asp struct private
by pespin 08 Nov '24

08 Nov '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38645?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sigtran: Make osmo_ss7_asp struct private ...................................................................... sigtran: Make osmo_ss7_asp struct private The object should only (and currently is only) be used throuh public APIs using a pointer. Change-Id: I5839b4dd04468af20d1836386dcc722e7a83ac5f --- M include/osmocom/sigtran/osmo_ss7.h M src/Makefile.am M src/ipa.c M src/m3ua.c M src/osmo_ss7.c M src/osmo_ss7_as.c M src/osmo_ss7_asp.c M src/osmo_ss7_hmrt.c M src/osmo_ss7_vty.c M src/osmo_ss7_xua_srv.c M src/sccp_user.c A src/ss7_asp.h M src/ss7_internal.h M src/sua.c M src/xua_as_fsm.c M src/xua_asp_fsm.c M src/xua_default_lm_fsm.c M src/xua_rkm.c M src/xua_shared.c M src/xua_snm.c M tests/ss7/ss7_test.c 21 files changed, 132 insertions(+), 89 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/45/38645/6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5839b4dd04468af20d1836386dcc722e7a83ac5f Gerrit-Change-Number: 38645 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[S] Change in libosmo-sigtran[master]: sigtran: Add API osmo_ss7_as_get_asp_protocol()
by pespin 08 Nov '24

08 Nov '24

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38717?usp=email ) Change subject: sigtran: Add API osmo_ss7_as_get_asp_protocol() ...................................................................... sigtran: Add API osmo_ss7_as_get_asp_protocol() This is currently needed for osmo-bsc, otherwise it's accessing the struct field of osmo_ss7-as directly. Change-Id: I6171287c9bc76db6561f8ff92c4aebe453efaa7d --- M TODO-RELEASE M include/osmocom/sigtran/osmo_ss7.h M src/osmo_ss7_as.c 3 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/17/38717/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6171287c9bc76db6561f8ff92c4aebe453efaa7d Gerrit-Change-Number: 38717 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[XS] Change in libosmo-sigtran[master]: sigtran: Add API osmo_ss7_as_get_asp_protocol()
by pespin 08 Nov '24

08 Nov '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38717?usp=email ) Change subject: sigtran: Add API osmo_ss7_as_get_asp_protocol() ...................................................................... sigtran: Add API osmo_ss7_as_get_asp_protocol() This is currently needed for osmo-bsc, otherwise it's accessing the struct field of osmo_ss7-as directly. Change-Id: I6171287c9bc76db6561f8ff92c4aebe453efaa7d --- M include/osmocom/sigtran/osmo_ss7.h M src/osmo_ss7_as.c 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/17/38717/1 diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h index d4fb87b..83956d8 100644 --- a/include/osmocom/sigtran/osmo_ss7.h +++ b/include/osmocom/sigtran/osmo_ss7.h @@ -268,6 +268,7 @@ struct osmo_ss7_as * osmo_ss7_as_find_or_create(struct osmo_ss7_instance *inst, const char *name, enum osmo_ss7_asp_protocol proto); +enum osmo_ss7_asp_protocol osmo_ss7_as_get_asp_protocol(const struct osmo_ss7_as *as); int osmo_ss7_as_add_asp(struct osmo_ss7_as *as, const char *asp_name); int osmo_ss7_as_del_asp(struct osmo_ss7_as *as, const char *asp_name); void osmo_ss7_as_destroy(struct osmo_ss7_as *as); diff --git a/src/osmo_ss7_as.c b/src/osmo_ss7_as.c index cc61b12..5af7098 100644 --- a/src/osmo_ss7_as.c +++ b/src/osmo_ss7_as.c @@ -95,6 +95,14 @@ return as; } +/*! \brief Get asp_protocol configuration of a given AS + * \param[in] as Application Server in which to look for \ref asp_protocol + * \returns The asp_protocol this AS is configured with */ +enum osmo_ss7_asp_protocol osmo_ss7_as_get_asp_protocol(const struct osmo_ss7_as *as) +{ + return as->cfg.proto; +} + /*! \brief Add given ASP to given AS * \param[in] as Application Server to which \ref asp is added * \param[in] asp Application Server Process to be added to \ref as -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6171287c9bc76db6561f8ff92c4aebe453efaa7d Gerrit-Change-Number: 38717 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: bsc_sccplite_msc_send(): Fix msgb leak
by pespin 08 Nov '24

08 Nov '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38716?usp=email ) Change subject: bsc_sccplite_msc_send(): Fix msgb leak ...................................................................... bsc_sccplite_msc_send(): Fix msgb leak Change-Id: I08839ae297fa4ec2ffc9ecceb1bad345bf76da10 --- M src/osmo-bsc/bsc_ctrl.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/16/38716/1 diff --git a/src/osmo-bsc/bsc_ctrl.c b/src/osmo-bsc/bsc_ctrl.c index 5cc8d90..28f9188 100644 --- a/src/osmo-bsc/bsc_ctrl.c +++ b/src/osmo-bsc/bsc_ctrl.c @@ -671,8 +671,10 @@ } /* don't attempt to send CTRL on a non-SCCPlite AS */ - if (as->cfg.proto != OSMO_SS7_ASP_PROT_IPA) + if (as->cfg.proto != OSMO_SS7_ASP_PROT_IPA) { + msgb_free(msg); return 0; + } return _ss7_as_send(as, msg); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38716?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I08839ae297fa4ec2ffc9ecceb1bad345bf76da10 Gerrit-Change-Number: 38716 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: Fixing 3-digit MNC PLMN Encoding/Decoding tests expected values for E...
by JPM 08 Nov '24

08 Nov '24

Attention is currently required from: JPM, dexter, fixeria, laforge. Hello Jenkins Builder, dexter, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38688?usp=email to look at the new patch set (#3). Change subject: Fixing 3-digit MNC PLMN Encoding/Decoding tests expected values for EF_OPL and EF_ePDGSelection. ...................................................................... Fixing 3-digit MNC PLMN Encoding/Decoding tests expected values for EF_OPL and EF_ePDGSelection. Related: pyosmocom.git I3811b227d629bd4e051a480c9622967e31f8a376 Change-Id: Ib2b586cb570dbe74a617c45c0fca276b08bb075e --- M pySim/ts_31_102.py M pySim/ts_51_011.py 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/88/38688/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib2b586cb570dbe74a617c45c0fca276b08bb075e Gerrit-Change-Number: 38688 Gerrit-PatchSet: 3 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in ...pyosmocom[master]: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests.
by JPM 08 Nov '24

08 Nov '24

Attention is currently required from: JPM, dexter, laforge. Hello Jenkins Builder, dexter, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email to look at the new patch set (#5). Change subject: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests. ...................................................................... Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests. Related: pysim.git Ib2b586cb570dbe74a617c45c0fca276b08bb075e Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376 --- M src/osmocom/construct.py M tests/test_construct.py 2 files changed, 19 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/87/38687/5 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376 Gerrit-Change-Number: 38687 Gerrit-PatchSet: 5 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: Fixing 3-digit MNC PLMN Encoding/Decoding tests expected values for E...
by JPM 08 Nov '24

08 Nov '24

JPM has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/38715?usp=email ) Change subject: Fixing 3-digit MNC PLMN Encoding/Decoding tests expected values for EF_OPL and EF_ePDGSelection. Related: pyosmocom.git I3811b227d629bd4e051a480c9622967e31f8a376 Change-Id: Ib2b586cb570dbe74a617c45c0fca276b08bb075e ...................................................................... Abandoned Duplicate -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38715?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I70740237332295b88959853d92ab32f6d74fb744 Gerrit-Change-Number: 38715 Gerrit-PatchSet: 1 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in pysim[master]: Fixing 3-digit MNC PLMN Encoding/Decoding tests expected values for E...
by JPM 08 Nov '24

08 Nov '24

Attention is currently required from: JPM, dexter, fixeria, laforge. Hello Jenkins Builder, dexter, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38688?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria Change subject: Fixing 3-digit MNC PLMN Encoding/Decoding tests expected values for EF_OPL and EF_ePDGSelection. Related: pyosmocom.git I3811b227d629bd4e051a480c9622967e31f8a376 Change-Id: Ib2b586cb570dbe74a617c45c0fca276b08bb075e ...................................................................... Fixing 3-digit MNC PLMN Encoding/Decoding tests expected values for EF_OPL and EF_ePDGSelection. Related: pyosmocom.git I3811b227d629bd4e051a480c9622967e31f8a376 Change-Id: Ib2b586cb570dbe74a617c45c0fca276b08bb075e --- M pySim/ts_31_102.py M pySim/ts_51_011.py 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/88/38688/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib2b586cb570dbe74a617c45c0fca276b08bb075e Gerrit-Change-Number: 38688 Gerrit-PatchSet: 2 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log