- gerrit-log - lists.osmocom.org

[XS] Change in osmo-hnbgw[pespin/rel-1.6.0]: coverity CID#358069
by pespin 12 Nov '24

12 Nov '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38704?usp=email ) Change subject: coverity CID#358069 ...................................................................... coverity CID#358069 Change-Id: Ib2ed76c1bdae96457f61c2e015846566f100b8d6 (cherry picked from commit 1eb2a759ad3368e595a0ad91c431609d9c25c73a) --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Verified fixeria: Looks good to me, but someone else must approve diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index 1cc79f6..e373600 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -446,7 +446,7 @@ static int hnbgw_rx_hnb_deregister(struct hnb_context *ctx, ANY_t *in) { HNBAP_HNBDe_RegisterIEs_t ies; - HNBAP_Cause_t cause; + HNBAP_Cause_t cause = {}; int rc; rc = hnbap_decode_hnbde_registeries(&ies, in); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38704?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: pespin/rel-1.6.0 Gerrit-Change-Id: Ib2ed76c1bdae96457f61c2e015846566f100b8d6 Gerrit-Change-Number: 38704 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[pespin/rel-1.6.0]: ps_rab_ass_fsm: Fix uninitialized ptr access
by pespin 12 Nov '24

12 Nov '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38705?usp=email ) Change subject: ps_rab_ass_fsm: Fix uninitialized ptr access ...................................................................... ps_rab_ass_fsm: Fix uninitialized ptr access /git/osmo-hnbgw/include/osmocom/hnbgw/context_map.h:211:9: error: 'rab' may be used uninitialized [-Werror=maybe-uninitialized] 211 | _map_rua_dispatch(MAP, EVENT, MSGB, __FILE__, __LINE__) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /git/osmo-hnbgw/src/osmo-hnbgw/ps_rab_ass_fsm.c:358:9: note: in expansion of macro 'map_rua_dispatch' 358 | map_rua_dispatch(rab->map, MAP_RUA_EV_TX_DIRECT_TRANSFER, msg); | ^~~~~~~~~~~~~~~~ /git/osmo-hnbgw/src/osmo-hnbgw/ps_rab_ass_fsm.c:297:24: note: 'rab' was declared here 297 | struct ps_rab *rab; | ^~~ Change-Id: Ifdcd4c369b35820c5c2beb695392d0b82d4ea34c (cherry picked from commit 89504050ea481a517d7da68b008c19e83f37aae2) --- M src/osmo-hnbgw/ps_rab_ass_fsm.c 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Verified fixeria: Looks good to me, but someone else must approve diff --git a/src/osmo-hnbgw/ps_rab_ass_fsm.c b/src/osmo-hnbgw/ps_rab_ass_fsm.c index 456d5aa..f400fcc 100644 --- a/src/osmo-hnbgw/ps_rab_ass_fsm.c +++ b/src/osmo-hnbgw/ps_rab_ass_fsm.c @@ -294,7 +294,7 @@ /* See whether all information is in so that we can forward the modified RAB Assignment Request to RUA. */ static void ps_rab_ass_req_check_local_f_teids(struct ps_rab_ass *rab_ass) { - struct ps_rab *rab; + struct ps_rab *rab = NULL; RANAP_RAB_AssignmentRequestIEs_t *ies = &rab_ass->ranap_rab_ass_req_message->msg.raB_AssignmentRequestIEs; int i; struct msgb *msg; @@ -346,6 +346,12 @@ ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RANAP_RAB_SetupOrModifyItemFirst, &first); } + if (!rab) { + LOG_PS_RAB_ASS(rab_ass, LOGL_ERROR, "Lookup PS RAB Assignment Request failed\n"); + ps_rab_ass_failure(rab_ass); + return; + } + /* Send the modified RAB Assignment Request to the hNodeB, wait for the RAB Assignment Response */ msg = ranap_rab_ass_req_encode(ies); if (!msg) { -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38705?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: pespin/rel-1.6.0 Gerrit-Change-Id: Ifdcd4c369b35820c5c2beb695392d0b82d4ea34c Gerrit-Change-Number: 38705 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[pespin/rel-1.6.0]: hnbgw: Fix wrong map object retrieved from hashtable
by pespin 12 Nov '24

12 Nov '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38706?usp=email ) Change subject: hnbgw: Fix wrong map object retrieved from hashtable ...................................................................... hnbgw: Fix wrong map object retrieved from hashtable If several map objects (mapping between RUA and SCCP transports for a given Iu connection) ended up in the same hashtable bucket, then the first one was always returned by map_from_conn_id(). As a result, when such collisions happened (e.g. when a big number of connections were inserted) a user could see a Iu message coming from SCCP connection "A" end up being forwarded to an unrelated RUA connection "B". Related: SYS#6602 Fixes: f3caea850bc892551cd09bbaf49f798c172590c4 Change-Id: I107f461bf5bcb92262422c893b23d190659f6f72 (cherry picked from commit 1150705a90330c096ff860dcf1c464684bdb33d3) --- M src/osmo-hnbgw/hnbgw_cn.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: pespin: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_cn.c b/src/osmo-hnbgw/hnbgw_cn.c index 6618fb9..7bfe526 100644 --- a/src/osmo-hnbgw/hnbgw_cn.c +++ b/src/osmo-hnbgw/hnbgw_cn.c @@ -446,8 +446,10 @@ const struct osmo_prim_hdr *oph) { struct hnbgw_context_map *map; - hash_for_each_possible(hsu->hnbgw_context_map_by_conn_id, map, hnbgw_sccp_user_entry, conn_id) - return map; + hash_for_each_possible(hsu->hnbgw_context_map_by_conn_id, map, hnbgw_sccp_user_entry, conn_id) { + if (map->scu_conn_id == conn_id) + return map; + } LOGP(DRANAP, LOGL_ERROR, "Rx for unknown SCCP connection ID: %u: %s\n", conn_id, osmo_scu_prim_hdr_name_c(OTC_SELECT, oph)); return NULL; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: pespin/rel-1.6.0 Gerrit-Change-Id: I107f461bf5bcb92262422c893b23d190659f6f72 Gerrit-Change-Number: 38706 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-hnbgw[pespin/rel-1.6.0]: Bump version: 1.6.0.7-a253 → 1.6.1
by pespin 12 Nov '24

12 Nov '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38714?usp=email ) Change subject: Bump version: 1.6.0.7-a253 → 1.6.1 ...................................................................... Bump version: 1.6.0.7-a253 → 1.6.1 Change-Id: I1cccf6c3851b05787dcd82026065d74af08ddc84 --- M debian/changelog 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Verified laforge: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index 094805b..1e98786 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,18 @@ +osmo-hnbgw (1.6.1) unstable; urgency=medium + + [ Neels Janosch Hofmeyr ] + * drop config.vty tests from make check + * coverity CID#358071 + * coverity CID#358072 + * coverity CID#358070 + * coverity CID#358069 + + [ Pau Espin Pedrol ] + * ps_rab_ass_fsm: Fix uninitialized ptr access + * hnbgw: Fix wrong map object retrieved from hashtable + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Fri, 08 Nov 2024 16:10:50 +0100 + osmo-hnbgw (1.6.0) unstable; urgency=medium [ Pau Espin Pedrol ] -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38714?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: pespin/rel-1.6.0 Gerrit-Change-Id: I1cccf6c3851b05787dcd82026065d74af08ddc84 Gerrit-Change-Number: 38714 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[pespin/rel-1.6.0]: coverity CID#358071
by pespin 12 Nov '24

12 Nov '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38701?usp=email ) Change subject: coverity CID#358071 ...................................................................... coverity CID#358071 Change-Id: I8237bf7d4985e993bb10aaaa9370cde2ece3d812 (cherry picked from commit 71f3169140061618b182c5cf6462861370c22387) --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved pespin: Verified diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index df4ec9d..ddf40c9 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -648,7 +648,7 @@ static int hnbgw_rx_ue_deregister(struct hnb_context *ctx, ANY_t *in) { HNBAP_UEDe_RegisterIEs_t ies; - HNBAP_Cause_t cause; + HNBAP_Cause_t cause = {}; int rc; uint32_t ctxid; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38701?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: pespin/rel-1.6.0 Gerrit-Change-Id: I8237bf7d4985e993bb10aaaa9370cde2ece3d812 Gerrit-Change-Number: 38701 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[pespin/rel-1.6.0]: drop config.vty tests from make check
by pespin 12 Nov '24

12 Nov '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38700?usp=email ) Change subject: drop config.vty tests from make check ...................................................................... drop config.vty tests from make check The intention of those tests was to test various osmo-hnbgw startup scenarios. It seemed the fastest/simplest way to do it at the time, but the output depends on another library, regularly causing test fallout. Keep the tests around for reference. They can still be invoked manually with 'make config-tests'. Related: OS#6380 Change-Id: I9c1540904b13d25db1c7933a88f6cc4b028fdd2b (cherry picked from commit 4468d8728e07d9e74a8b08d8bf2d903cc4c5bbfc) --- M tests/Makefile.am 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: pespin: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/tests/Makefile.am b/tests/Makefile.am index a4dcf4c..257c0bf 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -43,7 +43,6 @@ if ENABLE_EXT_TESTS python-tests: $(MAKE) vty-test - $(MAKE) config-tests osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v else @@ -69,6 +68,11 @@ $(U) $(srcdir)/$(VTY_TEST) # Test each config/*.cfg file with the corresponding config/*.vty transcript test. +# +# To be invoked manually only: This is not part of 'make check' because the +# output may change when libosmo-sccp changes its VTY appearance, which can +# cause annoying test fallout. +# # Each config test runs an osmo-hnbgw process to talk to, so they must not run concurrently. # To prevent 'make -j N' from running these tests in parallel, call a script with a linear for-loop. .PHONY: config-tests -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38700?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: pespin/rel-1.6.0 Gerrit-Change-Id: I9c1540904b13d25db1c7933a88f6cc4b028fdd2b Gerrit-Change-Number: 38700 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[pespin/rel-1.6.0]: coverity CID#358072
by pespin 12 Nov '24

12 Nov '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38702?usp=email ) Change subject: coverity CID#358072 ...................................................................... coverity CID#358072 Change-Id: I90b0c73530fa3ba8b0bf74728d5b215957ef7184 (cherry picked from commit 2fc8abeecf3f690a50f26873a779a0e2e2c8259e) --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index ddf40c9..9ed1e46 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -579,7 +579,7 @@ static int hnbgw_rx_ue_register_req(struct hnb_context *ctx, ANY_t *in) { HNBAP_UERegisterRequestIEs_t ies; - HNBAP_Cause_t cause; + HNBAP_Cause_t cause = {}; char imsi[GSM23003_IMSI_MAX_DIGITS+1]; int rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38702?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: pespin/rel-1.6.0 Gerrit-Change-Id: I90b0c73530fa3ba8b0bf74728d5b215957ef7184 Gerrit-Change-Number: 38702 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[pespin/rel-1.6.0]: hnbgw: Fix wrong map object retrieved from hashtable
by pespin 12 Nov '24

12 Nov '24

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38706?usp=email ) Change subject: hnbgw: Fix wrong map object retrieved from hashtable ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: pespin/rel-1.6.0 Gerrit-Change-Id: I107f461bf5bcb92262422c893b23d190659f6f72 Gerrit-Change-Number: 38706 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 10:21:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-hnbgw[pespin/rel-1.6.0]: ps_rab_ass_fsm: Fix uninitialized ptr access
by pespin 12 Nov '24

12 Nov '24

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38705?usp=email ) Change subject: ps_rab_ass_fsm: Fix uninitialized ptr access ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38705?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: pespin/rel-1.6.0 Gerrit-Change-Id: Ifdcd4c369b35820c5c2beb695392d0b82d4ea34c Gerrit-Change-Number: 38705 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 10:21:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-hnbgw[pespin/rel-1.6.0]: coverity CID#358069
by pespin 12 Nov '24

12 Nov '24

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38704?usp=email ) Change subject: coverity CID#358069 ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38704?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: pespin/rel-1.6.0 Gerrit-Change-Id: Ib2ed76c1bdae96457f61c2e015846566f100b8d6 Gerrit-Change-Number: 38704 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 10:21:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log