- gerrit-log - lists.osmocom.org

[M] Change in osmocom-bb[master]: trxcon/l1sched: clarify TDMA Fn (mod 26) maps
by osmith 13 Nov '24

13 Nov '24

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/38744?usp=email ) Change subject: trxcon/l1sched: clarify TDMA Fn (mod 26) maps ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/38744?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib664ba643073e7673aa86aa860a1649225c19aa1 Gerrit-Change-Number: 38744 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Nov 2024 09:39:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmocom-bb[master]: trxcon/l1sched: check-in trx_sched_tch.txt from osmo-bts.git
by osmith 13 Nov '24

13 Nov '24

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/38743?usp=email ) Change subject: trxcon/l1sched: check-in trx_sched_tch.txt from osmo-bts.git ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/38743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3582d6f6e489a345ba8fc6580f6bb29da630fc8e Gerrit-Change-Number: 38743 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Nov 2024 09:38:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: fix FACCH/H regression in rx_tchh_fn()
by osmith 13 Nov '24

13 Nov '24

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/38740?usp=email ) Change subject: trxcon/l1sched: fix FACCH/H regression in rx_tchh_fn() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/38740?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia4b737cf11d4d9ce9847cabb77189e9cbcbb8840 Gerrit-Change-Number: 38740 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Nov 2024 09:37:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: epdg: fix a DTE in as_GSUP_rx_CL_REQ
by fixeria 13 Nov '24

13 Nov '24

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38745?usp=email ) Change subject: epdg: fix a DTE in as_GSUP_rx_CL_REQ ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38745/comment/69aa0b58_736e… : PS1, Line 11: does not properly handle the '*' template kind: > why not making handling the "*" case in this patch properly instead? Because this again brings us to the topic of optional IEs in a `record of`. With the current limitations of TTCN-3, it's not possible to implement handling of `*` properly. See related discussion in https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586. File epdg/EPDG_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38745/comment/6b300970_7ad9… : PS1, Line 948: [] GSUP.receive(tr_GSUP_CL_REQ(g_pars.imsi, dom := omit, ctype := ctype)) -> value rx_gsup; > if it's possible that the domain is not transmitted, why not changing tr_GSUP_CL_REQ() to accept a " […] Please take a chance to read the code yourself a bit... `tr_GSUP_CL_REQ` already does accept a template without any restrictions, so the given parameter can be anything. Otherwise my code passing `omit` here would cause another DTE. The problem is actually in `f_gen_tr_ies()`, which is called by `tr_GSUP_CL_REQ` to generate a `record of` IEs. This is where the violation of `template (present)` was happening: ``` 1300 if (not istemplatekind(cn_domain, "omit")) { 1301 ies[idx] := tr_GSUP_IE_CnDomain(cn_domain); 1302 idx := idx + 1; 1303 } ``` This logic works for `omit`, `?`, and for values, but not for `*`. Before my 51490419 ("library/gsup: improve GSUP_IE templates") this code was passing `*` to `tr_GSUP_IE_CnDomain`, which was wrong and basically eqiovalent to `tr_GSUP_IE_CnDomain(?)`. NOTE: I am not the author of `f_gen_{tr,ts}_ies` and not planning to refactor it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38745?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26738c8c2a0a4b9066bfb619149cbdbaf3e3b5e1 Gerrit-Change-Number: 38745 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Nov 2024 08:44:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: epdg: fix a DTE in as_GSUP_rx_CL_REQ
by pespin 12 Nov '24

12 Nov '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38745?usp=email ) Change subject: epdg: fix a DTE in as_GSUP_rx_CL_REQ ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38745/comment/f0541863_2f34… : PS1, Line 11: does not properly handle the '*' template kind: why not making handling the "*" case in this patch properly instead? File epdg/EPDG_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38745/comment/98a82530_4d93… : PS1, Line 948: [] GSUP.receive(tr_GSUP_CL_REQ(g_pars.imsi, dom := omit, ctype := ctype)) -> value rx_gsup; if it's possible that the domain is not transmitted, why not changing tr_GSUP_CL_REQ() to accept a "template" instead of "template (present)"? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38745?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26738c8c2a0a4b9066bfb619149cbdbaf3e3b5e1 Gerrit-Change-Number: 38745 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 22:42:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: epdg: fix a DTE in as_GSUP_rx_CL_REQ
by fixeria 12 Nov '24

12 Nov '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38745?usp=email ) Change subject: epdg: fix a DTE in as_GSUP_rx_CL_REQ ...................................................................... epdg: fix a DTE in as_GSUP_rx_CL_REQ Recent commit 51490419 uncovered a problem of passing 'dom := *' to tr_GSUP_CL_REQ, which calls f_gen_tr_ies(), which in its turn does not properly handle the '*' template kind: ''' Dynamic test case error: Restriction `present' on template of type @GSUP_Types.GSUP_CnDomain violated. ''' The old code was basically equivalent of passing 'dom := ?', i.e. expecting the OSMO_GSUP_CN_DOMAIN_IE to be present. Work the problem around by having two alternatives: * GSUP.receive(tr_GSUP_CL_REQ(dom := omit) * GSUP.receive(tr_GSUP_CL_REQ(dom := ?) This patch makes TC_hss_initiated_deregister_permanent_termination pass. Change-Id: I26738c8c2a0a4b9066bfb619149cbdbaf3e3b5e1 Related: 51490419 ("library/gsup: improve GSUP_IE templates") --- M epdg/EPDG_Tests.ttcn 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/38745/1 diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index d9300a6..b551b67 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -943,8 +943,10 @@ private altstep as_GSUP_rx_CL_REQ(template GSUP_CancelType ctype := omit) runs on EPDG_ConnHdlr { var GSUP_PDU rx_gsup; - [] GSUP.receive(tr_GSUP_CL_REQ(g_pars.imsi, dom := *, ctype := ctype)) -> value rx_gsup { - } + /* XXX: workaround for 'dom := *' causing a DTE: + * "Dynamic test case error: Restriction `present' on template of type @GSUP_Types.GSUP_CnDomain violated." */ + [] GSUP.receive(tr_GSUP_CL_REQ(g_pars.imsi, dom := omit, ctype := ctype)) -> value rx_gsup; + [] GSUP.receive(tr_GSUP_CL_REQ(g_pars.imsi, dom := ?, ctype := ctype)) -> value rx_gsup; [] GSUP.receive(GSUP_PDU:?) -> value rx_gsup { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected GSUP msg rx: ", rx_gsup)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38745?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26738c8c2a0a4b9066bfb619149cbdbaf3e3b5e1 Gerrit-Change-Number: 38745 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in libosmo-pfcp[master]: pfcp: Make struct osmo_pfcp_cp_peer private
by pespin 12 Nov '24

12 Nov '24

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/38612?usp=email ) Change subject: pfcp: Make struct osmo_pfcp_cp_peer private ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > I would have really liked to read the actual rationale behind this in the commit log. The rationale is nothing strange, simply avoid breaking the ABI/API whenever something needs to be changed in the lib implementation-wise. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/38612?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I7f79ce239cb3c57bae2cf5846edf71e1aa03fa95 Gerrit-Change-Number: 38612 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 19:32:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>

1 0

[M] Change in osmocom-bb[master]: trxcon/l1sched: clarify TDMA Fn (mod 26) maps
by pespin 12 Nov '24

12 Nov '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/38744?usp=email ) Change subject: trxcon/l1sched: clarify TDMA Fn (mod 26) maps ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/38744?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib664ba643073e7673aa86aa860a1649225c19aa1 Gerrit-Change-Number: 38744 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 19:29:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmocom-bb[master]: trxcon/l1sched: check-in trx_sched_tch.txt from osmo-bts.git
by pespin 12 Nov '24

12 Nov '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/38743?usp=email ) Change subject: trxcon/l1sched: check-in trx_sched_tch.txt from osmo-bts.git ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/38743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3582d6f6e489a345ba8fc6580f6bb29da630fc8e Gerrit-Change-Number: 38743 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 19:28:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-pfcp[master]: pfcp: Make struct osmo_pfcp_cp_peer private
by neels 12 Nov '24

12 Nov '24

neels has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/38612?usp=email ) Change subject: pfcp: Make struct osmo_pfcp_cp_peer private ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: I would have really liked to read the actual rationale behind this in the commit log. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/38612?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I7f79ce239cb3c57bae2cf5846edf71e1aa03fa95 Gerrit-Change-Number: 38612 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 19:25:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log