dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38798?usp=email )
Change subject: docs/osmo-smdpp: restructure subsection "osmo-smdpp"
......................................................................
docs/osmo-smdpp: restructure subsection "osmo-smdpp"
Sphinx is complaining about a duplicate label "osmo-smdpp". Apparantly
because we use this label twices as section headline. The subsection
"osmo-smdpp" in "Running osmo-smdpp" talks about the commandline and the
supplementary files that osmo-smdpp needs to run. Let's split the two
topics into two different sections.
Change-Id: I8bc4979160a00d36a03b9cd10679562a08c2c55c
---
M docs/osmo-smdpp.rst
1 file changed, 9 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/98/38798/1
diff --git a/docs/osmo-smdpp.rst b/docs/osmo-smdpp.rst
index dd44469..329b3d7 100644
--- a/docs/osmo-smdpp.rst
+++ b/docs/osmo-smdpp.rst
@@ -79,12 +79,8 @@
You can of course achieve a similar functionality with apache, lighttpd or many other web server
software.
-
-osmo-smdpp
-~~~~~~~~~~
-
-osmo-smdpp currently doesn't have any configuration file or command line options. You just run it,
-and it will bind its plain-HTTP ES9+ interface to local TCP port 8000.
+supplementary files
+~~~~~~~~~~~~~~~~~~~
The `smdpp-data/certs`` directory contains the DPtls, DPauth and DPpb as well as CI certificates
used; they are copied from GSMA SGP.26 v2. You can of course replace them with custom certificates
@@ -93,6 +89,13 @@
The `smdpp-data/upp` directory contains the UPP (Unprotected Profile Package) used. The file names (without
.der suffix) are looked up by the matchingID parameter from the activation code presented by the LPA.
+commandline options
+~~~~~~~~~~~~~~~~~~~
+
+osmo-smdpp currently doesn't have any configuration file or command line options. You just run it,
+and it will bind its plain-HTTP ES9+ interface to local TCP port 8000.
+
+
DNS setup for your LPA
~~~~~~~~~~~~~~~~~~~~~~
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/38798?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I8bc4979160a00d36a03b9cd10679562a08c2c55c
Gerrit-Change-Number: 38798
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38793?usp=email )
Change subject: sctp_proxy: add fetch_info/1 for state introspection
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38793?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ifd495c3b5e6f036fca1fbb2a06330f06ddfbbe61
Gerrit-Change-Number: 38793
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Nov 2024 09:30:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38791?usp=email )
Change subject: sctp_server: add fetch_conn_list/0 for state introspection
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38791?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ia673d6d57bbc3decf2c8038c1ee9573937702520
Gerrit-Change-Number: 38791
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Nov 2024 09:29:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38790?usp=email )
Change subject: sctp_server: make it abstract from sctp_proxy logic
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38790?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Iee4202dd4d4e9762fe74ead985aa43343ebdc524
Gerrit-Change-Number: 38790
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Nov 2024 09:29:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38789?usp=email )
Change subject: sctp_server: pass #server_state to client_{add,del}()
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38789?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I5f784617745a9ecec2cfa998dc70e176311d24b1
Gerrit-Change-Number: 38789
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Nov 2024 09:27:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38788?usp=email )
Change subject: sctp_server: cosmetic: make #server_state last argument
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38788?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I34bcdb818f58ccfa045d9fe17743523480e785f2
Gerrit-Change-Number: 38788
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Nov 2024 09:25:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38787?usp=email )
Change subject: sctp_server: cosmetic: rename State -> S
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38787?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I8dde744ac8b8798cdeed5d4eac47d4f650fe03f9
Gerrit-Change-Number: 38787
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Nov 2024 09:25:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38786?usp=email )
Change subject: sctp_server: pass MME addr/port to sctp_proxy as opaque data
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/sctp_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38786/comment/6871e820_0156… :
PS1, Line 64: start_link(Aid, {MmeAddr, MmePort}) ->
I wonder what's the point in maintaining the 2 versions of the start_link here...
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38786?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I1bd5f17d940173c4ec2d8d7a1d48778098008c84
Gerrit-Change-Number: 38786
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Nov 2024 09:25:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38794?usp=email )
Change subject: change default reject cause to plmn-not-allowed
......................................................................
change default reject cause to plmn-not-allowed
Unless the Osmocom-based network operator has very carefully
considered what they are doing, returning MM/GMM reject cause #2
(IMSI unknown in HLR) to LU requests from bystander phones is a
very bad idea. Here is what typically happens when someone sets
up an Osmocom-based GSM network for development, testing or
research, without roaming interconnection with any commercial
operators:
* Even when the private network operates its BTS at very low power
levels, bystander phones in close proximity (e.g., in directly
adjacent neighbor apartments or office suites) will receive a much
stronger signal from the private/test network BTS than from any
commercial operator, i.e., the private/test network will be
the strongest signal.
* Many phones will attempt to "jump ship" to this strongest signal
even if it broadcasts a completely unknown PLMN ID that is not in
the preferred operator list, and even when they were previously
not roaming at all, registered to their most preferred home operator
with perfectly good reception quality.
* If these wayward phones receive reject cause #2 in response to their
LU attempt, the spec effectively requires them to go into a "black
hole" where they no longer attempt to register to any operator,
including their own legitimate one.
Returning reject cause #11 instead (PLMN not allowed) solves this
problem: wayward phones that erroneously attempted to register to the
private/test network go back to their own legitimate commercial
operator, and everyone is happy.
This bug should be considered critical: when the reject cause is set
to #2 by default, any private Osmocom-based network, no matter how
low-power, will effectively cause service disruption to all nearby
commercially-served phones even when there is no clash in terms of
used radio frequencies.
Change-Id: Icff1d19670c398b119ec68b1d5f0fad87b605702
---
M src/hlr.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/94/38794/1
diff --git a/src/hlr.c b/src/hlr.c
index 6f444aa..3d020d6 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -779,7 +779,7 @@
g_hlr->db_file_path = talloc_strdup(g_hlr, HLR_DEFAULT_DB_FILE_PATH);
g_hlr->mslookup.server.mdns.domain_suffix = talloc_strdup(g_hlr, OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT);
g_hlr->mslookup.client.mdns.domain_suffix = talloc_strdup(g_hlr, OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT);
- g_hlr->reject_cause = GMM_CAUSE_IMSI_UNKNOWN;
+ g_hlr->reject_cause = GMM_CAUSE_PLMN_NOTALLOWED;
g_hlr->no_proxy_reject_cause = GMM_CAUSE_IMSI_UNKNOWN;
/* Init default (call independent) SS session guard timeout value */
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38794?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icff1d19670c398b119ec68b1d5f0fad87b605702
Gerrit-Change-Number: 38794
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>