- gerrit-log - lists.osmocom.org

[XS] Change in android-apdu-proxy[master]: MainActivity: use Double:valueOf to convert release version number
by dexter 20 Nov '24

20 Nov '24

dexter has submitted this change. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38840?usp=email ) Change subject: MainActivity: use Double:valueOf to convert release version number ...................................................................... MainActivity: use Double:valueOf to convert release version number Releases are not always integer numbers, they can have decimal places too. Related: OS#6367 Change-Id: I2d0a72269e4056fb6f5ee8587b8d4ba762dd9d6d --- M app/src/main/java/org/osmocom/androidApduProxy/MainActivity.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/app/src/main/java/org/osmocom/androidApduProxy/MainActivity.java b/app/src/main/java/org/osmocom/androidApduProxy/MainActivity.java index fcdebea..e0174e6 100644 --- a/app/src/main/java/org/osmocom/androidApduProxy/MainActivity.java +++ b/app/src/main/java/org/osmocom/androidApduProxy/MainActivity.java @@ -164,7 +164,7 @@ //an error message and continue normally, maybe we are lucky and it works anyway. //(This check only works on Android 11 and higher, //see also https://developer.android.com/develop/connectivity/telecom/dialer-app/telep…) - if (Integer.valueOf(Build.VERSION.RELEASE) >= 11 && + if (Double.valueOf(Build.VERSION.RELEASE) >= 11 && !packageManager.hasSystemFeature(PackageManager.FEATURE_SE_OMAPI_UICC)) { msgBox("Feature FEATURE_SE_OMAPI_UICC is not available on this device, APDU access to UICC/eUICC not possible!", "Error"); -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: I2d0a72269e4056fb6f5ee8587b8d4ba762dd9d6d Gerrit-Change-Number: 38840 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in android-apdu-proxy[master]: READMe.md: add another OMAPI related URL to documentation
by dexter 20 Nov '24

20 Nov '24

dexter has submitted this change. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38839?usp=email ) Change subject: READMe.md: add another OMAPI related URL to documentation ...................................................................... READMe.md: add another OMAPI related URL to documentation Related: OS#6367 Change-Id: I048e64ae95438b343c7a037c9c7a4da567344449 --- M README.md 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/README.md b/README.md index c5d1ebb..789cdd4 100644 --- a/README.md +++ b/README.md @@ -41,6 +41,7 @@ Android APDU proxy will return a 6A82 status word. More information about OMAPI can be found under: +* https://source.android.com/docs/security/features/open-mobile-api * https://developer.android.com/reference/android/se/omapi/package-summary * https://globalplatform.org/wp-content/uploads/2018/04/GPD_Open_Mobile_API_S… -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: I048e64ae95438b343c7a037c9c7a4da567344449 Gerrit-Change-Number: 38839 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in android-apdu-proxy[master]: READMe.md: add another OMAPI related URL to documentation
by dexter 20 Nov '24

20 Nov '24

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38839?usp=email ) Change subject: READMe.md: add another OMAPI related URL to documentation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: I048e64ae95438b343c7a037c9c7a4da567344449 Gerrit-Change-Number: 38839 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Nov 2024 15:32:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in android-apdu-proxy[master]: MainActivity: use Double:valueOf to convert release version number
by dexter 20 Nov '24

20 Nov '24

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38840?usp=email ) Change subject: MainActivity: use Double:valueOf to convert release version number ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: I2d0a72269e4056fb6f5ee8587b8d4ba762dd9d6d Gerrit-Change-Number: 38840 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Nov 2024 15:32:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in android-apdu-proxy[master]: MainActivity: use Double:valueOf to convert release version number
by dexter 20 Nov '24

20 Nov '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38840?usp=email ) Change subject: MainActivity: use Double:valueOf to convert release version number ...................................................................... MainActivity: use Double:valueOf to convert release version number Releases are not always integer numbers, they can have decimal places too. Related: OS#6367 Change-Id: I2d0a72269e4056fb6f5ee8587b8d4ba762dd9d6d --- M app/src/main/java/org/osmocom/androidApduProxy/MainActivity.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/android-apdu-proxy refs/changes/40/38840/1 diff --git a/app/src/main/java/org/osmocom/androidApduProxy/MainActivity.java b/app/src/main/java/org/osmocom/androidApduProxy/MainActivity.java index fcdebea..e0174e6 100644 --- a/app/src/main/java/org/osmocom/androidApduProxy/MainActivity.java +++ b/app/src/main/java/org/osmocom/androidApduProxy/MainActivity.java @@ -164,7 +164,7 @@ //an error message and continue normally, maybe we are lucky and it works anyway. //(This check only works on Android 11 and higher, //see also https://developer.android.com/develop/connectivity/telecom/dialer-app/telep…) - if (Integer.valueOf(Build.VERSION.RELEASE) >= 11 && + if (Double.valueOf(Build.VERSION.RELEASE) >= 11 && !packageManager.hasSystemFeature(PackageManager.FEATURE_SE_OMAPI_UICC)) { msgBox("Feature FEATURE_SE_OMAPI_UICC is not available on this device, APDU access to UICC/eUICC not possible!", "Error"); -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: I2d0a72269e4056fb6f5ee8587b8d4ba762dd9d6d Gerrit-Change-Number: 38840 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in android-apdu-proxy[master]: READMe.md: add another OMAPI related URL to documentation
by dexter 20 Nov '24

20 Nov '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38839?usp=email ) Change subject: READMe.md: add another OMAPI related URL to documentation ...................................................................... READMe.md: add another OMAPI related URL to documentation Related: OS#6367 Change-Id: I048e64ae95438b343c7a037c9c7a4da567344449 --- M README.md 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/android-apdu-proxy refs/changes/39/38839/1 diff --git a/README.md b/README.md index c5d1ebb..789cdd4 100644 --- a/README.md +++ b/README.md @@ -41,6 +41,7 @@ Android APDU proxy will return a 6A82 status word. More information about OMAPI can be found under: +* https://source.android.com/docs/security/features/open-mobile-api * https://developer.android.com/reference/android/se/omapi/package-summary * https://globalplatform.org/wp-content/uploads/2018/04/GPD_Open_Mobile_API_S… -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: I048e64ae95438b343c7a037c9c7a4da567344449 Gerrit-Change-Number: 38839 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-remsim[master]: Replace deprecated ipa_msg_push_header()
by pespin 20 Nov '24

20 Nov '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/38824?usp=email ) Change subject: Replace deprecated ipa_msg_push_header() ...................................................................... Replace deprecated ipa_msg_push_header() Use the libosmocore API, which does the same except setting the l2h pointer, which we don't really need here. Change-Id: I3769e1e4a4c0167fa077a1d9b09af81a1aaf5707 --- M src/rspro_client_fsm.c M src/server/rspro_server.c 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 72176ab..351c642 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -76,7 +76,7 @@ static void push_and_send(struct ipa_client_conn *ipa, struct msgb *msg_tx) { ipa_prepend_header_ext(msg_tx, IPAC_PROTO_EXT_RSPRO); - ipa_msg_push_header(msg_tx, IPAC_PROTO_OSMO); + ipa_prepend_header(msg_tx, IPAC_PROTO_OSMO); ipa_client_conn_send(ipa, msg_tx); /* msg_tx is now queued and will be freed. */ } diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index da27a2d..5803c8a 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -59,7 +59,7 @@ return; } ipa_prepend_header_ext(msg_tx, IPAC_PROTO_EXT_RSPRO); - ipa_msg_push_header(msg_tx, IPAC_PROTO_OSMO); + ipa_prepend_header(msg_tx, IPAC_PROTO_OSMO); ipa_server_conn_send(conn->peer, msg_tx); } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/38824?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3769e1e4a4c0167fa077a1d9b09af81a1aaf5707 Gerrit-Change-Number: 38824 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-gprs[master]: gmm: gprs_gmm_att_tlvdef: Add newer definitions from current enum gsm...
by pespin 20 Nov '24

20 Nov '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/38833?usp=email ) Change subject: gmm: gprs_gmm_att_tlvdef: Add newer definitions from current enum gsm48_gprs_ie_mm ...................................................................... gmm: gprs_gmm_att_tlvdef: Add newer definitions from current enum gsm48_gprs_ie_mm Depends: libosmocore.git a28ae056435b0de575441f7608101117d1beda0c Change-Id: I154f1795696b42b8b57d03e867ce3c1f9aa7d879 --- M TODO-RELEASE M src/gmm/gmm_pdu.c 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index a0b3490..9ce8fb2 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,3 +8,4 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line libosmocore >1.8.0 gsm_fn2rfn(), gsm_rfn2fn() +libosmocore >1.10.0 enum gsm48_gprs_ie_mm: GSM48_IE_GMM_UE_NET_CAP, GSM48_IE_GMM_VD_PREF_UE_USAGE diff --git a/src/gmm/gmm_pdu.c b/src/gmm/gmm_pdu.c index 512bd98..084f2a6 100644 --- a/src/gmm/gmm_pdu.c +++ b/src/gmm/gmm_pdu.c @@ -154,6 +154,8 @@ [GSM48_IE_GMM_PS_LCS_CAPA] = { TLV_TYPE_TLV, 0 }, [GSM48_IE_GMM_GMM_MBMS_CTX_ST] = { TLV_TYPE_TLV, 0 }, [GSM48_IE_GMM_TIMER_T3346] = { TLV_TYPE_TLV, 0 }, + [GSM48_IE_GMM_UE_NET_CAP] = { TLV_TYPE_TLV, 0 }, + [GSM48_IE_GMM_VD_PREF_UE_USAGE] = { TLV_TYPE_TLV, 0 }, [GSM48_IE_GMM_NET_FEAT_SUPPORT] = { TLV_TYPE_SINGLE_TV, 1 }, }, }; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/38833?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I154f1795696b42b8b57d03e867ce3c1f9aa7d879 Gerrit-Change-Number: 38833 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-remsim[master]: Replace deprecated ipa_msg_push_header()
by osmith 20 Nov '24

20 Nov '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/38824?usp=email ) Change subject: Replace deprecated ipa_msg_push_header() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/38824?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3769e1e4a4c0167fa077a1d9b09af81a1aaf5707 Gerrit-Change-Number: 38824 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Nov 2024 13:29:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-hlr[master]: gsup: Replace deprecated ipa_msg_push_header()
by osmith 20 Nov '24

20 Nov '24

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38823?usp=email ) Change subject: gsup: Replace deprecated ipa_msg_push_header() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I7a4d05a0b09032d8133d8775fb4707a4da8f0cf3 Gerrit-Change-Number: 38823 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Nov 2024 13:29:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log