osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38850?usp=email )
Change subject: bts/run_fake_trx.sh: tweak cd logic
......................................................................
bts/run_fake_trx.sh: tweak cd logic
Don't test if FAKE_TRX_DIR is empty, because it is never empty at that
point. If it was empty, then the line above would assign a default
value.
Change-Id: I63f9720487b564de5c5609eb52a6bb9d5a8aa74f
---
M bts/run_fake_trx.sh
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/bts/run_fake_trx.sh b/bts/run_fake_trx.sh
index 2209972..6243ce2 100755
--- a/bts/run_fake_trx.sh
+++ b/bts/run_fake_trx.sh
@@ -4,8 +4,5 @@
# fake trx is part of osmo-trx
FAKE_TRX_DIR="${FAKE_TRX_DIR:-../../osmo-trx/osmocom-bb/src/target/trx_toolkit}"
-if [ -n "$FAKE_TRX_DIR" ] ; then
- cd "$FAKE_TRX_DIR"
-fi
-
+cd "$FAKE_TRX_DIR"
exec ./fake_trx.py --trx TRX1@127.0.0.1:5700/1 --trx TRX2@127.0.0.1:5700/2 --trx TRX3@127.0.0.1:5700/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38850?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I63f9720487b564de5c5609eb52a6bb9d5a8aa74f
Gerrit-Change-Number: 38850
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38849?usp=email )
Change subject: testenv: pass env var for --binary-repo
......................................................................
testenv: pass env var for --binary-repo
Pass TESTENV_BINARY_REPO=1 to the podman container if the --binary-repo
argument is set. This will be used for the BTS testsuite to figure out
from where we need to run fake-trx.
Change-Id: Ia88906147e2e579145e3c8d04090c58f533febd5
---
M _testenv/testenv/podman.py
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/_testenv/testenv/podman.py b/_testenv/testenv/podman.py
index 1281b3b..f8812e4 100644
--- a/_testenv/testenv/podman.py
+++ b/_testenv/testenv/podman.py
@@ -243,7 +243,12 @@
"PODMAN=1",
]
- if not testenv.args.binary_repo:
+ if testenv.args.binary_repo:
+ cmd += [
+ "-e",
+ "TESTENV_BINARY_REPO=1",
+ ]
+ else:
cmd += [
"--volume",
f"{osmo_dev_dir}:{osmo_dev_dir}",
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38849?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia88906147e2e579145e3c8d04090c58f533febd5
Gerrit-Change-Number: 38849
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
dexter has submitted this change. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38857?usp=email )
Change subject: MainActivity: use the API level to check the Android release version
......................................................................
MainActivity: use the API level to check the Android release version
Change-Id: I2e8a22a638a3c9033002cfa61e1179f8a8d547df
Related: OS#6367
---
M app/src/main/java/org/osmocom/androidApduProxy/MainActivity.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
osmith: Looks good to me, approved
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/app/src/main/java/org/osmocom/androidApduProxy/MainActivity.java b/app/src/main/java/org/osmocom/androidApduProxy/MainActivity.java
index e0174e6..2585663 100644
--- a/app/src/main/java/org/osmocom/androidApduProxy/MainActivity.java
+++ b/app/src/main/java/org/osmocom/androidApduProxy/MainActivity.java
@@ -162,9 +162,9 @@
//Check if this device even supports APDU access to an UICC/eUICC card, if not we display
//an error message and continue normally, maybe we are lucky and it works anyway.
- //(This check only works on Android 11 and higher,
+ //(This check only works on Android 11 / API-level 30 and higher,
//see also https://developer.android.com/develop/connectivity/telecom/dialer-app/telep…)
- if (Double.valueOf(Build.VERSION.RELEASE) >= 11 &&
+ if (Build.VERSION.SDK_INT >= 30 &&
!packageManager.hasSystemFeature(PackageManager.FEATURE_SE_OMAPI_UICC)) {
msgBox("Feature FEATURE_SE_OMAPI_UICC is not available on this device, APDU access to UICC/eUICC not possible!",
"Error");
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38857?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: I2e8a22a638a3c9033002cfa61e1179f8a8d547df
Gerrit-Change-Number: 38857
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Attention is currently required from: dexter.
osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38858?usp=email )
Change subject: Bump version to 0.1.0
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38858?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: I3338699a1df100eee094b66b9e9696abb8de856f
Gerrit-Change-Number: 38858
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Nov 2024 13:34:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
dexter has submitted this change. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38856?usp=email )
Change subject: README.md add section about device compatibility
......................................................................
README.md add section about device compatibility
To give potential users an estimate on which android devices the APDU proxy
may work, let's explain a bit about which Android releases have OMAPI and
which not. Let's also add a table with devices with which we have tested
the APDU proxy successfully.
Change-Id: I64459bbe2920c7381ab75e422bf317ad21c8b8cc
Related: OS#6367
---
M README.md
1 file changed, 30 insertions(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, approved
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/README.md b/README.md
index 37efb2a..8a5765b 100644
--- a/README.md
+++ b/README.md
@@ -264,4 +264,33 @@
```
To make sure that the re-signing was successful the apksigner utility can be
-used as already described in section `Signing and ARA-M configuration`
\ No newline at end of file
+used as already described in section `Signing and ARA-M configuration`
+
+Device compatibility
+--------------------
+
+Unfortunately Android APDU proxy does not run on any old Android device. It
+requires an Android device with at least Android 9 (API level 28), which
+was introduced in 2018.
+
+Only Android devices with Android 9 or higher will have the `OMAPI`
+interface that Android APDU proxy needs to access the UICC/eUICC. However,
+even if the Android device has OMAPI support, it is not guaranteed that it
+can be used to access the UICC/eUICC cards. This depends on the specific
+hardware/firmware properties of the device itself. With Android 11 (API level
+30), a feature flag `FEATURE_SE_OMAPI_UICC` was introduced that allows checking
+for OMAPI UICC/eUICC support explicitly. Android APDU proxy checks this flag
+(if present) and will generate an error message in case UICC/eUICC access is
+not possible.
+
+During development we have tested Android APDU proxy successfully on the
+following Android devices.
+
+| Brand | Model | Android version | API level |
+| -------- | ------------------------------ | --------------- | --------- |
+| Samsung | SM-A217F/DSN (Galaxy A21s) | 10 | 29 |
+| ONEPLUS | A6013 | 11 | 30 |
+| CAT | S62Pro | 11 | 30 |
+| Google | Pixel7a | 13 | 33 |
+| Google | Pixel4a | 14 | 34 |
+| SAMSUNG | SM-G990B/DS (Galaxy S21 FE 5G) | 14 | 34 |
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38856?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: I64459bbe2920c7381ab75e422bf317ad21c8b8cc
Gerrit-Change-Number: 38856
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Attention is currently required from: dexter.
osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38857?usp=email )
Change subject: MainActivity: use the API level to check the Android release version
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38857?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: I2e8a22a638a3c9033002cfa61e1179f8a8d547df
Gerrit-Change-Number: 38857
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Nov 2024 13:33:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38858?usp=email )
Change subject: Bump version to 0.1.0
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38858?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: I3338699a1df100eee094b66b9e9696abb8de856f
Gerrit-Change-Number: 38858
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Nov 2024 13:33:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38857?usp=email )
Change subject: MainActivity: use the API level to check the Android release version
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38857?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: I2e8a22a638a3c9033002cfa61e1179f8a8d547df
Gerrit-Change-Number: 38857
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Nov 2024 13:33:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes