Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/38871?usp=email )
Change subject: bts-omldummy: Support configuring logging through cmdline
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38871?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0b33919d71bacefe60be192810518fd927625127
Gerrit-Change-Number: 38871
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 22 Nov 2024 08:51:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email )
Change subject: testenv: build virtphy from src with --binary-repo
......................................................................
testenv: build virtphy from src with --binary-repo
Add logic to build virtphy from source when running with --binary-repo.
This extra code path is needed because we currently don't have virtphy
packaged (like trxcon and sccp_demo_user), and we need to build the
libosmocore binary package instead of building completely from source as
we would do it with osmo-dev.
Use ".split(" ", 1)[0]" on the program= value to only look at its first
word, so we can later on use it in testenv.cfg file as follows:
[virtphy]
program=virtphy -s /tmp/osmocom_l2
Change-Id: I37bac8509b2601286e4feab099782f82c8338dca
---
M _testenv/testenv/podman_install.py
1 file changed, 20 insertions(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/_testenv/testenv/podman_install.py b/_testenv/testenv/podman_install.py
index 3c38285..9033c14 100644
--- a/_testenv/testenv/podman_install.py
+++ b/_testenv/testenv/podman_install.py
@@ -13,6 +13,7 @@
git_dir = None
bb_dir = None
trxcon_dir = None
+virtphy_dir = None
sccp_dir = None
jobs = None
@@ -21,12 +22,14 @@
global git_dir
global bb_dir
global trxcon_dir
+ global virtphy_dir
global sccp_dir
global jobs
git_dir = os.path.join(testenv.args.cache, "git")
bb_dir = os.path.join(git_dir, "osmocom-bb")
trxcon_dir = os.path.join(bb_dir, "src/host/trxcon")
+ virtphy_dir = os.path.join(bb_dir, "src/host/virt_phy")
sccp_dir = os.path.join(git_dir, "libosmo-sigtran")
jobs = multiprocessing.cpu_count() + 1
@@ -148,6 +151,20 @@
testenv.cmd.run(["ln", "-s", trxcon_in_srcdir, "/usr/local/bin/trxcon"])
+def from_source_virtphy():
+ virtphy_in_srcdir = os.path.join(virtphy_dir, "src/virtphy")
+
+ if not os.path.exists(virtphy_in_srcdir):
+ clone_osmocom_bb()
+ apt_install(["libosmocore-dev"])
+ logging.info("Building virtphy")
+ testenv.cmd.run(["autoreconf", "-fi"], cwd=virtphy_dir)
+ testenv.cmd.run(["./configure"], cwd=virtphy_dir)
+ testenv.cmd.run(["make", "-j", f"{jobs}"], cwd=virtphy_dir)
+
+ testenv.cmd.run(["ln", "-s", virtphy_in_srcdir, "/usr/local/bin/virtphy"])
+
+
def from_source_sccp_demo_user():
sccp_demo_user_path = os.path.join(sccp_dir, "examples/sccp_demo_user")
@@ -178,9 +195,11 @@
def from_source(cfg, cfg_name, section):
- program = cfg[section]["program"]
+ program = cfg[section]["program"].split(" ", 1)[0]
if program == "trxcon":
return from_source_trxcon()
+ if program == "virtphy":
+ return from_source_virtphy()
if program == "run_fake_trx.sh":
return clone_osmocom_bb()
if program == "run_sccp_demo_user.sh":
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I37bac8509b2601286e4feab099782f82c8338dca
Gerrit-Change-Number: 38851
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge, pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email )
Change subject: testenv: build virtphy from src with --binary-repo
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851/comment/2948f4bf_d3a1… :
PS1, Line 9: Add logic to build virtphy from source when running with --binary-repo.
> > We can also make osmocom-bb tags and still keep it as "not officially released". […]
I don't think the patch here needs to block on this, I can make a follow-up patch to switch to the binary package for virtphy later on.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I37bac8509b2601286e4feab099782f82c8338dca
Gerrit-Change-Number: 38851
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 22 Nov 2024 08:34:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge, pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email )
Change subject: testenv: build virtphy from src with --binary-repo
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851/comment/f3c56cfb_30b6… :
PS1, Line 9: Add logic to build virtphy from source when running with --binary-repo.
> We can also make osmocom-bb tags and still keep it as "not officially released".
This sounds like a good solution. I'll package the programs we are using, and once merged I'll make a tag that is "not officially released".
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I37bac8509b2601286e4feab099782f82c8338dca
Gerrit-Change-Number: 38851
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 22 Nov 2024 08:32:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38872?usp=email )
Change subject: examples/ipa-stream-client: Fix wrong call to osmo_ipa_process_msg()
......................................................................
examples/ipa-stream-client: Fix wrong call to osmo_ipa_process_msg()
The function osmo_ipa_process_msg() is already called internally by the
segmentation callback osmo_ipa_segmentation_cb(), which calls
ipa_check_pull_headers() which in turn calls osmo_ipa_process_msg().
The program was still working because it was using msg->data which isn't
modified by osmo_ipa_process_msg(), but the l2h pointer was incorrectly
modified.
Change-Id: Idec574f59587c681dd059266c9a9cf244bf41dc3
---
M examples/ipa-stream-client.c
1 file changed, 1 insertion(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/72/38872/1
diff --git a/examples/ipa-stream-client.c b/examples/ipa-stream-client.c
index b58370e..2604266 100644
--- a/examples/ipa-stream-client.c
+++ b/examples/ipa-stream-client.c
@@ -115,13 +115,7 @@
return 0;
}
- if (osmo_ipa_process_msg(msg) < 0) {
- LOGP(DIPATEST, LOGL_ERROR, "bad IPA message\n");
- msgb_free(msg);
- return 0;
- }
-
- num = osmo_load32be(msg->data);
+ num = osmo_load32be(msgb_l2(msg));
LOGP(DLINP, LOGL_DEBUG, "received msg number %d\n", num);
llist_for_each_entry_safe(cur, tmp, &msg_sent_list, head) {
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38872?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Idec574f59587c681dd059266c9a9cf244bf41dc3
Gerrit-Change-Number: 38872
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>