- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: [cosmetic] esim.saip: Fix various typos in comments/docs/messages
by pespin 22 Nov '24

22 Nov '24

Attention is currently required from: laforge. pespin has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38899?usp=email ) Change subject: [cosmetic] esim.saip: Fix various typos in comments/docs/messages ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4fc603634a0f2b53e432a77f05e811a38ba065c2 Gerrit-Change-Number: 38899 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 22 Nov 2024 16:01:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: [cosmetic] esim.saip: Fix various typos in comments/docs/messages
by laforge 22 Nov '24

22 Nov '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38899?usp=email ) Change subject: [cosmetic] esim.saip: Fix various typos in comments/docs/messages ...................................................................... [cosmetic] esim.saip: Fix various typos in comments/docs/messages Change-Id: I4fc603634a0f2b53e432a77f05e811a38ba065c2 --- M pySim/esim/saip/__init__.py 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/99/38899/1 diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 355e6b9..1fcf61f 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -450,7 +450,7 @@ @property def header_name(self) -> str: """Return the name of the header field within the profile element.""" - # unneccessarry compliaction by inconsistent naming :( + # unnecessary complication by inconsistent naming :( if self.type.startswith('opt-'): return self.type.replace('-','') + '-header' if self.type in self.header_name_translation_dict: @@ -933,7 +933,7 @@ 'macLength': self.mac_length} class SecurityDomainKey: - """Represenation of a key used for SCP access to a security domain.""" + """Representation of a key used for SCP access to a security domain.""" def __init__(self, key_version_number: int, key_id: int, key_usage_qualifier: dict, key_components: List[SecurityDomainKeyComponent]): self.key_usage_qualifier = key_usage_qualifier @@ -1276,7 +1276,7 @@ sequence.""" def __init__(self): """After calling the constructor, you have to further initialize the instance by either - calling the parse_der() method, or by manually adding individual PEs, including the hedaer and + calling the parse_der() method, or by manually adding individual PEs, including the header and end PEs.""" self.pe_list: List[ProfileElement] = [] self.pe_by_type: Dict = {} @@ -1298,7 +1298,7 @@ def add_hdr_and_end(self): """Initialize the PE Sequence with a header and end PE.""" if len(self.pe_list): - raise ValueError("Cannot add header + end PE to a non-enmpty PE-Sequence") + raise ValueError("Cannot add header + end PE to a non-empty PE-Sequence") # start with a minimal/empty sequence of header + end self.append(ProfileElementHeader()) self.append(ProfileElementEnd()) @@ -1315,7 +1315,7 @@ def get_pe_for_type(self, tname: str) -> Optional[ProfileElement]: """Return a single profile element for given profile element type. Works only for - types of which there is only a signle instance in the PE Sequence!""" + types of which there is only a single instance in the PE Sequence!""" l = self.get_pes_for_type(tname) if len(l) == 0: return None @@ -1323,7 +1323,7 @@ return l[0] def get_pes_for_templateID(self, tid: oid.OID) -> List[ProfileElement]: - """Return list of profile elements present for given profile eleemnt type.""" + """Return list of profile elements present for given profile element type.""" res = [] for pe in self.pe_list: if not pe.templateID: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4fc603634a0f2b53e432a77f05e811a38ba065c2 Gerrit-Change-Number: 38899 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-bts[master]: bts-omldummy: print category names instead of hex values
by pespin 22 Nov '24

22 Nov '24

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/38883?usp=email to look at the new patch set (#2). Change subject: bts-omldummy: print category names instead of hex values ...................................................................... bts-omldummy: print category names instead of hex values Change-Id: I6082409f25e33cdf4480455bae16b5ac6c5bc1a4 --- M src/osmo-bts-omldummy/main.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/83/38883/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38883?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6082409f25e33cdf4480455bae16b5ac6c5bc1a4 Gerrit-Change-Number: 38883 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[M] Change in libosmo-netif[master]: stream_srv: Add osmo_stream_srv_link_set_{ip_dscp,priority}() APIs
by osmith 22 Nov '24

22 Nov '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38894?usp=email ) Change subject: stream_srv: Add osmo_stream_srv_link_set_{ip_dscp,priority}() APIs ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38894?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Iacb6b72a05055820253eaaa04850637dd2fc20e9 Gerrit-Change-Number: 38894 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 15:23:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-netif[master]: stream_cli: Announce failed connect() if reconnect is disabled
by osmith 22 Nov '24

22 Nov '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38893?usp=email ) Change subject: stream_cli: Announce failed connect() if reconnect is disabled ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38893?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I69a5f7c3c7cea97d31e2fa03e8c32ce806285eb6 Gerrit-Change-Number: 38893 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 15:07:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-netif[master]: stream_cli: Log all code paths ending up in close/reconnect
by osmith 22 Nov '24

22 Nov '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38892?usp=email ) Change subject: stream_cli: Log all code paths ending up in close/reconnect ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38892?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6debc5de193d99919fe858befd905223ef965d81 Gerrit-Change-Number: 38892 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 15:06:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-netif[master]: stream: Improve logging around recv() failure
by osmith 22 Nov '24

22 Nov '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38891?usp=email ) Change subject: stream: Improve logging around recv() failure ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic050e7141b029d984fbbcc76ffc175f8e6b01664 Gerrit-Change-Number: 38891 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 15:04:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: esim.saip: Fix computation of file content
by laforge 22 Nov '24

22 Nov '24

laforge has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/pysim/+/38898?usp=email ) Change subject: esim.saip: Fix computation of file content ...................................................................... esim.saip: Fix computation of file content When generating the file content (body), we need to proceed in the following order: 1a) If FCP contains fillPattern/repeatPattern, compute file content from those 1b) If FCP doesn't contain fillPattern/repeatPattern but template exists, compute file content from template 2) Apply any fillFileConten / fillFileOffset from the SAIP File on top of the above Change-Id: I822bb5fbec11a3be35910a496af7168458fd949c Closes: OS#6642 --- M pySim/esim/saip/__init__.py M pySim/ts_102_222.py 2 files changed, 27 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/98/38898/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38898?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I822bb5fbec11a3be35910a496af7168458fd949c Gerrit-Change-Number: 38898 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder

1 0

[XS] Change in libosmo-netif[master]: stream: Explicitly document MSG_NOTIFICATION case in recv() API
by osmith 22 Nov '24

22 Nov '24

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38890?usp=email ) Change subject: stream: Explicitly document MSG_NOTIFICATION case in recv() API ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I4fa70ae3f704d2379982153b5630009c13a6f316 Gerrit-Change-Number: 38890 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 15:03:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: gsmtap: Increase txqueue max_length from 64 to 1024
by osmith 22 Nov '24

22 Nov '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/38887?usp=email ) Change subject: gsmtap: Increase txqueue max_length from 64 to 1024 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38887?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie737e1d060ea3ee48631604bbae1b8b84cf787b9 Gerrit-Change-Number: 38887 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 15:02:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log