- gerrit-log - lists.osmocom.org

[M] Change in osmo-ci[master]: jobs/osmocom-release-android-apks: new job
by osmith 28 Nov '24

28 Nov '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38974?usp=email ) Change subject: jobs/osmocom-release-android-apks: new job ...................................................................... jobs/osmocom-release-android-apks: new job Add a job similar to the release tarballs job, that iterates over the tags of the android app repositories (currently only android-apdu-proxy) and builds/uploads an apk for each of them. Related: SYS#7197 Change-Id: Iab3472c8bf24a35c5f602b03a29510542e2c3d58 --- M .gitignore A jobs/osmocom-release-android-apks.yml A scripts/android/publish-apks-for-tags.sh 3 files changed, 208 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/74/38974/1 diff --git a/.gitignore b/.gitignore index 5f47674..6e99147 100644 --- a/.gitignore +++ b/.gitignore @@ -13,6 +13,7 @@ _release_tarballs/ _docker_playground _repo_install_test_data/ +_temp_apks/ _temp_manuals/ _temp_releases/ scripts/repo-install-test/run-inside-env.sh diff --git a/jobs/osmocom-release-android-apks.yml b/jobs/osmocom-release-android-apks.yml new file mode 100644 index 0000000..60b94ba --- /dev/null +++ b/jobs/osmocom-release-android-apks.yml @@ -0,0 +1,44 @@ +--- +- job: + name: 'Osmocom-release-android-apks' + node: osmocom-master + project-type: freestyle + defaults: global + description: | + Build and upload Android apks signed with a test key, to be later + re-signed with a proper key (SYS#7197). + properties: + - build-discarder: + days-to-keep: 30 + num-to-keep: 30 + parameters: + - string: + name: BRANCH_OSMO_CI + description: | + osmo-ci.git branch with scripts/android/publish-apks-for-tags.sh + default: 'master' + - string: + name: EMAIL_NOTIFICATIONS + description: For failed build notifications, set to empty to disable + default: 'jenkins-notifications(a)lists.osmocom.org' + builders: + - shell: | + JENKINS=1 scripts/android/publish-apks-for-tags.sh + scm: + - git: + branches: + - '$BRANCH_OSMO_CI' + url: https://gerrit.osmocom.org/osmo-ci + git-config-name: 'Jenkins Builder' + git-config-email: 'jenkins(a)osmocom.org' + wipe-workspace: true + triggers: + - timed: "H 05 * * *" + publishers: + - email: + notify-every-unstable-build: true + recipients: '$EMAIL_NOTIFICATIONS' + wrappers: + - ssh-agent-credentials: + users: + - binaries_ftp.osmocom.org diff --git a/scripts/android/publish-apks-for-tags.sh b/scripts/android/publish-apks-for-tags.sh new file mode 100755 index 0000000..b0ddeed --- /dev/null +++ b/scripts/android/publish-apks-for-tags.sh @@ -0,0 +1,163 @@ +#!/bin/sh -e +# Publish Android apks for tags, signed with a test key (to be re-signed with a +# proper key later on, see SYS#7197). + +. "$(dirname "$0")/../common.sh" +OSMO_CI_DIR="$(realpath $(dirname "$0")/../..)" +TEMP="$OSMO_CI_DIR/_temp_apks" +WEB_PATH="/downloads/home/binaries/web-files/android/.apks_testsig" +SSH_COMMAND="ssh -o UserKnownHostsFile=$OSMO_CI_DIR/contrib/known_hosts -p 48" +DOCKER_IMAGE="$USER/debian-bookworm-android" +LOG_PREFIX="::" + +OSMO_RELEASE_REPOS=" + android-apdu-proxy +" + +if [ "$JENKINS" = 1 ]; then + DOCKER_IMAGE="registry.osmocom.org/$DOCKER_IMAGE" +fi + +mkdir -p \ + "$TEMP" \ + "$TEMP/src" + +check_ssh_auth_sock() { + if [ -z "$SSH_AUTH_SOCK" ]; then + echo "ERROR: SSH_AUTH_SOCK is not set" + exit 1 + fi +} + +# $1: path on server, e.g. "/releases/osmo-bsc" +get_server_ls() { + local dir="$1" + local out="$TEMP/ls$(echo "$dir" | tr / _)" + + echo "$LOG_PREFIX Listing files on server: $dir" + + if [ -e "$out" ]; then + echo "Skipped, file exists: $out" + return + fi + + $SSH_COMMAND binaries(a)ftp.osmocom.org "ls -1 "$WEB_PATH$dir"" >"$out" +} + +# $1: repository +get_git_tags() { + local repo="$1" + local out="$TEMP/git_tags_$repo" + + echo "$LOG_PREFIX Getting git tags" + + if [ -e "$out" ]; then + echo "Skipped, file exists: $out" + return + fi + + osmo_git_last_tags "$repo" "all" >"$out" +} + +# $1: repository +# $2: tag +apk_exists() { + local repo="$1" + local tag="$2" + + grep -q "^$repo-$tag\.apk" "$TEMP"/ls_"$repo" +} + +# $1: repository +# $2: tag +clone_repo() { + local repo="$1" + local tag="$2" + local gitdir="$TEMP/src/$repo" + + if ! [ -d "$gitdir" ]; then + local url="$(osmo_git_clone_url "$repo")" + echo "$LOG_PREFIX Cloning $url" + git -C "$TEMP/src" clone "$url" "$repo" + fi + + echo "$LOG_PREFIX Checkout $tag" + cd "$gitdir" + git reset --hard HEAD + git checkout "$tag" + git submodule update --init + git clean -dxf +} + +build_apk() { + local repo="$1" + local tag="$2" + local gitdir="$TEMP/src/$repo" + + cd "$gitdir" + + echo "$LOG_PREFIX Building $repo-$tag.apk" + + ANDROID_CACHE="$HOME/android-cache/master-builds/android" + GRADLE_CACHE="$HOME/android-cache/master-builds/gradle" + mkdir -p "$ANDROID_CACHE" "$GRADLE_CACHE" + + if [ "$JENKINS" = 1 ]; then + docker pull "$DOCKER_IMAGE" + fi + + docker run --rm=true \ + -e HOME=/build \ + -i \ + -u build \ + -v "$ANDROID_CACHE":/build/.android \ + -v "$GRADLE_CACHE":/build/.gradle \ + -v "$PWD:/build" \ + -w /build \ + "$DOCKER_IMAGE" \ + timeout 60m contrib/jenkins.sh +} + +publish_apk() { + local repo="$1" + local tag="$2" + local apk_path_local="$TEMP/src/$repo/app/build/outputs/apk/release/app-release.apk" + + echo "$LOG_PREFIX Publishing $repo-$tag.apk" + + $SSH_COMMAND binaries(a)ftp.osmocom.org -- mkdir -p "$WEB_PATH/$repo" + rsync \ + -vz \ + -e "$SSH_COMMAND" \ + "$apk_path_local" \ + "binaries@ftp.osmocom.org:$WEB_PATH/$repo/$repo-$tag.apk" +} + +check_ssh_auth_sock +get_server_ls "/" + +for repo in $OSMO_RELEASE_REPOS; do + LOG_PREFIX=":: ($repo)" + + if grep -q "^$repo$" "$TEMP/ls_"; then + get_server_ls "/$repo" + else + echo "$LOG_PREFIX No release directory on server" + touch "$TEMP/ls_$repo" + fi + + get_git_tags "$repo" + + echo "$LOG_PREFIX Building missing apks" + for tag in $(cat "$TEMP"/git_tags_"$repo"); do + LOG_PREFIX=":: ($repo, $tag)" + if apk_exists "$repo" "$tag"; then + echo "$LOG_PREFIX Skipping, apk exists" + continue + fi + + clone_repo "$repo" "$tag" + build_apk "$repo" "$tag" + publish_apk "$repo" "$tag" + done +done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38974?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iab3472c8bf24a35c5f602b03a29510542e2c3d58 Gerrit-Change-Number: 38974 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-cbc[master]: .gitignore: Add install-sh~
by pespin 28 Nov '24

28 Nov '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/38973?usp=email ) Change subject: .gitignore: Add install-sh~ ...................................................................... .gitignore: Add install-sh~ Change-Id: Iad7ce44a2ecd90116376a458cc40f355d3883c53 --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/73/38973/1 diff --git a/.gitignore b/.gitignore index 1872058..5a68e22 100644 --- a/.gitignore +++ b/.gitignore @@ -21,6 +21,7 @@ missing stamp-h1 configure~ +install-sh~ # libtool ltmain.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/38973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Iad7ce44a2ecd90116376a458cc40f355d3883c53 Gerrit-Change-Number: 38973 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-netif[master]: stream: Allow null ptr in destroy() functions
by pespin 28 Nov '24

28 Nov '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38972?usp=email ) Change subject: stream: Allow null ptr in destroy() functions ...................................................................... stream: Allow null ptr in destroy() functions It's common pattern that free/destroy functions allow NULL pointers. Let's accept it here to make life easier for users. Change-Id: I99e23db6617af8261b512efffc62336b63b38516 --- M src/stream_cli.c M src/stream_srv.c 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/72/38972/1 diff --git a/src/stream_cli.c b/src/stream_cli.c index a00f32a..89681b0 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -962,6 +962,9 @@ * \param[in] cli Stream Client to destroy */ void osmo_stream_cli_destroy(struct osmo_stream_cli *cli) { + if (!cli) + return; + LOGSCLI(cli, LOGL_DEBUG, "destroy()\n"); OSMO_ASSERT(!stream_cli_close(cli)); osmo_timer_del(&cli->timer); diff --git a/src/stream_srv.c b/src/stream_srv.c index 4f9323b..c74f7b0 100644 --- a/src/stream_srv.c +++ b/src/stream_srv.c @@ -510,6 +510,8 @@ * \param[in] link Stream Server Link */ void osmo_stream_srv_link_destroy(struct osmo_stream_srv_link *link) { + if (!link) + return; osmo_stream_srv_link_close(link); talloc_free(link); } @@ -1140,6 +1142,9 @@ * \param[in] conn Stream Server to be destroyed */ void osmo_stream_srv_destroy(struct osmo_stream_srv *conn) { + if (!conn) + return; + switch (conn->mode) { case OSMO_STREAM_MODE_OSMO_FD: osmo_fd_unregister(&conn->ofd); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38972?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I99e23db6617af8261b512efffc62336b63b38516 Gerrit-Change-Number: 38972 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libasn1c[master]: debian/control: Build-Depends: add pkg-config
by osmith 28 Nov '24

28 Nov '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libasn1c/+/38970?usp=email ) Change subject: debian/control: Build-Depends: add pkg-config ...................................................................... debian/control: Build-Depends: add pkg-config In Debian Unstable libtalloc-dev 2.4.2-2 does not depend on pkg-config anymore [1]. Since this change libasn1c fails to build with: [ 153s] ./configure: line 12856: syntax error near unexpected token `LIBTALLOC,' [ 153s] ./configure: line 12856: `PKG_CHECK_MODULES(LIBTALLOC, talloc)' Fix it by adding pkg-config to Build-Depends. [1]: https://salsa.debian.org/samba-team/talloc/-/commit/8bebb86a9f0b4487149b0c5… "d/control: drop pkg-config dependency for libtalloc-dev " Change-Id: I5b26c8c81b9e94f1af11294d4fac0194f9a21aa8 --- M debian/control 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/control b/debian/control index 49cac89..d67abb8 100644 --- a/debian/control +++ b/debian/control @@ -6,6 +6,7 @@ Maintainer: Osmocom team <openbsc(a)lists.osmocom.org> Build-Depends: debhelper (>= 10), dh-autoreconf, + pkg-config, libtalloc-dev Standards-Version: 3.9.8 Vcs-Git: git://git.osmocom.org/libasn1c.git -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/38970?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: I5b26c8c81b9e94f1af11294d4fac0194f9a21aa8 Gerrit-Change-Number: 38970 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/ttcn3-ns-test{,-sns}: tweak timer
by pespin 28 Nov '24

28 Nov '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38971?usp=email ) Change subject: jobs/ttcn3-ns-test{,-sns}: tweak timer ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38971?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4f61013661d5de5382c3431650051989200fd785 Gerrit-Change-Number: 38971 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Nov 2024 12:16:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS
by pespin 28 Nov '24

28 Nov '24

Attention is currently required from: dexter, fixeria, laforge. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38957?usp=email ) Change subject: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS ...................................................................... Patch Set 4: Code-Review-1 (1 comment) Patchset: PS4: param still not passed. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38957?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3fbf5430db8b8ea29efb147bd162706990453fc5 Gerrit-Change-Number: 38957 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Nov 2024 12:16:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bts[master]: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS
by pespin 28 Nov '24

28 Nov '24

Attention is currently required from: dexter. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-bts/+/38958?usp=email ) Change subject: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS ...................................................................... Patch Set 2: (1 comment) File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/38958/comment/8793c385_96ceb644?usp… : PS1, Line 947: #define ENSURE_BTS_OBJECT() \ > shouldn't we better have something like this?: […] I prefer having the bts pointer param as an inout param. Otherwise you end up with a ninja assignment to bts pointer without showing up in code... -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38958?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1bb8d0ec5e8d4b9f822f94249a75d8dc477144a3 Gerrit-Change-Number: 38958 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Nov 2024 12:15:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in libasn1c[master]: debian/control: Build-Depends: add pkg-config
by pespin 28 Nov '24

28 Nov '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libasn1c/+/38970?usp=email ) Change subject: debian/control: Build-Depends: add pkg-config ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/38970?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: I5b26c8c81b9e94f1af11294d4fac0194f9a21aa8 Gerrit-Change-Number: 38970 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Nov 2024 12:14:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bts[master]: abis: Log line and ts nr of signal
by pespin 28 Nov '24

28 Nov '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/38966?usp=email ) Change subject: abis: Log line and ts nr of signal ...................................................................... abis: Log line and ts nr of signal Change-Id: I322633a90566dbd4fae10ab6b1fbbedf55907e8b --- M src/common/abis.c 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/common/abis.c b/src/common/abis.c index 5629cf2..3e0f6dc 100644 --- a/src/common/abis.c +++ b/src/common/abis.c @@ -476,8 +476,11 @@ return 0; struct input_signal_data *isd = signal_data; - DEBUGP(DABIS, "Input Signal %s received for link_type=%s\n", - get_value_string(e1inp_signal_names, signal), e1inp_signtype_name(isd->link_type)); + DEBUGP(DABIS, "Input Signal %s received for ts-%u-%u link_type=%s\n", + get_value_string(e1inp_signal_names, signal), + isd->line ? isd->line->num : -1, + isd->ts_nr, + e1inp_signtype_name(isd->link_type)); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38966?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I322633a90566dbd4fae10ab6b1fbbedf55907e8b Gerrit-Change-Number: 38966 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: abis: Fix reusing bts->*_link while it is being destroyed
by pespin 28 Nov '24

28 Nov '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/38967?usp=email ) Change subject: abis: Fix reusing bts->*_link while it is being destroyed ...................................................................... abis: Fix reusing bts->*_link while it is being destroyed Call to e1inp_sign_link_destroy() may trigger a sign_down() callback, which if happening synchronously, could end up reentring the same code path we are in before bts->*_link was set to NULL. Avoid it by marking the pointer as NULL immediatelly before calling e1inp_sign_link_destroy(). Change-Id: Ibc06cdc2d2cd2028b7676fa0c3211ae251cca587 --- M src/common/abis.c 1 file changed, 16 insertions(+), 4 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/common/abis.c b/src/common/abis.c index 3e0f6dc..e619ec8 100644 --- a/src/common/abis.c +++ b/src/common/abis.c @@ -87,10 +87,17 @@ static void reset_oml_link(struct gsm_bts *bts) { + struct e1inp_sign_link *link; + if (bts->oml_link) { struct timespec now; - e1inp_sign_link_destroy(bts->oml_link); + /* Mark bts->oml_link ptr null before calling sign_link_destroy, + * to avoid a callback triggering this same code path. */ + link = bts->oml_link; + bts->oml_link = NULL; + + e1inp_sign_link_destroy(link); /* Log a special notice if the OML connection was dropped relatively quickly. */ if (bts->oml_conn_established_timestamp.tv_sec != 0 && clock_gettime(CLOCK_MONOTONIC, &now) == 0 && @@ -100,14 +107,16 @@ "A common error is a mismatch between unit_id configuration parameters of BTS and BSC.\n", (uint64_t) (now.tv_sec - bts->oml_conn_established_timestamp.tv_sec)); } - bts->oml_link = NULL; } memset(&bts->oml_conn_established_timestamp, 0, sizeof(bts->oml_conn_established_timestamp)); /* Same for IPAC_PROTO_OSMO on the same ipa connection: */ if (bts->osmo_link) { - e1inp_sign_link_destroy(bts->osmo_link); + /* Mark bts->osmo_link ptr null before calling sign_link_destroy, + * to avoid a callback triggering this same code path. */ + link = bts->osmo_link; bts->osmo_link = NULL; + e1inp_sign_link_destroy(link); } } @@ -226,8 +235,11 @@ /* Then iterate over the RSL signalling links */ llist_for_each_entry(trx, &bts->trx_list, list) { if (trx->bb_transc.rsl.link) { - e1inp_sign_link_destroy(trx->bb_transc.rsl.link); + /* Mark link ptr null before calling sign_link_destroy, + * to avoid a callback triggering this same code path. */ + struct e1inp_sign_link *link = trx->bb_transc.rsl.link; trx->bb_transc.rsl.link = NULL; + e1inp_sign_link_destroy(link); if (trx == trx->bts->c0) load_timer_stop(trx->bts); } else { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibc06cdc2d2cd2028b7676fa0c3211ae251cca587 Gerrit-Change-Number: 38967 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log