Attention is currently required from: daniel, fixeria, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38983?usp=email )
Change subject: ipaccess: Convert BSC OML & RSL link to use stream_srv
......................................................................
Patch Set 4:
(3 comments)
File src/input/ipaccess.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/38983/comment/6a6b46f6_679f54b2… :
PS4, Line 387: ballback
callback
https://gerrit.osmocom.org/c/libosmo-abis/+/38983/comment/a8b77763_b34c999c… :
PS4, Line 470: default:
maybe put a log msg here?
https://gerrit.osmocom.org/c/libosmo-abis/+/38983/comment/62ef51f2_327840c9… :
PS4, Line 705: /* PESPIN: TODO: use osmo_stream_srv_send() instead */
did you leave this TODO intentionally?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38983?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Idf241c8f2fdb86d090d4132a9b316b7236402232
Gerrit-Change-Number: 38983
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Dec 2024 10:32:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/38999?usp=email )
Change subject: debian: prepare for more subpackages
......................................................................
debian: prepare for more subpackages
Prepare to add these subpackages in follow-up patches:
* osmocom-bb-trx-toolkit
* osmocom-bb-trxcon
* osmocom-bb-virtphy
We need these components to run some of the ttnc3 testsuites. By having
them packaged, we can just install them from the binary repositories
along with the SUT.
trxcon and virtphy are autootols based, so rework debian/rules to
support building multiple autotools projects.
Related: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851/1..2//COMMIT_MSG#b9
Change-Id: I77ad988f5405e6fa9e585eeb646e513ac7d92485
---
M debian/rules
1 file changed, 21 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/debian/rules b/debian/rules
index 8dd0df8..df0520e 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,7 +1,26 @@
#!/usr/bin/make -f
+DH_ARGS := -D src/host/$$SUBPKG_DIR --with-autoreconf
%:
- dh $@ -D src/host/layer23 --with-autoreconf
+ export SUBPKG=layer23; \
+ export SUBPKG_DIR=layer23; \
+ export SUBPKG_CFG=--with-gapk-io; \
+ dh $@ $(DH_ARGS)
+
+# We need to run autoreconf multiple times, but dh_autoreconf can only run once
+# (see dh-autoreconf(7)). Run autoreconf directly to work around this.
+override_dh_autoreconf:
+ cd src/host/$$SUBPKG_DIR && autoreconf -fi
override_dh_auto_configure:
- dh_auto_configure -D src/host/layer23 -- --with-gapk-io
+ dh_auto_configure -D src/host/$$SUBPKG_DIR -- $$SUBPKG_CFG
+
+override_dh_auto_install:
+ dh_auto_install -O-Dsrc/host/$$SUBPKG_DIR --destdir=debian/osmocom-bb-$$SUBPKG/
+
+# Run dh_prep only for the first subpackage. Otherwise previously built
+# binaries get removed and we end up with empty packages.
+override_dh_prep:
+ if [ "$$SUBPKG" = "layer23" ]; then \
+ dh_prep; \
+ fi
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/38999?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I77ad988f5405e6fa9e585eeb646e513ac7d92485
Gerrit-Change-Number: 38999
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39001?usp=email )
Change subject: debian: add subpackage osmocom-bb-virtphy
......................................................................
debian: add subpackage osmocom-bb-virtphy
I've decided to name the package osmocom-bb-virtphy so there is no
underscore in it (would look weird in addition to the minus character)
and because it matches the name of the binary "virtphy".
Change-Id: I09d98aba81ab6c76ad46aae36e7369114cef7dd7
---
M debian/control
M debian/rules
2 files changed, 10 insertions(+), 0 deletions(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/debian/control b/debian/control
index fbcda98..7c5306c 100644
--- a/debian/control
+++ b/debian/control
@@ -33,3 +33,9 @@
Multi-Arch: foreign
Depends: ${misc:Depends}, ${shlibs:Depends}
Description: OsmocomBB <-> SDR connection bridge
+
+Package: osmocom-bb-virtphy
+Architecture: any
+Multi-Arch: foreign
+Depends: ${misc:Depends}, ${shlibs:Depends}
+Description: Osmocom virtual physical layer
diff --git a/debian/rules b/debian/rules
index c3f71ad..e4f5cb0 100755
--- a/debian/rules
+++ b/debian/rules
@@ -11,6 +11,10 @@
export SUBPKG_DIR=trxcon; \
dh $@ $(DH_ARGS)
+ export SUBPKG=virtphy; \
+ export SUBPKG_DIR=virt_phy; \
+ dh $@ $(DH_ARGS)
+
# We need to run autoreconf multiple times, but dh_autoreconf can only run once
# (see dh-autoreconf(7)). Run autoreconf directly to work around this.
override_dh_autoreconf:
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39001?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I09d98aba81ab6c76ad46aae36e7369114cef7dd7
Gerrit-Change-Number: 39001
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>