- gerrit-log - lists.osmocom.org

[L] Change in osmo-msc[master]: Use gsup_client_mux from libosmo-gsup-client
by pespin 03 Dec '24

03 Dec '24

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-msc/+/39019?usp=email ) Change subject: Use gsup_client_mux from libosmo-gsup-client ...................................................................... Use gsup_client_mux from libosmo-gsup-client gsup_client_mux code was cloned a couple months ago to libosmo-gsup-client, use it in osmo-msc and drop its own copy. The code was not dropped at the time because it required tweaking the unit tests, because they were wrapping some underlaying functions which cannot be wrapped anymore since the code using them is now inside the separate already-linked libosmo-gsup-client.so. Solve it by actually wrapping one layer up in the gsup_client_mux itself since it now something we mantain here anymore. Change-Id: I34d02ae219f3ec8daf47942c46f52b21eab21242 --- M TODO-RELEASE M include/osmocom/msc/Makefile.am D include/osmocom/msc/gsup_client_mux.h M src/libmsc/Makefile.am M src/libmsc/e_link.c M src/libmsc/gsm_04_11_gsup.c M src/libmsc/gsm_09_11.c D src/libmsc/gsup_client_mux.c M src/libmsc/msc_net_init.c M src/libvlr/vlr.c M src/osmo-msc/msc_main.c M tests/msc_vlr/Makefile.am M tests/msc_vlr/msc_vlr_tests.c 13 files changed, 47 insertions(+), 249 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/19/39019/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I34d02ae219f3ec8daf47942c46f52b21eab21242 Gerrit-Change-Number: 39019 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[S] Change in osmo-msc[master]: vty: Avoid accessing gsupclient object fields directly
by pespin 03 Dec '24

03 Dec '24

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/39008?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: vty: Avoid accessing gsupclient object fields directly ...................................................................... vty: Avoid accessing gsupclient object fields directly Use new APIs recently added. Change-Id: I7ead95bb86d1ab510090c29390255007923f895f Depends: osmo-hlr.git Change-Id I401af83232022f1c141eef1f428cbe206a8aaaa2 --- M src/libmsc/e_link.c 1 file changed, 7 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/08/39008/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7ead95bb86d1ab510090c29390255007923f895f Gerrit-Change-Number: 39008 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-msc[master]: Usse gsup_client_mux from libosmo-gsup-client
by pespin 03 Dec '24

03 Dec '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/39019?usp=email ) Change subject: Usse gsup_client_mux from libosmo-gsup-client ...................................................................... Usse gsup_client_mux from libosmo-gsup-client gsup_client_mux code was cloned a couple months ago to libosmo-gsup-client, use it in osmo-msc and drop its own copy. The code was not dropped at the time because it required tweaking the unit tests, because they were wrapping some underlaying functions which cannot be wrapped anymore since the code using them is now inside the separate already-linked libosmo-gsup-client.so. Solve it by actually wrapping one layer up in the gsup_client_mux itself since it now something we mantain here anymore. Change-Id: I34d02ae219f3ec8daf47942c46f52b21eab21242 --- M TODO-RELEASE M include/osmocom/msc/Makefile.am D include/osmocom/msc/gsup_client_mux.h M src/libmsc/Makefile.am M src/libmsc/e_link.c M src/libmsc/gsm_04_11_gsup.c M src/libmsc/gsm_09_11.c D src/libmsc/gsup_client_mux.c M src/libmsc/msc_net_init.c M src/libvlr/vlr.c M src/osmo-msc/msc_main.c M tests/msc_vlr/Makefile.am M tests/msc_vlr/msc_vlr_tests.c 13 files changed, 47 insertions(+), 249 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/19/39019/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 35467f3..f351fab 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,3 +8,4 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line libosmo-sigtran >2.0.1 osmo_ss7_instance_get_id(), osmo_ss7_instance_get_name(), osmo_ss7_instance_get_pc_fmt(), osmo_ss7_instance_get_primary_pc() +libosmo-gsuo-client >1.8.0 gsup_client_mux.h \ No newline at end of file diff --git a/include/osmocom/msc/Makefile.am b/include/osmocom/msc/Makefile.am index b6901b9..61ed586 100644 --- a/include/osmocom/msc/Makefile.am +++ b/include/osmocom/msc/Makefile.am @@ -17,7 +17,6 @@ gsm_data.h \ gsm_data_shared.h \ gsm_subscriber.h \ - gsup_client_mux.h \ mncc.h \ mncc_call.h \ mncc_int.h \ diff --git a/include/osmocom/msc/gsup_client_mux.h b/include/osmocom/msc/gsup_client_mux.h deleted file mode 100644 index f327786..0000000 --- a/include/osmocom/msc/gsup_client_mux.h +++ /dev/null @@ -1,34 +0,0 @@ -#pragma once - -#include <osmocom/gsm/gsup.h> - -struct gsup_client_mux; -struct ipaccess_unit; - -struct gsup_client_mux_rx_cb { - int (* func )(struct gsup_client_mux *gcm, void *data, const struct osmo_gsup_message *gsup_msg); - void *data; -}; - -/* A GSUP client shared between code paths for various GSUP Message Classes. - * The main task is to dispatch GSUP messages to code paths corresponding to the respective Message Class, i.e. - * subscriber management, SMS, SS/USSD and inter-MSC messaging. - * If a GSUP Message Class IE is present in the message, the received message is dispatched directly to the rx_cb entry - * for that Message Class. Otherwise, the Message Class is determined by a switch() on the Message Type.*/ -struct gsup_client_mux { - struct osmo_gsup_client *gsup_client; - - /* Target clients by enum osmo_gsup_message_class */ - struct gsup_client_mux_rx_cb rx_cb[OSMO_GSUP_MESSAGE_CLASS_ARRAYSIZE]; -}; - -struct gsup_client_mux *gsup_client_mux_alloc(void *talloc_ctx); -int gsup_client_mux_start(struct gsup_client_mux *gcm, const char *gsup_server_addr_str, uint16_t gsup_server_port, - struct ipaccess_unit *ipa_dev); - -int gsup_client_mux_tx(struct gsup_client_mux *gcm, const struct osmo_gsup_message *gsup_msg); -void gsup_client_mux_tx_set_source(const struct gsup_client_mux *gcm, struct osmo_gsup_message *gsup_msg); -void gsup_client_mux_tx_error_reply(struct gsup_client_mux *gcm, const struct osmo_gsup_message *gsup_orig, - enum gsm48_gmm_cause cause); - -int gsup_client_mux_rx(struct osmo_gsup_client *gsup_client, struct msgb *msg); diff --git a/src/libmsc/Makefile.am b/src/libmsc/Makefile.am index 3cda322..22543cb 100644 --- a/src/libmsc/Makefile.am +++ b/src/libmsc/Makefile.am @@ -41,7 +41,6 @@ gsm_04_14.c \ gsm_04_80.c \ gsm_09_11.c \ - gsup_client_mux.c \ mncc.c \ mncc_builtin.c \ mncc_sock.c \ diff --git a/src/libmsc/e_link.c b/src/libmsc/e_link.c index 5107c22..4b61ec7 100644 --- a/src/libmsc/e_link.c +++ b/src/libmsc/e_link.c @@ -25,7 +25,7 @@ #include <osmocom/gsupclient/gsup_client.h> #include <osmocom/msc/gsm_data.h> -#include <osmocom/msc/gsup_client_mux.h> +#include <osmocom/gsupclient/gsup_client_mux.h> #include <osmocom/msc/e_link.h> #include <osmocom/msc/msub.h> #include <osmocom/msc/msc_roles.h> diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c index 3566e76..96fdbc6 100644 --- a/src/libmsc/gsm_04_11_gsup.c +++ b/src/libmsc/gsm_04_11_gsup.c @@ -32,7 +32,7 @@ #include <osmocom/msc/debug.h> #include <osmocom/vlr/vlr.h> #include <osmocom/msc/msub.h> -#include <osmocom/msc/gsup_client_mux.h> +#include <osmocom/gsupclient/gsup_client_mux.h> #include <osmocom/msc/msc_a.h> /* Common helper for preparing to be encoded GSUP message */ diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c index 86b4a4f..0b85cbd 100644 --- a/src/libmsc/gsm_09_11.c +++ b/src/libmsc/gsm_09_11.c @@ -50,7 +50,7 @@ #include <osmocom/msc/msc_a.h> #include <osmocom/msc/msub.h> #include <osmocom/msc/paging.h> -#include <osmocom/msc/gsup_client_mux.h> +#include <osmocom/gsupclient/gsup_client_mux.h> /* FIXME: choose a proper range */ static uint32_t new_callref = 0x20000001; diff --git a/src/libmsc/gsup_client_mux.c b/src/libmsc/gsup_client_mux.c deleted file mode 100644 index e27b664..0000000 --- a/src/libmsc/gsup_client_mux.c +++ /dev/null @@ -1,191 +0,0 @@ -/* Directing individual GSUP messages to their respective handlers. */ -/* - * (C) 2019 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> - * All Rights Reserved - * - * Author: Neels Hofmeyr - * - * SPDX-License-Identifier: AGPL-3.0+ - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation; either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Affero General Public License for more details. - */ -#include <errno.h> - -#include <osmocom/gsupclient/gsup_client.h> - -#include <osmocom/msc/debug.h> -#include <osmocom/msc/gsup_client_mux.h> - -static enum osmo_gsup_message_class gsup_client_mux_classify(struct gsup_client_mux *gcm, - const struct osmo_gsup_message *gsup_msg) -{ - if (gsup_msg->message_class) - return gsup_msg->message_class; - - LOGP(DLGSUP, LOGL_DEBUG, "No explicit GSUP Message Class, trying to guess from message type %s\n", - osmo_gsup_message_type_name(gsup_msg->message_type)); - - switch (gsup_msg->message_type) { - case OSMO_GSUP_MSGT_PROC_SS_REQUEST: - case OSMO_GSUP_MSGT_PROC_SS_RESULT: - case OSMO_GSUP_MSGT_PROC_SS_ERROR: - return OSMO_GSUP_MESSAGE_CLASS_USSD; - - /* GSM 04.11 code implementing MO SMS */ - case OSMO_GSUP_MSGT_MO_FORWARD_SM_ERROR: - case OSMO_GSUP_MSGT_MO_FORWARD_SM_RESULT: - case OSMO_GSUP_MSGT_READY_FOR_SM_ERROR: - case OSMO_GSUP_MSGT_READY_FOR_SM_RESULT: - case OSMO_GSUP_MSGT_MT_FORWARD_SM_REQUEST: - return OSMO_GSUP_MESSAGE_CLASS_SMS; - - default: - return OSMO_GSUP_MESSAGE_CLASS_SUBSCRIBER_MANAGEMENT; - } -} - -/* Non-static for unit tests */ -int gsup_client_mux_rx(struct osmo_gsup_client *gsup_client, struct msgb *msg) -{ - struct gsup_client_mux *gcm = gsup_client->data; - struct osmo_gsup_message gsup; - enum osmo_gsup_message_class message_class; - int rc; - - rc = osmo_gsup_decode(msgb_l2(msg), msgb_l2len(msg), &gsup); - if (rc < 0) { - LOGP(DLGSUP, LOGL_ERROR, "Failed to decode GSUP message: '%s' (%d) [ %s]\n", - get_value_string(gsm48_gmm_cause_names, -rc), -rc, osmo_hexdump(msg->data, msg->len)); - goto msgb_free_and_return; - } - - if (!gsup.imsi[0]) { - LOGP(DLGSUP, LOGL_ERROR, "Failed to decode GSUP message: missing IMSI\n"); - if (OSMO_GSUP_IS_MSGT_REQUEST(gsup.message_type)) - gsup_client_mux_tx_error_reply(gcm, &gsup, GMM_CAUSE_INV_MAND_INFO); - rc = -GMM_CAUSE_INV_MAND_INFO; - goto msgb_free_and_return; - } - - message_class = gsup_client_mux_classify(gcm, &gsup); - - if (message_class <= OSMO_GSUP_MESSAGE_CLASS_UNSET || message_class >= ARRAY_SIZE(gcm->rx_cb)) { - LOGP(DLGSUP, LOGL_ERROR, "Failed to classify GSUP message target\n"); - rc = -EINVAL; - goto msgb_free_and_return; - } - - if (!gcm->rx_cb[message_class].func) { - LOGP(DLGSUP, LOGL_ERROR, "No receiver set up for GSUP Message Class %s\n", osmo_gsup_message_class_name(message_class)); - rc = -ENOTSUP; - goto msgb_free_and_return; - } - - rc = gcm->rx_cb[message_class].func(gcm, gcm->rx_cb[message_class].data, &gsup); - -msgb_free_and_return: - msgb_free(msg); - return rc; -} - -/* Make it clear that struct gsup_client_mux should be talloc allocated, so that it can be used as talloc parent. */ -struct gsup_client_mux *gsup_client_mux_alloc(void *talloc_ctx) -{ - return talloc_zero(talloc_ctx, struct gsup_client_mux); -} - -/* Start a GSUP client to serve this gsup_client_mux. */ -int gsup_client_mux_start(struct gsup_client_mux *gcm, const char *gsup_server_addr_str, uint16_t gsup_server_port, - struct ipaccess_unit *ipa_dev) -{ - gcm->gsup_client = osmo_gsup_client_create2(gcm, ipa_dev, - gsup_server_addr_str, - gsup_server_port, - &gsup_client_mux_rx, NULL); - if (!gcm->gsup_client) - return -ENOMEM; - gcm->gsup_client->data = gcm; - return 0; -} - -int gsup_client_mux_tx(struct gsup_client_mux *gcm, const struct osmo_gsup_message *gsup_msg) -{ - struct msgb *msg; - int rc; - - if (!gcm || !gcm->gsup_client) { - LOGP(DLGSUP, LOGL_ERROR, "GSUP link is down, cannot send GSUP message\n"); - return -ENOTSUP; - } - - msg = osmo_gsup_client_msgb_alloc(); - rc = osmo_gsup_encode(msg, gsup_msg); - if (rc < 0) { - LOGP(DLGSUP, LOGL_ERROR, "Failed to encode GSUP message: '%s'\n", strerror(-rc)); - return rc; - } - - return osmo_gsup_client_send(gcm->gsup_client, msg); -} - -/* Set GSUP source_name to our local IPA name */ -void gsup_client_mux_tx_set_source(const struct gsup_client_mux *gcm, - struct osmo_gsup_message *gsup_msg) -{ - const char *local_msc_name; - - if (!gcm) - return; - if (!gcm->gsup_client) - return; - if (!gcm->gsup_client->ipa_dev) - return; - local_msc_name = gcm->gsup_client->ipa_dev->serno; - if (!local_msc_name) - return; - gsup_msg->source_name = (const uint8_t *) local_msc_name; - gsup_msg->source_name_len = strlen(local_msc_name) + 1; -} - -/* Transmit GSUP error in response to original message */ -void gsup_client_mux_tx_error_reply(struct gsup_client_mux *gcm, const struct osmo_gsup_message *gsup_orig, - enum gsm48_gmm_cause cause) -{ - struct osmo_gsup_message gsup_reply; - - /* No need to answer if we couldn't parse an ERROR message type, only REQUESTs need an error reply. */ - if (!OSMO_GSUP_IS_MSGT_REQUEST(gsup_orig->message_type)) - return; - - gsup_reply = (struct osmo_gsup_message){ - .cause = cause, - .message_type = OSMO_GSUP_TO_MSGT_ERROR(gsup_orig->message_type), - .message_class = gsup_orig->message_class, - .destination_name = gsup_orig->source_name, - .destination_name_len = gsup_orig->source_name_len, - - /* RP-Message-Reference is mandatory for SM Service */ - .sm_rp_mr = gsup_orig->sm_rp_mr, - }; - - OSMO_STRLCPY_ARRAY(gsup_reply.imsi, gsup_orig->imsi); - gsup_client_mux_tx_set_source(gcm, &gsup_reply); - - /* For SS/USSD, it's important to keep both session state and ID IEs */ - if (gsup_orig->session_state != OSMO_GSUP_SESSION_STATE_NONE) { - gsup_reply.session_state = OSMO_GSUP_SESSION_STATE_END; - gsup_reply.session_id = gsup_orig->session_id; - } - - if (osmo_gsup_client_enc_send(gcm->gsup_client, &gsup_reply)) - LOGP(DLGSUP, LOGL_ERROR, "Failed to send Error reply (imsi=%s)\n", - osmo_quote_str(gsup_orig->imsi, -1)); -} diff --git a/src/libmsc/msc_net_init.c b/src/libmsc/msc_net_init.c index 5f10e6c..8edca05 100644 --- a/src/libmsc/msc_net_init.c +++ b/src/libmsc/msc_net_init.c @@ -29,7 +29,7 @@ #include <osmocom/msc/gsm_data.h> #include <osmocom/vlr/vlr.h> #include <osmocom/msc/debug.h> -#include <osmocom/msc/gsup_client_mux.h> +#include <osmocom/gsupclient/gsup_client_mux.h> #include <osmocom/msc/gsm_04_11_gsup.h> #include <osmocom/msc/gsm_09_11.h> diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index 8a1dee5..32c2fbb 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -34,7 +34,7 @@ #include <osmocom/gsupclient/gsup_client.h> #include <osmocom/vlr/vlr_sgs.h> #include <osmocom/vlr/vlr.h> -#include <osmocom/msc/gsup_client_mux.h> +#include <osmocom/gsupclient/gsup_client_mux.h> #include <osmocom/msc/paging.h> #include <netinet/in.h> diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c index 5e99b4d..2238e2b 100644 --- a/src/osmo-msc/msc_main.c +++ b/src/osmo-msc/msc_main.c @@ -71,7 +71,7 @@ #include <osmocom/msc/msub.h> #include <osmocom/msc/call_leg.h> #include <osmocom/msc/msc_ho.h> -#include <osmocom/msc/gsup_client_mux.h> +#include <osmocom/gsupclient/gsup_client_mux.h> #include <osmocom/msc/e_link.h> #include <osmocom/msc/mncc_call.h> diff --git a/tests/msc_vlr/Makefile.am b/tests/msc_vlr/Makefile.am index cbdd6a4..1e332ef 100644 --- a/tests/msc_vlr/Makefile.am +++ b/tests/msc_vlr/Makefile.am @@ -20,8 +20,8 @@ $(NULL) AM_LDFLAGS = \ - -Wl,--wrap=osmo_gsup_client_create2 \ - -Wl,--wrap=osmo_gsup_client_send \ + -Wl,--wrap=gsup_client_mux_start \ + -Wl,--wrap=gsup_client_mux_tx \ -Wl,--wrap=gsm340_gen_scts \ -Wl,--wrap=osmo_get_rand_id \ -Wl,--wrap=ran_peers_down_paging \ diff --git a/tests/msc_vlr/msc_vlr_tests.c b/tests/msc_vlr/msc_vlr_tests.c index c1ae650..6c15b71 100644 --- a/tests/msc_vlr/msc_vlr_tests.c +++ b/tests/msc_vlr/msc_vlr_tests.c @@ -30,7 +30,7 @@ #include <osmocom/core/application.h> #include <osmocom/gsm/protocol/gsm_04_11.h> #include <osmocom/gsm/gsup.h> -#include <osmocom/msc/gsup_client_mux.h> +#include <osmocom/gsupclient/gsup_client_mux.h> #include <osmocom/msc/gsm_04_11.h> #include <osmocom/msc/debug.h> #include <osmocom/msc/gsm_04_08.h> @@ -136,6 +136,26 @@ gsm48_hdr_msg_type(gh)); } +static int _gsup_client_mux_rx(struct gsup_client_mux *gcm, struct msgb *msg) +{ + struct osmo_gsup_message gsup; + int rc; + + rc = osmo_gsup_decode(msgb_l2(msg), msgb_l2len(msg), &gsup); + if (rc < 0) { + LOGP(DLGSUP, LOGL_ERROR, "Failed to decode GSUP message: '%s' (%d) [ %s]\n", + get_value_string(gsm48_gmm_cause_names, -rc), -rc, osmo_hexdump(msg->data, msg->len)); + goto msgb_free_and_return; + } + + OSMO_ASSERT(gcm->rx_cb[gsup.message_class].func); + rc = gcm->rx_cb[gsup.message_class].func(gcm, gcm->rx_cb[gsup.message_class].data, &gsup); + +msgb_free_and_return: + msgb_free(msg); + return rc; +} + void gsup_rx(const char *rx_hex, const char *expect_tx_hex) { int rc; @@ -149,7 +169,7 @@ fprintf(stderr, "<-- GSUP rx %s: %s\n", label, osmo_hexdump_nospc(msgb_l2(msg), msgb_l2len(msg))); /* GSUP read cb takes ownership of msgb */ - rc = gsup_client_mux_rx(net->gcm->gsup_client, msg); + rc = _gsup_client_mux_rx(net->gcm, msg); fprintf(stderr, "<-- GSUP rx %s: vlr_gsupc_read_cb() returns %d\n", label, rc); if (expect_tx_hex) @@ -811,26 +831,30 @@ } struct osmo_gsup_client * -__real_osmo_gsup_client_create2(struct ipaccess_unit *ipa_dev, const char *ip_addr, - unsigned int tcp_port, osmo_gsup_client_read_cb_t read_cb, - struct osmo_oap_client_config *oap_config); +__real_gsup_client_mux_start(struct gsup_client_mux *gcm, const char *gsup_server_addr_str, uint16_t gsup_server_port, + struct ipaccess_unit *ipa_dev); struct osmo_gsup_client * -__wrap_osmo_gsup_client_create2(struct ipaccess_unit *ipa_dev, const char *ip_addr, - unsigned int tcp_port, osmo_gsup_client_read_cb_t read_cb, - struct osmo_oap_client_config *oap_config) +__wrap_gsup_client_mux_start(struct gsup_client_mux *gcm, const char *gsup_server_addr_str, uint16_t gsup_server_port, + struct ipaccess_unit *ipa_dev) { - struct osmo_gsup_client *gsupc; - gsupc = talloc_zero(msc_vlr_tests_ctx, struct osmo_gsup_client); - OSMO_ASSERT(gsupc); - return gsupc; + return 0; } /* override, requires '-Wl,--wrap=gsup_client_send' */ -int __real_osmo_gsup_client_send(struct osmo_gsup_client *gsupc, struct msgb *msg); -int __wrap_osmo_gsup_client_send(struct osmo_gsup_client *gsupc, struct msgb *msg) +int __real_gsup_client_mux_tx(struct gsup_client_mux *gcm, const struct osmo_gsup_message *gsup_msg); +int __wrap_gsup_client_mux_tx(struct gsup_client_mux *gcm, const struct osmo_gsup_message *gsup_msg) { uint8_t buf[512]; int len; + struct msgb *msg; + int rc; + + msg = osmo_gsup_client_msgb_alloc(); + rc = osmo_gsup_encode(msg, gsup_msg); + if (rc < 0) { + fprintf(stderr, "Failed to encode GSUP message: '%s'\n", strerror(-rc)); + return rc; + } fprintf(stderr, "GSUP --> HLR: %s: %s\n", osmo_gsup_message_type_name(msg->data[0]), osmo_hexdump_nospc(msg->data, msg->len)); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I34d02ae219f3ec8daf47942c46f52b21eab21242 Gerrit-Change-Number: 39019 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ggsn[master]: gtp: Rework gtp_resp() into gtp_resp_pdp()
by lynxis lazus 03 Dec '24

03 Dec '24

Attention is currently required from: laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38933?usp=email ) Change subject: gtp: Rework gtp_resp() into gtp_resp_pdp() ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38933?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Id9ff95e0e2a10a22e65ecf42b2a2b06a0f2d1a45 Gerrit-Change-Number: 38933 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 03 Dec 2024 16:45:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ggsn[master]: gtp_new(): use talloc instead of calloc/free
by lynxis lazus 03 Dec '24

03 Dec '24

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: gtp_new(): use talloc instead of calloc/free ...................................................................... gtp_new(): use talloc instead of calloc/free Required for SGSN Context Req fsm which is using talloc. Adds a new api to set the global gsn talloc context via gtp_set_talloc_ctx() Change-Id: I7c4a29c4bb1ef3c7bf506e59e99b3a804cabe34b --- M gtp/gsn.c M gtp/gsn_internal.h M include/osmocom/gtp/gsn.h 3 files changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/30/38930/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I7c4a29c4bb1ef3c7bf506e59e99b3a804cabe34b Gerrit-Change-Number: 38930 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ggsn[master]: gtp_new(): use talloc instead of calloc/free
by lynxis lazus 03 Dec '24

03 Dec '24

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email ) Change subject: gtp_new(): use talloc instead of calloc/free ...................................................................... Patch Set 3: (1 comment) File gtp/gsn.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/38930/comment/57ddbabb_29ae4c69?us… : PS3, Line 590: static __attribute__((constructor)) void gtp_talloc_init(void) > So that the app can pin this talloc subtree as part of its talloc tree. […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I7c4a29c4bb1ef3c7bf506e59e99b3a804cabe34b Gerrit-Change-Number: 38930 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Dec 2024 16:21:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: WIP: SGSN_Tests: f_TC_sgsn_context_req_out()
by lynxis lazus 03 Dec '24

03 Dec '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email ) Change subject: WIP: SGSN_Tests: f_TC_sgsn_context_req_out() ...................................................................... WIP: SGSN_Tests: f_TC_sgsn_context_req_out() Doesnt compile - missing GUTI Change-Id: I0666a518aed57c2594653ab6b0f801c4193fd2f3 --- M sgsn/SGSN_Tests.ttcn M sgsn/gen_links.sh 2 files changed, 140 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/39017/1 diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index c6c2c0a..d9f4bce 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -62,6 +62,12 @@ import from MobileL3_MM_Types all; import from BSSGP_ConnHdlr all; +//import from NAS_EPS_Types { +// type GUTI +//}; + +import from NAS_EPS_Types all; +import from NAS_Templates all; modulepar { /* IP/port on which we run our internal GSUP/HLR emulation */ @@ -1687,7 +1693,7 @@ /* Attempt an attach, but loose the Identification Request (IMEI) */ private function f_TC_attach_no_imei_response(charstring id) runs on BSSGP_ConnHdlr { var integer count_req := 0; - var MobileIdentityLV mi; + var MobileL3_CommonIE_Types.MobileIdentityLV mi; f_send_l3(ts_GMM_ATTACH_REQ(f_mi_get_lv(), f_random_RAI(), true, false, omit, omit)); @@ -1733,7 +1739,7 @@ /* Attempt an attach, but loose the Identification Request (IMSI) */ private function f_TC_attach_no_imsi_response(charstring id) runs on BSSGP_ConnHdlr { var integer count_req := 0; - var MobileIdentityLV mi; + var MobileL3_CommonIE_Types.MobileIdentityLV mi; /* set p_tmsi to use it in Attach Req via f_mi_get_lv() */ g_pars.p_tmsi := 'c0000035'O; @@ -2017,7 +2023,7 @@ private function f_TC_attach_gmm_attach_req_while_gmm_attach(charstring id) runs on BSSGP_ConnHdlr { var integer count_req := 0; - var MobileIdentityLV mi; + var MobileL3_CommonIE_Types.MobileIdentityLV mi; var RoutingAreaIdentificationV rand_rai := f_random_RAI(); var PDU_L3_SGSN_MS l3_mt; @@ -3104,24 +3110,98 @@ f_cleanup(); } +/* 3GPP TS 23.401 D.3.5, TS 23.003 2.8.2.1 */ +function guti2rai_ptmsi(in NAS_EPS_Types.GUTI guti, in OCT2 truncated_nas_token, out RoutingAreaIdentificationV rai, out OCT4 ptmsi, out OCT3 ptmsi_sig) { + var bitstring mtmsi_bits := oct2bit(guti.mTMSI); + var bitstring ptmsi_bits; + var bitstring ptmsi_sig_bits; + + rai := { + mccDigit1 := guti.mccDigit1, + mccDigit2 := guti.mccDigit2, + mccDigit3 := guti.mccDigit3, + mncDigit3 := guti.mncDigit3, + mncDigit1 := guti.mncDigit1, + mncDigit2 := guti.mncDigit2, + lac := guti.mMEGI, + rac := guti.mMEC + }; + /* 3GPP TS 23.003 2.8.2.0: "P-TMSI shall be of 32 bits length where the two topmost bits are + * reserved and always set to '11'. Hence, for a UE which may handover to GERAN/UTRAN (based on + * subscription and UE capabilities), the corresponding bits in the M-TMSI are set to '11'" + */ + ptmsi_bits := '11'B & substr(mtmsi_bits, 2, 6) & oct2bit(guti.mMEC) & substr(mtmsi_bits, 16, 16); + ptmsi_sig_bits := substr(mtmsi_bits, 8, 8) & oct2bit(truncated_nas_token); + ptmsi := bit2oct(ptmsi_bits); + ptmsi_sig := bit2oct(ptmsi_sig_bits); + /* TODO: The UE shall fill the remaining 2 octets of the <P-TMSI signature> according to clauses 9.1.1, 9.4.1, 10.2.1, or + * 10.5.1 of 3GPP TS.33.401 [89] , as appropriate, for RAU/Attach procedures.*/ +} + +function rai_to_oct(in RoutingAreaIdentity rai) return OCT6 { + var OCT6 ret; + ret := hex2oct(rai.mcc_digits[1] & rai.mcc_digits[0]) & + hex2oct(rai.mnc_digits[2] & rai.mcc_digits[2]) & + hex2oct(rai.mnc_digits[1] & rai.mnc_digits[0]) & + rai.lac & rai.rac; + return ret; +} + /* SGSN originated SGSN Context Request procedure (SGSN requests, we respond) * 3GPP TS 23.401, Figure D.3.5-1 "Routing Area Update procedure" */ private function f_TC_sgsn_context_req_out(charstring id) runs on BSSGP_ConnHdlr { var integer seq_nr := f_rnd_int(65535); var Gtp1cUnitdata gtpc_ud; - var OCT4 teidc := f_gtp_teid_random(); + /* Used by SGSN Ctx Req/Resp/Ack */ + var OCT4 ctx_teidc := f_gtp_teid_random(); + /* Used for the UE which is transmited via Ctx Response */ + var OCT4 pdp_teidc := f_gtp_teid_random(); timer T; + var RoutingAreaIdentificationV rai; + var P_TMSI_TypeTV p_tmsi_type; + var OCT3 p_tmsi_sig; + var OCT4 add_p_tmsi; + var OCT6 add_rai_oct; + var RoutingAreaIdentificationV add_rai; + var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip)); + var Gtp1cPeer peer := { + connId := 1, + remName := mp_sgsn_gtp_ip, + remPort := GTP1C_PORT + } + g_pars.vec := f_gen_auth_vec_3g(); + + /* SGSN Context Req doesn't necessarily contain IMSI, hence expect it through TEID=0 */ + f_gtp_register_teid('00000000'O); + f_gtp_register_teid(ctx_teidc); + f_gtp_register_teid(pdp_teidc); + + g_pars.ra := f_random_RAI(); + var NAS_EPS_Types.GUTI guti := valueof(ts_NAS_GUTI( + mcc_mnc := g_pars.ra.mccDigit1 & g_pars.ra.mccDigit2 & g_pars.ra.mccDigit3 & + g_pars.ra.mncDigit3 & g_pars.ra.mncDigit1 & g_pars.ra.mncDigit2, + mmegi := '000c'O, + mmec := '06'O, + tmsi := '12345678'O)); + + guti2rai_ptmsi(guti, '8888'O, add_rai, add_p_tmsi, p_tmsi_sig); + + // add_rai_oct := rai_to_oct(add_rai); /* The MS goes to GERAN/UTRAN from an LTE cell */ - f_send_l3(ts_GMM_RAU_REQ(mi_lv := valueof(ts_MI_TMSI_LV('DE42DE42'O)), + f_send_l3(ts_GMM_RAU_REQ(mi_lv := valueof(ts_MI_TMSI_LV(add_p_tmsi)), upd_type := GPRS_UPD_T_RA, - old_ra := f_random_RAI()), 0); - + old_ra := add_rai, + p_tmsi_sig := ts_PtmsiSigTV(p_tmsi_sig), + p_tmsi_type := ts_PtmsiTypeTV(c_GMM_PMTSI_TYPE_MAPPED), + ms_network_cap := ts_GMM_MsNetCapV + ), 0); /* The SGSN has no idea about the MS and inquires the MME about it */ T.start(2.0); alt { - [] GTP[GTP_GGSN_IDX].receive(tr_GTPC_SGSNContextReq(?, ?)) -> value gtpc_ud { + // [] GTP[GTP_GGSN_IDX].receive(tr_GTPC_SGSNContextReq(g_gn_iface_peer, tr_SGSNContextReqPDU(rai := rai, ptmsi := ts_PTMSI(ptmsi), ptmsi_sig := ts_PTMSI_sig(ptmsi_sig), rat_type := int2oct(enum2int(rat_type), 1)))) -> value gtpc_pdu { + [] GTP[GTP_GGSN_IDX].receive(tr_GTPC_SGSNContextReq(peer, ?)) -> value gtpc_ud { log("Rx SGSN Context Req from SGSN"); setverdict(pass); T.stop; @@ -3146,24 +3226,39 @@ } /* The MME responds */ - var OCT8 kc := f_rnd_octstring(8); + var OCT16 ck := f_rnd_octstring(16); + var OCT16 ik := f_rnd_octstring(16); var template (value) PDP_Context_GTPC pdp_ctx; pdp_ctx := ts_PDP_Context_GTPC(pdp_addr := f_inet_addr("10.10.10.10"), ggsn_gsn_addr := f_inet_addr(mp_ggsn_ip), - apn := '08696E7465726E6574'O); + apn := '08696E7465726E6574'O, + ggsn_teic := pdp_teidc); var template (value) GTPC_PDUs ctx_rsp; + var OCT4 old_sgsn_remote_teid := gtpc_ud.gtpc.gtpc_pdu.sgsn_ContextRequest.teidControlPlane.teidControlPlane; ctx_rsp := ts_SGSNContextRespPDU(cause := GTP_CAUSE_REQUEST_ACCEPTED, imsi := g_pars.imsi, - teic := teidc, - mm_context := ts_MM_ContextGSM(kc), + teic := ctx_teidc, + mm_context := ts_MM_ContextUMTS(ck, ik), pdp_ctx_list := { pdp_ctx }); - GTP[GTP_GGSN_IDX].send(ts_GTPC_SGSNContextResp(gtpc_ud.peer, '12345678'O, seq_nr, ctx_rsp)); + GTP[GTP_GGSN_IDX].send(ts_GTPC_SGSNContextResp(gtpc_ud.peer, + old_sgsn_remote_teid, + oct2int(gtpc_ud.gtpc.opt_part.sequenceNumber), + ctx_rsp)); - /* TODO: Security Functions (auth/ciphering?) */ + /* TODO: Create a test case which fails at auth! */ + /* We expect a Send Auth Information and ignoring all keys received by the MME */ + T.start(2.0); + alt { + [] as_gmm_auth(umts_aka_challenge := true, expect_sai := true) {}; + [] T.timeout { + setverdict(fail, "Timeout waiting for SGSN SAI"); + mtc.stop; + } + } - /* The SGSN ACKs */ + /* Step 4: The SGSN ACKs */ T.start(2.0); alt { [] GTP[GTP_GGSN_IDX].receive(tr_GTPC_SGSNContextAck) -> value gtpc_ud { @@ -3177,8 +3272,30 @@ } } - /* TODO: Update PDP Context Req/Resp */ - /* TODO: 7..10 Update Location, ISD */ + /* Step 5: There is no such step */ + /* Step 6: Update PDP Context Req/Resp */ + T.start(2.0); + alt { + [] as_ggsn_gtp_ctx_upd_req(apars, exp_dir_tun := false) { + log("Rx GTP PDP Context Update Request"); + setverdict(pass); + T.stop; + } + [] T.timeout { + setverdict(fail, "Timeout waiting for Update PDP Context Req"); + mtc.stop; + } + } + + /* 7..10 Update Location, ISD */ + T.start(2.0); + alt { + [] as_gmm_gsup_lu_isd(); + [] T.timeout { + setverdict(fail, "Timeout waiting for Update Location, ISD"); + mtc.stop; + } + } /* RAU procedure completion */ T.start(2.0); @@ -3194,6 +3311,7 @@ mtc.stop; } } + f_sleep(1.0); } testcase TC_sgsn_context_req_out() runs on test_CT { var BSSGP_ConnHdlr vc_conn; diff --git a/sgsn/gen_links.sh b/sgsn/gen_links.sh index bae9a3b..7c9905d 100755 --- a/sgsn/gen_links.sh +++ b/sgsn/gen_links.sh @@ -82,6 +82,10 @@ FILES+="RANAP_Types.ttcn RANAP_Templates.ttcn RANAP_CodecPort.ttcn RANAP_EncDec.cc " gen_links $DIR $FILES +DIR=$BASEDIR/titan.ProtocolModules.NAS_EPS_15.2.0.1/src +FILES="NAS_EPS_Types.ttcn" +gen_links $DIR $FILES + DIR=../library FILES="Misc_Helpers.ttcn General_Types.ttcn GSM_Types.ttcn Osmocom_Types.ttcn " FILES+="RAW_NS.ttcnpp NS_Provider_IPL4.ttcn NS_Emulation.ttcnpp " @@ -90,6 +94,7 @@ FILES+="Osmocom_VTY_Functions.ttcn " FILES+="LLC_Templates.ttcn L3_Templates.ttcn L3_Common.ttcn " FILES+="ITU_X213_Types.ttcn " +FILES+="NAS_Templates.ttcn " FILES+="RAN_Emulation.ttcnpp RAN_Adapter.ttcnpp SCCP_Templates.ttcn " # IPA_Emulation + dependencies FILES+="IPA_Types.ttcn IPA_Emulation.ttcnpp IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc Native_Functions.ttcn Native_FunctionDefs.cc " -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0666a518aed57c2594653ab6b0f801c4193fd2f3 Gerrit-Change-Number: 39017 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ttcn3-hacks[master]: try to fix RAUs
by lynxis lazus 03 Dec '24

03 Dec '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39018?usp=email ) Change subject: try to fix RAUs ...................................................................... try to fix RAUs Change-Id: I7125ed8aa81fbda48a19f7f4fc711bc1bf2c875f --- M sgsn/BSSGP_ConnHdlr.ttcn 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/18/39018/1 diff --git a/sgsn/BSSGP_ConnHdlr.ttcn b/sgsn/BSSGP_ConnHdlr.ttcn index 23f75ae..a41a147 100644 --- a/sgsn/BSSGP_ConnHdlr.ttcn +++ b/sgsn/BSSGP_ConnHdlr.ttcn @@ -685,8 +685,13 @@ function f_routing_area_update(RoutingAreaIdentificationV old_ra, GprsUpdateType upd_type := GPRS_UPD_T_RA, integer ran_index := 0, - float Tval := 2.0) runs on BSSGP_ConnHdlr { + float Tval := 2.0, + /* allow authentication to happen while RAU */ + boolean allow_auth := true, + /* require authentication before accepting the RAU */ + boolean require_auth := true) runs on BSSGP_ConnHdlr { var template (omit) OCT4 p_tmsi := omit; + var boolean authed := false; timer T := Tval; if (is_iu(ran_index)) { @@ -697,6 +702,10 @@ T.start; alt { + [allow_auth or require_auth] as_gmm_auth(umts_aka_challenge := true, ran_index := ran_index, expect_sai := true) { + authed := true; + repeat; + } [] as_routing_area_update(ran_index) { setverdict(pass); } [is_gb(ran_index)] BSSGP[ran_index].receive { repeat; } [is_iu(ran_index)] BSSAP.receive { repeat; } @@ -705,6 +714,11 @@ mtc.stop; } } + + if (require_auth and not authed) { + setverdict(fail, "RAU succeeded but without required authentication"); + mtc.stop; + } } /* Iu only -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39018?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7125ed8aa81fbda48a19f7f4fc711bc1bf2c875f Gerrit-Change-Number: 39018 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect auth...
by lynxis lazus 03 Dec '24

03 Dec '24

Attention is currently required from: fixeria, laforge, lynxis lazus, pespin. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Code-Review-1 by fixeria, Verified+1 by Jenkins Builder Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect authentication ...................................................................... SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect authentication On a Service Request, the authentication is optional. Either an authentication must happen or the key material from the previous authentication has to be used. The default behavior is still the same. Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058 --- M sgsn/BSSGP_ConnHdlr.ttcn 1 file changed, 93 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/96/38396/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: GMM Service Request: handle PMM IDLE UE correct
by lynxis lazus 03 Dec '24

03 Dec '24

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by pespin, Code-Review+2 by laforge, Code-Review-1 by fixeria, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: handle PMM IDLE UE correct ...................................................................... SGSN: BSSGP_ConnHdlr: GMM Service Request: handle PMM IDLE UE correct 24.008: 4.7.13.3: explicitly mention the completion of the low layer security to be an implicit Security Command Accept if the UE is in PMM Idle. Extend the as_service_request() to handle both cases when UE is in PMM-IDLE as well in PMM-CONNECTED. Change-Id: I29237997e414aea80f254247da54f909410a4b36 --- M sgsn/BSSGP_ConnHdlr.ttcn 1 file changed, 30 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/38397/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I29237997e414aea80f254247da54f909410a4b36 Gerrit-Change-Number: 38397 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log