- gerrit-log - lists.osmocom.org

[M] Change in osmo-remsim[master]: Remove rspro_client.c which is not used anyway
by pespin 04 Dec '24

04 Dec '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39021?usp=email ) Change subject: Remove rspro_client.c which is not used anyway ...................................................................... Remove rspro_client.c which is not used anyway rspro_client.c was already removed ~6 years ago in 511c51313d4b1994eaa5faebcf01e8e24fb8b5a5, so those APIs where not really implemented and hence used. Remove the header. Related: OS#5896 Change-Id: I3bacae853101a79804553175ebd4482acb188597 --- M debian/libosmo-rspro-dev.install M include/osmocom/rspro/Makefile.am D include/osmocom/rspro/rspro_client.h 3 files changed, 0 insertions(+), 65 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved diff --git a/debian/libosmo-rspro-dev.install b/debian/libosmo-rspro-dev.install index 5abeb9c..56c5908 100644 --- a/debian/libosmo-rspro-dev.install +++ b/debian/libosmo-rspro-dev.install @@ -1,4 +1,3 @@ -usr/include/osmocom/rspro usr/lib/*/libosmo-rspro*.a usr/lib/*/libosmo-rspro*.so usr/lib/*/libosmo-rspro*.la diff --git a/include/osmocom/rspro/Makefile.am b/include/osmocom/rspro/Makefile.am index 7549ffb..1943af1 100644 --- a/include/osmocom/rspro/Makefile.am +++ b/include/osmocom/rspro/Makefile.am @@ -72,8 +72,3 @@ noinst_HEADERS+=per_decoder.h noinst_HEADERS+=per_encoder.h noinst_HEADERS+=per_opentype.h - -rspro_HEADERS = \ - rspro_client.h - -rsprodir = $(includedir)/osmocom/rspro diff --git a/include/osmocom/rspro/rspro_client.h b/include/osmocom/rspro/rspro_client.h deleted file mode 100644 index 76f3da6..0000000 --- a/include/osmocom/rspro/rspro_client.h +++ /dev/null @@ -1,59 +0,0 @@ -/* Remote SIM Protocol client */ - -/* (C) 2018 by Harald Welte <laforge(a)gnumonks.org> - * All Rights Reserved - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program. If not, see <http://www.gnu.org/licenses/>. - * - */ -#pragma once - -#include <osmocom/core/timer.h> - -/* a loss of RSPRO is considered quite serious, let's try to recover as quickly as - * possible. Even one new connection attempt per second should be quite acceptable until the link is - * re-established */ -#define OSMO_RSPRO_CLIENT_RECONNECT_INTERVAL 1 -#define OSMO_RSPRO_CLIENT_PING_INTERVAL 20 - -struct msgb; -struct ipa_client_conn; -struct osmo_rspro_client; - -/* Expects message in msg->l2h */ -typedef int (*osmo_rspro_client_read_cb_t)(struct osmo_rspro_client *rsproc, struct msgb *msg); - -struct osmo_rspro_client { - const char *unit_name; - - struct ipa_client_conn *link; - osmo_rspro_client_read_cb_t read_cb; - void *data; - - struct osmo_timer_list ping_timer; - struct osmo_timer_list connect_timer; - int is_connected; - int got_ipa_pong; -}; - -struct osmo_rspro_client *osmo_rspro_client_create(void *talloc_ctx, - const char *unit_name, - const char *ip_addr, - unsigned int tcp_port, - osmo_rspro_client_read_cb_t read_cb); - -void osmo_rspro_client_destroy(struct osmo_rspro_client *rsproc); -int osmo_rspro_client_send(struct osmo_rspro_client *rsproc, struct msgb *msg); -struct msgb *osmo_rspro_client_msgb_alloc(void); - -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3bacae853101a79804553175ebd4482acb188597 Gerrit-Change-Number: 39021 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libusrp[master]: debian/control: add missing deps to -dev pkg
by pespin 04 Dec '24

04 Dec '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libusrp/+/39031?usp=email ) Change subject: debian/control: add missing deps to -dev pkg ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/39031?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: I43cebeb108dfefbdb9c0f62123c0f98ca8159e85 Gerrit-Change-Number: 39031 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Dec 2024 15:53:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-pfcp[master]: debian/control: add missing deps to -dev pkg
by pespin 04 Dec '24

04 Dec '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/39030?usp=email ) Change subject: debian/control: add missing deps to -dev pkg ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/39030?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ide5cd1c481e57b94f3dc915b2a2fe86a2e224acf Gerrit-Change-Number: 39030 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Dec 2024 15:53:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-gprs[master]: debian/control: add missing deps to -dev pkgs
by pespin 04 Dec '24

04 Dec '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/39029?usp=email ) Change subject: debian/control: add missing deps to -dev pkgs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/39029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I1615565365e312244bc4658695344c5a312b5c91 Gerrit-Change-Number: 39029 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Dec 2024 15:52:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: debian/control: libosmo-abis-dev: add missing dep
by pespin 04 Dec '24

04 Dec '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39028?usp=email ) Change subject: debian/control: libosmo-abis-dev: add missing dep ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39028?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib7012ffce6ab853396a55d65ae4e48c7409276a4 Gerrit-Change-Number: 39028 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Dec 2024 15:51:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
by lynxis lazus 04 Dec '24

04 Dec '24

Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits ...................................................................... Patch Set 2: (1 comment) File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/06fbcfea_47a6… : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 > The problem with this is that when you want to run a single test, eg by putting it in PCU_Tests_SNS. […] But if you want to use it by another test you can set those. I don't see/understand you point here. It works and IMHO: make it more clear that those are test input which are more important than other variables -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Dec 2024 15:02:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in ...osmo-epdg[master]: rebar.lock: update gtplib commit
by osmith 04 Dec '24

04 Dec '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/39025?usp=email ) Change subject: rebar.lock: update gtplib commit ...................................................................... rebar.lock: update gtplib commit Let the commit point at the tree that was just rebased, so building with a newer erlang version on debian unstable is fixed. Fix for: [ 619s] ===> Compiling _checkouts/gtplib/src/gtp_packet.erl failed [ 619s] gtp_packet.erl:252:1: syntax error before: 'maybe' Related: OS#6661 Change-Id: I44bd92b9d9ca90fe396d85f67a064cba08b3f6c3 --- M rebar.lock 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/rebar.lock b/rebar.lock index ab13202..cd1bc6e 100644 --- a/rebar.lock +++ b/rebar.lock @@ -23,7 +23,7 @@ 0}, {<<"gtplib">>, {git,"https://github.com/osmocom/gtplib", - {ref,"526a7e5d6ba4e76aaae87c31421f26a71dd79d33"}}, + {ref,"08781f86f340aeaa4708166bfbeccf754217023e"}}, 0}, {<<"lager">>, {git,"https://github.com/erlang-lager/lager", -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/39025?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I44bd92b9d9ca90fe396d85f67a064cba08b3f6c3 Gerrit-Change-Number: 39025 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in gapk[master]: debian/control: libosmogapk-dev: add missing dep
by osmith 04 Dec '24

04 Dec '24

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/gapk/+/39027?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: debian/control: libosmogapk-dev: add missing dep ...................................................................... debian/control: libosmogapk-dev: add missing dep libosmogapk.pc.in requires libosmocore and libosmocodec. Change-Id: I652db0c06164619df0d54055d10f0a5f2b9d7e4e --- M debian/control 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/27/39027/2 -- To view, visit https://gerrit.osmocom.org/c/gapk/+/39027?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I652db0c06164619df0d54055d10f0a5f2b9d7e4e Gerrit-Change-Number: 39027 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in ...osmo-epdg[master]: rebar.lock: update gtplib commit
by lynxis lazus 04 Dec '24

04 Dec '24

Attention is currently required from: osmith. lynxis lazus has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/39025?usp=email ) Change subject: rebar.lock: update gtplib commit ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: It would be great to use release on our erlang modules so we don't have to depend on the .lock files so much. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/39025?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I44bd92b9d9ca90fe396d85f67a064cba08b3f6c3 Gerrit-Change-Number: 39025 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Dec 2024 14:58:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-remsim[master]: Remove rspro_client.c which is not used anyway
by lynxis lazus 04 Dec '24

04 Dec '24

Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39021?usp=email ) Change subject: Remove rspro_client.c which is not used anyway ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3bacae853101a79804553175ebd4482acb188597 Gerrit-Change-Number: 39021 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Dec 2024 14:57:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log