- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: README.md update / re-wording
by Jenkins Builder 05 Dec '24

05 Dec '24

Jenkins Builder has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/39040?usp=email ) Change subject: README.md update / re-wording ...................................................................... Patch Set 1: (1 comment) File README.md: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20423): https://gerrit.osmocom.org/c/pysim/+/39040/comment/9f98c0c9_dadd5b8a?usp=em… : PS1, Line 25: programmable SIM/USIM/ISIM/HPSIM cards, such as the various trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39040?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ied2a9626594e9735d92d4eabe6c6b90f92aa2909 Gerrit-Change-Number: 39040 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 05 Dec 2024 15:41:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in pysim[master]: README.md update / re-wording
by laforge 05 Dec '24

05 Dec '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/39040?usp=email ) Change subject: README.md update / re-wording ...................................................................... README.md update / re-wording Let's give a better description of what the project is all about, and differentiate reading/exploring any SIM from writing/updating a special programmable one where you know the ADM credentials. Change-Id: Ied2a9626594e9735d92d4eabe6c6b90f92aa2909 --- M README.md 1 file changed, 21 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/40/39040/1 diff --git a/README.md b/README.md index 2c7a6c8..81abe57 100644 --- a/README.md +++ b/README.md @@ -1,16 +1,29 @@ -pySim - Read, Write and Browse Programmable SIM/USIM/ISIM/HPSIM Cards -===================================================================== +pySim - Tools for reading, decoding, browsing SIM/USIM/ISIM/HPSIM/eUICC Cards +============================================================================= -This repository contains a number of Python programs that can be used -to read, program (write) and browse all fields/parameters/files on -SIM/USIM/ISIM/HPSIM cards used in 3GPP cellular networks from 2G to 5G. +This repository contains a number of Python programs related to working with +subscriber identity modules of cellular networks, including but not limited +to SIM, UICC, USIM, ISIM, HPSIMs and eUICCs. + +* `pySim-shell.py` can be used to interactively explore, read and decode contents + of any of the supported card models / card applications. Furthermore, if + you have the credentials to your card (ADM PIN), you can also write to the card, + i.e. edit its contents. +* `pySim-read.py` and `pySim-prog.py` are _legacy_ tools for batch programming + some very common parameters to an entire batch of programmable cards +* `pySim-trace.py` is a tool to do an in-depth decode of SIM card protocol traces + such as those obtained by [Osmocom SIMtrace2](https://osmocom.org/projects/simtrace2/wiki) + or [osmo-qcdiag](https://osmocom.org/projects/osmo-qcdiag/wiki). +* `osmo-smdpp.py` is a proof-of-concept GSMA SGP.22 Consumer eSIM SM-DP+ for lab/research +* there are more related tools, particularly in the `contrib` directory. Note that the access control configuration of normal production cards issue by operators will restrict significantly which files a normal user can read, and particularly write to. The full functionality of pySim hence can only be used with on so-called -programmable SIM/USIM/ISIM/HPSIM cards. +programmable SIM/USIM/ISIM/HPSIM cards, such as the various +[sysmocom programmable card products](https://shop.sysmocom.de/SIM/). Such SIM/USIM/ISIM/HPSIM cards are special cards, which - unlike those issued by regular commercial operators - come with the kind of keys that @@ -49,9 +62,9 @@ ---------------------------- While you will find a lot of online resources still describing the use of -pySim-prog.py and pySim-read.py, those tools are considered legacy by +`pySim-prog.py` and `pySim-read.py`, those tools are considered legacy by now and have by far been superseded by the much more capable -pySim-shell. We strongly encourage users to adopt pySim-shell, unless +`pySim-shell.py`. We strongly encourage users to adopt pySim-shell, unless they have very specific requirements like batch programming of large quantities of cards, which is about the only remaining use case for the legacy tools. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39040?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ied2a9626594e9735d92d4eabe6c6b90f92aa2909 Gerrit-Change-Number: 39040 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-remsim[master]: rspro: use osmo_stream to handle IPA connection
by pespin 05 Dec '24

05 Dec '24

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/39023?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: rspro: use osmo_stream to handle IPA connection ...................................................................... rspro: use osmo_stream to handle IPA connection libosmo-abis is still needed since we are still using ipa_keepalive_fsm from there. This needs to be imported here or moved to libosmo-netif. Related: OS#5896 Change-Id: I9cba48bf8eba85215acef70eda7bcf8ec13ea49a --- M configure.ac M debian/control M src/Makefile.am M src/bankd/Makefile.am M src/bankd/bankd_main.c M src/client/Makefile.am M src/rspro_client_fsm.c M src/rspro_client_fsm.h M src/server/Makefile.am 9 files changed, 147 insertions(+), 52 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/23/39023/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9cba48bf8eba85215acef70eda7bcf8ec13ea49a Gerrit-Change-Number: 39023 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-gprs[master]: Make compatible with libosmocore >= 1.10.0
by pespin 05 Dec '24

05 Dec '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/39038?usp=email ) Change subject: Make compatible with libosmocore >= 1.10.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/39038?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I7476f1c7915770d6529104a7a58cb8c16a371ddd Gerrit-Change-Number: 39038 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Dec 2024 15:03:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-gprs[master]: debian/rules: remove override_dh_strip
by pespin 05 Dec '24

05 Dec '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/39037?usp=email ) Change subject: debian/rules: remove override_dh_strip ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/39037?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I03ea18523dcac4db8069e6481b25e2db836c7200 Gerrit-Change-Number: 39037 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Dec 2024 15:02:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: tests/gsm0408: remove outdated comment for bcap_csd_2400_v22bis
by laforge 05 Dec '24

05 Dec '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/38914?usp=email ) Change subject: tests/gsm0408: remove outdated comment for bcap_csd_2400_v22bis ...................................................................... tests/gsm0408: remove outdated comment for bcap_csd_2400_v22bis The problem has been fixed in aec32dbf ("gsm48_encode_bearer_cap(): properly set 'Structure' in octet 4") and the testcase is now passing. Change-Id: I4732cc08a485695e8b4dda47ed602046352c5759 --- M tests/gsm0408/gsm0408_test.c 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c index 7456ed8..5566b7c 100644 --- a/tests/gsm0408/gsm0408_test.c +++ b/tests/gsm0408/gsm0408_test.c @@ -131,9 +131,7 @@ static const struct bcap_test bcap_tests[] = { { csd_9600_v110_lv, &bcap_csd_9600_v110, "CSD 9600/V.110/transparent" }, { csd_4800_rlp_lv, &bcap_csd_4800_rlp, "CSD 4800/RLP/non-transparent" }, - { /* XXX: this testcase is expected to fail because octet 4 is not represented in - * 'struct gsm_mncc_bearer_cap' and the encoder unconditionally hard-codes it to 0x88. */ - csd_2400_v22bis_lv, &bcap_csd_2400_v22bis, "CSD 2400/V.22bis/transparent" }, + { csd_2400_v22bis_lv, &bcap_csd_2400_v22bis, "CSD 2400/V.22bis/transparent" }, { speech_all_lv, &bcap_speech_all, "Speech, all codecs" }, { speech_no3a_lv, &bcap_speech_no3a, "Speech, without octet 3a" }, }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38914?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4732cc08a485695e8b4dda47ed602046352c5759 Gerrit-Change-Number: 38914 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: tests/gsm0408: remove outdated comment for bcap_csd_2400_v22bis
by laforge 05 Dec '24

05 Dec '24

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/38914?usp=email ) Change subject: tests/gsm0408: remove outdated comment for bcap_csd_2400_v22bis ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38914?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4732cc08a485695e8b4dda47ed602046352c5759 Gerrit-Change-Number: 38914 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Dec 2024 13:49:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: tr_GTPC_SGSNContextReq: use the same template as MsgType
by laforge 05 Dec '24

05 Dec '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38923?usp=email ) Change subject: tr_GTPC_SGSNContextReq: use the same template as MsgType ...................................................................... tr_GTPC_SGSNContextReq: use the same template as MsgType Change-Id: Idd546c3ec387e9c3ea8f1b1a61cf8ca8230db46a --- M library/GTPv1C_Templates.ttcn 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/library/GTPv1C_Templates.ttcn b/library/GTPv1C_Templates.ttcn index 766870a..7371ab0 100644 --- a/library/GTPv1C_Templates.ttcn +++ b/library/GTPv1C_Templates.ttcn @@ -1402,11 +1402,11 @@ private_extension_gtpc := * } } + template (present) Gtp1cUnitdata tr_GTPC_SGSNContextReq(template (present) Gtp1cPeer peer, - template (present) GTPC_PDUs SGSNContextReqPDU) := { - peer := peer, - gtpc := tr_GTP1C_PDU(sgsnContextRequest, '00000000'O, SGSNContextReqPDU) -} + template (present) GTPC_PDUs SGSNContextReqPDU) + := tr_GTPC_MsgType(peer, sgsnContextRequest, '00000000'O, SGSNContextReqPDU) + template (value) GTPC_PDUs ts_SGSNContextReqPDU(template (value) RoutingAreaIdentity rai, template (value) OCT4 teic, template (value) octetstring sgsn_addr_control, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idd546c3ec387e9c3ea8f1b1a61cf8ca8230db46a Gerrit-Change-Number: 38923 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-gprs[master]: debian/rules: remove override_dh_strip
by osmith 05 Dec '24

05 Dec '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/39037?usp=email ) Change subject: debian/rules: remove override_dh_strip ...................................................................... debian/rules: remove override_dh_strip Remove this rule, as is not needed. From https://www.debian.org/doc/manuals/developers-reference/best-pkging-practic…: > it should not be necessary to use the old manually generated ones anymore. Change-Id: I03ea18523dcac4db8069e6481b25e2db836c7200 --- M debian/rules 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/37/39037/1 diff --git a/debian/rules b/debian/rules index 7701a8e..24f662e 100755 --- a/debian/rules +++ b/debian/rules @@ -8,12 +8,6 @@ %: dh $@ --with autoreconf -# See https://www.debian.org/doc/manuals/developers-reference/best-pkging-practic… -override_dh_strip: - dh_strip -plibosmo-csn1-0 --dbg-package=libosmo-csn1-dbg - dh_strip -plibosmo-gprs-llc0 --dbg-package=libosmo-gprs-llc-dbg - dh_strip -plibosmo-gprs-rlcmac0 --dbg-package=libosmo-gprs-rlcmac-dbg - # Print test results in case of a failure override_dh_auto_test: dh_auto_test || (find . -name testsuite.log -exec cat {} \; ; false) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/39037?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I03ea18523dcac4db8069e6481b25e2db836c7200 Gerrit-Change-Number: 39037 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in libosmo-gprs[master]: Make compatible with libosmocore >= 1.10.0
by osmith 05 Dec '24

05 Dec '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/39038?usp=email ) Change subject: Make compatible with libosmocore >= 1.10.0 ...................................................................... Make compatible with libosmocore >= 1.10.0 Work towards preparing a release tag for libosmo-gprs, as osmocom-bb is now in osmocom:latest but cannot build due to the missing libosmo-gprs dependency. libosmo-gprs currently doesn't build against latest stable libosmocore, because it uses new enum values introduced in libosmocore master. Add defines for these temporarily, until a new libosmocore version is released and libosmo-gprs can depend on it. Related: osmocom-bb Ifbfaead7ae89d9ac747d1bb495f061c5cbe7a241 Related: fbdcd28 ("gmm: gprs_gmm_att_tlvdef: Add newer definitions…") Change-Id: I7476f1c7915770d6529104a7a58cb8c16a371ddd --- M TODO-RELEASE M src/gmm/gmm_pdu.c 2 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/38/39038/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 9ce8fb2..60f6474 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -9,3 +9,4 @@ #library what description / commit summary line libosmocore >1.8.0 gsm_fn2rfn(), gsm_rfn2fn() libosmocore >1.10.0 enum gsm48_gprs_ie_mm: GSM48_IE_GMM_UE_NET_CAP, GSM48_IE_GMM_VD_PREF_UE_USAGE +libosmocore >1.10.0 remove "Remove after depending on libosmocore > 1.10.0" code in gmm_pdu.c diff --git a/src/gmm/gmm_pdu.c b/src/gmm/gmm_pdu.c index 084f2a6..cc1f2f8 100644 --- a/src/gmm/gmm_pdu.c +++ b/src/gmm/gmm_pdu.c @@ -129,6 +129,20 @@ .non_drx_timer = 0, }; +/* Remove after depending on libosmocore > 1.10.0 */ +#ifndef GSM48_IE_GMM_UE_NET_CAP +#define GSM48_IE_GMM_UE_NET_CAP 0x58 +#endif +#ifndef GSM48_IE_GMM_VD_PREF_UE_USAGE +#define GSM48_IE_GMM_VD_PREF_UE_USAGE 0x5d +#endif +#ifndef GSM48_IE_GMM_ADD_IDENTITY +#define GSM48_IE_GMM_ADD_IDENTITY 0x1a +#endif +#ifndef GSM48_IE_GMM_RAI2 +#define GSM48_IE_GMM_RAI2 0x1b +#endif + const struct tlv_definition gprs_gmm_att_tlvdef = { .def = { [GSM48_IE_GMM_CIPH_CKSN] = { TLV_TYPE_SINGLE_TV, 1 }, -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/39038?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I7476f1c7915770d6529104a7a58cb8c16a371ddd Gerrit-Change-Number: 39038 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log