- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: remsim: bankd: Install vsmartcard-vpcd
by pespin 12 Dec '24

12 Dec '24

Attention is currently required from: laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39135?usp=email ) Change subject: remsim: bankd: Install vsmartcard-vpcd ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39135?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib5ba5075eff4955354fa25d1c605f277e8a6962a Gerrit-Change-Number: 39135 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 12 Dec 2024 18:22:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: jobs/osmocom-obs: update descriptions
by pespin 12 Dec '24

12 Dec '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39141?usp=email ) Change subject: jobs/osmocom-obs: update descriptions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39141?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I311c7e5194b1ef516ab54972383f03730b8cd6f2 Gerrit-Change-Number: 39141 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 18:20:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: jobs/osmocom-obs: update descriptions
by osmith 12 Dec '24

12 Dec '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39141?usp=email ) Change subject: jobs/osmocom-obs: update descriptions ...................................................................... jobs/osmocom-obs: update descriptions Describe when which job gets triggered, and whether it is fine to trigger them manually. Change-Id: I311c7e5194b1ef516ab54972383f03730b8cd6f2 --- M jobs/osmocom-obs.yml 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/41/39141/1 diff --git a/jobs/osmocom-obs.yml b/jobs/osmocom-obs.yml index e61b16b..39fa5fb 100644 --- a/jobs/osmocom-obs.yml +++ b/jobs/osmocom-obs.yml @@ -1,17 +1,30 @@ --- - project: name: Osmocom_OBS + description_extra: "" jobs: - Osmocom_OBS_{type} type: - master: conflict_version: "" + description_extra: | + This job gets triggered by jenkins whenever something gets merged + to master. - nightly: # For nightly we don't provide ABI compatibility, make sure packages # from different build dates are not mixed by accident conflict_version: "$(date +%Y%m%d%H%M)" + description_extra: | + This job gets triggered every night. + Do not trigger manually! This causes a rebuild of ALL packages + for ALL supported Linux distributions and architectures, and should + only run once every night! - latest: conflict_version: "" + description_extra: | + This job gets triggered every night. + Triggering this manually after making a release is fine, because + only the packages that have a new version will be built. - job-template: name: 'Osmocom_OBS_{type}' @@ -20,7 +33,7 @@ defaults: global description: | See <a href="https://osmocom.org/projects/cellular-infrastructure/wiki/Binary_Packages">Wiki: binary packages</a> - for more information. + for more information. {description_extra} properties: - build-discarder: days-to-keep: 30 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39141?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I311c7e5194b1ef516ab54972383f03730b8cd6f2 Gerrit-Change-Number: 39141 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: remsim: bankd: Install vsmartcard-vpcd
by osmith 12 Dec '24

12 Dec '24

Attention is currently required from: laforge, osmith, pespin. osmith has uploaded a new patch set (#3) to the change originally created by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39135?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by osmith Change subject: remsim: bankd: Install vsmartcard-vpcd ...................................................................... remsim: bankd: Install vsmartcard-vpcd This is needed for test RemsimBankd_Tests.TC_createMapping_exchangeTPDU to work. Add require_vsmartcard_vpcd.sh to give a meaningful error message when running without --podman, if the user doesn't have it installed. Co-authored-by: Oliver Smith <osmith(a)sysmocom.de> Change-Id: Ib5ba5075eff4955354fa25d1c605f277e8a6962a --- M _testenv/data/podman/Dockerfile A _testenv/data/scripts/require_vsmartcard_vpcd.sh M remsim/testenv_bankd.cfg 3 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/39135/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39135?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib5ba5075eff4955354fa25d1c605f277e8a6962a Gerrit-Change-Number: 39135 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: remsim: bankd: Install vsmartcard-vpcd
by osmith 12 Dec '24

12 Dec '24

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39135?usp=email ) Change subject: remsim: bankd: Install vsmartcard-vpcd ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39135?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib5ba5075eff4955354fa25d1c605f277e8a6962a Gerrit-Change-Number: 39135 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 14:21:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: remsim: bankd: Install vsmartcard-vpcd
by osmith 12 Dec '24

12 Dec '24

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39135?usp=email ) Change subject: remsim: bankd: Install vsmartcard-vpcd ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Well done! Yeah it's better to do this once in _testenv/data/podman/Dockerfile. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39135?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib5ba5075eff4955354fa25d1c605f277e8a6962a Gerrit-Change-Number: 39135 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 14:21:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: Fix BTS nr >255 wrapping up during bts allocation
by laforge 12 Dec '24

12 Dec '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39138?usp=email ) Change subject: Fix BTS nr >255 wrapping up during bts allocation ...................................................................... Fix BTS nr >255 wrapping up during bts allocation Commit which introduced the gsm_bts_nr_t type forgot to use it in these functions. As a result, bts 256 ended up trying to allocate rate counters for id=0. Change-Id: I5128becaf453f5cfbc722a55c756432e525fc884 Fixes: 6fe0e28a23a3aa3e707d147569add7f68d5dc4a1 Related: SYS#7063 --- M include/osmocom/bsc/bts.h M include/osmocom/bsc/bts_sm.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_sm.c 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 251c161..248c746 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -805,7 +805,7 @@ return &lai; } -struct gsm_bts *gsm_bts_alloc(struct gsm_network *net, struct gsm_bts_sm *bts_sm, uint8_t bts_num); +struct gsm_bts *gsm_bts_alloc(struct gsm_network *net, struct gsm_bts_sm *bts_sm, gsm_bts_nr_t bts_num); int gsm_bts_check_cfg(struct gsm_bts *bts); char *gsm_bts_name(const struct gsm_bts *bts); diff --git a/include/osmocom/bsc/bts_sm.h b/include/osmocom/bsc/bts_sm.h index 13be3d9..8fbdd74 100644 --- a/include/osmocom/bsc/bts_sm.h +++ b/include/osmocom/bsc/bts_sm.h @@ -68,7 +68,7 @@ return site_mgr->bts[0]; } -struct gsm_bts_sm *gsm_bts_sm_alloc(struct gsm_network *net, uint8_t bts_num); +struct gsm_bts_sm *gsm_bts_sm_alloc(struct gsm_network *net, gsm_bts_nr_t bts_num); void gsm_bts_sm_mo_reset(struct gsm_bts_sm *bts_sm); diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index c21e5b3..9febe35 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -193,7 +193,7 @@ * This part is shared among the thin programs in osmo-bsc/src/utils/. * osmo-bsc requires further initialization that pulls in more dependencies (see * bsc_bts_alloc_register()). */ -struct gsm_bts *gsm_bts_alloc(struct gsm_network *net, struct gsm_bts_sm *bts_sm, uint8_t bts_num) +struct gsm_bts *gsm_bts_alloc(struct gsm_network *net, struct gsm_bts_sm *bts_sm, gsm_bts_nr_t bts_num) { struct gsm_bts *bts = talloc_zero(bts_sm, struct gsm_bts); diff --git a/src/osmo-bsc/bts_sm.c b/src/osmo-bsc/bts_sm.c index ca572f1..d122369 100644 --- a/src/osmo-bsc/bts_sm.c +++ b/src/osmo-bsc/bts_sm.c @@ -49,7 +49,7 @@ return 0; } -struct gsm_bts_sm *gsm_bts_sm_alloc(struct gsm_network *net, uint8_t bts_num) +struct gsm_bts_sm *gsm_bts_sm_alloc(struct gsm_network *net, gsm_bts_nr_t bts_num) { struct gsm_bts_sm *bts_sm = talloc_zero(net, struct gsm_bts_sm); struct gsm_bts *bts; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5128becaf453f5cfbc722a55c756432e525fc884 Gerrit-Change-Number: 39138 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-bsc[master]: Use correct bts_nr field during MO init
by laforge 12 Dec '24

12 Dec '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39139?usp=email ) Change subject: Use correct bts_nr field during MO init ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8a70c61cef74c0febeefae88dee575fbb4936d3e Gerrit-Change-Number: 39139 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 14:21:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: remsim: bankd: Install vsmartcard-vpcd
by osmith 12 Dec '24

12 Dec '24

Attention is currently required from: laforge, pespin. osmith has uploaded a new patch set (#2) to the change originally created by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39135?usp=email ) The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: remsim: bankd: Install vsmartcard-vpcd ...................................................................... remsim: bankd: Install vsmartcard-vpcd This is needed for test RemsimBankd_Tests.TC_createMapping_exchangeTPDU to work. Co-authored-by: Oliver Smith <osmith(a)sysmocom.de> Change-Id: Ib5ba5075eff4955354fa25d1c605f277e8a6962a --- M _testenv/data/podman/Dockerfile A _testenv/data/scripts/require_vsmartcard_vpcd.sh M remsim/testenv_bankd.cfg 3 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/39135/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39135?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib5ba5075eff4955354fa25d1c605f277e8a6962a Gerrit-Change-Number: 39135 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: Fix BTS nr >255 wrapping up during bts allocation
by laforge 12 Dec '24

12 Dec '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39138?usp=email ) Change subject: Fix BTS nr >255 wrapping up during bts allocation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5128becaf453f5cfbc722a55c756432e525fc884 Gerrit-Change-Number: 39138 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 14:20:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log