- gerrit-log - lists.osmocom.org

[S] Change in osmo-pcap[master]: pcap-server: Avoid pcap time-based rotation if wall clock went backwards
by pespin 18 Dec '24

18 Dec '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39164?usp=email ) Change subject: pcap-server: Avoid pcap time-based rotation if wall clock went backwards ...................................................................... pcap-server: Avoid pcap time-based rotation if wall clock went backwards Keep writing to the last pcap created instead of creating a new pcap with older timestamp if clock jumped backwards. Change-Id: If2f609f6980156a70a12a8759110038df44c6655 --- M src/osmo_server_network.c 1 file changed, 28 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/64/39164/1 diff --git a/src/osmo_server_network.c b/src/osmo_server_network.c index 1d442bf..ce9c6e9 100644 --- a/src/osmo_server_network.c +++ b/src/osmo_server_network.c @@ -146,26 +146,42 @@ return close_connection(conn); } +/* Update conn->last_write if needed. This field is used to keep the last time + * period where we wrote to the pcap file. Once a new write period (based on + * rotation VTY config) is detected, the pcap file we write to is rotated. */ +static void update_last_write(struct osmo_pcap_conn *conn, time_t now) +{ + time_t last = mktime(&conn->last_write); + + /* Skip time udpates if wall clock went backwards (ie. due to drift + * correction or DST). As a result, time rotation checks will skip + * opening a new pcap file with an older timestamp, and instead keep + * using the current one. */ + if (now > last) + localtime_r(&now, &conn->last_write); +} + static void restart_pcap(struct osmo_pcap_conn *conn) { time_t now = time(NULL); - struct tm *tm = localtime(&now); + struct tm tm; int rc; osmo_pcap_server_close_trace(conn); /* omit any storing/creation of the file */ if (conn->no_store) { - conn->last_write = *tm; + update_last_write(conn, now); talloc_free(conn->curr_filename); conn->curr_filename = NULL; return; } + localtime_r(&now, &tm); conn->curr_filename = talloc_asprintf(conn, "%s/trace-%s-%d%.2d%.2d_%.2d%.2d%.2d.pcap", conn->server->base_path, conn->name, - tm->tm_year + 1900, tm->tm_mon + 1, tm->tm_mday, - tm->tm_hour, tm->tm_min, tm->tm_sec); + tm.tm_year + 1900, tm.tm_mon + 1, tm.tm_mday, + tm.tm_hour, tm.tm_min, tm.tm_sec); if (!conn->curr_filename) { LOGP(DSERVER, LOGL_ERROR, "Failed to assemble filename for %s.\n", conn->name); @@ -187,7 +203,7 @@ return; } - conn->last_write = *tm; + update_last_write(conn, now); } static int link_data(struct osmo_pcap_conn *conn, struct osmo_pcap_data *data) @@ -335,12 +351,14 @@ } } -static bool check_restart_pcap_localtime(struct osmo_pcap_conn *conn, const struct tm *tm) +static bool check_restart_pcap_localtime(struct osmo_pcap_conn *conn, time_t now) { + struct tm tm; if (!pcap_server->rotate_localtime.enabled) return false; - if (!check_localtime(&conn->last_write, tm, + localtime_r(&now, &tm); + if (!check_localtime(&conn->last_write, &tm, pcap_server->rotate_localtime.intv, pcap_server->rotate_localtime.modulus)) return false; @@ -355,13 +373,12 @@ static int write_data(struct osmo_pcap_conn *conn, struct osmo_pcap_data *data) { time_t now = time(NULL); - struct tm *tm = localtime(&now); int rc; client_data(conn, data); if (conn->no_store) { - conn->last_write = *tm; + update_last_write(conn, now); return 1; } @@ -371,9 +388,9 @@ } if (!check_restart_pcap_max_size(conn, data)) - check_restart_pcap_localtime(conn, tm); + check_restart_pcap_localtime(conn, now); - conn->last_write = *tm; + update_last_write(conn, now); rc = write(conn->local_fd, &data->data[0], data->len); if (rc != data->len) { LOGP(DSERVER, LOGL_ERROR, "Failed to write for %s\n", conn->name); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39164?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: If2f609f6980156a70a12a8759110038df44c6655 Gerrit-Change-Number: 39164 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-pcap[master]: pcap-server: Improve log error opening pcap file
by pespin 18 Dec '24

18 Dec '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39163?usp=email ) Change subject: pcap-server: Improve log error opening pcap file ...................................................................... pcap-server: Improve log error opening pcap file Change-Id: Id7ff71f2259cd1e0401937ffcd51b8bb0be56e3e --- M src/osmo_server_network.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/63/39163/1 diff --git a/src/osmo_server_network.c b/src/osmo_server_network.c index 056decc..1d442bf 100644 --- a/src/osmo_server_network.c +++ b/src/osmo_server_network.c @@ -174,7 +174,8 @@ conn->local_fd = creat(conn->curr_filename, conn->server->permission_mask); if (conn->local_fd < 0) { - LOGP(DSERVER, LOGL_ERROR, "Failed to file: '%s'\n", conn->curr_filename); + LOGP(DSERVER, LOGL_ERROR, "Failed to create file '%s': %s\n", + conn->curr_filename, strerror(errno)); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39163?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Id7ff71f2259cd1e0401937ffcd51b8bb0be56e3e Gerrit-Change-Number: 39163 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in osmo-pcap[master]: pcap-server: Make rotate-localtime feature configurable through VTY
by osmith 18 Dec '24

18 Dec '24

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email ) Change subject: pcap-server: Make rotate-localtime feature configurable through VTY ...................................................................... Patch Set 5: (2 comments) File src/osmo_server_network.c: https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/a4a1b17e_99e130eb?us… : PS3, Line 231: /* Checks if we are in a new record period since last time we wrote to a pcap, to know (return true) whether a new pcap file needs to be opened. > Acknowledged Done File src/osmo_server_vty.c: https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/6cef74db_959faa46?us… : PS3, Line 219: frecuency > Acknowledged Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idf17a161c17050bb62793a82e39179a093b35f73 Gerrit-Change-Number: 39158 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Dec 2024 11:50:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in osmo-pcap[master]: pcap-server: Make rotate-localtime feature configurable through VTY
by osmith 18 Dec '24

18 Dec '24

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email ) Change subject: pcap-server: Make rotate-localtime feature configurable through VTY ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File doc/manuals/chapters/server.adoc: https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/d09057f7_ab508777?us… : PS3, Line 117: > ack, I'd suggest to document the current behavior with this patch in the docs file though (to be adj […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idf17a161c17050bb62793a82e39179a093b35f73 Gerrit-Change-Number: 39158 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Dec 2024 11:49:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in osmo-pcap[master]: pcap-server: Make rotate-localtime feature configurable through VTY
by pespin 18 Dec '24

18 Dec '24

Attention is currently required from: fixeria, laforge, osmith, pespin. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: pcap-server: Make rotate-localtime feature configurable through VTY ...................................................................... pcap-server: Make rotate-localtime feature configurable through VTY Related: SYS#7100 Change-Id: Idf17a161c17050bb62793a82e39179a093b35f73 --- M .gitignore M configure.ac M doc/manuals/chapters/server.adoc M include/osmo-pcap/osmo_pcap_server.h M src/osmo_server_main.c M src/osmo_server_network.c M src/osmo_server_vty.c M tests/Makefile.am A tests/rotate_localtime/Makefile.am A tests/rotate_localtime/rotate_localtime_test.c A tests/rotate_localtime/rotate_localtime_test.err A tests/rotate_localtime/rotate_localtime_test.ok M tests/testsuite.at 13 files changed, 1,754 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/58/39158/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idf17a161c17050bb62793a82e39179a093b35f73 Gerrit-Change-Number: 39158 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XL] Change in osmo-pcap[master]: pcap-server: Make rotate-localtime feature configurable through VTY
by osmith 18 Dec '24

18 Dec '24

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email ) Change subject: pcap-server: Make rotate-localtime feature configurable through VTY ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File doc/manuals/chapters/server.adoc: https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/6929b6f4_7f253385?us… : PS3, Line 117: > This is actually quite a lengthy discussion. […] ack, I'd suggest to document the current behavior with this patch in the docs file though (to be adjusted later in follow up patches as well if they are made) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idf17a161c17050bb62793a82e39179a093b35f73 Gerrit-Change-Number: 39158 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Dec 2024 11:33:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in osmo-pcap[master]: pcap-server: Make rotate-localtime feature configurable through VTY
by pespin 18 Dec '24

18 Dec '24

Attention is currently required from: fixeria, laforge, pespin. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email ) Change subject: pcap-server: Make rotate-localtime feature configurable through VTY ...................................................................... Patch Set 3: (1 comment) File doc/manuals/chapters/server.adoc: https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/6625a68c_8a8e78c5?us… : PS3, Line 117: > Maybe worth document what happens if the system's localtime goes backward (daylight savings time or […] This is actually quite a lengthy discussion. Yes, in theory it can happen that we try to reopen an existing file. Right now we use creat() in restart_pcap(), which will truncate the file to zero length if it already exists. In general it's more difficult than it seems to actually ending up opening the same file, because the file name is based on the timestamp of the time at which we received the packet up to second granularity, so we have further entropy there to end up with a different file name. But yes, it could happen, see test_check_localtime_dst_europe() I just added. We could add an extra check to avoid store the "last_write" tm if the current tm is older in time than the one in use. But it makes sense to do this in a follow-up patch imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idf17a161c17050bb62793a82e39179a093b35f73 Gerrit-Change-Number: 39158 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Dec 2024 11:30:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XL] Change in osmo-pcap[master]: pcap-server: Make rotate-localtime feature configurable through VTY
by pespin 18 Dec '24

18 Dec '24

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: pcap-server: Make rotate-localtime feature configurable through VTY ...................................................................... pcap-server: Make rotate-localtime feature configurable through VTY Related: SYS#7100 Change-Id: Idf17a161c17050bb62793a82e39179a093b35f73 --- M .gitignore M configure.ac M doc/manuals/chapters/server.adoc M include/osmo-pcap/osmo_pcap_server.h M src/osmo_server_main.c M src/osmo_server_network.c M src/osmo_server_vty.c M tests/Makefile.am A tests/rotate_localtime/Makefile.am A tests/rotate_localtime/rotate_localtime_test.c A tests/rotate_localtime/rotate_localtime_test.err A tests/rotate_localtime/rotate_localtime_test.ok M tests/testsuite.at 13 files changed, 1,748 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/58/39158/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idf17a161c17050bb62793a82e39179a093b35f73 Gerrit-Change-Number: 39158 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XL] Change in osmo-pcap[master]: pcap-server: Make rotate-localtime feature configurable through VTY
by osmith 18 Dec '24

18 Dec '24

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email ) Change subject: pcap-server: Make rotate-localtime feature configurable through VTY ...................................................................... Patch Set 3: (2 comments) File configure.ac: https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/14e77d80_743b12b7?us… : PS3, Line 65: dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang > Well they start to be needed here since I'm adding unit tests for the feature I'm adding, I think it […] Acknowledged File src/osmo_server_vty.c: https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/cd8cd9ec_e649c37e?us… : PS3, Line 246: max_mod = 4294967295; > We cannot use it easily in DEFUN since stringifying it then adds eg. "UL" at the end. […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idf17a161c17050bb62793a82e39179a093b35f73 Gerrit-Change-Number: 39158 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Dec 2024 11:10:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in osmo-pcap[master]: pcap-server: Make rotate-localtime feature configurable through VTY
by pespin 18 Dec '24

18 Dec '24

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email ) Change subject: pcap-server: Make rotate-localtime feature configurable through VTY ...................................................................... Patch Set 3: (4 comments) File configure.ac: https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/8887d85c_e3ee174c?us… : PS3, Line 65: dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang > put the configure.ac and . […] Well they start to be needed here since I'm adding unit tests for the feature I'm adding, I think it makes sense to have it here. File src/osmo_server_network.c: https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/816682d3_352d8f98?us… : PS3, Line 231: /* Checks if we are in a new record period since last time we wrote to a pcap, to know (return true) whether a new pcap file needs to be opened. > cosmetic: very long line Acknowledged File src/osmo_server_vty.c: https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/a316200e_85782104?us… : PS3, Line 219: frecuency > frequency Acknowledged https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/e236778c_3498c22d?us… : PS3, Line 246: max_mod = 4294967295; > (that will take a while :D) […] We cannot use it easily in DEFUN since stringifying it then adds eg. "UL" at the end. I think it doesn't really matter in this case, take it as simply a big enough year :) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idf17a161c17050bb62793a82e39179a093b35f73 Gerrit-Change-Number: 39158 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Dec 2024 10:50:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log