Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262?usp=email )
Change subject: SGSN: add testcases for PDP Context Status
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/19b87696_b14a… :
PS3, Line 2592: f_send_l3(ts_GMM_RAU_REQ(f_mi_get_lv(), GPRS_UPD_T_RA, old_ra := g_pars.ra, pdp_status := '2000'O /* NSAPI 5 */), ran_index);
we should probably have this somehow stored in "apars", and generate the pdp_status with a function from there.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5a29e667f53cc2834fbddd2c5dc901d3e6ae72c7
Gerrit-Change-Number: 39262
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 08 Jan 2025 18:15:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39257?usp=email )
Change subject: SGSN: TC_attach_gsup_lu_timeout: increase timeout to 35 seconds
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
we should ideally change the timeout to a lower value instead, to avoid increasing testsuite runtime by 1 minute...
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39257?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie882dd39f3c606e5fe00162fcf17c47b9f713d49
Gerrit-Change-Number: 39257
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 08 Jan 2025 18:10:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email )
Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/9e9c7fa1_1b48… :
PS3, Line 12: message, the old GMM Attach should be discard silently and a new
dicarded?
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/04fc79fb_c4c7… :
PS3, Line 2215: /* FIXME: Extract P-TMSI, if any. Only send Complete if necessary */
what about this?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia721d3c29bf09014b197670ae02d1cd1901750bc
Gerrit-Change-Number: 39256
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 08 Jan 2025 18:08:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255?usp=email )
Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_retransmit
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255/comment/d07170d5_2303… :
PS3, Line 10: by "loosing" an ID Req message.
losing
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255/comment/e2a6ddc4_a239… :
PS3, Line 2125: /* send out a second GMM_Attach Request.
same here, this is not true here, no second GMM attach here... please re-read the whole test.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8d208c0a98675238dba439ab3e75758293928588
Gerrit-Change-Number: 39255
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 08 Jan 2025 18:07:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes