- gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: nokia_site: introduce hopping control for Nokia *Site
by csaba.sipos 11 Jan '25

11 Jan '25

Attention is currently required from: csaba.sipos. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: nokia_site: introduce hopping control for Nokia *Site ...................................................................... nokia_site: introduce hopping control for Nokia *Site nokia_site hopping-type 0 sets baseband hopping nokia_site hopping-type 1 sets sythesizer (RF) hopping Signed-off-by: csaba.sipos <metro4(a)freemail.hu> Change-Id: Idb1d269d2ee80d72ede2394125e8acedf0ee8b06 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts_nokia_site.c M src/osmo-bsc/bts_vty.c 3 files changed, 49 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/90/39290/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idb1d269d2ee80d72ede2394125e8acedf0ee8b06 Gerrit-Change-Number: 39290 Gerrit-PatchSet: 3 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu>

1 0

[M] Change in osmo-bsc[master]: nokia_site: introduce hopping control for Nokia *Site
by Jenkins Builder 11 Jan '25

11 Jan '25

Attention is currently required from: csaba.sipos. Jenkins Builder has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email ) Change subject: nokia_site: introduce hopping control for Nokia *Site ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/bts_vty.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20869): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/7715478d_8db87d3d?usp… : PS2, Line 478: if (!is_nokia_bts(bts)) { suspect code indent for conditional statements (16, 32) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idb1d269d2ee80d72ede2394125e8acedf0ee8b06 Gerrit-Change-Number: 39290 Gerrit-PatchSet: 2 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Comment-Date: Sat, 11 Jan 2025 18:35:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-bsc[master]: nokia_site: introduce hopping control for Nokia *Site
by csaba.sipos 11 Jan '25

11 Jan '25

Attention is currently required from: csaba.sipos. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: nokia_site: introduce hopping control for Nokia *Site ...................................................................... nokia_site: introduce hopping control for Nokia *Site nokia_site hopping-type 0 sets baseband hopping nokia_site hopping-type 1 sets sythesizer (RF) hopping Signed-off-by: csaba.sipos <metro4(a)freemail.hu> Change-Id: Idb1d269d2ee80d72ede2394125e8acedf0ee8b06 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts_nokia_site.c M src/osmo-bsc/bts_vty.c 3 files changed, 49 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/90/39290/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idb1d269d2ee80d72ede2394125e8acedf0ee8b06 Gerrit-Change-Number: 39290 Gerrit-PatchSet: 2 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu>

1 0

[M] Change in osmo-bsc[master]: nokia_site: introduce hopping control for Nokia *Site
by Jenkins Builder 11 Jan '25

11 Jan '25

Jenkins Builder has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email ) Change subject: nokia_site: introduce hopping control for Nokia *Site ...................................................................... Patch Set 1: (29 comments) File src/osmo-bsc/bts_nokia_site.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/12154456_4e0d81b9?usp… : PS1, Line 1137: switch (hopping_type) { switch and case should be at the same indent File src/osmo-bsc/bts_vty.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/658f9929_9242d19e?usp… : PS1, Line 469: cfg_bts_nokia_site_hopping_type_cmd, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/d3e9c9c3_a57e5e62?usp… : PS1, Line 469: cfg_bts_nokia_site_hopping_type_cmd, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/936bc0ef_d42eabf5?usp… : PS1, Line 470: "nokia_site nokia_hopping (0|1)", code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/6c34df9f_b55ae118?usp… : PS1, Line 470: "nokia_site nokia_hopping (0|1)", please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/45aa982e_4689318b?usp… : PS1, Line 471: NOKIA_STR code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/cb91dca0_007a17e0?usp… : PS1, Line 471: NOKIA_STR please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/cf115d0d_e2f49dcf?usp… : PS1, Line 472: "This parameter sets the frequency hopping type for Nokia *Site\n" code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/e2b9498c_f7b56bc1?usp… : PS1, Line 472: "This parameter sets the frequency hopping type for Nokia *Site\n" please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/946f4a9b_b5bf97d5?usp… : PS1, Line 473: "0=Baseband hopping, 1=Synthesizer (RF) hopping\n", code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/d967ca2b_0aa1cbe7?usp… : PS1, Line 473: "0=Baseband hopping, 1=Synthesizer (RF) hopping\n", please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/f2c378fa_78b8a635?usp… : PS1, Line 474: CMD_ATTR_IMMEDIATE) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/f411af94_fb316456?usp… : PS1, Line 474: CMD_ATTR_IMMEDIATE) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/e33bbbdb_2e11dec6?usp… : PS1, Line 476: struct gsm_bts *bts = vty->index; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/257e62d8_c43a662b?usp… : PS1, Line 476: struct gsm_bts *bts = vty->index; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/713a4a4e_a54e687b?usp… : PS1, Line 478: if (!is_nokia_bts(bts)) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/2243de2e_3d2b06ba?usp… : PS1, Line 478: if (!is_nokia_bts(bts)) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/783d1560_87e9a727?usp… : PS1, Line 479: vty_out(vty, "%% BTS is not of Nokia *Site type%s", code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/334dd2fc_f9e2d4cb?usp… : PS1, Line 479: vty_out(vty, "%% BTS is not of Nokia *Site type%s", please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/05698914_f15da317?usp… : PS1, Line 480: VTY_NEWLINE); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/23e88df5_fbadb913?usp… : PS1, Line 480: VTY_NEWLINE); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/c7635a0d_a1bc4354?usp… : PS1, Line 481: return CMD_WARNING; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/49bb6f26_80f4886a?usp… : PS1, Line 481: return CMD_WARNING; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/4ec5c987_dd158407?usp… : PS1, Line 482: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/d4df6351_c60a6266?usp… : PS1, Line 482: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/1f2c7fb3_c1fa0c50?usp… : PS1, Line 484: bts->nokia.nokia_hopping = atoi(argv[0]); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/4a2d7537_482dfc8f?usp… : PS1, Line 484: bts->nokia.nokia_hopping = atoi(argv[0]); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/e142ea38_f6e70c6f?usp… : PS1, Line 486: return CMD_SUCCESS; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/52b69d58_eb367d30?usp… : PS1, Line 486: return CMD_SUCCESS; please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idb1d269d2ee80d72ede2394125e8acedf0ee8b06 Gerrit-Change-Number: 39290 Gerrit-PatchSet: 1 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sat, 11 Jan 2025 18:09:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-bsc[master]: nokia_site: introduce hopping control for Nokia *Site
by csaba.sipos 11 Jan '25

11 Jan '25

csaba.sipos has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email ) Change subject: nokia_site: introduce hopping control for Nokia *Site ...................................................................... nokia_site: introduce hopping control for Nokia *Site nokia_site hopping-type 0 sets baseband hopping nokia_site hopping-type 1 sets sythesizer (RF) hopping Signed-off-by: csaba.sipos <metro4(a)freemail.hu> Change-Id: Idb1d269d2ee80d72ede2394125e8acedf0ee8b06 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts_nokia_site.c M src/osmo-bsc/bts_vty.c 3 files changed, 49 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/90/39290/1 diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 248c746..cb49361 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -488,7 +488,8 @@ no_loc_rel_cnf:1, /* don't wait for RSL REL CONF */ bts_reset_timer_cnf, /* timer for BTS RESET */ did_reset:1, /* we received a RESET ACK */ - wait_reset:2; /* we are waiting for reset to complete */ + wait_reset:2, /* we are waiting for reset to complete */ + nokia_hopping:1; /* hopping type selection for Nokia */ struct osmo_timer_list reset_timer; } nokia; }; diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c index 14d4388..3a12b57 100644 --- a/src/osmo-bsc/bts_nokia_site.c +++ b/src/osmo-bsc/bts_nokia_site.c @@ -1102,7 +1102,7 @@ */ static int make_bts_config(struct gsm_bts *bts, uint8_t bts_type, int n_trx, uint8_t * fu_config, - int need_hopping) + int need_hopping, int hopping_type) { /* is it an InSite BTS ? */ if (bts_type == 0x0E || bts_type == 0x0F || bts_type == 0x10) { /* TODO */ @@ -1132,11 +1132,27 @@ len += (sizeof(bts_config_1) + (n_trx - 1)); memcpy(fu_config + len, bts_config_2, sizeof(bts_config_2)); - /* set hopping mode (Baseband and RF hopping work for the MetroSite) */ - if (need_hopping) - fu_config[len + 2 + 1] = 1; /* 0: no hopping, 1: Baseband hopping, 2: RF hopping */ + /* set hopping mode */ + if (need_hopping) { + switch (hopping_type) { + /* 0: no hopping, 1: Baseband hopping, 2: RF hopping */ + case 0: + LOG_BTS(bts, DNM, LOGL_INFO, "Baseband hopping selected!\n"); + fu_config[len + 2 + 1] = 1; + break; + case 1: + LOG_BTS(bts, DNM, LOGL_INFO, "Synthesizer (RF) hopping selected!\n"); + fu_config[len + 2 + 1] = 2; + break; + default: + LOG_BTS(bts, DNM, LOGL_INFO, "No hopping is selected!\n"); + fu_config[len + 2 + 1] = 0; + break; + } + } len += sizeof(bts_config_2); + /* set extended cell radius for each TRX */ for (i = 0; i < n_trx; i++) { memcpy(fu_config + len, bts_config_3, sizeof(bts_config_3)); @@ -1381,6 +1397,9 @@ int ret; int hopping = 0; int need_hopping = 0; + int hopping_type = 0; + + hopping_type = bts->nokia.nokia_hopping; memset(config, 0, sizeof(config)); @@ -1407,7 +1426,7 @@ idx++; } - ret = make_bts_config(bts, bts_type, idx, config + len, need_hopping); + ret = make_bts_config(bts, bts_type, idx, config + len, need_hopping, hopping_type); len += ret; #if 0 /* debugging */ diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index f6ee514..a023591 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -464,6 +464,28 @@ return CMD_SUCCESS; } + +DEFUN_ATTR(cfg_bts_nokia_site_hopping_type, + cfg_bts_nokia_site_hopping_type_cmd, + "nokia_site nokia_hopping (0|1)", + NOKIA_STR + "This parameter sets the frequency hopping type for Nokia *Site\n" + "0=Baseband hopping, 1=Synthesizer (RF) hopping\n", + CMD_ATTR_IMMEDIATE) +{ + struct gsm_bts *bts = vty->index; + + if (!is_nokia_bts(bts)) { + vty_out(vty, "%% BTS is not of Nokia *Site type%s", + VTY_NEWLINE); + return CMD_WARNING; + } + + bts->nokia.nokia_hopping = atoi(argv[0]); + + return CMD_SUCCESS; +} + #define OML_STR "Organization & Maintenance Link\n" #define IPA_STR "A-bis/IP Specific Options\n" @@ -4926,6 +4948,7 @@ install_element(BTS_NODE, &cfg_bts_nokia_site_skip_reset_cmd); install_element(BTS_NODE, &cfg_bts_nokia_site_no_loc_rel_cnf_cmd); install_element(BTS_NODE, &cfg_bts_nokia_site_bts_reset_timer_cnf_cmd); + install_element(BTS_NODE, &cfg_bts_nokia_site_hopping_type_cmd); install_element(BTS_NODE, &cfg_bts_stream_id_cmd); install_element(BTS_NODE, &cfg_bts_deprecated_stream_id_cmd); install_element(BTS_NODE, &cfg_bts_oml_e1_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idb1d269d2ee80d72ede2394125e8acedf0ee8b06 Gerrit-Change-Number: 39290 Gerrit-PatchSet: 1 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu>

1 0

[L] Change in osmo-pcap[master]: client: Introduce osmo_pcap_file to prepare support for pcapng
by laforge 11 Jan '25

11 Jan '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39288?usp=email ) Change subject: client: Introduce osmo_pcap_file to prepare support for pcapng ...................................................................... Patch Set 1: (1 comment) File src/osmo_pcap_file.c: https://gerrit.osmocom.org/c/osmo-pcap/+/39288/comment/350e4c6d_f6f85c9c?us… : PS1, Line 38: osmo_pcap_file_global_header_size do we reeally need a function for this? Do we ever expect that there will be a future file format which will return anything but a constant here? Especially since we are not passing any data/context into the function, I have a hard time imagining any future implementation that would not return a constant? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ifd389a2a32897e101c62fd280ddca984d485d373 Gerrit-Change-Number: 39288 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Jan 2025 14:56:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-pcap[master]: Makefile.am: proper format and reorder source file lists
by laforge 11 Jan '25

11 Jan '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39286?usp=email ) Change subject: Makefile.am: proper format and reorder source file lists ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39286?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ie39bd0348f4f329539c1d9dabc8fa87f3e4bbefe Gerrit-Change-Number: 39286 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Jan 2025 14:54:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-pcap[master]: Cleanup and reorder includes in header files
by laforge 11 Jan '25

11 Jan '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39285?usp=email ) Change subject: Cleanup and reorder includes in header files ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39285?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I0467d3c3a2687a7990c0db7371d0c89f97e8400a Gerrit-Change-Number: 39285 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Jan 2025 14:54:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: nokia_site: change RSL bootstrap logic
by laforge 11 Jan '25

11 Jan '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39277?usp=email ) Change subject: nokia_site: change RSL bootstrap logic ...................................................................... nokia_site: change RSL bootstrap logic Wait for BTS_CONF_COMPL and start RSL bootstrap after. This way the TRX SW load has enough time to complete and the RSL LAPD becomes available. Important for MetroSite, UltraSite BTS types. Change-Id: I7319a64f069d239a582547bc422058ff5848d2e2 Signed-off-by: csaba.sipos <metro4(a)freemail.hu> --- M src/osmo-bsc/bts_nokia_site.c 1 file changed, 15 insertions(+), 21 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c index 688a8a4..14d4388 100644 --- a/src/osmo-bsc/bts_nokia_site.c +++ b/src/osmo-bsc/bts_nokia_site.c @@ -1731,27 +1731,6 @@ osmo_timer_setup(&bts->nokia.reset_timer, reset_timer_cb, bts); osmo_timer_schedule(&bts->nokia.reset_timer, 0, 0); } - - /* ACK for CONF DATA message ? */ - if (bts->nokia.configured != 0) { - /* start TRX (RSL link) */ - - struct gsm_e1_subslot *e1_link = - &sign_link->trx->rsl_e1_link; - struct e1inp_line *line; - - bts->nokia.configured = 0; - - /* RSL Link */ - line = e1inp_line_find(e1_link->e1_nr); - if (!line) { - LOG_BTS(bts, DLINP, LOGL_ERROR, "RSL link referring to " - "non-existing E1 line %u\n", e1_link->e1_nr); - return -ENOMEM; - } - /* start TRX */ - start_sabm_in_line(line, 1, SAPI_RSL); /* start only RSL */ - } break; case NOKIA_MSG_STATE_CHANGED: /* send ACK */ @@ -1760,6 +1739,21 @@ case NOKIA_MSG_CONF_COMPLETE: /* send ACK */ abis_nm_ack(bts, ref); + if (bts->nokia.configured != 0) { + /* start TRX (RSL link) */ + struct gsm_e1_subslot *e1_link = &sign_link->trx->rsl_e1_link; + struct e1inp_line *line; + bts->nokia.configured = 0; + /* RSL Link */ + line = e1inp_line_find(e1_link->e1_nr); + if (!line) { + LOG_BTS(bts, DLINP, LOGL_ERROR, "RSL link referring to " + "non-existing E1 line %u\n", e1_link->e1_nr); + return -ENOMEM; + } + /* start TRX */ + start_sabm_in_line(line, 1, SAPI_RSL); /* start only RSL */ + } /* fake 12.21 OM */ nokia_abis_nm_fake_1221_ok(bts); break; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39277?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7319a64f069d239a582547bc422058ff5848d2e2 Gerrit-Change-Number: 39277 Gerrit-PatchSet: 2 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-gsm-manuals[master]: bibliography.adoc: add TW-TS-* references
by falconia 11 Jan '25

11 Jan '25

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289?usp=email ) Change subject: bibliography.adoc: add TW-TS-* references ...................................................................... bibliography.adoc: add TW-TS-* references Some Osmocom components include support for interfaces that are defined in Themyscira Wireless specs (TW-TS): * OsmoBTS includes support for TW-TS-001, may also support TW-TS-002 for HRv1 codec in the future; * OsmoBSC includes support for TW-TS-003 BSSMAP extension; * TW-TS-005 hex file format can be used in some unit tests. Therefore, these specs should be linked from Osmocom bibliography. Change-Id: Ia34a61b5f834f2c70f81012dcc816dd6014c784f --- M common/chapters/bibliography.adoc 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/89/39289/1 diff --git a/common/chapters/bibliography.adoc b/common/chapters/bibliography.adoc index 9d635b0..126f3cc 100644 --- a/common/chapters/bibliography.adoc +++ b/common/chapters/bibliography.adoc @@ -227,3 +227,16 @@ License. https://www.gnu.org/licenses/agpl-3.0.en.html - [[[freeswitch_pbx]]] FreeSWITCH SIP PBX https://freeswitch.org + +- [[[tw-ts-001]]] TW-TS-001: Enhanced RTP transport of FR and EFR codec frames + in an IP-based GSM RAN + https://www.freecalypso.org/specs/tw-ts-001-v010100.txt +- [[[tw-ts-002]]] TW-TS-002: Enhanced RTP transport of HRv1 codec frames + in an IP-based GSM RAN + https://www.freecalypso.org/specs/tw-ts-002-v010100.txt +- [[[tw-ts-003]]] TW-TS-003: BSSMAP extension for selection of enhanced RTP + transport formats + https://www.freecalypso.org/specs/tw-ts-003-v010002.txt +- [[[tw-ts-005]]] TW-TS-005: Hexadecimal file format for sequences of RTP + payloads for GSM speech codecs + https://www.freecalypso.org/specs/tw-ts-005-v010003.txt -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ia34a61b5f834f2c70f81012dcc816dd6014c784f Gerrit-Change-Number: 39289 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

2026

2025

2024

2023

2022

gerrit-log