- gerrit-log - lists.osmocom.org

[XS] Change in osmo-mgw[master]: mgw: Move several params setting to mgcp_rtp_end_init()
by daniel 14 Jan '25

14 Jan '25

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39220?usp=email ) Change subject: mgw: Move several params setting to mgcp_rtp_end_init() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39220?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I38e2cfbe03c1e2de48e48f30a04af746bc2368a4 Gerrit-Change-Number: 39220 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 15:25:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-mgw[master]: mgw: Move force_ptime logic outside of main CRCX func handler
by daniel 14 Jan '25

14 Jan '25

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39217?usp=email ) Change subject: mgw: Move force_ptime logic outside of main CRCX func handler ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39217?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I02a92a090887caa8e05917a44c8b2351fa7b9b50 Gerrit-Change-Number: 39217 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 15:24:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-mgw[master]: mgw: Cleanup rtp_endp fields in its own function
by daniel 14 Jan '25

14 Jan '25

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39216?usp=email ) Change subject: mgw: Cleanup rtp_endp fields in its own function ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39216?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I0b2ccb94129dc7aed6fe13bb20f9910a53d8a41e Gerrit-Change-Number: 39216 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 15:21:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-mgw[master]: mgw: Introduce struct mgcp_codecset struct
by daniel 14 Jan '25

14 Jan '25

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39215?usp=email ) Change subject: mgw: Introduce struct mgcp_codecset struct ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39215?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id7db7ab01d56b7fa2415123b604375e48c82ab25 Gerrit-Change-Number: 39215 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 15:20:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: nokia_site: add object_type, object_state and reset_type
by csaba.sipos 14 Jan '25

14 Jan '25

csaba.sipos has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email ) Change subject: nokia_site: add object_type, object_state and reset_type ...................................................................... nokia_site: add object_type, object_state and reset_type Change-Id: I0f31cd711768c963e5c14c0f4969ff76cb05c12b --- M src/osmo-bsc/bts_nokia_site.c 1 file changed, 51 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/15/39315/1 diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c index 256b49f..1626886 100644 --- a/src/osmo-bsc/bts_nokia_site.c +++ b/src/osmo-bsc/bts_nokia_site.c @@ -598,6 +598,57 @@ return get_value_string(nokia_severity, severity); } +static const struct value_string nokia_object_type[] = { + { 0x01, "BCF" }, /* Base Control Function */ + { 0x02, "OMU" }, /* Operation and Maintenance Unit */ + { 0x04, "TRX" }, /* Transceiver (FU + CU) */ + { 0x05, "BTS" }, /* Base Transceiver Station (1..248) */ + { 0x07, "FU" }, /* Frame Unit */ + { 0x08, "CU" }, /* Carrier Unit */ + { 0x10, "TRE" }, /* Transmission Equipment (0..15) */ + { 0x11, "TRU" }, /* Transmission Unit */ + { 0x13, "RTSL" }, /* Radio Timeslot of a FU (0..7) */ + { 0x14, "DMR" }, /* Digital Microwave Radio Link */ + { 0x15, "CF" }, /* Conversion Function */ + { 0x64, "RTC" }, /* Remote Tune Combiner */ + { 0, NULL } +}; + +static const char *get_object_type_string(uint8_t object_type) +{ + return get_value_string(nokia_object_type, object_type); +} + +static const struct value_string nokia_object_state[] = { + { 0x0, "Enabled" }, + { 0x1, "Disabled" }, + { 0x2, "Locked" }, + { 0x3, "Unlocked" }, + { 0x4, "Shutdown" }, /* reserved for BTS MMI use */ + { 0x5, "Powersave" }, /* reserved for BTS MMI use */ + { 0, NULL } +}; + +static const char *get_object_state_string(uint8_t object_state) +{ + return get_value_string(nokia_object_state, object_state); +} + +static const struct value_string nokia_reset_type[] = { + { 0, "OMU reset" }, /* BTS is still able to carry traffic */ + { 1, "Site reset" }, + { 2, "reserved" }, + { 3, "Autoconfiguration site reset" }, + { 4, "MetroSite VTGA reset" }, + { 5, "Total reset" }, /* Complete reset of Packet Abis BTS and Conversion Function reset */ + { 0, NULL } +}; + +static const char *get_reset_type_string(uint8_t reset_type) +{ + return get_value_string(nokia_reset_type, reset_type); +} + /* TODO: put in a separate file ? */ /* some message IDs */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f31cd711768c963e5c14c0f4969ff76cb05c12b Gerrit-Change-Number: 39315 Gerrit-PatchSet: 1 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu>

1 0

[M] Change in osmo-ttcn3-hacks[master]: RFC: add support to create a shallow copy
by lynxis lazus 14 Jan '25

14 Jan '25

Attention is currently required from: osmith. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39234?usp=email ) Change subject: RFC: add support to create a shallow copy ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Thanks for making this! […] The motivation for this is: "my source tree shouldn't be touched by osmo-dev at all". Also security wise I don't like it can modify my tree. You need a autoreconf -fi/compile anyway, because the docker and my system might (and are) complete different. This also is a problem, because autoconf have a problem, if I build in-tree. Changing to cmake seems to be much bigger work than this. Maybe "shallow" is the wrong word. In OpenWrt this feature is call git-src tree override, which allows ignoring the source.tar.gz of a package. Yes, it doesn't track uncommitted changes, but IMHO, this is ok, as long it is clear. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39234?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0f1ac8852218f158ece14c176f05574f60d9d1f7 Gerrit-Change-Number: 39234 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 15:13:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-mgw[master]: mgw: Introduce mgcp_rtp_end_init()
by daniel 14 Jan '25

14 Jan '25

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39214?usp=email ) Change subject: mgw: Introduce mgcp_rtp_end_init() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39214?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I29f57dfde60e3134f1db422dc63e7c58d3db7d54 Gerrit-Change-Number: 39214 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 15:02:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-mgw[master]: mgw: Split mgcp_rtp_end to its own file
by daniel 14 Jan '25

14 Jan '25

Attention is currently required from: neels, pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39213?usp=email ) Change subject: mgw: Split mgcp_rtp_end to its own file ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39213?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id1b6cab57e44ad4859bde8212d0ac9f7146d7198 Gerrit-Change-Number: 39213 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 15:01:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-msc[master]: vlr: add PS support
by daniel 14 Jan '25

14 Jan '25

Attention is currently required from: laforge, lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email ) Change subject: vlr: add PS support ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 Gerrit-Change-Number: 38490 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 14 Jan 2025 14:44:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: RFC: add support to create a shallow copy
by osmith 14 Jan '25

14 Jan '25

Attention is currently required from: lynxis lazus. osmith has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39234?usp=email ) Change subject: RFC: add support to create a shallow copy ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: Thanks for making this! As I understand, the purpose is avoiding configure's error that one must run `make distclean` before being able to do an out-of-tree build with osmo-dev/testenv, if one ran `autoreconf -fi && ./configure` inside the source tree before (prepared an in-tree build)? If that is the case, then this is something I'd like to avoid as well and it seems in any case that patch would allow this. If not, then please explain what your motivation for this is :) > I think ttcn-hacks are still required to mount writeable, but we could also use such shallow copy for it as well. The source files from osmo-ttcn3-hacks [get copied to a cache directory with rsync](https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks/src/commit/d05a3a0e… (without deleting existing target files, so it keeps already built binary objects, and with excluding the .git dir). This happens outside of podman, and then only the cache directory gets mounted when running podman. This is mostly a workaround because we can't do an out-of-tree build with the current osmo-ttcn3-hacks buildsystem (and if we did another in-tree build then we would have potentially incompatible binary objects from compiling in podman vs. outside of podman). But this also has the effect that the source directory is not touched at all, like a read-only option. > Should I follow and add an argument for the main program? It would be also possible to use this without podman, however i'm using it with podman. I would prefer if we make this the default instead of opt-in (to avoid the "make distclean" error by default). But this also requires that it doesn't behave unexpected for users in other ways, some problems I currently see: * This does not handle dirty trees (modified/added/removed files that are not committed). Maybe it would make sense to add similar rsync logic instead, so this is handled as well? * I suggest we make it so that it runs on only exactly on the repositories we currently need for a build instead of all repositories. Also it shouldn't break when osmo-dev has just cloned a new repository because the user is building a project for which the git repos were not cloned yet. Therefore I think this logic needs to be moved to osmo-dev, as optional extra step before running `autoreconf -fi` / `configure` / compiling sources for each repository. testenv would then call osmo-dev with an argument to enable this feature. * (I found the term shallow copy for this a bit confusing, as I understand it usually means using [git clone --depth=](https://git-scm.com/docs/git-clone#Documentation/git-clone.txt-code--depthltdepthgtcode)) @lynxis@fe80.eu: so did I understand the motivation for this patch right and do you agree with my suggestion for moving this to osmo-dev etc.? If you prefer, I could also take this over. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39234?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0f1ac8852218f158ece14c176f05574f60d9d1f7 Gerrit-Change-Number: 39234 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 14 Jan 2025 14:38:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log