Attention is currently required from: laforge.
osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ci/+/39333?usp=email )
Change subject: ansible: build5-deb12build is also a coverity builder
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I'll merge these for fixing https://osmocom.org/issues/6702 on top
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39333?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Id9d35658197409bcaba3e267cab36d7aa2a28972
Gerrit-Change-Number: 39333
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 15 Jan 2025 15:20:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: csaba.sipos.
pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email )
Change subject: nokia_site: add object_type, object_state and reset_type
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Hi Pau, […]
Put it together in the same patch with the code using it.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I0f31cd711768c963e5c14c0f4969ff76cb05c12b
Gerrit-Change-Number: 39315
Gerrit-PatchSet: 1
Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu>
Gerrit-Comment-Date: Wed, 15 Jan 2025 15:20:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: csaba.sipos <metro4(a)freemail.hu>
csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email )
Change subject: nokia_site: add object_type, object_state and reset_type
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Hi Pau,
The only warning Jenkins gave is that the newly added functions are not used. Which is correct as this commit only adds these elements, related functions are coming later.
What should I do? Keep it like this and then this can be reviewed and merged, or I can also revoke this commit and add everything together later. Although I think it is better to keep these patches small and separate.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I0f31cd711768c963e5c14c0f4969ff76cb05c12b
Gerrit-Change-Number: 39315
Gerrit-PatchSet: 1
Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 15 Jan 2025 15:13:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: laforge, pespin.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-pcap/+/39323?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: server: Split buffer read from full msg handling
......................................................................
server: Split buffer read from full msg handling
This also simplifies follow-up patches modifying the way we read
packets through osmo_stream.
Change-Id: Ie7b8af0edbccc83812a44c6bfd61c98fbc3df324
---
M src/osmo_server_network.c
1 file changed, 37 insertions(+), 28 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/23/39323/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39323?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: Ie7b8af0edbccc83812a44c6bfd61c98fbc3df324
Gerrit-Change-Number: 39323
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39339?usp=email )
Change subject: jobs/gerrit: build libosmo-netif for centos7
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39339?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ie39f375152e8000c4e34bddd591c2c1ea91f9765
Gerrit-Change-Number: 39339
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 15 Jan 2025 15:08:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes