- gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[pespin/rel-1.10.0]: osmo_io: Increase default queue max_length from 32 to 1024
by pespin 16 Jan '25

16 Jan '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39346?usp=email ) Change subject: osmo_io: Increase default queue max_length from 32 to 1024 ...................................................................... osmo_io: Increase default queue max_length from 32 to 1024 The default value is way too low, and can be hit easily by apps submitting several messages in one main loop run. This is the case for instance of the Abis OML protocol, where a cascade of "State Changed Event Reports" are sent for the whole object tree. Set the default to a saner bigger value. In the end, increasing the value doesn't hurt normal use of apps, and 1024 is still a fairly small number to avoid the app eating the whole system memory if something unexpected happens. Change-Id: I92d5369af523f6297d45d4b534bb0f349ae74485 (cherry picked from commit 9cbc92e80e8a70131851b363c4438c216e559335) --- M src/core/osmo_io.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified neels: Looks good to me, but someone else must approve diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index af096e6..98d8ef3 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -637,7 +637,7 @@ * The created osmo_io_fd is initialized with some default settings: * * msgb allocations size: OSMO_IO_DEFAULT_MSGB_SIZE (1024) * * msgb headroom: OSMO_IO_DEFAULT_MSGB_HEADROOM (128) - * * tx_queue depth: 32 + * * tx_queue depth: 1024 * * Those values may be adjusted from their defaults by using osmo_iofd_set_alloc_info() and * osmo_iofd_set_txqueue_max_length() on the osmo_io_fd. @@ -696,7 +696,7 @@ iofd->msgb_alloc.size = OSMO_IO_DEFAULT_MSGB_SIZE; iofd->msgb_alloc.headroom = OSMO_IO_DEFAULT_MSGB_HEADROOM; - iofd->tx_queue.max_length = 32; + iofd->tx_queue.max_length = 1024; INIT_LLIST_HEAD(&iofd->tx_queue.msg_queue); return iofd; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39346?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: pespin/rel-1.10.0 Gerrit-Change-Id: I92d5369af523f6297d45d4b534bb0f349ae74485 Gerrit-Change-Number: 39346 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in pysim[master]: global_platform: add new command "install_cap"
by laforge 16 Jan '25

16 Jan '25

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39199?usp=email ) Change subject: global_platform: add new command "install_cap" ...................................................................... Patch Set 6: (1 comment) File docs/shell.rst: https://gerrit.osmocom.org/c/pysim/+/39199/comment/44d70710_93c9fc65?usp=em… : PS6, Line 1058: ~~~~ does this work if the line is not as long as the word above it? I never tried... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6cbd37f0fad5579b20e83c27349bd5acc129e6d0 Gerrit-Change-Number: 39199 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Jan 2025 13:28:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in pysim[master]: global_platform: LOAD and INSTALL [for load] support
by laforge 16 Jan '25

16 Jan '25

Attention is currently required from: dexter. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37454?usp=email ) Change subject: global_platform: LOAD and INSTALL [for load] support ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37454?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I924aaeecbb3a72bdb65eefbff6135e4e9570579e Gerrit-Change-Number: 37454 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Jan 2025 13:27:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-msc[master]: vlr: add PS support
by neels 16 Jan '25

16 Jan '25

Attention is currently required from: laforge, lynxis lazus, pespin. neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email ) Change subject: vlr: add PS support ...................................................................... Patch Set 5: (2 comments) File src/libvlr/vlr_lu_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/c5303c2f_54ae6b9a?usp… : PS5, Line 357: int N; /*! counter of timeouts */ > I would like to have it in osmo_fsm. […] N is a good name IMO https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/2ffd4493_c0fe73a7?usp… : PS5, Line 771: /*! count times timer T timed out */ > (maybe: "count nr of times that timer... […] . -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 Gerrit-Change-Number: 38490 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 16 Jan 2025 13:26:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ci[master]: ansible/hosts: add comments with usage hints
by osmith 16 Jan '25

16 Jan '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39356?usp=email ) Change subject: ansible/hosts: add comments with usage hints ...................................................................... ansible/hosts: add comments with usage hints When adding build5, these steps were not intuitive so add some documentation hints about them. Change-Id: I7b9c14db47d747dab4d96464ab67f4bec5cf9b7a --- M ansible/hosts 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/ansible/hosts b/ansible/hosts index 57966d3..d8ed3fe 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -6,6 +6,7 @@ build4-deb12build-ansible ansible_host=2a01:4f8:121:200a::1:3 build5-deb12build-ansible ansible_host=2a01:4f8:140:926a::1:3 +# Add new x86_64 entries to [coverity_slaves] and [qemu] too! [jenkins_slaves] build4-deb12build-ansible ansible_host=2a01:4f8:121:200a::1:3 osmocom_jenkins_slave_fstrim=True docker_max_image_space="50 GB" build5-deb12build-ansible ansible_host=2a01:4f8:140:926a::1:3 osmocom_jenkins_slave_fstrim=True docker_max_image_space="50 GB" @@ -22,7 +23,9 @@ build5-obsworker ansible_host=2a01:4f8:140:926a::1:2 obs_worker_instances=8 obs_worker_jobs=8 lx2-1-obs-aarch64-1 ansible_host=2a02:8106:13:1e34:4e9:e7ff:fe97:fe92 obs_worker_instances=1 obs_worker_jobs=4 -# Need to have kvm inside lxc, see OS#5365 +# Need to have kvm inside lxc, see OS#5365. Make sure to disconnect and +# reconnect the jenkins agent after running this playbook, so its login session +# gets the kvm group! [qemu] build4-deb12build-ansible ansible_host=2a01:4f8:121:200a::1:3 build5-deb12build-ansible ansible_host=2a01:4f8:140:926a::1:3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39356?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7b9c14db47d747dab4d96464ab67f4bec5cf9b7a Gerrit-Change-Number: 39356 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: scripts/repo-install-test: add disconnect hint
by osmith 16 Jan '25

16 Jan '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39357?usp=email ) Change subject: scripts/repo-install-test: add disconnect hint ...................................................................... scripts/repo-install-test: add disconnect hint Add a hint that would have been useful when we set up build5. Change-Id: I208cacaaf4018dc3adf5c4b878147c19769381ff --- M scripts/repo-install-test.sh 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: neels: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/scripts/repo-install-test.sh b/scripts/repo-install-test.sh index 66604f6..9345876 100755 --- a/scripts/repo-install-test.sh +++ b/scripts/repo-install-test.sh @@ -173,6 +173,14 @@ echo "Contents of $LOG_FILE:" echo cat "$LOG_FILE" + echo + echo "---" + echo "NOTE: If you have just set up a new jenkins node, and get the" + echo "error 'Could not access KVM kernel module: Permission denied'," + echo "then you probably need to disconnect jenkins, connect it again" + echo "and retry." + echo "---" + echo } qemu_ssh_wait() { -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39357?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I208cacaaf4018dc3adf5c4b878147c19769381ff Gerrit-Change-Number: 39357 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-ci[master]: scripts/{manuals,tarballs}: skip old sigtran tags
by osmith 16 Jan '25

16 Jan '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39358?usp=email ) Change subject: scripts/{manuals,tarballs}: skip old sigtran tags ...................................................................... scripts/{manuals,tarballs}: skip old sigtran tags After the old libosmo-sccp.git tags have been imported into libosmo-sigtran.git, they now need to be ignored in the manuals and release tarballs job. Related: OS#6683 Change-Id: Ia182f79ba3f0a80b98af3c1c77a1390f5d08ca93 --- M scripts/manuals/publish-manuals-for-tags.sh M scripts/tarballs/publish-tarballs-for-tags.sh 2 files changed, 60 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/scripts/manuals/publish-manuals-for-tags.sh b/scripts/manuals/publish-manuals-for-tags.sh index 77ad3d2..902019b 100755 --- a/scripts/manuals/publish-manuals-for-tags.sh +++ b/scripts/manuals/publish-manuals-for-tags.sh @@ -195,6 +195,36 @@ libosmo-sccp:1.1.0, libosmo-sccp:1.2.0, + libosmo-sigtran:0.0.1, + libosmo-sigtran:0.0.2, + libosmo-sigtran:0.0.3, + libosmo-sigtran:0.0.4, + libosmo-sigtran:0.0.5, + libosmo-sigtran:0.0.5.1, + libosmo-sigtran:0.0.6, + libosmo-sigtran:0.0.6.1, + libosmo-sigtran:0.0.6.2, + libosmo-sigtran:0.0.6.3, + libosmo-sigtran:0.10.0, + libosmo-sigtran:0.7.0, + libosmo-sigtran:0.8.0, + libosmo-sigtran:0.8.1, + libosmo-sigtran:0.9.0, + libosmo-sigtran:1.0.0, + libosmo-sigtran:1.1.0, + libosmo-sigtran:1.2.0, + libosmo-sigtran:1.2.1, + libosmo-sigtran:1.3.0, + libosmo-sigtran:1.4.0, + libosmo-sigtran:1.5.0, + libosmo-sigtran:1.6.0, + libosmo-sigtran:1.7.0, + libosmo-sigtran:1.7.1, + libosmo-sigtran:1.8.0, + libosmo-sigtran:1.8.1, + libosmo-sigtran:1.8.2, + libosmo-sigtran:1.9.0, + osmo-trx:0.2.0, osmo-trx:0.3.0, osmo-trx:0.4.0, diff --git a/scripts/tarballs/publish-tarballs-for-tags.sh b/scripts/tarballs/publish-tarballs-for-tags.sh index 0335bd3..e4ca1c8 100755 --- a/scripts/tarballs/publish-tarballs-for-tags.sh +++ b/scripts/tarballs/publish-tarballs-for-tags.sh @@ -115,6 +115,36 @@ libosmo-sccp-legacy:2.0.0, libosmo-sccp-legacy:2.0.1, libosmo-sccp-legacy:2.0.2, + + libosmo-sigtran:0.0.1, + libosmo-sigtran:0.0.2, + libosmo-sigtran:0.0.3, + libosmo-sigtran:0.0.4, + libosmo-sigtran:0.0.5, + libosmo-sigtran:0.0.5.1, + libosmo-sigtran:0.0.6, + libosmo-sigtran:0.0.6.1, + libosmo-sigtran:0.0.6.2, + libosmo-sigtran:0.0.6.3, + libosmo-sigtran:0.10.0, + libosmo-sigtran:0.7.0, + libosmo-sigtran:0.8.0, + libosmo-sigtran:0.8.1, + libosmo-sigtran:0.9.0, + libosmo-sigtran:1.0.0, + libosmo-sigtran:1.1.0, + libosmo-sigtran:1.2.0, + libosmo-sigtran:1.2.1, + libosmo-sigtran:1.3.0, + libosmo-sigtran:1.4.0, + libosmo-sigtran:1.5.0, + libosmo-sigtran:1.6.0, + libosmo-sigtran:1.7.0, + libosmo-sigtran:1.7.1, + libosmo-sigtran:1.8.0, + libosmo-sigtran:1.8.1, + libosmo-sigtran:1.8.2, + libosmo-sigtran:1.9.0, " mkdir -p \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39358?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia182f79ba3f0a80b98af3c1c77a1390f5d08ca93 Gerrit-Change-Number: 39358 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-mgw[master]: mgw: MDCX: Simplify early return code paths
by neels 16 Jan '25

16 Jan '25

Attention is currently required from: daniel, laforge, pespin. neels has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39250?usp=email ) Change subject: mgw: MDCX: Simplify early return code paths ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39250?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icb03a95e34e0c7d9396fefc2e37ee33ab09daa89 Gerrit-Change-Number: 39250 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Jan 2025 13:00:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: ansible/hosts: add comments with usage hints
by neels 16 Jan '25

16 Jan '25

Attention is currently required from: osmith, pespin. neels has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39356?usp=email ) Change subject: ansible/hosts: add comments with usage hints ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39356?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7b9c14db47d747dab4d96464ab67f4bec5cf9b7a Gerrit-Change-Number: 39356 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Jan 2025 12:57:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: scripts/repo-install-test: add disconnect hint
by neels 16 Jan '25

16 Jan '25

Attention is currently required from: osmith. neels has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39357?usp=email ) Change subject: scripts/repo-install-test: add disconnect hint ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39357?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I208cacaaf4018dc3adf5c4b878147c19769381ff Gerrit-Change-Number: 39357 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Jan 2025 12:56:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log