- gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: osmo_io: segmentation: Remove unneeded impossible check
by pespin 16 Jan '25

16 Jan '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39360?usp=email ) Change subject: osmo_io: segmentation: Remove unneeded impossible check ...................................................................... osmo_io: segmentation: Remove unneeded impossible check The rc <= 0 case is already early returned above. Change-Id: I9316730aeaf7c7efd3ea8965ab43fa21f844260c --- M src/core/osmo_io.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/60/39360/1 diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 45aaef3..15703cf 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -343,7 +343,7 @@ do { pending = NULL; res = iofd_handle_segmentation(iofd, msg, &pending); - if (res != IOFD_SEG_ACT_DEFER || rc < 0) { + if (res != IOFD_SEG_ACT_DEFER) { iofd->io_ops.read_cb(iofd, rc, msg); /* The user could unregister/close the iofd during read_cb() above. * Once that's done, it doesn't expect to receive any more events, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9316730aeaf7c7efd3ea8965ab43fa21f844260c Gerrit-Change-Number: 39360 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: cosmetic: osmo_io: Improvde documentation of read_cb when segmentatio...
by pespin 16 Jan '25

16 Jan '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39361?usp=email ) Change subject: cosmetic: osmo_io: Improvde documentation of read_cb when segmentation is used ...................................................................... cosmetic: osmo_io: Improvde documentation of read_cb when segmentation is used Change-Id: I93ac0b3224e17bfd1ecd4244a6dc7a44457c06e8 --- M include/osmocom/core/osmo_io.h M src/core/osmo_io.c 2 files changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/39361/1 diff --git a/include/osmocom/core/osmo_io.h b/include/osmocom/core/osmo_io.h index fa1f9c3..f4bfec4 100644 --- a/include/osmocom/core/osmo_io.h +++ b/include/osmocom/core/osmo_io.h @@ -98,7 +98,11 @@ * \param[in] iofd osmo_io_fd for which read() has completed. * \param[in] res return value of the read() call, or -errno in case of error. * \param[in] msg message buffer containing the read data. Ownership is transferred to the - * call-back, and it must make sure to msgb_free() it eventually! */ + * call-back, and it must make sure to msgb_free() it eventually! + * + * NOTE: If segmentation_cb is in use, the bytes read in res value + * may be different than those provided in the msg parameter! + */ void (*read_cb)(struct osmo_io_fd *iofd, int res, struct msgb *msg); /*! completion call-back function when write issued via osmo_iofd_write_msgb() has completed diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 15703cf..65c9b33 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -344,6 +344,9 @@ pending = NULL; res = iofd_handle_segmentation(iofd, msg, &pending); if (res != IOFD_SEG_ACT_DEFER) { + /* It it expected as per API spec that we return the + * return value of read here. The amount of bytes in msg is + * available to the user in msg itself. */ iofd->io_ops.read_cb(iofd, rc, msg); /* The user could unregister/close the iofd during read_cb() above. * Once that's done, it doesn't expect to receive any more events, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I93ac0b3224e17bfd1ecd4244a6dc7a44457c06e8 Gerrit-Change-Number: 39361 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-trx[master]: comma_delimited_to_vector() optimization CID#465430
by neels 16 Jan '25

16 Jan '25

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/39359?usp=email ) Change subject: comma_delimited_to_vector() optimization CID#465430 ...................................................................... comma_delimited_to_vector() optimization CID#465430 (I am not sure about this, just doing as coverity says.) Change-Id: I30e57c6a9df39552bc4f8c18d27bc421f5c60f49 --- M CommonLibs/Utils.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/59/39359/1 diff --git a/CommonLibs/Utils.cpp b/CommonLibs/Utils.cpp index 3ab598d..6703531 100644 --- a/CommonLibs/Utils.cpp +++ b/CommonLibs/Utils.cpp @@ -28,7 +28,7 @@ { std::string substr; getline(ss, substr, ','); - result.push_back(substr); + result.push_back(std::move(substr)); } return result; } -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/39359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I30e57c6a9df39552bc4f8c18d27bc421f5c60f49 Gerrit-Change-Number: 39359 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[M] Change in osmo-mgw[master]: mgw: Decouple SDP parsing step from conn obj update
by daniel 16 Jan '25

16 Jan '25

Attention is currently required from: laforge, pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39248?usp=email ) Change subject: mgw: Decouple SDP parsing step from conn obj update ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39248?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4a2aecb542886672c1f586c6607714e0356abe35 Gerrit-Change-Number: 39248 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Jan 2025 16:55:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: nokia_site: add reset_type attribute
by pespin 16 Jan '25

16 Jan '25

Attention is currently required from: csaba.sipos, laforge. pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email ) Change subject: nokia_site: add reset_type attribute ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f31cd711768c963e5c14c0f4969ff76cb05c12b Gerrit-Change-Number: 39315 Gerrit-PatchSet: 7 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 16 Jan 2025 16:49:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: nokia_site: add reset_type attribute
by csaba.sipos 16 Jan '25

16 Jan '25

Attention is currently required from: laforge, pespin. csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email ) Change subject: nokia_site: add reset_type attribute ...................................................................... Patch Set 7: (1 comment) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39315/comment/3b61cb89_d20cf7a8?usp… : PS5, Line 1721: } else > You didn't not set up the curly braches correctly... […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f31cd711768c963e5c14c0f4969ff76cb05c12b Gerrit-Change-Number: 39315 Gerrit-PatchSet: 7 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Jan 2025 15:53:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: nokia_site: add reset_type attribute
by csaba.sipos 16 Jan '25

16 Jan '25

Attention is currently required from: csaba.sipos, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: nokia_site: add reset_type attribute ...................................................................... nokia_site: add reset_type attribute Change-Id: I0f31cd711768c963e5c14c0f4969ff76cb05c12b --- M src/osmo-bsc/bts_nokia_site.c 1 file changed, 27 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/15/39315/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f31cd711768c963e5c14c0f4969ff76cb05c12b Gerrit-Change-Number: 39315 Gerrit-PatchSet: 7 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: nokia_site: add reset_type attribute
by Jenkins Builder 16 Jan '25

16 Jan '25

Attention is currently required from: csaba.sipos, laforge, pespin. Jenkins Builder has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email ) Change subject: nokia_site: add reset_type attribute ...................................................................... Patch Set 6: (2 comments) File src/osmo-bsc/bts_nokia_site.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21072): https://gerrit.osmocom.org/c/osmo-bsc/+/39315/comment/a02e19fd_88974d04?usp… : PS6, Line 1717: else { else should follow close brace '}' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21072): https://gerrit.osmocom.org/c/osmo-bsc/+/39315/comment/0bb50c5e_76e2e908?usp… : PS6, Line 1725: else { else should follow close brace '}' -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f31cd711768c963e5c14c0f4969ff76cb05c12b Gerrit-Change-Number: 39315 Gerrit-PatchSet: 6 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Jan 2025 15:45:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-bsc[master]: nokia_site: add reset_type attribute
by csaba.sipos 16 Jan '25

16 Jan '25

Attention is currently required from: csaba.sipos, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: nokia_site: add reset_type attribute ...................................................................... nokia_site: add reset_type attribute Change-Id: I0f31cd711768c963e5c14c0f4969ff76cb05c12b --- M src/osmo-bsc/bts_nokia_site.c 1 file changed, 29 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/15/39315/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f31cd711768c963e5c14c0f4969ff76cb05c12b Gerrit-Change-Number: 39315 Gerrit-PatchSet: 6 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-pcap[master]: server: Use osmo_stream_srv for non-tls read tcp sock
by pespin 16 Jan '25

16 Jan '25

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39343?usp=email ) Change subject: server: Use osmo_stream_srv for non-tls read tcp sock ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-pcap/+/39343/comment/078b174b_70d212d3?us… : PS2, Line 9: TLS handling adds a lot of complexity, so TLS sockets are still read : through the previous code paths, and conversion to osmo_stream_srv is : left as a future improvement. > one might even argue that osmo_stream itself should integrate the TLS support at some point, so that […] I spent some time at the start trying to already integrate the TLS stuff into the new osmo_stream backend, but the fact that I don't know the details about TLS and that the gnutls API is a bit cumbersome to work with (it expects to call a recv() or similar function even if it is implemented by a buffer) made me take the decision to delay it, otherwise I'd end up burning lots of hours with that. Also because I don't have a osmo-pcap TLS setup to test stuff in first place. I don't even know whether the TLS feature is expected to work, since I even see some TODOs regarding that feature, example in osmo-pcap.git/TODO... -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39343?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I537620fcad6c8e65206a41a1c21bd4b6453fbed4 Gerrit-Change-Number: 39343 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 16 Jan 2025 15:34:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log