- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: ATR: use lowercase hex strings without spaces as ATR constants
by laforge 03 Feb '25

03 Feb '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/39429?usp=email ) Change subject: ATR: use lowercase hex strings without spaces as ATR constants ...................................................................... ATR: use lowercase hex strings without spaces as ATR constants The ATR constants are the only hex string constants where the hex bytes digits are separated with spaces. Also the hex digits are in lowercase. Let's use a lowercase string without spaces here like we do in many other code locations. Related: OS#6322 Change-Id: I95118115b02523ed262a2fbe4369ace3996cd8f5 --- M pySim/legacy/cards.py M pySim/sysmocom_sja2.py 2 files changed, 19 insertions(+), 19 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/legacy/cards.py b/pySim/legacy/cards.py index 1f5db8a..ab69eed 100644 --- a/pySim/legacy/cards.py +++ b/pySim/legacy/cards.py @@ -781,7 +781,7 @@ def autodetect(kls, scc): try: # Look for ATR - if scc.get_atr() == toBytes("3B 99 18 00 11 88 22 33 44 55 66 77 60"): + if scc.get_atr() == toBytes("3b991800118822334455667760"): return kls(scc) except: return None @@ -826,7 +826,7 @@ def autodetect(kls, scc): try: # Look for ATR - if scc.get_atr() == toBytes("3B 7D 94 00 00 55 55 53 0A 74 86 93 0B 24 7C 4D 54 68"): + if scc.get_atr() == toBytes("3b7d9400005555530a7486930b247c4d5468"): return kls(scc) except: return None @@ -904,7 +904,7 @@ def autodetect(kls, scc): try: # Look for ATR - if scc.get_atr() == toBytes("3B 9F 96 80 1F C7 80 31 A0 73 BE 21 13 67 43 20 07 18 00 00 01 A5"): + if scc.get_atr() == toBytes("3b9f96801fc78031a073be21136743200718000001a5"): return kls(scc) except: return None @@ -1032,7 +1032,7 @@ def autodetect(kls, scc): try: # Look for ATR - if scc.get_atr() == toBytes("3B 9F 96 80 1F C7 80 31 A0 73 BE 21 13 67 44 22 06 10 00 00 01 A9"): + if scc.get_atr() == toBytes("3b9f96801fc78031a073be21136744220610000001a9"): return kls(scc) except: return None @@ -1166,7 +1166,7 @@ def autodetect(kls, scc): try: # Look for ATR - if scc.get_atr() == toBytes("3B 9F 95 80 1F C3 80 31 E0 73 FE 21 13 57 86 81 02 86 98 44 18 A8"): + if scc.get_atr() == toBytes("3b9f95801fc38031e073fe21135786810286984418a8"): return kls(scc) except: return None @@ -1215,7 +1215,7 @@ def autodetect(kls, scc): try: # Look for ATR - if scc.get_atr() == toBytes("3B 9F 95 80 1F C7 80 31 E0 73 F6 21 13 67 4D 45 16 00 43 01 00 8F"): + if scc.get_atr() == toBytes("3b9f95801fc78031e073f62113674d4516004301008f"): return kls(scc) except: return None @@ -1305,17 +1305,17 @@ def autodetect(kls, scc): try: # Try card model #1 - atr = "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 4C 75 30 34 05 4B A9" + atr = "3b9f96801f878031e073fe211b674a4c753034054ba9" if scc.get_atr() == toBytes(atr): return kls(scc) # Try card model #2 - atr = "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 4C 75 31 33 02 51 B2" + atr = "3b9f96801f878031e073fe211b674a4c7531330251b2" if scc.get_atr() == toBytes(atr): return kls(scc) # Try card model #3 - atr = "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 4C 52 75 31 04 51 D5" + atr = "3b9f96801f878031e073fe211b674a4c5275310451d5" if scc.get_atr() == toBytes(atr): return kls(scc) except: @@ -1554,15 +1554,15 @@ def autodetect(kls, scc): try: # Try card model #1 (9FJ) - atr = "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 35 75 30 35 02 51 CC" + atr = "3b9f96801f878031e073fe211b674a357530350251cc" if scc.get_atr() == toBytes(atr): return kls(scc) # Try card model #2 (SLM17) - atr = "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 35 75 30 35 02 65 F8" + atr = "3b9f96801f878031e073fe211b674a357530350265f8" if scc.get_atr() == toBytes(atr): return kls(scc) # Try card model #3 (9FV) - atr = "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 35 75 30 35 02 59 C4" + atr = "3b9f96801f878031e073fe211b674a357530350259c4" if scc.get_atr() == toBytes(atr): return kls(scc) except: @@ -1592,7 +1592,7 @@ def autodetect(cls, scc): try: # Look for ATR - if scc.get_atr() == toBytes('3B 9F 95 80 1F C7 80 31 A0 73 B6 A1 00 67 CF 32 15 CA 9C D7 09 20'): + if scc.get_atr() == toBytes('3b9f95801fc78031a073b6a10067cf3215ca9cd70920'): return cls(scc) except: return None diff --git a/pySim/sysmocom_sja2.py b/pySim/sysmocom_sja2.py index bef955a..c145f0f 100644 --- a/pySim/sysmocom_sja2.py +++ b/pySim/sysmocom_sja2.py @@ -298,9 +298,9 @@ class SysmocomSJA2(CardModel): - _atrs = ["3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 4C 75 30 34 05 4B A9", - "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 4C 75 31 33 02 51 B2", - "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 4C 52 75 31 04 51 D5"] + _atrs = ["3b9f96801f878031e073fe211b674a4c753034054ba9", + "3b9f96801f878031e073fe211b674a4c7531330251b2", + "3b9f96801f878031e073fe211b674a4c5275310451d5"] @classmethod def add_files(cls, rs: RuntimeState): @@ -329,9 +329,9 @@ isim_adf.add_files(files_adf_isim) class SysmocomSJA5(CardModel): - _atrs = ["3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 35 75 30 35 02 51 CC", - "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 35 75 30 35 02 65 F8", - "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 35 75 30 35 02 59 C4"] + _atrs = ["3b9f96801f878031e073fe211b674a357530350251cc", + "3b9f96801f878031e073fe211b674a357530350265f8", + "3b9f96801f878031e073fe211b674a357530350259c4"] @classmethod def add_files(cls, rs: RuntimeState): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39429?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95118115b02523ed262a2fbe4369ace3996cd8f5 Gerrit-Change-Number: 39429 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: ATR: align get_atr() return value type
by laforge 03 Feb '25

03 Feb '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/39293?usp=email ) Change subject: ATR: align get_atr() return value type ...................................................................... ATR: align get_atr() return value type type annotations claimed the return type was Hexstr, but in reality it was a list of integers. Let's fix that. Change-Id: I01b247dad40ec986cf199302f8e92d16848bd499 Closes: OS#6322 --- M pySim-shell.py M pySim/filesystem.py M pySim/legacy/cards.py M pySim/runtime.py M pySim/transport/pcsc.py M pySim/transport/serial.py 6 files changed, 19 insertions(+), 21 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim-shell.py b/pySim-shell.py index d08dc21..9733b22 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -294,7 +294,7 @@ if self.rs is None: # In case no runtime state is available we go the direct route self.card._scc.reset_card() - atr = b2h(self.card._scc.get_atr()) + atr = self.card._scc.get_atr() else: atr = self.rs.reset(self) self.poutput('Card ATR: %s' % atr) diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 6e8852a..246afb0 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1530,8 +1530,7 @@ """Test if given card matches this model.""" card_atr = scc.get_atr() for atr in cls._atrs: - atr_bin = toBytes(atr) - if atr_bin == card_atr: + if atr == card_atr: print("Detected CardModel:", cls.__name__) return True return False diff --git a/pySim/legacy/cards.py b/pySim/legacy/cards.py index ab69eed..3a68e18 100644 --- a/pySim/legacy/cards.py +++ b/pySim/legacy/cards.py @@ -3,7 +3,6 @@ ################################################################################ import abc -from smartcard.util import toBytes from pytlv.TLV import * from pySim.cards import SimCardBase, UiccCardBase @@ -781,7 +780,7 @@ def autodetect(kls, scc): try: # Look for ATR - if scc.get_atr() == toBytes("3b991800118822334455667760"): + if scc.get_atr() == "3b991800118822334455667760": return kls(scc) except: return None @@ -826,7 +825,7 @@ def autodetect(kls, scc): try: # Look for ATR - if scc.get_atr() == toBytes("3b7d9400005555530a7486930b247c4d5468"): + if scc.get_atr() == "3b7d9400005555530a7486930b247c4d5468": return kls(scc) except: return None @@ -904,7 +903,7 @@ def autodetect(kls, scc): try: # Look for ATR - if scc.get_atr() == toBytes("3b9f96801fc78031a073be21136743200718000001a5"): + if scc.get_atr() == "3b9f96801fc78031a073be21136743200718000001a5": return kls(scc) except: return None @@ -1032,7 +1031,7 @@ def autodetect(kls, scc): try: # Look for ATR - if scc.get_atr() == toBytes("3b9f96801fc78031a073be21136744220610000001a9"): + if scc.get_atr() == "3b9f96801fc78031a073be21136744220610000001a9": return kls(scc) except: return None @@ -1166,7 +1165,7 @@ def autodetect(kls, scc): try: # Look for ATR - if scc.get_atr() == toBytes("3b9f95801fc38031e073fe21135786810286984418a8"): + if scc.get_atr() == "3b9f95801fc38031e073fe21135786810286984418a8": return kls(scc) except: return None @@ -1215,7 +1214,7 @@ def autodetect(kls, scc): try: # Look for ATR - if scc.get_atr() == toBytes("3b9f95801fc78031e073f62113674d4516004301008f"): + if scc.get_atr() == "3b9f95801fc78031e073f62113674d4516004301008f": return kls(scc) except: return None @@ -1306,17 +1305,17 @@ try: # Try card model #1 atr = "3b9f96801f878031e073fe211b674a4c753034054ba9" - if scc.get_atr() == toBytes(atr): + if scc.get_atr() == atr: return kls(scc) # Try card model #2 atr = "3b9f96801f878031e073fe211b674a4c7531330251b2" - if scc.get_atr() == toBytes(atr): + if scc.get_atr() == atr: return kls(scc) # Try card model #3 atr = "3b9f96801f878031e073fe211b674a4c5275310451d5" - if scc.get_atr() == toBytes(atr): + if scc.get_atr() == atr: return kls(scc) except: return None @@ -1555,15 +1554,15 @@ try: # Try card model #1 (9FJ) atr = "3b9f96801f878031e073fe211b674a357530350251cc" - if scc.get_atr() == toBytes(atr): + if scc.get_atr() == atr: return kls(scc) # Try card model #2 (SLM17) atr = "3b9f96801f878031e073fe211b674a357530350265f8" - if scc.get_atr() == toBytes(atr): + if scc.get_atr() == atr: return kls(scc) # Try card model #3 (9FV) atr = "3b9f96801f878031e073fe211b674a357530350259c4" - if scc.get_atr() == toBytes(atr): + if scc.get_atr() == atr: return kls(scc) except: return None @@ -1592,7 +1591,7 @@ def autodetect(cls, scc): try: # Look for ATR - if scc.get_atr() == toBytes('3b9f95801fc78031a073b6a10067cf3215ca9cd70920'): + if scc.get_atr() == '3b9f95801fc78031a073b6a10067cf3215ca9cd70920': return cls(scc) except: return None diff --git a/pySim/runtime.py b/pySim/runtime.py index 3e48f75..ec19cb4 100644 --- a/pySim/runtime.py +++ b/pySim/runtime.py @@ -141,7 +141,7 @@ continue del self.lchan[lchan_nr] self.adm_verified = False - atr = i2h(self.card.reset()) + atr = self.card.reset() if cmd_app: cmd_app.lchan = self.lchan[0] # select MF to reset internal state and to verify card really works diff --git a/pySim/transport/pcsc.py b/pySim/transport/pcsc.py index bb820ed..adac6ee 100644 --- a/pySim/transport/pcsc.py +++ b/pySim/transport/pcsc.py @@ -103,7 +103,7 @@ raise NoCardError() from exc def get_atr(self) -> Hexstr: - return self._con.getATR() + return i2h(self._con.getATR()) def disconnect(self): self._con.disconnect() diff --git a/pySim/transport/serial.py b/pySim/transport/serial.py index 938c319..658943b 100644 --- a/pySim/transport/serial.py +++ b/pySim/transport/serial.py @@ -21,7 +21,7 @@ import argparse from typing import Optional import serial -from osmocom.utils import h2b, b2h, Hexstr +from osmocom.utils import h2b, b2h, i2h, Hexstr from pySim.exceptions import NoCardError, ProtocolError from pySim.transport import LinkBaseTpdu @@ -96,7 +96,7 @@ self.reset_card() def get_atr(self) -> Hexstr: - return self._atr + return i2h(self._atr) def disconnect(self): pass # Nothing to do really ... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39293?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01b247dad40ec986cf199302f8e92d16848bd499 Gerrit-Change-Number: 39293 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim/transport: add abstract get_atr method to LinkBase
by laforge 03 Feb '25

03 Feb '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/39424?usp=email ) Change subject: pySim/transport: add abstract get_atr method to LinkBase ...................................................................... pySim/transport: add abstract get_atr method to LinkBase The implementations that inheret from the LinkBase class are expected to implement a get_atr method. This method is mandatory, since it is one of the most basic functionalities of pySim to display an ATR. Also the ATR is sometimes needed to distinguish between different card models. The modem_atcmd and calypso implementation completely lack the get_atr method. Apparantly it is not possible to get an ATR in those environments, so lets add a dummy method there. Related: OS#6322 Change-Id: I4fc020ca45658af78e495a5c1b985213f83cbb50 --- M pySim/transport/__init__.py M pySim/transport/calypso.py M pySim/transport/modem_atcmd.py 3 files changed, 11 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py index 8055306..5b0ee07 100644 --- a/pySim/transport/__init__.py +++ b/pySim/transport/__init__.py @@ -120,6 +120,11 @@ """ @abc.abstractmethod + def get_atr(self) -> Hexstr: + """Retrieve card ATR + """ + + @abc.abstractmethod def disconnect(self): """Disconnect from card """ diff --git a/pySim/transport/calypso.py b/pySim/transport/calypso.py index fa3a9f2..f28e40c 100644 --- a/pySim/transport/calypso.py +++ b/pySim/transport/calypso.py @@ -123,6 +123,9 @@ def connect(self): self.reset_card() + def get_atr(self) -> Hexstr: + return "3b00" # Dummy ATR + def disconnect(self): pass # Nothing to do really ... diff --git a/pySim/transport/modem_atcmd.py b/pySim/transport/modem_atcmd.py index e7614c0..440ec77 100644 --- a/pySim/transport/modem_atcmd.py +++ b/pySim/transport/modem_atcmd.py @@ -139,6 +139,9 @@ def connect(self): pass # Nothing to do really ... + def get_atr(self) -> Hexstr: + return "3b00" # Dummy ATR + def disconnect(self): pass # Nothing to do really ... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39424?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4fc020ca45658af78e495a5c1b985213f83cbb50 Gerrit-Change-Number: 39424 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: pySim/transport: add abstract get_atr method to LinkBase
by laforge 03 Feb '25

03 Feb '25

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39424?usp=email ) Change subject: pySim/transport: add abstract get_atr method to LinkBase ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39424?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4fc020ca45658af78e495a5c1b985213f83cbb50 Gerrit-Change-Number: 39424 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Feb 2025 19:11:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: ATR: align get_atr() return value type
by laforge 03 Feb '25

03 Feb '25

Attention is currently required from: dexter. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/39293?usp=email ) Change subject: ATR: align get_atr() return value type ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39293?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01b247dad40ec986cf199302f8e92d16848bd499 Gerrit-Change-Number: 39293 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Feb 2025 19:11:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in upf-benchmark[master]: trex-tunmap: Increase test params to 100k sessions
by laforge 03 Feb '25

03 Feb '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/39458?usp=email ) Change subject: trex-tunmap: Increase test params to 100k sessions ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/39458?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: I8fa40b2d796b74a23d23e88a925626d6f9fff94b Gerrit-Change-Number: 39458 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Feb 2025 19:11:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in upf-benchmark[master]: trex-tunmap: Introduce setup to test osmo-upf with TRex
by laforge 03 Feb '25

03 Feb '25

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/39457?usp=email ) Change subject: trex-tunmap: Introduce setup to test osmo-upf with TRex ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/39457?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: If27d7f4e7a92d14377192eecbf77ab18d1d1032c Gerrit-Change-Number: 39457 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Feb 2025 19:11:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-pfcp[master]: Use hashtable to look up req/resp by seq_nr
by laforge 03 Feb '25

03 Feb '25

Attention is currently required from: neels, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/39456?usp=email ) Change subject: Use hashtable to look up req/resp by seq_nr ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/39456?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I1b7138206ed035bed3d266f713ce1dd62cbe7286 Gerrit-Change-Number: 39456 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Feb 2025 19:10:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta...
by laforge 03 Feb '25

03 Feb '25

Attention is currently required from: csaba.sipos, fixeria. laforge has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email ) Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 5 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Feb 2025 19:10:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-pfcp[master]: Use hashtable to look up req/resp by seq_nr
by fixeria 03 Feb '25

03 Feb '25

Attention is currently required from: neels, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/39456?usp=email ) Change subject: Use hashtable to look up req/resp by seq_nr ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/39456?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I1b7138206ed035bed3d266f713ce1dd62cbe7286 Gerrit-Change-Number: 39456 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Feb 2025 14:52:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log