pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39484?usp=email )
Change subject: MGCP_Emulation: Make sure peer is running before Tx
......................................................................
MGCP_Emulation: Make sure peer is running before Tx
This avoid DTE with "Broken pipe" if messages are being transmitted
while tear down process has already started, even if components are
created as "alive".
Change-Id: I8724870b9b967ffa49c3da03e1cdb2941f81653a
---
M library/MGCP_Emulation.ttcn
1 file changed, 10 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
diff --git a/library/MGCP_Emulation.ttcn b/library/MGCP_Emulation.ttcn
index 3167579..7106f63 100644
--- a/library/MGCP_Emulation.ttcn
+++ b/library/MGCP_Emulation.ttcn
@@ -252,9 +252,17 @@
private function f_forward_to_client(MGCP_RecvFrom mrf, MGCP_ConnHdlr vc_conn) runs on MGCP_Emulation_CT {
if (g_pars.multi_conn_mode) {
- MGCP_CLIENT_MULTI.send(mrf) to vc_conn;
+ if (MGCP_CLIENT_MULTI.checkstate("Connected") and vc_conn.running) {
+ MGCP_CLIENT_MULTI.send(mrf) to vc_conn;
+ } else {
+ log("MGCP_CLIENT_MULTI: Discarding msg due to peer unavailable: ", mrf);
+ }
} else {
- MGCP_CLIENT.send(mrf.msg.command) to vc_conn;
+ if (MGCP_CLIENT.checkstate("Connected") and vc_conn.running) {
+ MGCP_CLIENT.send(mrf.msg.command) to vc_conn;
+ } else {
+ log("MGCP_CLIENT: Discarding msg due to peer unavailable: ", mrf);
+ }
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39484?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8724870b9b967ffa49c3da03e1cdb2941f81653a
Gerrit-Change-Number: 39484
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39484?usp=email )
Change subject: MGCP_Emulation: Make sure peer is running before Tx
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39484?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8724870b9b967ffa49c3da03e1cdb2941f81653a
Gerrit-Change-Number: 39484
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 07 Feb 2025 12:21:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39484?usp=email )
Change subject: MGCP_Emulation: Make sure peer is running before Tx
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I'm not sure where the "peer" terminology comes from. […]
I meant peer as in generic "peer component", the ttcn3 component which we send the msg to through the ttcn3 port.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39484?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8724870b9b967ffa49c3da03e1cdb2941f81653a
Gerrit-Change-Number: 39484
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 07 Feb 2025 12:19:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: fixeria, laforge, osmith, pespin.
Hello Jenkins Builder, laforge, osmith, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: Add GSMTAP logging handler
......................................................................
Add GSMTAP logging handler
This patch integrates a logging handler [1][2] for Erlang's built-in
logger. It sends logging messages via GSMTAP (udp/4729), allowing
capture of log messages alongside with other PDUs (S1AP, PFCP)
sent/received by the gateway.
The new handler is added to the example configuration, sending
all logging messages (DEBUG and above) to 127.0.0.1 by default.
[1] https://www.erlang.org/doc/apps/kernel/logger_handler.html
[2] https://gitea.osmocom.org/erlang/logger_gsmtap
Change-Id: Iea884e2ca146b852c64bd9f135d8c71f4c925f09
---
M config/sys.config
M rebar.config
M rebar.lock
M src/osmo_s1gw.app.src
4 files changed, 15 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/15/39415/7
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Iea884e2ca146b852c64bd9f135d8c71f4c925f09
Gerrit-Change-Number: 39415
Gerrit-PatchSet: 7
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>