- gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_retransmit
by lynxis lazus 10 Feb '25

10 Feb '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255?usp=email ) Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_retransmit ...................................................................... Patch Set 4: Code-Review+2 (4 comments) Patchset: PS4: 1+1=2 Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255/comment/535fbd15_6009… : PS3, Line 10: by "loosing" an ID Req message. > losing Done File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255/comment/0c588afa_0692… : PS3, Line 2125: /* send out a second GMM_Attach Request. > removed it. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255/comment/2168f4ca_3555… : PS3, Line 2125: /* send out a second GMM_Attach Request. > removed it. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d208c0a98675238dba439ab3e75758293928588 Gerrit-Change-Number: 39255 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Feb 2025 11:27:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in ...osmo-s1gw[master]: osmo_s1gw.app.src: set 'vsn' to 'semver'
by fixeria 10 Feb '25

10 Feb '25

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39490?usp=email ) Change subject: osmo_s1gw.app.src: set 'vsn' to 'semver' ...................................................................... osmo_s1gw.app.src: set 'vsn' to 'semver' This way the app version is automatically generated using git. Change-Id: I8a39e632556c75648cef0fb79f47e61043a4149a --- M src/osmo_s1gw.app.src 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_s1gw.app.src b/src/osmo_s1gw.app.src index 363d6d6..743a5d5 100644 --- a/src/osmo_s1gw.app.src +++ b/src/osmo_s1gw.app.src @@ -2,7 +2,7 @@ {application, osmo_s1gw, [ {description, "Osmocom S1AP Gateway"}, - {vsn, "1"}, + {vsn, semver}, {registered, []}, {applications, [ kernel, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8a39e632556c75648cef0fb79f47e61043a4149a Gerrit-Change-Number: 39490 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in ...osmo-s1gw[master]: rebar.config: cosmetic: use spaces, not tabs
by fixeria 10 Feb '25

10 Feb '25

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39491?usp=email ) Change subject: rebar.config: cosmetic: use spaces, not tabs ...................................................................... rebar.config: cosmetic: use spaces, not tabs Change-Id: Ia6a026b51a0219353b1e898d9fc643381e985dc7 --- M rebar.config 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/rebar.config b/rebar.config index e124ac4..0a62c76 100644 --- a/rebar.config +++ b/rebar.config @@ -41,9 +41,9 @@ {escript_name, "osmo-s1gw"}. {relx, [{release, {"osmo-s1gw", "0.2.0"}, [osmo_s1gw]}, - {sys_config, "./config/sys.config"}, - {dev_mode, true}, - {include_erts, false}, - {extended_start_script, true}]}. + {sys_config, "./config/sys.config"}, + {dev_mode, true}, + {include_erts, false}, + {extended_start_script, true}]}. %% vim:set ts=4 sw=4 et: -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ia6a026b51a0219353b1e898d9fc643381e985dc7 Gerrit-Change-Number: 39491 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in ...osmo-s1gw[master]: rebar.config: relx: generate the version automatically
by fixeria 10 Feb '25

10 Feb '25

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39493?usp=email ) Change subject: rebar.config: relx: generate the version automatically ...................................................................... rebar.config: relx: generate the version automatically Change-Id: I7a4ed74416d4eef3c3befc0605d1857e147324e7 --- M rebar.config 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/rebar.config b/rebar.config index b4fd1fd..0100f17 100644 --- a/rebar.config +++ b/rebar.config @@ -40,7 +40,7 @@ {escript_main_app, osmo_s1gw}. {escript_name, "osmo-s1gw"}. -{relx, [{release, {'osmo-s1gw', "0.2.0"}, [osmo_s1gw]}, +{relx, [{release, {'osmo-s1gw', semver}, [osmo_s1gw]}, {sys_config, "./config/sys.config"}, {dev_mode, true}, {include_erts, false}, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39493?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7a4ed74416d4eef3c3befc0605d1857e147324e7 Gerrit-Change-Number: 39493 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in ...osmo-s1gw[master]: rebar.config: relx: fix release name (must be an atom)
by fixeria 10 Feb '25

10 Feb '25

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39492?usp=email ) Change subject: rebar.config: relx: fix release name (must be an atom) ...................................................................... rebar.config: relx: fix release name (must be an atom) https://rebar3.org/docs/deployment/releases/ states it must be an atom. Change-Id: Ic788ebb1c78c890939bd8dfd9bc34b06fe5c26fd --- M rebar.config 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/rebar.config b/rebar.config index 0a62c76..b4fd1fd 100644 --- a/rebar.config +++ b/rebar.config @@ -40,7 +40,7 @@ {escript_main_app, osmo_s1gw}. {escript_name, "osmo-s1gw"}. -{relx, [{release, {"osmo-s1gw", "0.2.0"}, [osmo_s1gw]}, +{relx, [{release, {'osmo-s1gw', "0.2.0"}, [osmo_s1gw]}, {sys_config, "./config/sys.config"}, {dev_mode, true}, {include_erts, false}, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic788ebb1c78c890939bd8dfd9bc34b06fe5c26fd Gerrit-Change-Number: 39492 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Submit proper L3 PDUs during CR
by pespin 10 Feb '25

10 Feb '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39489?usp=email ) Change subject: hnbgw: Submit proper L3 PDUs during CR ...................................................................... hnbgw: Submit proper L3 PDUs during CR Generating random PDU values makes hnbgw act on it, since it looks up higher layers to figure out NRI steering. Change-Id: I725c35a3584b7d2d162c24ab2b662cfb80e539d7 Related: OS#6717 --- M hnbgw/ConnHdlr.ttcn 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index 47c25a7..efba060 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -493,7 +493,17 @@ var octetstring nas; if (pars.tx_sccp_cr_data_len == 0) { - nas := f_rnd_octstring(10); + var octetstring tmsi := f_gen_tmsi(suffix := 0); + var MobileIdentityLV mi_lv := valueof(ts_MI_IMSI_LV(pars.imsi)); + if (pars.ps_domain) { + var PDU_L3_MS_SGSN l3_pdu; + l3_pdu := valueof(ts_GMM_ATTACH_REQ(mi_lv, f_RAI('001'H, '01'H, '2a2a'O, '17'O))); + nas := enc_PDU_L3_MS_SGSN(l3_pdu); + } else { + var PDU_ML3_MS_NW l3_pdu; + l3_pdu := valueof(ts_LU_REQ(LU_Type_IMSI_Attach, mi_lv, '00F110'O)); + nas := enc_PDU_ML3_MS_NW(l3_pdu); + } } else { /* The test asks for an exact number of Optional Data bytes. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I725c35a3584b7d2d162c24ab2b662cfb80e539d7 Gerrit-Change-Number: 39489 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Submit proper L3 PDUs during CR
by osmith 10 Feb '25

10 Feb '25

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39489?usp=email ) Change subject: hnbgw: Submit proper L3 PDUs during CR ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I725c35a3584b7d2d162c24ab2b662cfb80e539d7 Gerrit-Change-Number: 39489 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Feb 2025 10:44:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Submit proper L3 PDUs during CR
by pespin 10 Feb '25

10 Feb '25

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39489?usp=email ) Change subject: hnbgw: Submit proper L3 PDUs during CR ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39489/comment/be90a92e_d1e0… : PS2, Line 9: ac ton > "act on" / "act up on"? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I725c35a3584b7d2d162c24ab2b662cfb80e539d7 Gerrit-Change-Number: 39489 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Feb 2025 10:44:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in ...osmo-s1gw[master]: rebar.config: relx: generate the version automatically
by osmith 10 Feb '25

10 Feb '25

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39493?usp=email ) Change subject: rebar.config: relx: generate the version automatically ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39493?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7a4ed74416d4eef3c3befc0605d1857e147324e7 Gerrit-Change-Number: 39493 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Feb 2025 10:43:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Submit proper L3 PDUs during CR
by pespin 10 Feb '25

10 Feb '25

Attention is currently required from: fixeria, osmith, pespin. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39489?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by osmith Change subject: hnbgw: Submit proper L3 PDUs during CR ...................................................................... hnbgw: Submit proper L3 PDUs during CR Generating random PDU values makes hnbgw act on it, since it looks up higher layers to figure out NRI steering. Change-Id: I725c35a3584b7d2d162c24ab2b662cfb80e539d7 Related: OS#6717 --- M hnbgw/ConnHdlr.ttcn 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/89/39489/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I725c35a3584b7d2d162c24ab2b662cfb80e539d7 Gerrit-Change-Number: 39489 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log