- gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: pcu: Fix TC_dl_cs1_to_cs4 sporadic fail
by osmith 12 Feb '25

12 Feb '25

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39499?usp=email ) Change subject: pcu: Fix TC_dl_cs1_to_cs4 sporadic fail ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39499?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7fb40689547645adf1d54f43c263161be1d7a440 Gerrit-Change-Number: 39499 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Feb 2025 07:59:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: out ep: fix swapped msgb list error handling
by Hoernchen 11 Feb '25

11 Feb '25

Hoernchen has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39501?usp=email ) Change subject: out ep: fix swapped msgb list error handling ...................................................................... out ep: fix swapped msgb list error handling Change-Id: I2833f0aca3ffebfceaaf2a0681a9f8242817e722 --- M sysmoOCTSIM/main.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/01/39501/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39501?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I2833f0aca3ffebfceaaf2a0681a9f8242817e722 Gerrit-Change-Number: 39501 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[XS] Change in osmo-ccid-firmware[master]: out ep: fix swapped error handling
by Hoernchen 11 Feb '25

11 Feb '25

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39501?usp=email ) Change subject: out ep: fix swapped error handling ...................................................................... out ep: fix swapped error handling Change-Id: I2833f0aca3ffebfceaaf2a0681a9f8242817e722 --- M sysmoOCTSIM/main.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/01/39501/1 diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c index 6fc2aac..d4e97ca 100644 --- a/sysmoOCTSIM/main.c +++ b/sysmoOCTSIM/main.c @@ -208,7 +208,7 @@ rc = ccid_df_read_out(msgb_data(msg), msgb_tailroom(msg)); if (rc != ERR_NONE) { /* re-add to the list of free msgb's */ - llist_add_tail_at(&g_ccid_s.free_q, &msg->list); + llist_add_tail_at(&msg->list, &g_ccid_s.free_q); return 0; } return 1; -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39501?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I2833f0aca3ffebfceaaf2a0681a9f8242817e722 Gerrit-Change-Number: 39501 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

1 0

[S] Change in osmo-ccid-firmware[master]: add ext power detect & dev reset
by Hoernchen 11 Feb '25

11 Feb '25

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: add ext power detect & dev reset ...................................................................... add ext power detect & dev reset Change-Id: Ied62450670dba2227daa96cbcd162cfe8414445a --- M sysmoOCTSIM/main.c M sysmoOCTSIM/usb/device/usbdc.c 2 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/47/39447/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ied62450670dba2227daa96cbcd162cfe8414445a Gerrit-Change-Number: 39447 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: pcu: Fix wrong BSN uint size
by pespin 11 Feb '25

11 Feb '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39498?usp=email ) Change subject: pcu: Fix wrong BSN uint size ...................................................................... pcu: Fix wrong BSN uint size 3GPP TS 44.060 9.1.4.2, BSN is 11 bit long. Change-Id: Id1ef8b58dc61ab91de2c781a2fd1e8da5eba83a7 --- M pcu/GPRS_Components.ttcn 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index 849a251..cf8ef5f 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -1316,7 +1316,7 @@ /* This function does what could probably be done with templates */ function f_rlcmac_dl_block_verify_data_egprs(in RlcmacDlEgprsDataBlock data_block, template (present) octetstring data := ?, - template (present) uint14_t exp_bsn := ?, + template (present) uint11_t exp_bsn := ?, template (present) CodingScheme exp_cs := ?) runs on MS_BTS_IFACE_CT { if (not match(data_block.mac_hdr.bsn1, exp_bsn)) { @@ -1343,9 +1343,9 @@ /* High level (task specific) helper for matching GPRS/EGPRS data blocks */ function f_rlcmac_dl_block_exp_data(in RlcmacDlBlock dl_block, - template (present) octetstring data := ?, - template (present) uint7_t exp_bsn := ?, - template (present) CodingScheme exp_cs := ?) + template (present) octetstring data := ?, + template (present) uint11_t exp_bsn := ?, + template (present) CodingScheme exp_cs := ?) runs on MS_BTS_IFACE_CT { /* Make sure it's either GPRS or EGPRS data block */ if (not match(dl_block, tr_RLCMAC_DATA)) { @@ -1367,7 +1367,7 @@ /* High level (task specific) helper for receiving and matching GPRS/EGPRS data blocks */ function f_rx_rlcmac_dl_block_exp_data(out RlcmacDlBlock dl_block, out uint32_t dl_fn, template (present) octetstring data := ?, - template (present) uint7_t exp_bsn := ?, + template (present) uint11_t exp_bsn := ?, template (present) CodingScheme exp_cs := ?, template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum) runs on MS_BTS_IFACE_CT { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id1ef8b58dc61ab91de2c781a2fd1e8da5eba83a7 Gerrit-Change-Number: 39498 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: pcu: Fix wrong BSN uint size
by lynxis lazus 11 Feb '25

11 Feb '25

Attention is currently required from: fixeria, osmith, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39498?usp=email ) Change subject: pcu: Fix wrong BSN uint size ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id1ef8b58dc61ab91de2c781a2fd1e8da5eba83a7 Gerrit-Change-Number: 39498 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Feb 2025 17:08:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-asf4-dfu[master]: gitgnore
by lynxis lazus 11 Feb '25

11 Feb '25

Attention is currently required from: Hoernchen. lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39431?usp=email ) Change subject: gitgnore ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39431/comment/64ba4809_a983a8b… : PS3, Line 7: gitgnore typo. Also it would be great to have a little bit more context. e.g. "gitignore: gcc cache files" or gitignore: compile artifacts. -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39431?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I95af162a01fb35656e0f9ccc9ce46b59a15c8c34 Gerrit-Change-Number: 39431 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Feb 2025 16:51:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Fix dummy DL block received due to timer race conditions
by pespin 11 Feb '25

11 Feb '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39500?usp=email ) Change subject: pcu: Fix dummy DL block received due to timer race conditions ...................................................................... pcu: Fix dummy DL block received due to timer race conditions Timer X2002, which manages delay at PCU between sending DL TBF Ass over CCCH and start transmitting for it over PDCH, is clock-time based. As a result, timer at PCU process and ttcn3 process may time out slightly differently. Hence, it can happen that we request a DL block immediatelly *before* the timer triggers at the PCU. In that scenario, PCU transmits a dummy block instead of a data block. Account for this race condition in several tests; some tests already used this formula. Change-Id: Ic2bb953483cd1f678cbe32c7a94e177f79ecb4e4 --- M pcu/PCU_Tests.ttcn 1 file changed, 51 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/00/39500/1 diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index f1f80db..23709dc 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -453,7 +453,9 @@ /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); - f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0); + /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ + dl_fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); + f_rlcmac_dl_block_exp_data(dl_block, data, 0); /* MS has moved to CS, it sent SUSP REQ to BTS and PCU gets it, TBF is freed: */ BTS.send(ts_PCUIF_SUSP_REQ(0, ms.tlli, ra_id, 0)); @@ -1066,7 +1068,8 @@ /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); - f_rx_rlcmac_dl_block_exp_data(dl_block, poll_fn, data, 0, exp_dl_cs_mcs); + poll_fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); + f_rlcmac_dl_block_exp_data(dl_block, data, 0, exp_dl_cs_mcs); /* ACK the DL block */ f_acknackdesc_ack_block(ms.dl_tbf.acknack_desc, dl_block, '1'B); @@ -1343,7 +1346,9 @@ /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); - f_rx_rlcmac_dl_block_exp_data(dl_block, poll_fn, data, 0, exp_dl_cs_mcs); + /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ + poll_fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); + f_rlcmac_dl_block_exp_data(dl_block, data, 0, exp_dl_cs_mcs); /* ACK the DL block */ f_dltbf_ack_block(ms.dl_tbf, dl_block, '1'B); @@ -1739,7 +1744,9 @@ f_sleep(X2002); while (true) { - f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, ?, ?); + /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ + dl_fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); + f_rlcmac_dl_block_exp_data(dl_block, ?, ?); /* Keep Ack/Nack description updated (except for last BSN) */ f_acknackdesc_ack_block(ms.dl_tbf.acknack_desc, dl_block); @@ -1843,7 +1850,9 @@ * FINAL_ACK one), so that PCU sees we are listening in PDCH and avoids * other code paths like trying to Imm Assign on CCCH again, etc.. */ while (true) { - f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, ?, ?); + /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ + dl_fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); + f_rlcmac_dl_block_exp_data(dl_block, ?, ?); if (dl_block.data.mac_hdr.hdr_ext.fbi) { log("Received FINAL_ACK"); @@ -1871,8 +1880,10 @@ /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); + /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ + dl_fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); /* Now that we confirmed the new assignment in the dl-tbf, lets receive the data and ack it */ - f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data2, 0); + f_rlcmac_dl_block_exp_data(dl_block, data2, 0); f_acknackdesc_ack_block(ms.dl_tbf.acknack_desc, dl_block, '1'B); f_ms_tx_ul_block(ms, ts_RLCMAC_DL_ACK_NACK(ms.dl_tbf.tfi, ms.dl_tbf.acknack_desc), f_dl_block_ack_fn(dl_block, dl_fn)); @@ -1917,7 +1928,9 @@ /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); - f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0); + /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ + dl_fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); + f_rlcmac_dl_block_exp_data(dl_block, data, 0); if (dl_block.data.mac_hdr.hdr_ext.fbi == false) { setverdict(fail, "Expected DL data block with FBI=1 but got FBI=0"); f_shutdown(__BFILE__, __LINE__); @@ -2070,7 +2083,9 @@ /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); - f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data2, 0); + /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ + dl_fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); + f_rlcmac_dl_block_exp_data(dl_block, data2, 0); /* ACK the DL block */ f_acknackdesc_ack_block(ms.dl_tbf.acknack_desc, dl_block, '1'B); @@ -2135,7 +2150,9 @@ /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); - f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0); + /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ + dl_fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); + f_rlcmac_dl_block_exp_data(dl_block, data, 0); /* ACK the DL block */ f_acknackdesc_ack_block(ms.dl_tbf.acknack_desc, dl_block, '1'B); @@ -2637,7 +2654,9 @@ /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); - f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0, exp_cs_mcs); + /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ + dl_fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); + f_rlcmac_dl_block_exp_data(dl_block, data, 0, exp_cs_mcs); /* ACK the DL block */ f_acknackdesc_ack_block(ms.dl_tbf.acknack_desc, dl_block, '1'B); @@ -2829,7 +2848,6 @@ f_sleep(X2002); /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ dl_fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); - f_rlcmac_dl_block_exp_data(dl_block, data, 0, exp_cs_mcs); /* ACK the DL block, and request UL TBF at the same time */ @@ -2982,7 +3000,9 @@ /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); - f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0); + /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ + dl_fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); + f_rlcmac_dl_block_exp_data(dl_block, data, 0); /* Now we don't ack the dl block (emulate MS failed receiveing IMM ASS * or GPRS DL, or DL ACK was lost for some reason). As a result, PCU @@ -2991,7 +3011,9 @@ /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); - f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0); + /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ + dl_fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); + f_rlcmac_dl_block_exp_data(dl_block, data, 0); /* ACK the DL block */ f_acknackdesc_ack_block(ms.dl_tbf.acknack_desc, dl_block, '1'B); @@ -3233,7 +3255,9 @@ /* Recv DL data until receiving RRBP to DL ACK (because it's last queued DL data) */ while (true) { - f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, ?, ?); + /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ + dl_fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); + f_rlcmac_dl_block_exp_data(dl_block, ?, ?); /* Keep Ack/Nack description updated (except for last BSN) */ f_acknackdesc_ack_block(ms.dl_tbf.acknack_desc, dl_block); @@ -3847,7 +3871,9 @@ /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); - f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0); + /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ + dl_fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); + f_rlcmac_dl_block_exp_data(dl_block, data, 0); /* ACK the DL block, asking for new UL TBF by including ChanReqDesc */ f_dltbf_ack_block(ms.dl_tbf, dl_block, '1'B); @@ -4261,12 +4287,14 @@ /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); - f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0); + /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ + dl_fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); + f_rlcmac_dl_block_exp_data(dl_block, data, 0); /* ACK the DL block */ f_acknackdesc_ack_block(ms.dl_tbf.acknack_desc, dl_block, '1'B); f_ms_tx_ul_block(ms, ts_RLCMAC_DL_ACK_NACK(ms.dl_tbf.tfi, ms.dl_tbf.acknack_desc), - f_dl_block_ack_fn(dl_block, dl_fn)); + f_dl_block_ack_fn(dl_block, dl_fn)); var StatsDExpects expect := { { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1}, @@ -4353,9 +4381,10 @@ /* Wait timer X2002 and DL block is available after CCCH IMM ASS */ f_sleep(X2002); - + /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ + fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); /* Expect the first (GPRS DL) block with bsn=0 and rrbp_valid=1 */ - f_rx_rlcmac_dl_block_exp_data(dl_block, fn, data, 0); + f_rlcmac_dl_block_exp_data(dl_block, data, 0); if (ischosen(dl_block.data_egprs)) { if (lengthof(dl_block.data_egprs.blocks) != 2) { @@ -4447,7 +4476,9 @@ f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); - f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0); + /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ + dl_fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); + f_rlcmac_dl_block_exp_data(dl_block, data, 0); f_shutdown(__BFILE__, __LINE__, final := true); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39500?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic2bb953483cd1f678cbe32c7a94e177f79ecb4e4 Gerrit-Change-Number: 39500 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: f_routing_area_update: add authentication argument
by pespin 11 Feb '25

11 Feb '25

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39018?usp=email ) Change subject: SGSN: f_routing_area_update: add authentication argument ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39018?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7125ed8aa81fbda48a19f7f4fc711bc1bf2c875f Gerrit-Change-Number: 39018 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 11 Feb 2025 16:44:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: rework TC_sgsn_context_req_out to actual function
by pespin 11 Feb '25

11 Feb '25

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email ) Change subject: SGSN_Tests: rework TC_sgsn_context_req_out to actual function ...................................................................... Patch Set 3: (3 comments) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/d14341e7_866d… : PS3, Line 3187: // add_rai_oct := rai_to_oct(add_rai); why is this commented out? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/ce0a32db_456d… : PS3, Line 3200: // [] GTP[GTP_GGSN_IDX].receive(tr_GTPC_SGSNContextReq(g_gn_iface_peer, tr_SGSNContextReqPDU(rai := rai, ptmsi := ts_PTMSI(ptmsi), ptmsi_sig := ts_PTMSI_sig(ptmsi_sig), rat_type := int2oct(enum2int(rat_type), 1)))) -> value gtpc_pdu { why is this commented out? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/694ab21d_93ea… : PS3, Line 3311: f_sleep(1.0); is this really needed? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0666a518aed57c2594653ab6b0f801c4193fd2f3 Gerrit-Change-Number: 39017 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 11 Feb 2025 16:40:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log