- gerrit-log - lists.osmocom.org

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2
by Jenkins Builder 16 Feb '25

16 Feb '25

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email ) Change subject: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2 ...................................................................... Patch Set 2: (32 comments) File include/osmocom/vlr/vlr.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/903e94bb_1817c25b?us… : PS2, Line 121: long long unsigned int id; type 'long long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order File src/libvlr/vlr.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/18e46fad_42687710?us… : PS2, Line 238: OSMO_STRBUF_PRINTF(sb, "%sMSISDN-%s", present? ":" : "", vsub->msisdn); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/cfbf8032_0919ba9a?us… : PS2, Line 242: OSMO_STRBUF_PRINTF(sb, "%sTMSI-0x%08X", present? ":" : "", vsub->tmsi); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/cb92549e_e1403b88?us… : PS2, Line 246: OSMO_STRBUF_PRINTF(sb, "%sTMSInew-0x%08X", present? ":" : "", vsub->tmsi_new); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/6adc1cce_8deba49a?us… : PS2, Line 258: char *name = (char*)vlr_subscr_name(vsub); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/fa06b281_2009ae9b?us… : PS2, Line 263: strcpy(name + maxlen - 2, ".."); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/5146457d_dec67a80?us… : PS2, Line 380: vlr_subscr_name(vsub), (e->count - old_use_count) > 0? "+" : "-", e->use, spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/210fbbde_bf9efd18?us… : PS2, Line 705: osmo_plmn_name(&vsub->sgs.last_eutran_plmn) : code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/c1a047cc_287631b1?us… : PS2, Line 810: struct sgsn_subscriber_pdp_data* pdata; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/ac9562d1_75b6661e?us… : PS2, Line 1447: VLR_AUTH_E_MS_ID_IMSI, (void*)mi->imsi); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/e48e0663_fd15e269?us… : PS2, Line 1455: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMSI, (void*)mi->imsi); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/f389965a_f25f00e1?us… : PS2, Line 1457: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEI, (void*)mi->imei); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/8141dd12_7715a510?us… : PS2, Line 1459: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEISV, (void*)mi->imeisv); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/672415b9_b00d46e2?us… : PS2, Line 1716: struct vlr_subscr **fsub = (void*)&target->filter_data[LOG_FLT_VLR_SUBSCR]; "(foo*)" should be "(foo *)" File src/libvlr/vlr_access_req_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/2fcac026_db6ab2e1?us… : PS2, Line 111: return par->result? gsm48_reject_value_name(par->result) : "PASSED"; spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/6ce1981d_08b78dfa?us… : PS2, Line 415: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/d27471ce_4a887b81?us… : PS2, Line 421: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/24376f0e_a2b289a8?us… : PS2, Line 496: result = *(enum vlr_ciph_result_cause*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/7c21c885_50dd804e?us… : PS2, Line 791: .in_event_mask = , space prohibited before that ',' (ctx:WxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/8c2c1a2c_aba5fec7?us… : PS2, Line 798: .in_event_mask = , space prohibited before that ',' (ctx:WxE) File src/libvlr/vlr_auth_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3f91682d_b49c6f6f?us… : PS2, Line 199: res_len, (res_len == vec->res_len)? "valid" : "INVALID on UTRAN"); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/756e8c1f_9284c0bd?us… : PS2, Line 216: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/cf7699de_f4035616?us… : PS2, Line 543: strncpy(vsub->imsi, mi_string, sizeof(vsub->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() File src/libvlr/vlr_lu_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/5899dfad_d0b8df06?us… : PS2, Line 160: return (struct vlr_subscr*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/fd59f74c_197f12f5?us… : PS2, Line 272: return (struct vlr_subscr*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/92b3ab2d_307b0044?us… : PS2, Line 667: return (struct lu_compl_vlr_priv*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/a9c33227_760b82f0?us… : PS2, Line 1282: result = *(enum vlr_ciph_result_cause*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/982d6340_83368091?us… : PS2, Line 1404: cause = *(uint8_t*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/6510c6b1_f3c1916a?us… : PS2, Line 1436: cause = *(uint8_t*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/d0e39c5b_b855f107?us… : PS2, Line 1643: return (struct lu_fsm_priv*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/888cf695_f78111e1?us… : PS2, Line 1691: strncpy(lfp->imsi, imsi, sizeof(lfp->imsi)-1); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() File src/libvlr/vlr_sgs.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/069f787e_8e4ab419?us… : PS2, Line 324: } void function return statements are not generally useful -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 16 Feb 2025 21:40:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in osmo-sgsn[master]: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection
by Jenkins Builder 16 Feb '25

16 Feb '25

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email ) Change subject: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection ...................................................................... Patch Set 3: (13 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21554): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/c370157c_338be0e0?us… : PS3, Line 2568: if (mmctx) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21554): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/136d5fbe_b9470e8d?us… : PS3, Line 2597: if (!mme) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21554): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/c882e71b_558be22e?us… : PS3, Line 2627: } else { else is not generally useful after a break or return File src/sgsn/gprs_rau_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21554): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/38985099_e80396b3?us… : PS3, Line 365: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_GGSN_UPD_RESP) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) File src/sgsn/sgsn_libgtp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21554): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/a146b799_b3eed156?us… : PS3, Line 190: if (!ggsn->gsn) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21554): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/a6a88f70_b7e6299c?us… : PS3, Line 913: #define CHECK_SPACE_ERR(bytes) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21554): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/504db988_927fbfd2?us… : PS3, Line 918: #define MEMCPY_CHK(dst, src, len) \ Macros with multiple statements should be enclosed in a do - while loop Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21554): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/a7b8ef7d_efa5cac2?us… : PS3, Line 918: #define MEMCPY_CHK(dst, src, len) \ macros should not use a trailing semicolon Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21554): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/e5c71c16_921aa1ae?us… : PS3, Line 1085: LOGMMCTXP(LOGL_INFO, mmctx, "Ctx will be transfered to another SGSN/MME\n"); 'transfered' may be misspelled - perhaps 'transferred'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21554): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/5345de74_548b39b6?us… : PS3, Line 1125: if (buf_len <= 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21554): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/8022684a_0e747ce5?us… : PS3, Line 1139: // break; please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21554): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/98acc286_73fbfc73?us… : PS3, Line 1378: strncpy(mmctx->imsi, imsi_str, sizeof(mmctx->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21554): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/017380e5_f0b233ce?us… : PS3, Line 1388: if (rc) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iffe83b31db2b6e6869fedf2351375184096cff6f Gerrit-Change-Number: 39563 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 16 Feb 2025 21:39:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in osmo-sgsn[master]: Rework SGSN code to use new libvlr code
by Jenkins Builder 16 Feb '25

16 Feb '25

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email ) Change subject: Rework SGSN code to use new libvlr code ...................................................................... Patch Set 3: (24 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/f9b6b63f_2b1c6eb4?us… : PS3, Line 1220: if (req.mi.type == GSM_MI_TYPE_IMSI) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/bb2fc1ce_2406d56e?us… : PS3, Line 1290: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/5fad0f97_a60d9ba2?us… : PS3, Line 1551: else { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/59a0492a_19b66cce?us… : PS3, Line 1555: if (TLVP_PRESENT(&req.tlv, GSM48_IE_GMM_PTMSI_TYPE)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/f8c628ca_f6e87380?us… : PS3, Line 1673: if (!foreign_ra && that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/09935e3d_81db8a9b?us… : PS3, Line 1759: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/c73f37cb_52c184b4?us… : PS3, Line 1787: if (mmctx) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/2588de34_b8360a71?us… : PS3, Line 1817: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/31d1f5a3_bbf69544?us… : PS3, Line 1964: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/c5101ee1_c5b58ab9?us… : PS3, Line 2321: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/7bce4b24_3e839384?us… : PS3, Line 2345: /* FIXME: when loosing the VLR subscriber, we should ensure the GMM is in IDLE (same for PMM) */ 'loosing' may be misspelled - perhaps 'losing'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/e2b407b6_58635fc4?us… : PS3, Line 2372: if (ctx->p_tmsi != send_tmsi && ctx->p_tmsi != GSM_RESERVED_TMSI && send_tmsi != GSM_RESERVED_TMSI) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/c650fb5e_0949b9f6?us… : PS3, Line 2387: if (ctx->attach_rau.rau_fsm) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/b541c192_41750e2a?us… : PS3, Line 2393: switch(ctx->ran_type) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/eca3b257_f4ef2163?us… : PS3, Line 2431: if (ctx->iu.mm_state_fsm->state == ST_PMM_CONNECTED) { braces {} are not necessary for single statement blocks File src/sgsn/gprs_rau_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/717dab4b_d94d4097?us… : PS3, Line 206: switch(mmctx->ran_type) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/ced4a57f_4f4a5fe2?us… : PS3, Line 231: switch(mmctx->ran_type) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/2aa38ddc_52e46c8d?us… : PS3, Line 304: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/2cb27979_bc9d95cb?us… : PS3, Line 310: .in_event_mask = S(GMM_RAU_E_UE_RAU_COMPLETE) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/a5b4dea0_7c91d07d?us… : PS3, Line 339: static __attribute__((constructor)) void gmm_rau_fsm_init() Bad function definition - void gmm_rau_fsm_init() should probably be void gmm_rau_fsm_init(void) File src/sgsn/mmctx.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/1525febf_3c105db4?us… : PS3, Line 619: if (!strlen(mm->imsi) && strlen(mm->vsub->imsi)) { braces {} are not necessary for single statement blocks File src/sgsn/sgsn_libgtp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/6d3e35d4_98e5a126?us… : PS3, Line 537: if (cause != GTPCAUSE_NON_EXIST) { braces {} are not necessary for single statement blocks File src/sgsn/sgsn_main.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/8a36f5ad_55a39384?us… : PS3, Line 360: [DVLR] = { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21553): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/34ec79b5_9db017b9?us… : PS3, Line 364: }, please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 Gerrit-Change-Number: 39562 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 16 Feb 2025 21:39:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-sgsn[master]: GMM: implement IMEI SV on auth/ciph response
by lynxis lazus 16 Feb '25

16 Feb '25

Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39425?usp=email ) Change subject: GMM: implement IMEI SV on auth/ciph response ...................................................................... Patch Set 2: (1 comment) File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39425/comment/cf7e0b9f_fcb36b69?us… : PS2, Line 683: has broken > super minor cosmetic spelling: phones (plural) ... have. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39425?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia8b428967a4ce3132a4a63ae10fe610de81c3a29 Gerrit-Change-Number: 39425 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 16 Feb 2025 21:36:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-sgsn[master]: GMM: implement IMEI SV on auth/ciph response
by lynxis lazus 16 Feb '25

16 Feb '25

Attention is currently required from: laforge, lynxis lazus, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39425?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: GMM: implement IMEI SV on auth/ciph response ...................................................................... GMM: implement IMEI SV on auth/ciph response The SGSN is requesting the IMEI SV on an auth/ciphering response. Parse the answer of the MS/UE. Change-Id: Ia8b428967a4ce3132a4a63ae10fe610de81c3a29 --- M src/sgsn/gprs_gmm.c 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/25/39425/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39425?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia8b428967a4ce3132a4a63ae10fe610de81c3a29 Gerrit-Change-Number: 39425 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[L] Change in osmo-sgsn[master]: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection
by Jenkins Builder 16 Feb '25

16 Feb '25

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email ) Change subject: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection ...................................................................... Patch Set 2: (13 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21548): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/d194d338_5f9e49ca?us… : PS2, Line 2568: if (mmctx) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21548): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/8a9bd497_c3301369?us… : PS2, Line 2597: if (!mme) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21548): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/13a5186c_ca4ba791?us… : PS2, Line 2627: } else { else is not generally useful after a break or return File src/sgsn/gprs_rau_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21548): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/177fee29_3da9bef5?us… : PS2, Line 365: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_GGSN_UPD_RESP) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) File src/sgsn/sgsn_libgtp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21548): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/c02b717e_e7740800?us… : PS2, Line 190: if (!ggsn->gsn) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21548): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/0e0b38f5_cf44dbb1?us… : PS2, Line 913: #define CHECK_SPACE_ERR(bytes) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21548): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/cd7eabdb_8f8cbe42?us… : PS2, Line 918: #define MEMCPY_CHK(dst, src, len) \ Macros with multiple statements should be enclosed in a do - while loop Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21548): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/65fa52a1_5e1ef2f2?us… : PS2, Line 918: #define MEMCPY_CHK(dst, src, len) \ macros should not use a trailing semicolon Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21548): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/b307f27a_da6ced6e?us… : PS2, Line 1085: LOGMMCTXP(LOGL_INFO, mmctx, "Ctx will be transfered to another SGSN/MME\n"); 'transfered' may be misspelled - perhaps 'transferred'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21548): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/057bc6a4_d53093e0?us… : PS2, Line 1125: if (buf_len <= 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21548): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/ce147776_b33fbf29?us… : PS2, Line 1139: // break; please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21548): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/ab6c3335_1c544150?us… : PS2, Line 1378: strncpy(mmctx->imsi, imsi_str, sizeof(mmctx->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21548): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/2f84eb57_f7171ff1?us… : PS2, Line 1388: if (rc) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iffe83b31db2b6e6869fedf2351375184096cff6f Gerrit-Change-Number: 39563 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 16 Feb 2025 21:34:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in osmo-sgsn[master]: Rework SGSN code to use new libvlr code
by Jenkins Builder 16 Feb '25

16 Feb '25

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email ) Change subject: Rework SGSN code to use new libvlr code ...................................................................... Patch Set 2: (24 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/5e876bb9_9615685e?us… : PS2, Line 1220: if (req.mi.type == GSM_MI_TYPE_IMSI) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/7fadb321_da06420a?us… : PS2, Line 1290: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/2b62636e_4a77b8f7?us… : PS2, Line 1551: else { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/06e6a06f_9e56471e?us… : PS2, Line 1555: if (TLVP_PRESENT(&req.tlv, GSM48_IE_GMM_PTMSI_TYPE)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/e1f0ede6_41de4b71?us… : PS2, Line 1673: if (!foreign_ra && that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/ff451c77_16615e55?us… : PS2, Line 1759: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/8eac3fe2_7536caac?us… : PS2, Line 1787: if (mmctx) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/de998779_913ee1cc?us… : PS2, Line 1817: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/3606244a_48a3bcf1?us… : PS2, Line 1964: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/fd4c448b_afb8dad6?us… : PS2, Line 2321: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/006b0de4_f5416c62?us… : PS2, Line 2345: /* FIXME: when loosing the VLR subscriber, we should ensure the GMM is in IDLE (same for PMM) */ 'loosing' may be misspelled - perhaps 'losing'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/671f4348_5137e42f?us… : PS2, Line 2372: if (ctx->p_tmsi != send_tmsi && ctx->p_tmsi != GSM_RESERVED_TMSI && send_tmsi != GSM_RESERVED_TMSI) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/70213992_104b6be4?us… : PS2, Line 2387: if (ctx->attach_rau.rau_fsm) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/de0c8b76_db553311?us… : PS2, Line 2393: switch(ctx->ran_type) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/9fb3701a_e15e9627?us… : PS2, Line 2431: if (ctx->iu.mm_state_fsm->state == ST_PMM_CONNECTED) { braces {} are not necessary for single statement blocks File src/sgsn/gprs_rau_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/9cf169c4_534ada1a?us… : PS2, Line 206: switch(mmctx->ran_type) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/73e915fa_e02c7d3c?us… : PS2, Line 231: switch(mmctx->ran_type) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/5c4279d2_892a372f?us… : PS2, Line 304: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/2250ce2e_b9de3a19?us… : PS2, Line 310: .in_event_mask = S(GMM_RAU_E_UE_RAU_COMPLETE) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/db3de23e_63b0605d?us… : PS2, Line 339: static __attribute__((constructor)) void gmm_rau_fsm_init() Bad function definition - void gmm_rau_fsm_init() should probably be void gmm_rau_fsm_init(void) File src/sgsn/mmctx.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/4eaec78f_43d6b17b?us… : PS2, Line 619: if (!strlen(mm->imsi) && strlen(mm->vsub->imsi)) { braces {} are not necessary for single statement blocks File src/sgsn/sgsn_libgtp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/eecf4f54_3289a484?us… : PS2, Line 537: if (cause != GTPCAUSE_NON_EXIST) { braces {} are not necessary for single statement blocks File src/sgsn/sgsn_main.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/6071f793_b6c1715e?us… : PS2, Line 360: [DVLR] = { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/ab36be4a_4607c6f6?us… : PS2, Line 364: }, please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 Gerrit-Change-Number: 39562 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 16 Feb 2025 21:33:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-sgsn[master]: libvlr: squash libvlr reworks
by lynxis lazus 16 Feb '25

16 Feb '25

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39561?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: libvlr: squash libvlr reworks ...................................................................... libvlr: squash libvlr reworks * logging/debug.h: add own debug * add PVLR support * add vlr_ra_update() * internally use RAI instead of LAI Change-Id: I7ef8e10e9553181913c66546c97a71b21fa9ef64 --- A include/osmocom/vlr/debug.h M include/osmocom/vlr/vlr.h M src/libvlr/vlr.c M src/libvlr/vlr_auth_fsm.c M src/libvlr/vlr_lu_fsm.c 5 files changed, 101 insertions(+), 33 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/61/39561/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39561?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I7ef8e10e9553181913c66546c97a71b21fa9ef64 Gerrit-Change-Number: 39561 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-msc[master]: libvlr: replace strncpy with osmo_strlcpy
by lynxis lazus 16 Feb '25

16 Feb '25

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/39565?usp=email ) Change subject: libvlr: replace strncpy with osmo_strlcpy ...................................................................... libvlr: replace strncpy with osmo_strlcpy The compile warns about these strncpys because they might not null terminated. Even the next line ensures this. Change-Id: I96a27ef42cb06dd2365f5c9902933323c7caf9a8 --- M src/libvlr/vlr_auth_fsm.c M src/libvlr/vlr_lu_fsm.c 2 files changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/65/39565/1 diff --git a/src/libvlr/vlr_auth_fsm.c b/src/libvlr/vlr_auth_fsm.c index b4ebd05..818daa0 100644 --- a/src/libvlr/vlr_auth_fsm.c +++ b/src/libvlr/vlr_auth_fsm.c @@ -540,8 +540,7 @@ LOGVSUBP(LOGL_ERROR, vsub, "IMSI in ID RESP differs:" " %s\n", mi_string); } else { - strncpy(vsub->imsi, mi_string, sizeof(vsub->imsi)); - vsub->imsi[sizeof(vsub->imsi)-1] = '\0'; + osmo_strlcpy(vsub->imsi, mi_string, sizeof(vsub->imsi)); } /* retry with identity=IMSI */ afp->by_imsi = true; diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index 2854d9d..d99a771 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -1675,8 +1675,7 @@ lfp->is_utran = is_utran; lfp->assign_tmsi = assign_tmsi; if (imsi) { - strncpy(lfp->imsi, imsi, sizeof(lfp->imsi)-1); - lfp->imsi[sizeof(lfp->imsi)-1] = '\0'; + osmo_strlcpy(lfp->imsi, imsi, sizeof(lfp->imsi)); lfp->lu_by_tmsi = false; } fi->priv = lfp; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39565?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I96a27ef42cb06dd2365f5c9902933323c7caf9a8 Gerrit-Change-Number: 39565 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[L] Change in osmo-sgsn[master]: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection
by Jenkins Builder 16 Feb '25

16 Feb '25

Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email ) Change subject: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection ...................................................................... Patch Set 1: (13 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/3adebc21_17c3a4a3?us… : PS1, Line 2568: if (mmctx) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/9fe6af42_1d83bf37?us… : PS1, Line 2597: if (!mme) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/e0367f0a_157472f4?us… : PS1, Line 2627: } else { else is not generally useful after a break or return File src/sgsn/gprs_rau_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/c8164ef6_c961c8be?us… : PS1, Line 365: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_GGSN_UPD_RESP) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) File src/sgsn/sgsn_libgtp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/c805ca91_96de29e1?us… : PS1, Line 190: if (!ggsn->gsn) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/6d0ad31e_28877b73?us… : PS1, Line 913: #define CHECK_SPACE_ERR(bytes) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/993b195d_f96a5409?us… : PS1, Line 918: #define MEMCPY_CHK(dst, src, len) \ Macros with multiple statements should be enclosed in a do - while loop Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/34e03114_2a1acb2e?us… : PS1, Line 918: #define MEMCPY_CHK(dst, src, len) \ macros should not use a trailing semicolon Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/0f57ee6f_ffb0f04d?us… : PS1, Line 1085: LOGMMCTXP(LOGL_INFO, mmctx, "Ctx will be transfered to another SGSN/MME\n"); 'transfered' may be misspelled - perhaps 'transferred'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/6e0fa6f0_392ad55c?us… : PS1, Line 1125: if (buf_len <= 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/f7cb4530_e3f0f237?us… : PS1, Line 1139: // break; please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/295b1b25_c8a33931?us… : PS1, Line 1378: strncpy(mmctx->imsi, imsi_str, sizeof(mmctx->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/eb567e81_45f4fb2b?us… : PS1, Line 1388: if (rc) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iffe83b31db2b6e6869fedf2351375184096cff6f Gerrit-Change-Number: 39563 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sun, 16 Feb 2025 21:09:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log