Attention is currently required from: osmith.
laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39596?usp=email )
Change subject: gitreview: new file
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39596?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I4699c2101254aa3b2b2aee8fceafcc6c21dcef4c
Gerrit-Change-Number: 39596
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 20 Feb 2025 12:52:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith.
laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39594?usp=email )
Change subject: drivers/dahdi/Kbuild: fix 'No rule to make target'
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
please mention specifically the version like x.y.z-rcXX that introduced this in the changelog. I believe this is also what we've done historiclaly if you look at older such instances.
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39594?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I653318e158caf133bf4c81cd04da0adec14ed0d8
Gerrit-Change-Number: 39594
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 20 Feb 2025 12:51:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: osmith.
laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email )
Change subject: drivers/dahdi: fix always true cond
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
please mention specifically the version like x.y.z-rcXX that introduced this in the changelog. I believe this is also what we've done historiclaly if you look at older such instances.
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I33ee446a32de3bb8d9fe966a2989994bf4bbd806
Gerrit-Change-Number: 39593
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 20 Feb 2025 12:51:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: osmith.
laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39592?usp=email )
Change subject: drivers/dahdi/wct4xxp: fix inline not at beginning
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
please mention specifically the version like x.y.z-rcXX that introduced this in the changelog. I believe this is also what we've done historiclaly if you look at older such instances.
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39592?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: Ic77d94271e7844ea2e06ccd001156d90f321367e
Gerrit-Change-Number: 39592
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 20 Feb 2025 12:51:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, osmith, pespin.
laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now.
Change subject: drivers/dahdi: fix MAX redefine
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/dahdi-linux/+/39591/comment/9464735d_2e9dadbe?… :
PS1, Line 9: current linux master:
please mention specifically the version like x.y.z-rcXX that introduced this in the changelog. I believe this is also what we've done historiclaly if you look at older such instances.
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: If048523ac2c69b1251fdee758a2cd3e14f8e617c
Gerrit-Change-Number: 39591
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 20 Feb 2025 12:51:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes