- gerrit-log - lists.osmocom.org

[XS] Change in ...pyosmocom[master]: .gitignore: add vim swap file pattern
by laforge 25 Feb '25

25 Feb '25

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39601?usp=email ) Change subject: .gitignore: add vim swap file pattern ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I20780f311623e44040fa3ec4e865b57a71559524 Gerrit-Change-Number: 39601 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 08:57:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...pyosmocom[master]: utils: add unrpad()
by laforge 25 Feb '25

25 Feb '25

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39600?usp=email ) Change subject: utils: add unrpad() ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/osmocom/utils.py: https://gerrit.osmocom.org/c/python/pyosmocom/+/39600/comment/086504a6_d8e6… : PS1, Line 125: """unpad string on the right side -- reverse of rpad(). in which way is this different from the python standard library string.rstrip method? you can also pass stirng.rstrip the charcter[s] that shall be removed from the right end. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I48c23390926f8c9412624edb4481e7f4cd3f4b46 Gerrit-Change-Number: 39600 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 08:57:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in dahdi-linux[master]: drivers/dahdi/Kbuild: fix 'No rule to make target'
by osmith 25 Feb '25

25 Feb '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39594?usp=email ) Change subject: drivers/dahdi/Kbuild: fix 'No rule to make target' ...................................................................... drivers/dahdi/Kbuild: fix 'No rule to make target' Add a workaround for this error with current linux master: make[4]: *** No rule to make target 'vpmadt032_loader/vpmadt032_x86_64.o', needed by 'dahdi_vpmadt032_loader.o'. Stop. Change-Id: I653318e158caf133bf4c81cd04da0adec14ed0d8 --- M drivers/dahdi/Kbuild 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/drivers/dahdi/Kbuild b/drivers/dahdi/Kbuild index c3ec58e..4d05f12 100644 --- a/drivers/dahdi/Kbuild +++ b/drivers/dahdi/Kbuild @@ -146,6 +146,12 @@ endif endif +# FIXME: This workaround should not be necessary, but for some reason the rule +# '$(obj)/%: $(src)/%_shipped' from linux.git scripts/Makefile.lib doesn't +# cover this anymore. +vpmadt032_loader/vpmadt032_$(DAHDI_ARCH).o: $(src)/vpmadt032_loader/vpmadt032_$(DAHDI_ARCH).o_shipped + $(call cmd,copy) + ############################################################################### # HPEC Support ############################################################################### -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I653318e158caf133bf4c81cd04da0adec14ed0d8 Gerrit-Change-Number: 39594 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in dahdi-linux[master]: drivers/dahdi/Kbuild: fix 'No rule to make target'
by osmith 25 Feb '25

25 Feb '25

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39594?usp=email ) Change subject: drivers/dahdi/Kbuild: fix 'No rule to make target' ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: I'll merge this so the jenkins job stops failing every day, and the gerrit verifications work again for dahdi-linux. -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I653318e158caf133bf4c81cd04da0adec14ed0d8 Gerrit-Change-Number: 39594 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 08:56:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: cosmetic: add .gitignore to doc/examples
by falconia 25 Feb '25

25 Feb '25

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39604?usp=email ) Change subject: cosmetic: add .gitignore to doc/examples ...................................................................... cosmetic: add .gitignore to doc/examples The two binaries built in doc/examples add noise to git status output, making other work in this repository more difficult. Change-Id: Id54e9a8c471dcfbf1588c2f69c37bf0d6feda47f --- A doc/examples/.gitignore 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/04/39604/1 diff --git a/doc/examples/.gitignore b/doc/examples/.gitignore new file mode 100644 index 0000000..3da0af7 --- /dev/null +++ b/doc/examples/.gitignore @@ -0,0 +1,2 @@ +lapd-over-datagram-network +lapd-over-datagram-user -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Id54e9a8c471dcfbf1588c2f69c37bf0d6feda47f Gerrit-Change-Number: 39604 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

[S] Change in osmo-hnbgw[master]: Log RAB_STATE name instead of value
by laforge 25 Feb '25

25 Feb '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39602?usp=email ) Change subject: Log RAB_STATE name instead of value ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39602?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I24593a1db1334052f3a79f59a521228393fc1ed7 Gerrit-Change-Number: 39602 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 08:00:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: eim: move es9p_Types_JSON to library
by laforge 25 Feb '25

25 Feb '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39603?usp=email ) Change subject: eim: move es9p_Types_JSON to library ...................................................................... eim: move es9p_Types_JSON to library The TTCN3 module es9p_Types_JSON is currently only used by the eIM testsuite, but it may also be helpful in other testsuites in the future. Related: SYS#7339 Change-Id: If4be10a298e30188aebe7c9d3efbdb56d2816c7f --- M eim/gen_links.sh R library/euicc/es9p_Types_JSON.ttcn 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/eim/gen_links.sh b/eim/gen_links.sh index 4bb1ea8..1996da9 100755 --- a/eim/gen_links.sh +++ b/eim/gen_links.sh @@ -35,7 +35,8 @@ FILES+="PKIX1Explicit88_Templates.ttcn PKIX1Explicit88_Types.ttcn PKIX1Implicit88_Templates.ttcn " FILES+="PKIX1Implicit88_Types.ttcn RSPDefinitions_Templates.ttcn RSPDefinitions_Types.ttcn " FILES+="SGP32Definitions_Templates.ttcn SGP32Definitions_Types.ttcn " -FILES+="PKIX1Explicit88_EncDec.cc PKIX1Implicit88_EncDec.cc RSPDefinitions_EncDec.cc SGP32Definitions_EncDec.cc" +FILES+="PKIX1Explicit88_EncDec.cc PKIX1Implicit88_EncDec.cc RSPDefinitions_EncDec.cc SGP32Definitions_EncDec.cc " +FILES+="es9p_Types_JSON.ttcn" gen_links $DIR $FILES DIR=../library diff --git a/eim/es9p_Types_JSON.ttcn b/library/euicc/es9p_Types_JSON.ttcn similarity index 100% rename from eim/es9p_Types_JSON.ttcn rename to library/euicc/es9p_Types_JSON.ttcn -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4be10a298e30188aebe7c9d3efbdb56d2816c7f Gerrit-Change-Number: 39603 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: eim: move es9p_Types_JSON to library
by laforge 25 Feb '25

25 Feb '25

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39603?usp=email ) Change subject: eim: move es9p_Types_JSON to library ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4be10a298e30188aebe7c9d3efbdb56d2816c7f Gerrit-Change-Number: 39603 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 07:59:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta...
by laforge 25 Feb '25

25 Feb '25

Attention is currently required from: csaba.sipos, domi, fixeria, pespin. laforge has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email ) Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Patch Set 22: (1 comment) Patchset: PS22: > @laforge@osmocom.org […] There were tons of unresolved review comments here; I usually only review code that either has no review yet, or where all the existing review is marked as done/resolved. I've now cleaned up those comments that clearly were done but had not been marked as such. We still have 6 unresolved (one of them this, so 5 remaining) that need to be cleared up one way or another. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 22 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: domi <domi(a)tomcsanyi.net> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: domi <domi(a)tomcsanyi.net> Gerrit-Comment-Date: Tue, 25 Feb 2025 07:59:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: csaba.sipos <metro4(a)freemail.hu>

1 0

[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta...
by laforge 25 Feb '25

25 Feb '25

Attention is currently required from: csaba.sipos, domi, fixeria, pespin. laforge has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email ) Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Patch Set 22: (8 comments) Patchset: PS22: please make sure to mark review comments as done if they are addressed. Otherwise you will discourage further review. I usually only review code where other review issues are resolved already. File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/a364b58f_b871dd90?usp… : PS14, Line 1716: #define FIND_ELEM(data, data_len, ei, var) (find_element(data, data_len, ei, var, sizeof(var)) == sizeof(var)) > Let me put this back to WIP, as this must be grossly annoying. […] Done File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/90554bee_ab3c887d?usp… : PS21, Line 1828: get_object_identity_string(object_id_state[4]), > If you want I send you a printscreen that it looks perfect on my side. Done https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/b2f4015b_64f2d63c?usp… : PS21, Line 1876: get_object_identity_string(object_identity[1]), > Same as on the first one. Done https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/cf279dd0_40af37b8?usp… : PS21, Line 1884: get_object_identity_string(object_identity[1]), > Same as on the first one. Done https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/97d372e4_e9896905?usp… : PS21, Line 1898: get_object_identity_string(object_identity[1]), > wrong indentation Done https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/0a95b997_63eb4962?usp… : PS21, Line 1907: get_object_identity_string(object_identity[1]), > wrong indentation Done https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/cf6a8bef_118f89c9?usp… : PS21, Line 1916: object_identity[2], > wrong indentation Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 22 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: domi <domi(a)tomcsanyi.net> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: domi <domi(a)tomcsanyi.net> Gerrit-Comment-Date: Tue, 25 Feb 2025 07:57:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: csaba.sipos <metro4(a)freemail.hu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log