- gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: Fix setting traffic-mode 'roundrobin' over VTY
by pespin 03 Mar '25

03 Mar '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39650?usp=email ) Change subject: Fix setting traffic-mode 'roundrobin' over VTY ...................................................................... Fix setting traffic-mode 'roundrobin' over VTY String in osmo_ss7_as_traffic_mode_vals[] is "round-robin" while string in VTY command was "roundrobin", so it didn't really match when set over VTY. This has apparently broken for really long, I couldn't find the originating commit breaking this. Use "roundrobin" (without dash) to match wording used in Cisco ITP. Change-Id: I61340549c596f1c04bc2269dbc165c327bf72037 --- M src/osmo_ss7_as.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve diff --git a/src/osmo_ss7_as.c b/src/osmo_ss7_as.c index 076cc35..ab48ca8 100644 --- a/src/osmo_ss7_as.c +++ b/src/osmo_ss7_as.c @@ -49,7 +49,7 @@ struct value_string osmo_ss7_as_traffic_mode_vals[] = { { OSMO_SS7_AS_TMOD_BCAST, "broadcast" }, { OSMO_SS7_AS_TMOD_LOADSHARE, "loadshare" }, - { OSMO_SS7_AS_TMOD_ROUNDROBIN, "round-robin" }, + { OSMO_SS7_AS_TMOD_ROUNDROBIN, "roundrobin" }, { OSMO_SS7_AS_TMOD_OVERRIDE, "override" }, { 0, NULL } }; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39650?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I61340549c596f1c04bc2269dbc165c327bf72037 Gerrit-Change-Number: 39650 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: Fix setting traffic-mode 'roundrobin' over VTY
by fixeria 03 Mar '25

03 Mar '25

Attention is currently required from: daniel, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39650?usp=email ) Change subject: Fix setting traffic-mode 'roundrobin' over VTY ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39650?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I61340549c596f1c04bc2269dbc165c327bf72037 Gerrit-Change-Number: 39650 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Mar 2025 10:04:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Fix brokeness in TC_tmt_loadshare
by pespin 03 Mar '25

03 Mar '25

Attention is currently required from: fixeria, laforge, osmith, pespin. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39651?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: stp: Fix brokeness in TC_tmt_loadshare ...................................................................... stp: Fix brokeness in TC_tmt_loadshare The test was not even setting the traffic-mode in the UIT. Furthermore, it was expecting pure round-robin behavior, which was the older behavior of osmo-stp when loadshare traffic-mode was selected. Actually split the test into 2, naming them properly (since round robin is not a AS traffic mode in itself, but a possible implementation of the loadshare traffic-mode. The new test validates the usual loadshare traffic-mode based on SLS distribution. Related: SYS#7112 Depends: libosmo-sigtran.git Change-Id I61340549c596f1c04bc2269dbc165c327bf72037 Change-Id: I16d81cb2f88bb2927f248182ad4f8f27c8c24859 --- M stp/STP_Tests_M3UA.ttcn M stp/expected-results.xml 2 files changed, 105 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/51/39651/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39651?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I16d81cb2f88bb2927f248182ad4f8f27c8c24859 Gerrit-Change-Number: 39651 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: Fix setting traffic-mode 'roundrobin' over VTY
by osmith 03 Mar '25

03 Mar '25

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39650?usp=email ) Change subject: Fix setting traffic-mode 'roundrobin' over VTY ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39650?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I61340549c596f1c04bc2269dbc165c327bf72037 Gerrit-Change-Number: 39650 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Mar 2025 09:59:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: Fix setting traffic-mode 'roundrobin' over VTY
by pespin 03 Mar '25

03 Mar '25

Attention is currently required from: daniel, fixeria, laforge, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39650?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: Fix setting traffic-mode 'roundrobin' over VTY ...................................................................... Fix setting traffic-mode 'roundrobin' over VTY String in osmo_ss7_as_traffic_mode_vals[] is "round-robin" while string in VTY command was "roundrobin", so it didn't really match when set over VTY. This has apparently broken for really long, I couldn't find the originating commit breaking this. Use "roundrobin" (without dash) to match wording used in Cisco ITP. Change-Id: I61340549c596f1c04bc2269dbc165c327bf72037 --- M src/osmo_ss7_as.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/50/39650/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39650?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I61340549c596f1c04bc2269dbc165c327bf72037 Gerrit-Change-Number: 39650 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: NOTIFY expectancy fixes
by pespin 03 Mar '25

03 Mar '25

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39646?usp=email ) Change subject: stp: NOTIFY expectancy fixes ...................................................................... Patch Set 1: (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39646/comment/968af7cf_dadc… : PS1, Line 798: f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, rctxB)); : f_M3UA_exp(0, tr_M3UA_DAVA({*}, rctxA)); : f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, rctxA)); : f_M3UA_exp(0, tr_M3UA_DAVA({*}, rctxB)); > Acknowledged Just for completeness, I guess most of those tests had the "rctx passing" as "TODO" because ttcn3 failed to properly decode the NOTIFY messages and hence wouldn't match if expecting a given rctx. That's fixed after the patch I submitted upstream for titan.ProtocolModules.M3UA. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39646?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3a56b4fcb8c119a31815f3175db2d7899fbfddd7 Gerrit-Change-Number: 39646 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Mar 2025 09:37:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: NOTIFY expectancy fixes
by osmith 03 Mar '25

03 Mar '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39646?usp=email ) Change subject: stp: NOTIFY expectancy fixes ...................................................................... Patch Set 1: (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39646/comment/a857c134_936a… : PS1, Line 798: f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, rctxB)); : f_M3UA_exp(0, tr_M3UA_DAVA({*}, rctxA)); : f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, rctxA)); : f_M3UA_exp(0, tr_M3UA_DAVA({*}, rctxB)); > The fact that they are interleaved is intentional, since activating B generates a DAVA on A and vice […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39646?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3a56b4fcb8c119a31815f3175db2d7899fbfddd7 Gerrit-Change-Number: 39646 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Mar 2025 09:29:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Use fork of titan.ProtocolModules.M3UA containing fix
by pespin 03 Mar '25

03 Mar '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39645?usp=email ) Change subject: Use fork of titan.ProtocolModules.M3UA containing fix ...................................................................... Use fork of titan.ProtocolModules.M3UA containing fix Use a fork of the repository until the M3UA_NOTIFY decoding bug gets its fix merged, currently submitted upstream in [1]. [1] https://gitlab.eclipse.org/eclipse/titan/titan.ProtocolModules.M3UA/-/merge… Change-Id: I9ac3dcad88cd13c1b45fb70bdcd2a474d084a652 --- M deps/Makefile 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/deps/Makefile b/deps/Makefile index d57e37a..61daa48 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -34,7 +34,6 @@ titan.ProtocolModules.JSON_v07_2006 \ titan.ProtocolModules.L2TP \ titan.ProtocolModules.LLC_v7.1.0 \ - titan.ProtocolModules.M3UA \ titan.ProtocolModules.MobileL3_v13.4.0 \ titan.ProtocolModules.SMPP \ titan.ProtocolModules.TCP \ @@ -66,7 +65,8 @@ OSMOGITHUB_REPOS= titan.TestPorts.SCTPasp \ titan.TestPorts.MTP3asp \ titan.ProtocolEmulations.SCCP \ - titan.ProtocolModules.BSSGP_v13.0.0 + titan.ProtocolModules.BSSGP_v13.0.0 \ + titan.ProtocolModules.M3UA OSMOGERRIT_REPOS= osmo-uecups @@ -104,7 +104,7 @@ titan.ProtocolModules.LLC_v7.1.0_commit= 09817f113255d7fb56f1d45d3dd629a093d9248d titan.ProtocolModules.MAP_commit= R.2.A-1-g79c6a3d titan.ProtocolModules.M2PA_commit= R.2.A-5-ga75b589 -titan.ProtocolModules.M3UA_commit= c496d298876fed55c2b730278b7ee77982555563 +titan.ProtocolModules.M3UA_commit= 509fb5d3074d643024e691116d3df7ba42ef9587 titan.ProtocolModules.MobileL3_v13.4.0_commit= b6602eb357673f097ea1a1d22edd568ecd239da1 titan.ProtocolModules.NAS_EPS_15.2.0.1_commit= R.1.A-2-g2ba853c titan.ProtocolModules.NS_v7.3.0_commit= R.2.A-6-gf73f195 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ac3dcad88cd13c1b45fb70bdcd2a474d084a652 Gerrit-Change-Number: 39645 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: NOTIFY expectancy fixes
by pespin 03 Mar '25

03 Mar '25

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39646?usp=email ) Change subject: stp: NOTIFY expectancy fixes ...................................................................... Patch Set 1: (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39646/comment/17b7cf3e_b64f… : PS1, Line 798: f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, rctxB)); : f_M3UA_exp(0, tr_M3UA_DAVA({*}, rctxA)); : f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, rctxA)); : f_M3UA_exp(0, tr_M3UA_DAVA({*}, rctxB)); > is the order in which rctxB and A are used intentional? […] The fact that they are interleaved is intentional, since activating B generates a DAVA on A and viceversa. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39646?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3a56b4fcb8c119a31815f3175db2d7899fbfddd7 Gerrit-Change-Number: 39646 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Mar 2025 09:26:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in libosmo-netif[master]: cosmetic: add .gitignore to utils
by pespin 03 Mar '25

03 Mar '25

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39653?usp=email ) Change subject: cosmetic: add .gitignore to utils ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I would like to raise the concern here that we usually put everything in the .gitignore in the root directory. IMHO that makes it a lot easier to figure out why stuff doesn't end up in git without having to look recursively in gitignore files. I'm not necessarily against this, but I'd like to know what others think about it beforehand to try to reach a general consensus. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5fd24c19b00f3ea3a18d30d6ee1ccb621c28434c Gerrit-Change-Number: 39653 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 03 Mar 2025 09:25:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log