- gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: ASP loadsharing: Pass xua_msg down to xua_as_transmit_msg
by laforge 04 Mar '25

04 Mar '25

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39398?usp=email ) Change subject: ASP loadsharing: Pass xua_msg down to xua_as_transmit_msg ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39398?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I70e5d33c7537dc0b72b5abced876e69018cc0829 Gerrit-Change-Number: 39398 Gerrit-PatchSet: 9 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Mar 2025 06:19:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-abis[master]: trau_frame encode8_hr: simplify setting of C5 for odd parity
by laforge 04 Mar '25

04 Mar '25

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39669?usp=email ) Change subject: trau_frame encode8_hr: simplify setting of C5 for odd parity ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm not entirely sure if this optimization is worth it. It feels like it's premature in a sense that it will bite us in the butt if we ever want to change anything about this function, and the strange assumption no longer holds true. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39669?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I30c7dfdaaadd0fd4cb084cf02c66c0f19a40ae42 Gerrit-Change-Number: 39669 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 04 Mar 2025 06:18:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-abis[master]: trau_frame cosmetic: document exact behavior for C1..C5
by laforge 04 Mar '25

04 Mar '25

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39668?usp=email ) Change subject: trau_frame cosmetic: document exact behavior for C1..C5 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39668?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Id1824c7cc8845ee2a730d556bec807c3cfa75beb Gerrit-Change-Number: 39668 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 04 Mar 2025 06:16:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: trau_frame cosmetic: fix doxygen comments
by laforge 04 Mar '25

04 Mar '25

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39667?usp=email ) Change subject: trau_frame cosmetic: fix doxygen comments ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I5a69c25c4abeef0b62d92bedc2c56a2d533390c5 Gerrit-Change-Number: 39667 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 04 Mar 2025 06:16:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Fix brokeness in STP_Tests_IPA.TC_tmt_loadshare
by laforge 04 Mar '25

04 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39661?usp=email ) Change subject: stp: Fix brokeness in STP_Tests_IPA.TC_tmt_loadshare ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39661?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I61c3efbf8e30533d051e2de506f7c8eaae7e297b Gerrit-Change-Number: 39661 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Mar 2025 06:15:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-abis[master]: trau_frame cosmetic: document exact behavior for C1..C5
by falconia 04 Mar '25

04 Mar '25

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39668?usp=email ) Change subject: trau_frame cosmetic: document exact behavior for C1..C5 ...................................................................... trau_frame cosmetic: document exact behavior for C1..C5 For historical reasons, osmo_trau_frame_encode() API has quirky behavior with regard to output of control bits C1..C5: for some frame types these bits are set to user-controlled values taken from fr->c_bits[], yet for other frame types the function fills in what it "knows" to be the correct frame type code, ignoring the first 5 bits out of user-supplied fr->c_bits[]. One particular combination of frame type and direction is even more bizarre, taking only fr->c_bits[3] while fixing the other 4 C-bits. Unfortunately this behavior cannot be changed without breaking API compatibility with previous released versions, i.e., without breaking external applications that rely on this library behavior. Therefore, we do the next best thing: thoroughly and succinctly document these quirks. Change-Id: Id1824c7cc8845ee2a730d556bec807c3cfa75beb --- M src/trau/trau_frame.c 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/68/39668/1 diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index b8085c2..652c703 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -1246,6 +1246,25 @@ * where C1..C5 may need to be modified (especially TFO-AMR where this C1..C5 * modification must be done before CRC computation), please use * osmo_trau_frame_encode_tfo(). + * + * The following list summarizes the behavior of the present function with + * regard to C1..C5 bits for different frame types: + * + * - For all TRAU-16k frame types in both UL and DL directions, and for + * OSMO_TRAU8_SPEECH (TRAU-8k for HRv1 speech) in UL direction, the first 5 + * bits of fr->c_bits[] are ignored and replaced with internally supplied + * constant values. + * + * - For OSMO_TRAU8_SPEECH in DL direction, only fr->c_bits[3] is used to set + * C4; constant values for C1..C3 and odd parity value for C5 are fixed + * by the function. + * + * - For OSMO_TRAU8_DATA, OSMO_TRAU8_OAM and all AMR-8k frame types, + * user-supplied fr->c_bits[] are always used. + * + * This unfortunate manipulation applies only to C1..C5 as listed above; + * for control bits C6 and higher (for frame types that have them), + * user-supplied fr->c_bits[] are always used. */ int osmo_trau_frame_encode(ubit_t *bits, size_t n_bits, const struct osmo_trau_frame *fr) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39668?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Id1824c7cc8845ee2a730d556bec807c3cfa75beb Gerrit-Change-Number: 39668 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

[XS] Change in libosmo-abis[master]: trau_frame cosmetic: fix doxygen comments
by falconia 04 Mar '25

04 Mar '25

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39667?usp=email ) Change subject: trau_frame cosmetic: fix doxygen comments ...................................................................... trau_frame cosmetic: fix doxygen comments Change-Id: I5a69c25c4abeef0b62d92bedc2c56a2d533390c5 --- M src/trau/trau_frame.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/67/39667/1 diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 74f4526..b8085c2 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -1231,10 +1231,10 @@ /*! Encode a TRAU frame from its decoded representation to a sequence of unpacked bits. - * \param[out] bits caller-allocated buffer for unpacked outpud bits + * \param[out] bits caller-allocated buffer for unpacked output bits * \param[in] n_bits size of 'bits' output buffer in number of unpacked bits * \param[in] fr decoded representation of TRAU frame to be encoded - * \return 0 number of unpacked output bits generated; negative in case of error + * \returns number of unpacked output bits generated; negative in case of error * * This function exhibits a behavioral quirk which users need to be aware of: * for many frame types, the first 5 bits out of user-provided fr->c_bits[] @@ -1326,10 +1326,10 @@ } /*! Encode a TFO frame from its decoded representation to a sequence of unpacked bits. - * \param[out] bits caller-allocated buffer for unpacked outpud bits + * \param[out] bits caller-allocated buffer for unpacked output bits * \param[in] n_bits size of 'bits' output buffer in number of unpacked bits * \param[in] fr decoded representation of TRAU frame to be encoded - * \return 0 number of unpacked output bits generated; negative in case of error + * \returns number of unpacked output bits generated; negative in case of error * * Compared to regular osmo_trau_frame_encode(), this TFO-specific TRAU frame * encoding function restricts the set of possible frame types to those that -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I5a69c25c4abeef0b62d92bedc2c56a2d533390c5 Gerrit-Change-Number: 39667 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

[S] Change in libosmo-abis[master]: trau_frame encode8_hr: simplify setting of C5 for odd parity
by falconia 04 Mar '25

04 Mar '25

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39669?usp=email ) Change subject: trau_frame encode8_hr: simplify setting of C5 for odd parity ...................................................................... trau_frame encode8_hr: simplify setting of C5 for odd parity As detailed in the previous commit, the API "contract" of osmo_trau_frame_encode() for OSMO_TRAU8_SPEECH in DL direction immortalizes a strange choice where C4 is controlled by the user while C1..C3 and C5 are overridden by the function. C5 is the odd parity bit; because C1..C3 are fixed and only C4 comes from the user, the correct odd parity bit C5 can be set more efficiently by simply inverting C4, skipping full computation of OP. Change-Id: I30c7dfdaaadd0fd4cb084cf02c66c0f19a40ae42 --- M src/trau/trau_frame.c 1 file changed, 6 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/69/39669/1 diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 652c703..3e8364a 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -812,23 +812,6 @@ return 0; } -/* compute the odd parity bit of the given input bit sequence */ -static ubit_t compute_odd_parity(const ubit_t *in, unsigned int num_bits) -{ - int i; - unsigned int sum = 0; - - for (i = 0; i < num_bits; i++) { - if (in[i]) - sum++; - } - - if (sum & 1) - return 0; - else - return 1; -} - /* TS 08.61 Section 5.2.1.1 */ static int encode8_hr(ubit_t *trau_bits, const struct osmo_trau_frame *fr, bool is_tfo) { @@ -855,11 +838,16 @@ cbits_out[4] = 0; } } else { + /* Per backward-compatible API "contract", we consider only + * fr->c_bits[3] set by the user, and override the other 4 + * bits. C1..C3 are constant frame type code; C5 is odd + * parity, which in this case is always the inverse of C4. + */ cbits_out[0] = 0; cbits_out[1] = 0; cbits_out[2] = 0; cbits_out[3] = fr->c_bits[3]; - cbits_out[4] = compute_odd_parity(cbits_out, 4); + cbits_out[4] = !fr->c_bits[3]; } /* XC1 .. XC2 */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39669?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I30c7dfdaaadd0fd4cb084cf02c66c0f19a40ae42 Gerrit-Change-Number: 39669 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: STP_Tests.ttcn: Use M3UA PC and RCTX from config
by laforge 03 Mar '25

03 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39662?usp=email ) Change subject: stp: STP_Tests.ttcn: Use M3UA PC and RCTX from config ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39662?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I81c8402d5ccd6e59f2a6869927c637fff30cb952 Gerrit-Change-Number: 39662 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Mar 2025 22:39:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Fix brokeness in STP_Tests_M3UA.TC_tmt_loadshare
by laforge 03 Mar '25

03 Mar '25

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39651?usp=email ) Change subject: stp: Fix brokeness in STP_Tests_M3UA.TC_tmt_loadshare ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39651?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I16d81cb2f88bb2927f248182ad4f8f27c8c24859 Gerrit-Change-Number: 39651 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Mar 2025 22:38:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log