Attention is currently required from: fixeria, laforge.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+2 by fixeria, Verified+1 by Jenkins Builder
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2
......................................................................
gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2
This IE is defined in 3GPP TS 44.060 Table 12.5a.2.1. Each presence
bit indicates presence of the next two entries, not one.
This patch does affect the output of csn1_ts_44_060_test, though it
does not fix decoding because it's caused by an unrelated problem.
Early versions of 3GPP TS 44.060 required to use the standard
2b-padding. Later versions added release extensions and say that 0 **
(zero padding) shall be used. This does not take backwards
compatibility into account, and makes it hard to parse RLC/MAC PDUs
originated by old phones. In this case the PDU has 2b2b2b at the end,
but we implement the recent version of 3GPP, so we try to parse padding
and run into problems...
Related: libosmo-gprs.git Iac4de18ef25386f774bb409201b7a7996d1c8824
Change-Id: I061ac16df5e6413266de08884f791f0264791192
---
M src/gsm_rlcmac.c
M tests/rlcmac/RLCMACTest.err
2 files changed, 10 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/88/39188/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I061ac16df5e6413266de08884f791f0264791192
Gerrit-Change-Number: 39188
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39657?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by pespin, Verified+1 by Jenkins Builder
Change subject: HTTP_Adapter: allow requests to different hosts
......................................................................
HTTP_Adapter: allow requests to different hosts
The host that is requested via the HTTP_Adapter is configured once on
initialization. This is fine if the test scenario only has exactly one
destination to query. For multiple destinations, this model does not
work. Let's add an http_pars parameter to the request functions, so
that the user can direct the requests to different hosts dynamically.
Related: SYS#7339
Change-Id: Ic87674f2381b3c6a1be6d0ce28a9e5403cda201b
---
M library/HTTP_Adapter.ttcn
1 file changed, 27 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/57/39657/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39657?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic87674f2381b3c6a1be6d0ce28a9e5403cda201b
Gerrit-Change-Number: 39657
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39406?usp=email )
Change subject: AS loadsharing: Introduce AS rate_ctr rx:msu:sls:*
......................................................................
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39406?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I695bd3933a116323db45ab7f45dcf539791139aa
Gerrit-Change-Number: 39406
Gerrit-PatchSet: 9
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 05 Mar 2025 10:12:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: daniel, fixeria, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39676?usp=email )
Change subject: sccp_user: Fix ASP not restarted after associating a new AS to it
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39676?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I5cccad3347dbea33433028e17571b1c16ecaf719
Gerrit-Change-Number: 39676
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 05 Mar 2025 10:11:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes