- gerrit-log - lists.osmocom.org

[XS] Change in osmo-ccid-firmware[master]: ccid: unbreak deinit a bit more..
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39572?usp=email ) Change subject: ccid: unbreak deinit a bit more.. ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: better commit log comment would be great. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39572?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I07f8e39ff0d51cf0d986645b12181b17bca345f5 Gerrit-Change-Number: 39572 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:59:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: AS loadsharing: Initial routing implementation based on extended-SLS
by pespin 05 Mar '25

05 Mar '25

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377?usp=email ) Change subject: AS loadsharing: Initial routing implementation based on extended-SLS ...................................................................... Patch Set 11: (1 comment) File include/osmocom/sigtran/osmo_ss7.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377/comment/c43f0a8e_b063b… : PS11, Line 129: O > so basically an external application cannot look routes anymore? I'm not saying it's critical, just […] This function becomes deprecated because anyway it doesn't take into account all the possible route-label fields, hence it's not really useful in the general scenario. Deprecating this one indeed leaves no "public" way of looking up routes, but I acknowledge this may be updated in follow-up patches once I have this tone, see previous comment https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377/4/include/osmocom/sigt… which contains further explanation. I prefer now to have this private and once I look into the specific IPA scenario from osmo-bsc I mention in the comment see what's the best set of APIs to expose. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0fb4ca4959096f748a23082efa0481300de56436 Gerrit-Change-Number: 39377 Gerrit-PatchSet: 11 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:57:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in ...pyosmocom[master]: utils: add unrpad()
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39600?usp=email ) Change subject: utils: add unrpad() ...................................................................... Patch Set 1: -Code-Review (1 comment) File src/osmocom/utils.py: https://gerrit.osmocom.org/c/python/pyosmocom/+/39600/comment/4aebfd59_b20e… : PS1, Line 125: """unpad string on the right side -- reverse of rpad(). > hmm indeed .. […] wouldn't it be good then to add unrpad as a method to the hexstr type? Maybe also call it rstrip there to make it look like the stdlib, as that's what it basically is? -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I48c23390926f8c9412624edb4481e7f4cd3f4b46 Gerrit-Change-Number: 39600 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:57:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-pcu[master]: Drop function declaration for non longer existing function
by laforge 05 Mar '25

05 Mar '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39686?usp=email ) Change subject: Drop function declaration for non longer existing function ...................................................................... Drop function declaration for non longer existing function Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: I999ac55fca21cf942876bc19c19f0eda2754501b Fixes: 1ec29c7324e69a6f294704fb8eeb093a33085aba --- M src/pcu_vty.h 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/pcu_vty.h b/src/pcu_vty.h index 45d3227..8178e11 100644 --- a/src/pcu_vty.h +++ b/src/pcu_vty.h @@ -9,9 +9,6 @@ PCU_NODE = _LAST_OSMOVTY_NODE + 1, }; -int pcu_vty_go_parent(struct vty *vty); -int pcu_vty_is_config_node(struct vty *vty, int node); - int pcu_vty_init(); extern struct vty_app_info pcu_vty_info; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I999ac55fca21cf942876bc19c19f0eda2754501b Gerrit-Change-Number: 39686 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-pcu[master]: Drop function declaration for non longer existing function
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39686?usp=email ) Change subject: Drop function declaration for non longer existing function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I999ac55fca21cf942876bc19c19f0eda2754501b Gerrit-Change-Number: 39686 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:55:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sip-connector[master]: Drop use of deprecated vty is_config_node() cb
by laforge 05 Mar '25

05 Mar '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/39688?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: I3809f9c0529004ff117e9e79ee81d30dca6e9bc4 --- M src/vty.c 1 file changed, 1 insertion(+), 8 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/vty.c b/src/vty.c index ea76d46..f7fa041 100644 --- a/src/vty.c +++ b/src/vty.c @@ -33,7 +33,6 @@ struct app_config g_app; static int mncc_vty_go_parent(struct vty *vty); -static int mncc_vty_is_config_node(struct vty *vty, int node); static struct cmd_node sip_node = { SIP_NODE, @@ -57,7 +56,6 @@ .name = "OsmoSIPcon", .version = PACKAGE_VERSION, .go_parent_cb = mncc_vty_go_parent, - .is_config_node = mncc_vty_is_config_node, .copyright = "GNU AGPLv3+\n", }; @@ -71,7 +69,7 @@ vty->index = NULL; break; default: - if (mncc_vty_is_config_node(vty, vty->node)) + if (vty->node >= SIP_NODE) vty->node = CONFIG_NODE; else vty->node = ENABLE_NODE; @@ -81,11 +79,6 @@ return vty->node; } -static int mncc_vty_is_config_node(struct vty *vty, int node) -{ - return node >= SIP_NODE; -} - static int config_write_sip(struct vty *vty) { vty_out(vty, "sip%s", VTY_NEWLINE); -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/39688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I3809f9c0529004ff117e9e79ee81d30dca6e9bc4 Gerrit-Change-Number: 39688 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-sip-connector[master]: Drop use of deprecated vty is_config_node() cb
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/39688?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/39688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I3809f9c0529004ff117e9e79ee81d30dca6e9bc4 Gerrit-Change-Number: 39688 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:55:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-msc[master]: Drop use of deprecated vty is_config_node() cb
by laforge 05 Mar '25

05 Mar '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/39684?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: Id6620095af153781cde926458f54fed5bd51a9e7 --- M src/osmo-msc/msc_main.c 1 file changed, 0 insertions(+), 19 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c index 2238e2b..2435029 100644 --- a/src/osmo-msc/msc_main.c +++ b/src/osmo-msc/msc_main.c @@ -354,29 +354,10 @@ return vty->node; } -static int msc_vty_is_config_node(struct vty *vty, int node) -{ - /* Check if libosmo-sigtran declares the node in - * question as config node */ - if (osmo_ss7_is_config_node(vty, node)) - return 1; - - switch (node) { - /* add items that are not config */ - case SUBSCR_NODE: - case CONFIG_NODE: - return 0; - - default: - return 1; - } -} - static struct vty_app_info msc_vty_info = { .name = "OsmoMSC", .version = PACKAGE_VERSION, .go_parent_cb = msc_vty_go_parent, - .is_config_node = msc_vty_is_config_node, }; #define DEFAULT_M3UA_LOCAL_IP "localhost" -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id6620095af153781cde926458f54fed5bd51a9e7 Gerrit-Change-Number: 39684 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-msc[master]: Drop use of deprecated vty is_config_node() cb
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/39684?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id6620095af153781cde926458f54fed5bd51a9e7 Gerrit-Change-Number: 39684 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:55:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ggsn[master]: Drop use of deprecated vty is_config_node() cb
by laforge 05 Mar '25

05 Mar '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/39685?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: Ief57c4ce98055e5063aafc53cb8330d3bd95d323 --- M ggsn/ggsn_vty.c 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/ggsn/ggsn_vty.c b/ggsn/ggsn_vty.c index b0f07fe..534b3d2 100644 --- a/ggsn/ggsn_vty.c +++ b/ggsn/ggsn_vty.c @@ -1124,17 +1124,6 @@ return 0; } -static int ggsn_vty_is_config_node(struct vty *vty, int node) -{ - switch (node) { - case GGSN_NODE: - case APN_NODE: - return 1; - default: - return 0; - } -} - static int ggsn_vty_go_parent(struct vty *vty) { switch (vty->node) { @@ -1174,5 +1163,4 @@ .version = PACKAGE_VERSION, .copyright = ggsn_copyright, .go_parent_cb = ggsn_vty_go_parent, - .is_config_node = ggsn_vty_is_config_node, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/39685?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ief57c4ce98055e5063aafc53cb8330d3bd95d323 Gerrit-Change-Number: 39685 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log