- gerrit-log - lists.osmocom.org

[XS] Change in osmocom-bb[master]: fake_trx: Remove unneeded field assignment
by fixeria 19 Mar '25

19 Mar '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39825?usp=email ) Change subject: fake_trx: Remove unneeded field assignment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39825?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib8808f8bf8f3ef084334debac47ca48a48aa0cea Gerrit-Change-Number: 39825 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Mar 2025 06:18:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmocom-bb[master]: fake_trx: Allow setting sched RR priority for clckgen thread
by pespin 18 Mar '25

18 Mar '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39815?usp=email ) Change subject: fake_trx: Allow setting sched RR priority for clckgen thread ...................................................................... Patch Set 3: (1 comment) File src/target/trx_toolkit/clck_gen.py: https://gerrit.osmocom.org/c/osmocom-bb/+/39815/comment/074531c2_c3d4fec7?u… : PS3, Line 73: self._thread.sched_rr_prio = self.sched_rr_prio > As you can see from existing code, the worker has access to `self.ctr_interval`, `self. […] https://gerrit.osmocom.org/c/osmocom-bb/+/39825 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39815?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3c7f36c17fc7b9cae1023b4a0ed37f983dc286dc Gerrit-Change-Number: 39815 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Mar 2025 22:57:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: fake_trx: Remove unneeded field assignment
by pespin 18 Mar '25

18 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39825?usp=email ) Change subject: fake_trx: Remove unneeded field assignment ...................................................................... fake_trx: Remove unneeded field assignment The assignment is not really needed, since worker can already access the field anyway. Fixes: 6f45d36e936c9209a18e02b6a8c3a04eb1ff9fd9 Change-Id: Ib8808f8bf8f3ef084334debac47ca48a48aa0cea --- M src/target/trx_toolkit/clck_gen.py 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/25/39825/1 diff --git a/src/target/trx_toolkit/clck_gen.py b/src/target/trx_toolkit/clck_gen.py index f73ac16..ae7a899 100755 --- a/src/target/trx_toolkit/clck_gen.py +++ b/src/target/trx_toolkit/clck_gen.py @@ -70,7 +70,6 @@ # Initialize and start a new thread self._thread = threading.Thread(target = self._worker) self._thread.daemon = True - self._thread.sched_rr_prio = self.sched_rr_prio self._thread.start() def stop(self): -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39825?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib8808f8bf8f3ef084334debac47ca48a48aa0cea Gerrit-Change-Number: 39825 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-dev[master]: all.urls: add osmo-gsm-shark
by fixeria 18 Mar '25

18 Mar '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/39820?usp=email ) Change subject: all.urls: add osmo-gsm-shark ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39820?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: If4e17fac28ebae9a3e937242e3e1a40893496a4d Gerrit-Change-Number: 39820 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Mar 2025 19:56:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-dev[master]: src/_update_src_copy: handle symlink projects
by fixeria 18 Mar '25

18 Mar '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/39819?usp=email ) Change subject: src/_update_src_copy: handle symlink projects ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Icfe701b8a237385597718374be50a8b81c6ac433 Gerrit-Change-Number: 39819 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Mar 2025 19:55:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-dev[master]: src/_update_src_copy: move functions to top
by fixeria 18 Mar '25

18 Mar '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/39818?usp=email ) Change subject: src/_update_src_copy: move functions to top ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39818?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I9a2b346e8e6d9a33aa4fc55add6bb9124ea2d3ed Gerrit-Change-Number: 39818 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Mar 2025 19:55:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmocom-bb[master]: fake_trx: Allow setting sched RR priority for clckgen thread
by fixeria 18 Mar '25

18 Mar '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39815?usp=email ) Change subject: fake_trx: Allow setting sched RR priority for clckgen thread ...................................................................... Patch Set 3: (1 comment) File src/target/trx_toolkit/clck_gen.py: https://gerrit.osmocom.org/c/osmocom-bb/+/39815/comment/0ea07683_6dc1900e?u… : PS3, Line 73: self._thread.sched_rr_prio = self.sched_rr_prio > Sorry I didn't see your comment before merging. […] As you can see from existing code, the worker has access to `self.ctr_interval`, `self._breaker`, and `self.send_clck_ind()`. So your understanding is incorrect. Please submit a separate patch removing this line. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39815?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3c7f36c17fc7b9cae1023b4a0ed37f983dc286dc Gerrit-Change-Number: 39815 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Mar 2025 19:53:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: Run osmo-bts-trx with sched_rr priority
by pespin 18 Mar '25

18 Mar '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39821?usp=email ) Change subject: bts: Run osmo-bts-trx with sched_rr priority ...................................................................... bts: Run osmo-bts-trx with sched_rr priority use a real time prio since it really needs to do stuff in ral time with high prio. Use lower rt prio than fake_trx since that one is the most important piece providing clock. Change-Id: I0251ed3ec0645617cf4e9bcc03e75c805bf1634c --- M bts/osmo-bts.cfg 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/bts/osmo-bts.cfg b/bts/osmo-bts.cfg index e80f51b..a683a03 100644 --- a/bts/osmo-bts.cfg +++ b/bts/osmo-bts.cfg @@ -32,6 +32,9 @@ no login bind 127.0.0.1 ! +cpu-sched + policy rr 10 +! e1_input e1_line 0 driver ipa e1_line 0 port 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0251ed3ec0645617cf4e9bcc03e75c805bf1634c Gerrit-Change-Number: 39821 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in docker-playground[master]: ttcn3-bts: Allow running osmo-bts-trx with rt prio
by pespin 18 Mar '25

18 Mar '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/39822?usp=email ) Change subject: ttcn3-bts: Allow running osmo-bts-trx with rt prio ...................................................................... ttcn3-bts: Allow running osmo-bts-trx with rt prio osmo-ttcn3-hacks.git Change-Id I0251ed3ec0645617cf4e9bcc03e75c805bf1634c adds "policy rr" to VTY config of osmo-bts-trx. Allow the process to set it inside docker. Change-Id: Ie85d62a865db9ee0ec26a476bb42e4a6ca0ef70b --- M ttcn3-bts-test/jenkins.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 7800539..a25456e 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -47,6 +47,8 @@ fi docker run --rm \ $(docker_network_params $SUBNET 20) \ + --cap-add=SYS_ADMIN \ + --ulimit rtprio=99 \ --ulimit core=-1 \ -v $VOL_BASE_DIR/bts:/data \ -v $VOL_BASE_DIR/unix:/data/unix \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie85d62a865db9ee0ec26a476bb42e4a6ca0ef70b Gerrit-Change-Number: 39822 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in docker-playground[master]: ttcn3-bts-test: Run fake_trx with sched-prio-rr
by pespin 18 Mar '25

18 Mar '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/39816?usp=email ) Change subject: ttcn3-bts-test: Run fake_trx with sched-prio-rr ...................................................................... ttcn3-bts-test: Run fake_trx with sched-prio-rr Depends: osmocom-bb.git I3c7f36c17fc7b9cae1023b4a0ed37f983dc286dc Change-Id: I8f9df66e0819881587b55c93043fed9a294ab5e8 --- M ttcn3-bts-test/jenkins.sh 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index d4b59e7..7800539 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -60,6 +60,8 @@ echo Starting container with fake_trx docker run --rm \ $(docker_network_params $SUBNET 21) \ + --cap-add=SYS_ADMIN \ + --ulimit rtprio=99 \ --ulimit core=-1 \ -v $VOL_BASE_DIR/fake_trx:/data \ --name ${BUILD_TAG}-fake_trx -d \ @@ -70,6 +72,7 @@ --log-file-level DEBUG \ --log-file-time \ --log-level INFO \ + --sched-rr-prio 30 \ -R $SUB4_PREFIX.$SUBNET.20 \ -r $SUB4_PREFIX.$SUBNET.22 \ --trx TRX1@$SUB4_PREFIX.$SUBNET.20:5700/1 \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39816?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8f9df66e0819881587b55c93043fed9a294ab5e8 Gerrit-Change-Number: 39816 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log