- gerrit-log - lists.osmocom.org

[XS] Change in osmo-bts[master]: rsl: rsl_rx_chan_activ(): fix code formatting
by pespin 21 Mar '25

21 Mar '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39828?usp=email ) Change subject: rsl: rsl_rx_chan_activ(): fix code formatting ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39828?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib22f9b90a5194370d2b5bb768d050cc0b167320e Gerrit-Change-Number: 39828 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 14:48:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: power_control: always feed input values to do_avg_algo()
by pespin 21 Mar '25

21 Mar '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39831?usp=email ) Change subject: power_control: always feed input values to do_avg_algo() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2ccad1cb0ebbfcce64a93bc81b66db37b1399769 Gerrit-Change-Number: 39831 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 14:48:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: fixup: rsl: properly initialize MS/BS Power Control state
by pespin 21 Mar '25

21 Mar '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email ) Change subject: fixup: rsl: properly initialize MS/BS Power Control state ...................................................................... Patch Set 1: (1 comment) File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/39830/comment/77121fd1_b1553bf2?usp… : PS1, Line 2059: lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max; so this means always the current level becomes max level. Are you sure this is correct? You seem to be changing the logic here? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I46c881d5a3959c2542610ed767e0f131d01f9f98 Gerrit-Change-Number: 39830 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 14:46:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-bts[master]: rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC
by pespin 21 Mar '25

21 Mar '25

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email ) Change subject: rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC ...................................................................... Patch Set 1: (1 comment) File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/39829/comment/55ddd6a4_dbbb1344?usp… : PS1, Line 2068: lchan->ta_ctrl.current = 0; > it's a bit of a question whether we expect all of those valuse to be zero or otherwise sanely defaul […] I also think it may make more sense to do it during lchan init/release, but I'm oen to this approach too. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I83f26ff06cebdfe8d4e75944f496e9678310e2a2 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 14:41:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ci[master]: obs: gerrit_binpkgs: set --allow-unknown-package
by laforge 21 Mar '25

21 Mar '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39826?usp=email ) Change subject: obs: gerrit_binpkgs: set --allow-unknown-package ...................................................................... obs: gerrit_binpkgs: set --allow-unknown-package The gerrit_binpkgs.sh script can be used to quickly test building of debian packages in a container even for packages that we don't have in the OBS osmocom repositories. For example I'm currently using it to test-build kamailio packages. Use the --allow-unknown-package argument so build_srcpkg.py doesn't complain if this gets called with a package that isn't a known Osmocom package. Change-Id: I79e89c0d7a73f8b2262fd10a0f7a118aa8351635 --- M scripts/obs/gerrit_binpkgs.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/scripts/obs/gerrit_binpkgs.sh b/scripts/obs/gerrit_binpkgs.sh index 443c33f..f199844 100755 --- a/scripts/obs/gerrit_binpkgs.sh +++ b/scripts/obs/gerrit_binpkgs.sh @@ -37,6 +37,7 @@ echo ":: Building the source package" "$SCRIPTS_OBS_DIR"/build_srcpkg.py \ + --allow-unknown-package \ --docker \ --feed master \ --git-skip-fetch \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39826?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I79e89c0d7a73f8b2262fd10a0f7a118aa8351635 Gerrit-Change-Number: 39826 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: obs: gerrit_binpkgs: set --allow-unknown-package
by laforge 21 Mar '25

21 Mar '25

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39826?usp=email ) Change subject: obs: gerrit_binpkgs: set --allow-unknown-package ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39826?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I79e89c0d7a73f8b2262fd10a0f7a118aa8351635 Gerrit-Change-Number: 39826 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 08:12:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: protocol/gsm_04_08.h: Add GSM 04.08 message types for SI21/22/23
by laforge 21 Mar '25

21 Mar '25

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/39827?usp=email ) Change subject: protocol/gsm_04_08.h: Add GSM 04.08 message types for SI21/22/23 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: not quite sure why the build would fail after such a trivial change ading 5 more defines... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39827?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1bb96f3c09b0499c3a76519a49d63c2a30130612 Gerrit-Change-Number: 39827 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 21 Mar 2025 08:11:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-bts[master]: fixup: rsl: properly initialize MS/BS Power Control state
by laforge 21 Mar '25

21 Mar '25

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email ) Change subject: fixup: rsl: properly initialize MS/BS Power Control state ...................................................................... Patch Set 1: (1 comment) File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/39830/comment/cb7264bc_03b5a390?usp… : PS1, Line 1992: memset(&lchan->bs_power_ctrl, 0, sizeof(lchan->bs_power_ctrl)); ok, more initialization here rather than re-set-to-sane-defaults during deactivation. Can be done this way - but then make sure all of it happens here and none in the deactivation path. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I46c881d5a3959c2542610ed767e0f131d01f9f98 Gerrit-Change-Number: 39830 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 08:09:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-bts[master]: rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC
by laforge 21 Mar '25

21 Mar '25

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email ) Change subject: rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC ...................................................................... Patch Set 1: (1 comment) File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/39829/comment/e19c083a_c9ae185a?usp… : PS1, Line 2068: lchan->ta_ctrl.current = 0; it's a bit of a question whether we expect all of those valuse to be zero or otherwise sanely default-initialized when we start using a lchan or not. My preference would be to re-set the ta_ctrl.current to zero during LCHAN release/deactivation. If you want to do it here, then why are we not also setting ms_power_ctrl.{max,current} if the RSL_IE_MS_POWER is not presetn? opr many other parts of this function... -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I83f26ff06cebdfe8d4e75944f496e9678310e2a2 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 08:08:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-bts[master]: rsl: rsl_rx_chan_activ(): fix code formatting
by laforge 21 Mar '25

21 Mar '25

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39828?usp=email ) Change subject: rsl: rsl_rx_chan_activ(): fix code formatting ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39828?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib22f9b90a5194370d2b5bb768d050cc0b167320e Gerrit-Change-Number: 39828 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 08:07:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log