Attention is currently required from: daniel, lynxis lazus, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841?usp=email )
Change subject: mme: Take into account KSI update by Network
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
File mme/MME_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841/comment/213b5838_9cc7… :
PS1, Line 405: c_NAS_TSC_NATIVE_SEC_CTX
> It's the default param value, but I prefer keeping it here so it explicitly shows what we are using […]
Then there's a little sense in using the template here, you could do:
```
kset_id := { '000'B, c_NAS_TSC_NATIVE_SEC_CTX }
```
or even more explicit:
```
kset_id := { identifier := '000'B,
tSC := c_NAS_TSC_NATIVE_SEC_CTX }
```
but this is all cosmetics and I am not blocking here.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841/comment/2e66d9cc_a1f3… :
PS1, Line 405: '000'B
> '000'B, guess what, means 0, which is basically one of the 2^3-1 you can select to start with, and w […]
Ok, I just thought it might be a special kind of value like '111'B.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie97788c5d9996370cd3e24cc0ff7c003adff1a65
Gerrit-Change-Number: 39841
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 24 Mar 2025 15:16:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, lynxis lazus, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39842?usp=email )
Change subject: mme: Replace TC_s1ap_setup_wrong_plmn with test with different expectancies
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39842?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3aba3d642e3bc70f08b6e0713514fb8906da775d
Gerrit-Change-Number: 39842
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 24 Mar 2025 15:10:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: daniel, fixeria, lynxis lazus.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841?usp=email )
Change subject: mme: Take into account KSI update by Network
......................................................................
Patch Set 1:
(2 comments)
File mme/MME_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841/comment/0fb92c9e_bdfe… :
PS1, Line 405: '000'B
> What does `'000'B` mean? Can we have a constant value for that?
'000'B, guess what, means 0, which is basically one of the 2^3-1 you can select to start with, and which was already being selected before.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841/comment/4dd74967_c530… :
PS1, Line 405: c_NAS_TSC_NATIVE_SEC_CTX
> cosmetic: this is the default param value, so can be omitted.
It's the default param value, but I prefer keeping it here so it explicitly shows what we are using here by default in all tests.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie97788c5d9996370cd3e24cc0ff7c003adff1a65
Gerrit-Change-Number: 39841
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 24 Mar 2025 15:10:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: daniel, lynxis lazus, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841?usp=email )
Change subject: mme: Take into account KSI update by Network
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File mme/MME_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841/comment/5599c19c_d2f7… :
PS1, Line 405: '000'B
What does `'000'B` mean? Can we have a constant value for that?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841/comment/bdd929b1_d0b8… :
PS1, Line 405: c_NAS_TSC_NATIVE_SEC_CTX
cosmetic: this is the default param value, so can be omitted.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie97788c5d9996370cd3e24cc0ff7c003adff1a65
Gerrit-Change-Number: 39841
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 24 Mar 2025 15:08:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes