Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39881?usp=email )
Change subject: s1gw: ConnHdlr: allow passing {MME,ENB}-UE-S1AP-ID
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
> I'm not following this in detail, but my gut feeling tells me it might have been preferable to encap […]
Ack, I'd at least probably add a new record containing both "MME_UE_S1AP_ID mme_ue_id" and "ENB_UE_S1AP_ID enb_ue_id". This will also help later in using/updating per-UE state.
Feel free to do it a in follow-up patch if it's easier though.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39881?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ife37c77cff348cdfbde191dbad6da816e68ca941
Gerrit-Change-Number: 39881
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Apr 2025 08:45:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39881?usp=email )
Change subject: s1gw: ConnHdlr: allow passing {MME,ENB}-UE-S1AP-ID
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
I'm not following this in detail, but my gut feeling tells me it might have been preferable to encapsulate all those extra function arguments in a per-UE component and then use that component instead of the eNB globsl ConnHdlr? this way more convenience and less explicit function arguments...
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39881?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ife37c77cff348cdfbde191dbad6da816e68ca941
Gerrit-Change-Number: 39881
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Apr 2025 05:59:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39881?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: s1gw: ConnHdlr: allow passing {MME,ENB}-UE-S1AP-ID
......................................................................
s1gw: ConnHdlr: allow passing {MME,ENB}-UE-S1AP-ID
This is needed for follow-up UEMux testcases, in which we spawn
multiple virtual UEs with unique {MME,ENB}-UE-S1AP-IDs.
Change-Id: Ife37c77cff348cdfbde191dbad6da816e68ca941
Related: SYS#7288
---
M s1gw/S1GW_ConnHdlr.ttcn
M s1gw/S1GW_Tests.ttcn
2 files changed, 177 insertions(+), 96 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/81/39881/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39881?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ife37c77cff348cdfbde191dbad6da816e68ca941
Gerrit-Change-Number: 39881
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder